diff --git a/channels/audin/client/oss/audin_oss.c b/channels/audin/client/oss/audin_oss.c
index d7baaed45..52ffd7bce 100644
--- a/channels/audin/client/oss/audin_oss.c
+++ b/channels/audin/client/oss/audin_oss.c
@@ -160,8 +160,8 @@ static DWORD WINAPI audin_oss_thread_func(LPVOID arg)
if (oss->dev_unit != -1)
{
- sprintf_s(dev_name, (PATH_MAX - 1), "/dev/dsp%i", oss->dev_unit);
- sprintf_s(mixer_name, PATH_MAX - 1, "/dev/mixer%i", oss->dev_unit);
+ (void)sprintf_s(dev_name, (PATH_MAX - 1), "/dev/dsp%i", oss->dev_unit);
+ (void)sprintf_s(mixer_name, PATH_MAX - 1, "/dev/mixer%i", oss->dev_unit);
}
WLog_INFO(TAG, "open: %s", dev_name);
diff --git a/channels/client/addin.c b/channels/client/addin.c
index 2f3b990ba..56dcf106b 100644
--- a/channels/client/addin.c
+++ b/channels/client/addin.c
@@ -111,7 +111,7 @@ static FREERDP_ADDIN** freerdp_channels_list_client_static_addins(LPCSTR pszName
goto error_out;
}
- sprintf_s(pAddin->cName, ARRAYSIZE(pAddin->cName), "%s", table->name);
+ (void)sprintf_s(pAddin->cName, ARRAYSIZE(pAddin->cName), "%s", table->name);
pAddin->dwFlags = FREERDP_ADDIN_CLIENT;
pAddin->dwFlags |= FREERDP_ADDIN_STATIC;
pAddin->dwFlags |= FREERDP_ADDIN_NAME;
@@ -128,8 +128,9 @@ static FREERDP_ADDIN** freerdp_channels_list_client_static_addins(LPCSTR pszName
goto error_out;
}
- sprintf_s(pAddin->cName, ARRAYSIZE(pAddin->cName), "%s", table->name);
- sprintf_s(pAddin->cSubsystem, ARRAYSIZE(pAddin->cSubsystem), "%s", subsystems[j].name);
+ (void)sprintf_s(pAddin->cName, ARRAYSIZE(pAddin->cName), "%s", table->name);
+ (void)sprintf_s(pAddin->cSubsystem, ARRAYSIZE(pAddin->cSubsystem), "%s",
+ subsystems[j].name);
pAddin->dwFlags = FREERDP_ADDIN_CLIENT;
pAddin->dwFlags |= FREERDP_ADDIN_STATIC;
pAddin->dwFlags |= FREERDP_ADDIN_NAME;
@@ -190,23 +191,23 @@ static FREERDP_ADDIN** freerdp_channels_list_dynamic_addins(LPCSTR pszName, LPCS
if (pszName && pszSubsystem && pszType)
{
- sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client-%s-%s.%s",
- pszName, pszSubsystem, pszType, pszExtension);
+ (void)sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client-%s-%s.%s",
+ pszName, pszSubsystem, pszType, pszExtension);
}
else if (pszName && pszType)
{
- sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client-?-%s.%s",
- pszName, pszType, pszExtension);
+ (void)sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client-?-%s.%s",
+ pszName, pszType, pszExtension);
}
else if (pszName)
{
- sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client*.%s", pszName,
- pszExtension);
+ (void)sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "%s-client*.%s",
+ pszName, pszExtension);
}
else
{
- sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "?-client*.%s",
- pszExtension);
+ (void)sprintf_s(pszPattern, cchPattern, FREERDP_SHARED_LIBRARY_PREFIX "?-client*.%s",
+ pszExtension);
}
cchPattern = strnlen(pszPattern, cchPattern);
@@ -567,10 +568,10 @@ static DWORD WINAPI channel_client_thread_proc(LPVOID userdata)
if (error && internals->ctx)
{
char msg[128];
- _snprintf(msg, 127,
- "%s_virtual_channel_client_thread reported an"
- " error",
- internals->channel_name);
+ (void)_snprintf(msg, 127,
+ "%s_virtual_channel_client_thread reported an"
+ " error",
+ internals->channel_name);
setChannelError(internals->ctx, error, msg);
}
ExitThread(error);
@@ -696,7 +697,8 @@ UINT channel_client_post_message(void* MsgsHandle, LPVOID pData, UINT32 dataLeng
if (Stream_Capacity(data_in) != Stream_GetPosition(data_in))
{
char msg[128];
- _snprintf(msg, 127, "%s_plugin_process_received: read error", internals->channel_name);
+ (void)_snprintf(msg, 127, "%s_plugin_process_received: read error",
+ internals->channel_name);
WLog_ERR(TAG, msg);
return ERROR_INTERNAL_ERROR;
}
diff --git a/channels/cliprdr/client/cliprdr_main.c b/channels/cliprdr/client/cliprdr_main.c
index 60136ff5f..c28eced33 100644
--- a/channels/cliprdr/client/cliprdr_main.c
+++ b/channels/cliprdr/client/cliprdr_main.c
@@ -1120,8 +1120,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS p
cliprdr->channelDef.options = CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP |
CHANNEL_OPTION_COMPRESS_RDP | CHANNEL_OPTION_SHOW_PROTOCOL;
- sprintf_s(cliprdr->channelDef.name, ARRAYSIZE(cliprdr->channelDef.name),
- CLIPRDR_SVC_CHANNEL_NAME);
+ (void)sprintf_s(cliprdr->channelDef.name, ARRAYSIZE(cliprdr->channelDef.name),
+ CLIPRDR_SVC_CHANNEL_NAME);
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
WINPR_ASSERT(pEntryPointsEx);
diff --git a/channels/cliprdr/cliprdr_common.c b/channels/cliprdr/cliprdr_common.c
index aea102e5a..65320414a 100644
--- a/channels/cliprdr/cliprdr_common.c
+++ b/channels/cliprdr/cliprdr_common.c
@@ -61,7 +61,7 @@ static const char* CB_MSG_TYPE_STR(UINT32 type)
const char* CB_MSG_TYPE_STRING(UINT16 type, char* buffer, size_t size)
{
- _snprintf(buffer, size, "%s [0x%04" PRIx16 "]", CB_MSG_TYPE_STR(type), type);
+ (void)_snprintf(buffer, size, "%s [0x%04" PRIx16 "]", CB_MSG_TYPE_STR(type), type);
return buffer;
}
@@ -79,7 +79,7 @@ const char* CB_MSG_FLAGS_STRING(UINT16 msgFlags, char* buffer, size_t size)
winpr_str_append("NONE", buffer, size, "");
char val[32] = { 0 };
- _snprintf(val, sizeof(val), "[0x%04" PRIx16 "]", msgFlags);
+ (void)_snprintf(val, sizeof(val), "[0x%04" PRIx16 "]", msgFlags);
winpr_str_append(val, buffer, size, "|");
return buffer;
}
diff --git a/channels/drdynvc/client/drdynvc_main.c b/channels/drdynvc/client/drdynvc_main.c
index 6be4c8c70..d3795eb45 100644
--- a/channels/drdynvc/client/drdynvc_main.c
+++ b/channels/drdynvc/client/drdynvc_main.c
@@ -1997,8 +1997,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS_E
drdynvc->channelDef.options =
CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP | CHANNEL_OPTION_COMPRESS_RDP;
- sprintf_s(drdynvc->channelDef.name, ARRAYSIZE(drdynvc->channelDef.name),
- DRDYNVC_SVC_CHANNEL_NAME);
+ (void)sprintf_s(drdynvc->channelDef.name, ARRAYSIZE(drdynvc->channelDef.name),
+ DRDYNVC_SVC_CHANNEL_NAME);
drdynvc->state = DRDYNVC_STATE_INITIAL;
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
diff --git a/channels/encomsp/client/encomsp_main.c b/channels/encomsp/client/encomsp_main.c
index 18b856e62..e6dc2834d 100644
--- a/channels/encomsp/client/encomsp_main.c
+++ b/channels/encomsp/client/encomsp_main.c
@@ -1244,8 +1244,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS_E
encomsp->channelDef.options = CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP |
CHANNEL_OPTION_COMPRESS_RDP | CHANNEL_OPTION_SHOW_PROTOCOL;
- sprintf_s(encomsp->channelDef.name, ARRAYSIZE(encomsp->channelDef.name),
- ENCOMSP_SVC_CHANNEL_NAME);
+ (void)sprintf_s(encomsp->channelDef.name, ARRAYSIZE(encomsp->channelDef.name),
+ ENCOMSP_SVC_CHANNEL_NAME);
CHANNEL_ENTRY_POINTS_FREERDP_EX* pEntryPointsEx =
(CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
WINPR_ASSERT(pEntryPointsEx);
diff --git a/channels/location/client/location_main.c b/channels/location/client/location_main.c
index df6b82e5b..f84d7fc2e 100644
--- a/channels/location/client/location_main.c
+++ b/channels/location/client/location_main.c
@@ -138,7 +138,7 @@ static const char* location_version_str(UINT32 version, char* buffer, size_t siz
break;
}
- _snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, version);
+ (void)_snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, version);
return buffer;
}
diff --git a/channels/printer/client/cups/printer_cups.c b/channels/printer/client/cups/printer_cups.c
index 043b44e70..6f996dd95 100644
--- a/channels/printer/client/cups/printer_cups.c
+++ b/channels/printer/client/cups/printer_cups.c
@@ -110,8 +110,9 @@ static void printer_cups_get_printjob_name(char* buf, size_t size, size_t id)
WINPR_ASSERT(buf);
WINPR_ASSERT(size > 0);
- sprintf_s(buf, size - 1, "FreeRDP Print %04d-%02d-%02d %02d-%02d-%02d - Job %" PRIdz,
- t->tm_year + 1900, t->tm_mon + 1, t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, id);
+ (void)sprintf_s(buf, size - 1, "FreeRDP Print %04d-%02d-%02d %02d-%02d-%02d - Job %" PRIdz,
+ t->tm_year + 1900, t->tm_mon + 1, t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec,
+ id);
}
static bool http_status_ok(http_status_t status)
diff --git a/channels/printer/client/printer_main.c b/channels/printer/client/printer_main.c
index c458c0fdc..b89bf9b32 100644
--- a/channels/printer/client/printer_main.c
+++ b/channels/printer/client/printer_main.c
@@ -972,7 +972,7 @@ static UINT printer_register(PDEVICE_SERVICE_ENTRY_POINTS pEntryPoints, rdpPrint
if (!printer_dev->device.data)
goto error_out;
- sprintf_s(printer_dev->port, sizeof(printer_dev->port), "PRN%" PRIdz, printer->id);
+ (void)sprintf_s(printer_dev->port, sizeof(printer_dev->port), "PRN%" PRIdz, printer->id);
printer_dev->device.type = RDPDR_DTYP_PRINT;
printer_dev->device.name = printer_dev->port;
printer_dev->device.IRPRequest = printer_irp_request;
diff --git a/channels/rail/client/client_rails.c b/channels/rail/client/client_rails.c
index ee6db44d6..d6a358b21 100644
--- a/channels/rail/client/client_rails.c
+++ b/channels/rail/client/client_rails.c
@@ -82,8 +82,8 @@ UINT client_rail_server_start_cmd(RailClientContext* context)
freerdp_settings_get_string(settings, FreeRDP_RemoteApplicationCmdLine);
if (RemoteApplicationFile && RemoteApplicationCmdLine)
{
- _snprintf(argsAndFile, ARRAYSIZE(argsAndFile), "%s %s", RemoteApplicationCmdLine,
- RemoteApplicationFile);
+ (void)_snprintf(argsAndFile, ARRAYSIZE(argsAndFile), "%s %s", RemoteApplicationCmdLine,
+ RemoteApplicationFile);
exec.RemoteApplicationArguments = argsAndFile;
}
else if (RemoteApplicationFile)
diff --git a/channels/rail/client/rail_main.c b/channels/rail/client/rail_main.c
index f1c9426d6..ad82355f8 100644
--- a/channels/rail/client/rail_main.c
+++ b/channels/rail/client/rail_main.c
@@ -677,7 +677,7 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS p
rail->sendHandshake = TRUE;
rail->channelDef.options = CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP |
CHANNEL_OPTION_COMPRESS_RDP | CHANNEL_OPTION_SHOW_PROTOCOL;
- sprintf_s(rail->channelDef.name, ARRAYSIZE(rail->channelDef.name), RAIL_SVC_CHANNEL_NAME);
+ (void)sprintf_s(rail->channelDef.name, ARRAYSIZE(rail->channelDef.name), RAIL_SVC_CHANNEL_NAME);
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
if ((pEntryPointsEx->cbSize >= sizeof(CHANNEL_ENTRY_POINTS_FREERDP_EX)) &&
diff --git a/channels/rail/rail_common.c b/channels/rail/rail_common.c
index dc3a566a3..f80b6ed70 100644
--- a/channels/rail/rail_common.c
+++ b/channels/rail/rail_common.c
@@ -90,8 +90,8 @@ const char* rail_get_order_type_string(UINT16 orderType)
const char* rail_get_order_type_string_full(UINT16 orderType, char* buffer, size_t length)
{
- _snprintf(buffer, length, "%s[0x%04" PRIx16 "]", rail_get_order_type_string(orderType),
- orderType);
+ (void)_snprintf(buffer, length, "%s[0x%04" PRIx16 "]", rail_get_order_type_string(orderType),
+ orderType);
return buffer;
}
@@ -594,7 +594,7 @@ const char* rail_handshake_ex_flags_to_string(UINT32 flags, char* buffer, size_t
if (len < 1)
return NULL;
- _snprintf(buffer, len, "{");
+ (void)_snprintf(buffer, len, "{");
char* fbuffer = &buffer[1];
len--;
@@ -612,7 +612,7 @@ const char* rail_handshake_ex_flags_to_string(UINT32 flags, char* buffer, size_t
winpr_str_append("EXTENDED_SPI_2_SUPPORTED", fbuffer, len, "|");
char number[16] = { 0 };
- _snprintf(number, sizeof(number), "[0x%08" PRIx32 "]", flags);
+ (void)_snprintf(number, sizeof(number), "[0x%08" PRIx32 "]", flags);
winpr_str_append(number, buffer, len, "}");
return buffer;
}
diff --git a/channels/rdp2tcp/client/rdp2tcp_main.c b/channels/rdp2tcp/client/rdp2tcp_main.c
index 0b2c8f17d..21b2e6a80 100644
--- a/channels/rdp2tcp/client/rdp2tcp_main.c
+++ b/channels/rdp2tcp/client/rdp2tcp_main.c
@@ -145,7 +145,7 @@ static DWORD WINAPI copyThread(void* data)
if (!buffer)
{
- fprintf(stderr, "rdp2tcp copyThread: malloc failed\n");
+ (void)fprintf(stderr, "rdp2tcp copyThread: malloc failed\n");
goto fail;
}
@@ -167,7 +167,7 @@ static DWORD WINAPI copyThread(void* data)
plugin->initHandle, plugin->openHandle, buffer, dwRead, buffer) != CHANNEL_RC_OK)
{
free(buffer);
- fprintf(stderr, "rdp2tcp copyThread failed %i\n", (int)dwRead);
+ (void)fprintf(stderr, "rdp2tcp copyThread failed %i\n", (int)dwRead);
goto fail;
}
diff --git a/channels/rdpdr/client/rdpdr_main.c b/channels/rdpdr/client/rdpdr_main.c
index 6995acbf5..b435d266d 100644
--- a/channels/rdpdr/client/rdpdr_main.c
+++ b/channels/rdpdr/client/rdpdr_main.c
@@ -738,11 +738,11 @@ static BOOL isAutomountLocation(const char* path)
size_t length = 0;
if (strstr(location, "%lu"))
- snprintf(buffer, sizeof(buffer), location, (unsigned long)uid);
+ (void)snprintf(buffer, sizeof(buffer), location, (unsigned long)uid);
else if (strstr(location, "%s"))
- snprintf(buffer, sizeof(buffer), location, uname);
+ (void)snprintf(buffer, sizeof(buffer), location, uname);
else
- snprintf(buffer, sizeof(buffer), "%s", location);
+ (void)snprintf(buffer, sizeof(buffer), "%s", location);
length = strnlen(buffer, sizeof(buffer));
@@ -848,7 +848,7 @@ static UINT handle_platform_mounts_linux(wLog* log, hotplug_dev* dev_array, size
{
handle_mountpoint(dev_array, size, ent->mnt_dir);
}
- fclose(f);
+ (void)fclose(f);
return ERROR_SUCCESS;
}
#endif
@@ -2311,7 +2311,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS p
rdpdr->channelDef.options =
CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP | CHANNEL_OPTION_COMPRESS_RDP;
- sprintf_s(rdpdr->channelDef.name, ARRAYSIZE(rdpdr->channelDef.name), RDPDR_SVC_CHANNEL_NAME);
+ (void)sprintf_s(rdpdr->channelDef.name, ARRAYSIZE(rdpdr->channelDef.name),
+ RDPDR_SVC_CHANNEL_NAME);
rdpdr->sequenceId = 0;
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
diff --git a/channels/rdpsnd/client/oss/rdpsnd_oss.c b/channels/rdpsnd/client/oss/rdpsnd_oss.c
index 84105fd92..d62b193c3 100644
--- a/channels/rdpsnd/client/oss/rdpsnd_oss.c
+++ b/channels/rdpsnd/client/oss/rdpsnd_oss.c
@@ -191,7 +191,7 @@ static void rdpsnd_oss_open_mixer(rdpsndOssPlugin* oss)
return;
if (oss->dev_unit != -1)
- sprintf_s(mixer_name, PATH_MAX - 1, "/dev/mixer%i", oss->dev_unit);
+ (void)sprintf_s(mixer_name, PATH_MAX - 1, "/dev/mixer%i", oss->dev_unit);
if ((oss->mixer_handle = open(mixer_name, O_RDWR)) < 0)
{
@@ -218,7 +218,7 @@ static BOOL rdpsnd_oss_open(rdpsndDevicePlugin* device, const AUDIO_FORMAT* form
return TRUE;
if (oss->dev_unit != -1)
- sprintf_s(dev_name, PATH_MAX - 1, "/dev/dsp%i", oss->dev_unit);
+ (void)sprintf_s(dev_name, PATH_MAX - 1, "/dev/dsp%i", oss->dev_unit);
WLog_INFO(TAG, "open: %s", dev_name);
diff --git a/channels/rdpsnd/client/rdpsnd_main.c b/channels/rdpsnd/client/rdpsnd_main.c
index 6c66d33ec..027574140 100644
--- a/channels/rdpsnd/client/rdpsnd_main.c
+++ b/channels/rdpsnd/client/rdpsnd_main.c
@@ -1227,9 +1227,9 @@ static VOID VCAPITYPE rdpsnd_virtual_channel_open_event_ex(LPVOID lpUserParam, D
if (error && rdpsnd && rdpsnd->rdpcontext)
{
char buffer[8192];
- _snprintf(buffer, sizeof(buffer),
- "%s rdpsnd_virtual_channel_open_event_ex reported an error",
- rdpsnd_is_dyn_str(rdpsnd->dynamic));
+ (void)_snprintf(buffer, sizeof(buffer),
+ "%s rdpsnd_virtual_channel_open_event_ex reported an error",
+ rdpsnd_is_dyn_str(rdpsnd->dynamic));
setChannelError(rdpsnd->rdpcontext, error, buffer);
}
}
@@ -1523,8 +1523,8 @@ static VOID VCAPITYPE rdpsnd_virtual_channel_init_event_ex(LPVOID lpUserParam, L
if (error && plugin && plugin->rdpcontext)
{
char buffer[8192];
- _snprintf(buffer, sizeof(buffer), "%s reported an error",
- rdpsnd_is_dyn_str(plugin->dynamic));
+ (void)_snprintf(buffer, sizeof(buffer), "%s reported an error",
+ rdpsnd_is_dyn_str(plugin->dynamic));
setChannelError(plugin->rdpcontext, error, buffer);
}
}
@@ -1576,7 +1576,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE rdpsnd_VirtualChannelEntryEx(PCHANNEL_ENTRY_P
return FALSE;
rdpsnd->channelDef.options = CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP;
- sprintf_s(rdpsnd->channelDef.name, ARRAYSIZE(rdpsnd->channelDef.name), RDPSND_CHANNEL_NAME);
+ (void)sprintf_s(rdpsnd->channelDef.name, ARRAYSIZE(rdpsnd->channelDef.name),
+ RDPSND_CHANNEL_NAME);
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
if ((pEntryPointsEx->cbSize >= sizeof(CHANNEL_ENTRY_POINTS_FREERDP_EX)) &&
diff --git a/channels/remdesk/client/remdesk_main.c b/channels/remdesk/client/remdesk_main.c
index 46222983e..978f5c6e2 100644
--- a/channels/remdesk/client/remdesk_main.c
+++ b/channels/remdesk/client/remdesk_main.c
@@ -218,8 +218,8 @@ static UINT remdesk_prepare_ctl_header(REMDESK_CTL_HEADER* ctlHeader, UINT32 msg
WINPR_ASSERT(ctlHeader);
ctlHeader->msgType = msgType;
- sprintf_s(ctlHeader->ch.ChannelName, ARRAYSIZE(ctlHeader->ch.ChannelName),
- REMDESK_CHANNEL_CTL_NAME);
+ (void)sprintf_s(ctlHeader->ch.ChannelName, ARRAYSIZE(ctlHeader->ch.ChannelName),
+ REMDESK_CHANNEL_CTL_NAME);
ctlHeader->ch.DataLength = 4 + msgSize;
return CHANNEL_RC_OK;
}
@@ -1059,8 +1059,8 @@ FREERDP_ENTRY_POINT(BOOL VCAPITYPE VirtualChannelEntryEx(PCHANNEL_ENTRY_POINTS p
remdesk->channelDef.options = CHANNEL_OPTION_INITIALIZED | CHANNEL_OPTION_ENCRYPT_RDP |
CHANNEL_OPTION_COMPRESS_RDP | CHANNEL_OPTION_SHOW_PROTOCOL;
- sprintf_s(remdesk->channelDef.name, ARRAYSIZE(remdesk->channelDef.name),
- REMDESK_SVC_CHANNEL_NAME);
+ (void)sprintf_s(remdesk->channelDef.name, ARRAYSIZE(remdesk->channelDef.name),
+ REMDESK_SVC_CHANNEL_NAME);
remdesk->Version = 2;
pEntryPointsEx = (CHANNEL_ENTRY_POINTS_FREERDP_EX*)pEntryPoints;
diff --git a/channels/remdesk/server/remdesk_main.c b/channels/remdesk/server/remdesk_main.c
index 4c823aab9..5aed1e3dd 100644
--- a/channels/remdesk/server/remdesk_main.c
+++ b/channels/remdesk/server/remdesk_main.c
@@ -128,8 +128,8 @@ static UINT remdesk_prepare_ctl_header(REMDESK_CTL_HEADER* ctlHeader, UINT32 msg
UINT32 msgSize)
{
ctlHeader->msgType = msgType;
- sprintf_s(ctlHeader->ch.ChannelName, ARRAYSIZE(ctlHeader->ch.ChannelName),
- REMDESK_CHANNEL_CTL_NAME);
+ (void)sprintf_s(ctlHeader->ch.ChannelName, ARRAYSIZE(ctlHeader->ch.ChannelName),
+ REMDESK_CHANNEL_CTL_NAME);
ctlHeader->ch.DataLength = 4 + msgSize;
return CHANNEL_RC_OK;
}
diff --git a/channels/tsmf/client/tsmf_media.c b/channels/tsmf/client/tsmf_media.c
index b20db4159..878ba0dfd 100644
--- a/channels/tsmf/client/tsmf_media.c
+++ b/channels/tsmf/client/tsmf_media.c
@@ -384,7 +384,7 @@ static char* guid_to_string(const BYTE* guid, char* str, size_t len)
return NULL;
for (size_t i = 0; i < GUID_SIZE && (len > 2 * i); i++)
- sprintf_s(str + (2 * i), len - 2 * i, "%02" PRIX8 "", guid[i]);
+ (void)sprintf_s(str + (2 * i), len - 2 * i, "%02" PRIX8 "", guid[i]);
return str;
}
@@ -1504,12 +1504,12 @@ static void tsmf_signal_handler(int s)
if (s == SIGINT)
{
- signal(s, SIG_DFL);
+ (void)signal(s, SIG_DFL);
kill(getpid(), s);
}
else if (s == SIGUSR1)
{
- signal(s, SIG_DFL);
+ (void)signal(s, SIG_DFL);
}
}
diff --git a/channels/urbdrc/client/libusb/libusb_udevice.c b/channels/urbdrc/client/libusb/libusb_udevice.c
index 331adecf3..4604e1aaf 100644
--- a/channels/urbdrc/client/libusb/libusb_udevice.c
+++ b/channels/urbdrc/client/libusb/libusb_udevice.c
@@ -141,7 +141,7 @@ static BOOL log_libusb_result_(wLog* log, DWORD lvl, WINPR_FORMAT_ARG const char
char buffer[8192] = { 0 };
va_list ap;
va_start(ap, error);
- vsnprintf(buffer, sizeof(buffer), fmt, ap);
+ (void)vsnprintf(buffer, sizeof(buffer), fmt, ap);
va_end(ap);
WLog_Print(log, lvl, "[%s:%" PRIuz "]: %s: error %s[%d]", fkt, line, buffer,
@@ -894,8 +894,8 @@ static UINT32 libusb_udev_control_query_device_text(IUDEVICE* idev, UINT32 TextT
case DeviceTextLocationInformation:
bus_number = libusb_get_bus_number(pdev->libusb_dev);
device_address = libusb_get_device_address(pdev->libusb_dev);
- sprintf_s(deviceLocation, sizeof(deviceLocation),
- "Port_#%04" PRIu8 ".Hub_#%04" PRIu8 "", device_address, bus_number);
+ (void)sprintf_s(deviceLocation, sizeof(deviceLocation),
+ "Port_#%04" PRIu8 ".Hub_#%04" PRIu8 "", device_address, bus_number);
len = strnlen(deviceLocation,
MIN(sizeof(deviceLocation), (inSize > 0) ? inSize - 1U : 0));
@@ -1608,7 +1608,7 @@ static int udev_get_device_handle(URBDRC_PLUGIN* urbdrc, libusb_context* ctx, UD
error = 0;
WLog_Print(urbdrc->log, WLOG_DEBUG, " Port: %d", pdev->port_number);
/* gen device path */
- sprintf(pdev->path, "%" PRIu16 "-%d", bus_number, pdev->port_number);
+ (void)sprintf(pdev->path, "%" PRIu16 "-%d", bus_number, pdev->port_number);
WLog_Print(urbdrc->log, WLOG_DEBUG, " DevPath: %s", pdev->path);
}
diff --git a/channels/urbdrc/client/urbdrc_main.c b/channels/urbdrc/client/urbdrc_main.c
index 96e443d88..6d868b25e 100644
--- a/channels/urbdrc/client/urbdrc_main.c
+++ b/channels/urbdrc/client/urbdrc_main.c
@@ -80,33 +80,33 @@ static int func_container_id_generate(IUDEVICE* pdev, char* strContainerId)
else
p = path;
- sprintf_s((char*)containerId, sizeof(containerId), "%04" PRIX16 "%04" PRIX16 "%s", idVendor,
- idProduct, p);
+ (void)sprintf_s((char*)containerId, sizeof(containerId), "%04" PRIX16 "%04" PRIX16 "%s",
+ idVendor, idProduct, p);
/* format */
- sprintf_s(strContainerId, DEVICE_CONTAINER_STR_SIZE,
- "{%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8
- "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8
- "%02" PRIx8 "%02" PRIx8 "}",
- containerId[0], containerId[1], containerId[2], containerId[3], containerId[4],
- containerId[5], containerId[6], containerId[7], containerId[8], containerId[9],
- containerId[10], containerId[11], containerId[12], containerId[13], containerId[14],
- containerId[15]);
+ (void)sprintf_s(strContainerId, DEVICE_CONTAINER_STR_SIZE,
+ "{%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8
+ "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8
+ "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "}",
+ containerId[0], containerId[1], containerId[2], containerId[3], containerId[4],
+ containerId[5], containerId[6], containerId[7], containerId[8], containerId[9],
+ containerId[10], containerId[11], containerId[12], containerId[13],
+ containerId[14], containerId[15]);
return 0;
}
static int func_instance_id_generate(IUDEVICE* pdev, char* strInstanceId, size_t len)
{
char instanceId[17] = { 0 };
- sprintf_s(instanceId, sizeof(instanceId), "\\%s", pdev->getPath(pdev));
+ (void)sprintf_s(instanceId, sizeof(instanceId), "\\%s", pdev->getPath(pdev));
/* format */
- sprintf_s(strInstanceId, len,
- "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8
- "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8
- "%02" PRIx8 "%02" PRIx8 "",
- instanceId[0], instanceId[1], instanceId[2], instanceId[3], instanceId[4],
- instanceId[5], instanceId[6], instanceId[7], instanceId[8], instanceId[9],
- instanceId[10], instanceId[11], instanceId[12], instanceId[13], instanceId[14],
- instanceId[15]);
+ (void)sprintf_s(strInstanceId, len,
+ "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8
+ "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8 "-%02" PRIx8 "%02" PRIx8
+ "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "%02" PRIx8 "",
+ instanceId[0], instanceId[1], instanceId[2], instanceId[3], instanceId[4],
+ instanceId[5], instanceId[6], instanceId[7], instanceId[8], instanceId[9],
+ instanceId[10], instanceId[11], instanceId[12], instanceId[13], instanceId[14],
+ instanceId[15]);
return 0;
}
@@ -246,11 +246,11 @@ static UINT urdbrc_send_usb_device_add(GENERIC_CHANNEL_CALLBACK* callback, IUDEV
const UINT16 idVendor = (UINT16)pdev->query_device_descriptor(pdev, ID_VENDOR);
const UINT16 idProduct = (UINT16)pdev->query_device_descriptor(pdev, ID_PRODUCT);
const UINT16 bcdDevice = (UINT16)pdev->query_device_descriptor(pdev, BCD_DEVICE);
- sprintf_s(HardwareIds[1], DEVICE_HARDWARE_ID_SIZE,
- "USB\\VID_%04" PRIX16 "&PID_%04" PRIX16 "", idVendor, idProduct);
- sprintf_s(HardwareIds[0], DEVICE_HARDWARE_ID_SIZE,
- "USB\\VID_%04" PRIX16 "&PID_%04" PRIX16 "&REV_%04" PRIX16 "", idVendor, idProduct,
- bcdDevice);
+ (void)sprintf_s(HardwareIds[1], DEVICE_HARDWARE_ID_SIZE,
+ "USB\\VID_%04" PRIX16 "&PID_%04" PRIX16 "", idVendor, idProduct);
+ (void)sprintf_s(HardwareIds[0], DEVICE_HARDWARE_ID_SIZE,
+ "USB\\VID_%04" PRIX16 "&PID_%04" PRIX16 "&REV_%04" PRIX16 "", idVendor,
+ idProduct, bcdDevice);
}
{
const UINT8 bDeviceClass = (UINT8)pdev->query_device_descriptor(pdev, B_DEVICE_CLASS);
@@ -259,22 +259,22 @@ static UINT urdbrc_send_usb_device_add(GENERIC_CHANNEL_CALLBACK* callback, IUDEV
if (!(pdev->isCompositeDevice(pdev)))
{
- sprintf_s(CompatibilityIds[2], DEVICE_COMPATIBILITY_ID_SIZE, "USB\\Class_%02" PRIX8 "",
- bDeviceClass);
- sprintf_s(CompatibilityIds[1], DEVICE_COMPATIBILITY_ID_SIZE,
- "USB\\Class_%02" PRIX8 "&SubClass_%02" PRIX8 "", bDeviceClass,
- bDeviceSubClass);
- sprintf_s(CompatibilityIds[0], DEVICE_COMPATIBILITY_ID_SIZE,
- "USB\\Class_%02" PRIX8 "&SubClass_%02" PRIX8 "&Prot_%02" PRIX8 "",
- bDeviceClass, bDeviceSubClass, bDeviceProtocol);
+ (void)sprintf_s(CompatibilityIds[2], DEVICE_COMPATIBILITY_ID_SIZE,
+ "USB\\Class_%02" PRIX8 "", bDeviceClass);
+ (void)sprintf_s(CompatibilityIds[1], DEVICE_COMPATIBILITY_ID_SIZE,
+ "USB\\Class_%02" PRIX8 "&SubClass_%02" PRIX8 "", bDeviceClass,
+ bDeviceSubClass);
+ (void)sprintf_s(CompatibilityIds[0], DEVICE_COMPATIBILITY_ID_SIZE,
+ "USB\\Class_%02" PRIX8 "&SubClass_%02" PRIX8 "&Prot_%02" PRIX8 "",
+ bDeviceClass, bDeviceSubClass, bDeviceProtocol);
}
else
{
- sprintf_s(CompatibilityIds[2], DEVICE_COMPATIBILITY_ID_SIZE, "USB\\DevClass_00");
- sprintf_s(CompatibilityIds[1], DEVICE_COMPATIBILITY_ID_SIZE,
- "USB\\DevClass_00&SubClass_00");
- sprintf_s(CompatibilityIds[0], DEVICE_COMPATIBILITY_ID_SIZE,
- "USB\\DevClass_00&SubClass_00&Prot_00");
+ (void)sprintf_s(CompatibilityIds[2], DEVICE_COMPATIBILITY_ID_SIZE, "USB\\DevClass_00");
+ (void)sprintf_s(CompatibilityIds[1], DEVICE_COMPATIBILITY_ID_SIZE,
+ "USB\\DevClass_00&SubClass_00");
+ (void)sprintf_s(CompatibilityIds[0], DEVICE_COMPATIBILITY_ID_SIZE,
+ "USB\\DevClass_00&SubClass_00&Prot_00");
}
}
func_instance_id_generate(pdev, strInstanceId, DEVICE_INSTANCE_STR_SIZE);
diff --git a/client/SDL/SDL2/sdl_freerdp.cpp b/client/SDL/SDL2/sdl_freerdp.cpp
index 8880f68ca..ceb63a585 100644
--- a/client/SDL/SDL2/sdl_freerdp.cpp
+++ b/client/SDL/SDL2/sdl_freerdp.cpp
@@ -663,9 +663,9 @@ static const char* sdl_window_get_title(rdpSettings* settings)
char buffer[MAX_PATH + 64] = { 0 };
if (!addPort)
- sprintf_s(buffer, sizeof(buffer), "%s %s", prefix, name);
+ (void)sprintf_s(buffer, sizeof(buffer), "%s %s", prefix, name);
else
- sprintf_s(buffer, sizeof(buffer), "%s %s:%" PRIu32, prefix, name, port);
+ (void)sprintf_s(buffer, sizeof(buffer), "%s %s:%" PRIu32, prefix, name, port);
if (!freerdp_settings_set_string(settings, FreeRDP_WindowTitle, buffer))
return nullptr;
diff --git a/client/Wayland/wlf_cliprdr.c b/client/Wayland/wlf_cliprdr.c
index 3b0ff36fc..cfe08f8c7 100644
--- a/client/Wayland/wlf_cliprdr.c
+++ b/client/Wayland/wlf_cliprdr.c
@@ -108,7 +108,7 @@ static void wlf_request_free(void* rq)
{
free(request->responseMime);
if (request->responseFile)
- fclose(request->responseFile);
+ (void)fclose(request->responseFile);
}
free(request);
}
diff --git a/client/Wayland/wlfreerdp.c b/client/Wayland/wlfreerdp.c
index c77d16389..a0bef14eb 100644
--- a/client/Wayland/wlfreerdp.c
+++ b/client/Wayland/wlfreerdp.c
@@ -582,7 +582,7 @@ disconnect:
static BOOL wlf_client_global_init(void)
{
- setlocale(LC_ALL, "");
+ (void)setlocale(LC_ALL, "");
if (freerdp_handle_signals() != 0)
return FALSE;
diff --git a/client/X11/xf_client.c b/client/X11/xf_client.c
index e8fd8f617..4031d77ea 100644
--- a/client/X11/xf_client.c
+++ b/client/X11/xf_client.c
@@ -539,10 +539,10 @@ static char* xf_window_get_title(rdpSettings* settings)
return NULL;
if (!port)
- sprintf_s(windowTitle, size, "%s %s", prefix, name);
+ (void)sprintf_s(windowTitle, size, "%s %s", prefix, name);
else
- sprintf_s(windowTitle, size, "%s %s:%i", prefix, name,
- freerdp_settings_get_uint32(settings, FreeRDP_ServerPort));
+ (void)sprintf_s(windowTitle, size, "%s %s:%i", prefix, name,
+ freerdp_settings_get_uint32(settings, FreeRDP_ServerPort));
return windowTitle;
}
@@ -1749,7 +1749,7 @@ static void xf_PanningChangeEventHandler(void* context, const PanningChangeEvent
static BOOL xfreerdp_client_global_init(void)
{
- setlocale(LC_ALL, "");
+ (void)setlocale(LC_ALL, "");
if (freerdp_handle_signals() != 0)
return FALSE;
diff --git a/client/X11/xf_event.c b/client/X11/xf_event.c
index 5da6fde26..ac91a6472 100644
--- a/client/X11/xf_event.c
+++ b/client/X11/xf_event.c
@@ -305,8 +305,8 @@ static BOOL xf_event_execute_action_script(xfContext* xfc, const XEvent* event)
char command[2048] = { 0 };
char arg[2048] = { 0 };
- _snprintf(command, sizeof(command), "xevent %s", xeventName);
- _snprintf(arg, sizeof(arg), "%lu", (unsigned long)xfc->window->handle);
+ (void)_snprintf(command, sizeof(command), "xevent %s", xeventName);
+ (void)_snprintf(arg, sizeof(arg), "%lu", (unsigned long)xfc->window->handle);
if (!run_action_script(xfc, command, arg, action_script_run, NULL))
return FALSE;
return TRUE;
diff --git a/client/X11/xf_keyboard.c b/client/X11/xf_keyboard.c
index c51b309e6..74ed404a0 100644
--- a/client/X11/xf_keyboard.c
+++ b/client/X11/xf_keyboard.c
@@ -533,7 +533,7 @@ static int xf_keyboard_execute_action_script(xfContext* xfc, XF_MODIFIER_KEYS* m
if (!match)
return 1;
- sprintf_s(command, sizeof(command), "key %s", combination);
+ (void)sprintf_s(command, sizeof(command), "key %s", combination);
if (!run_action_script(xfc, command, NULL, action_script_run, &status))
return -1;
diff --git a/client/X11/xf_utils.c b/client/X11/xf_utils.c
index 58d6ebccf..2f99a3ad7 100644
--- a/client/X11/xf_utils.c
+++ b/client/X11/xf_utils.c
@@ -194,7 +194,7 @@ BOOL run_action_script(xfContext* xfc, const char* what, const char* arg, fn_act
goto fail;
char command[2048] = { 0 };
- sprintf_s(command, sizeof(command), "%s %s", ActionScript, what);
+ (void)sprintf_s(command, sizeof(command), "%s %s", ActionScript, what);
keyScript = popen(command, "r");
if (!keyScript)
@@ -208,7 +208,7 @@ BOOL run_action_script(xfContext* xfc, const char* what, const char* arg, fn_act
while (fgets(buffer, sizeof(buffer), keyScript) != NULL)
{
char* context = NULL;
- strtok_s(buffer, "\n", &context);
+ (void)strtok_s(buffer, "\n", &context);
if (fkt)
{
diff --git a/client/X11/xf_window.c b/client/X11/xf_window.c
index 774f3d5f2..0516b4569 100644
--- a/client/X11/xf_window.c
+++ b/client/X11/xf_window.c
@@ -472,7 +472,8 @@ static void xf_SetWindowPID(xfContext* xfc, Window window, pid_t pid)
static const char* get_shm_id(void)
{
static char shm_id[64];
- sprintf_s(shm_id, sizeof(shm_id), "/com.freerdp.xfreerdp.tsmf_%016X", GetCurrentProcessId());
+ (void)sprintf_s(shm_id, sizeof(shm_id), "/com.freerdp.xfreerdp.tsmf_%016X",
+ GetCurrentProcessId());
return shm_id;
}
diff --git a/client/common/client.c b/client/common/client.c
index 1f78f75ef..04bd78ff2 100644
--- a/client/common/client.c
+++ b/client/common/client.c
@@ -458,7 +458,7 @@ static BOOL client_cli_authenticate_raw(freerdp* instance, rdp_auth_reason reaso
{
size_t username_size = 0;
printf("%s", prompt[0]);
- fflush(stdout);
+ (void)fflush(stdout);
if (freerdp_interruptible_get_line(instance->context, username, &username_size, stdin) < 0)
{
@@ -479,7 +479,7 @@ static BOOL client_cli_authenticate_raw(freerdp* instance, rdp_auth_reason reaso
{
size_t domain_size = 0;
printf("%s", prompt[1]);
- fflush(stdout);
+ (void)fflush(stdout);
if (freerdp_interruptible_get_line(instance->context, domain, &domain_size, stdin) < 0)
{
@@ -579,7 +579,7 @@ BOOL client_cli_choose_smartcard(freerdp* instance, SmartcardCertInfo** cert_lis
printf("\nChoose a smartcard to use for %s (0 - %" PRIu32 "): ",
gateway ? "gateway authentication" : "logon", count - 1);
- fflush(stdout);
+ (void)fflush(stdout);
if (!fgets(input, 10, stdin))
{
WLog_ERR(TAG, "could not read from stdin");
@@ -631,7 +631,7 @@ static DWORD client_cli_accept_certificate(freerdp* instance)
while (1)
{
printf("Do you trust the above certificate? (Y/T/N) ");
- fflush(stdout);
+ (void)fflush(stdout);
answer = freerdp_interruptible_getc(instance->context, stdin);
if ((answer == EOF) || feof(stdin))
@@ -943,7 +943,7 @@ BOOL client_cli_present_gateway_message(freerdp* instance, UINT32 type, BOOL isD
while (isConsentMandatory)
{
printf("I understand and agree to the terms of this policy (Y/N) \n");
- fflush(stdout);
+ (void)fflush(stdout);
answer = freerdp_interruptible_getc(instance->context, stdin);
if ((answer == EOF) || feof(stdin))
diff --git a/client/common/client_cliprdr_file.c b/client/common/client_cliprdr_file.c
index df9226f24..12a1ed3da 100644
--- a/client/common/client_cliprdr_file.c
+++ b/client/common/client_cliprdr_file.c
@@ -1401,7 +1401,7 @@ static void cliprdr_local_file_try_close(CliprdrLocalFile* file, UINT res, UINT6
// TODO: for the time being just close again.
}
if (file->fp)
- fclose(file->fp);
+ (void)fclose(file->fp);
file->fp = NULL;
}
@@ -1705,9 +1705,11 @@ static CliprdrFuseFile* clip_data_dir_new(CliprdrFileContext* file_context, BOOL
}
if (has_clip_data_id)
- _snprintf(clip_data_dir->filename_with_root, path_length, "/%u", (unsigned)clip_data_id);
+ (void)_snprintf(clip_data_dir->filename_with_root, path_length, "/%u",
+ (unsigned)clip_data_id);
else
- _snprintf(clip_data_dir->filename_with_root, path_length, "/%" PRIu64, NO_CLIP_DATA_ID);
+ (void)_snprintf(clip_data_dir->filename_with_root, path_length, "/%" PRIu64,
+ NO_CLIP_DATA_ID);
clip_data_dir->filename = strrchr(clip_data_dir->filename_with_root, '/') + 1;
@@ -1863,8 +1865,8 @@ static BOOL set_selection_for_clip_data_entry(CliprdrFileContext* file_context,
return FALSE;
}
- _snprintf(fuse_file->filename_with_root, path_length, "%s/%s",
- clip_data_dir->filename_with_root, filename);
+ (void)_snprintf(fuse_file->filename_with_root, path_length, "%s/%s",
+ clip_data_dir->filename_with_root, filename);
free(filename);
fuse_file->filename = strrchr(fuse_file->filename_with_root, '/') + 1;
@@ -2098,7 +2100,8 @@ static BOOL create_base_path(CliprdrFileContext* file)
WINPR_ASSERT(file);
char base[64] = { 0 };
- _snprintf(base, sizeof(base), "com.freerdp.client.cliprdr.%" PRIu32, GetCurrentProcessId());
+ (void)_snprintf(base, sizeof(base), "com.freerdp.client.cliprdr.%" PRIu32,
+ GetCurrentProcessId());
file->path = GetKnownSubPath(KNOWN_PATH_TEMP, base);
if (!file->path)
@@ -2120,7 +2123,7 @@ static void cliprdr_local_file_free(CliprdrLocalFile* file)
if (file->fp)
{
WLog_Print(file->context->log, WLOG_DEBUG, "closing file %s, discarding entry", file->name);
- fclose(file->fp);
+ (void)fclose(file->fp);
}
free(file->name);
*file = empty;
@@ -2366,7 +2369,7 @@ static CliprdrFuseFile* fuse_file_new_root(CliprdrFileContext* file_context)
return NULL;
}
- _snprintf(root_dir->filename_with_root, 2, "/");
+ (void)_snprintf(root_dir->filename_with_root, 2, "/");
root_dir->filename = root_dir->filename_with_root;
root_dir->ino = FUSE_ROOT_ID;
diff --git a/client/common/cmdline.c b/client/common/cmdline.c
index bd057163a..feb4a69f3 100644
--- a/client/common/cmdline.c
+++ b/client/common/cmdline.c
@@ -100,10 +100,10 @@ static BOOL freerdp_client_print_codepages(const char* arg)
char buffer[2048] = { 0 };
if (strnlen(page->subLanguageSymbol, ARRAYSIZE(page->subLanguageSymbol)) > 0)
- _snprintf(buffer, sizeof(buffer), "[%s|%s]", page->primaryLanguageSymbol,
- page->subLanguageSymbol);
+ (void)_snprintf(buffer, sizeof(buffer), "[%s|%s]", page->primaryLanguageSymbol,
+ page->subLanguageSymbol);
else
- _snprintf(buffer, sizeof(buffer), "[%s]", page->primaryLanguageSymbol);
+ (void)_snprintf(buffer, sizeof(buffer), "[%s]", page->primaryLanguageSymbol);
printf("id=0x%04" PRIx16 ": [%-6s] %-60s %-36s %-48s\n", page->id, page->locale, buffer,
page->primaryLanguage, page->subLanguage);
}
@@ -2857,7 +2857,7 @@ static int parse_kbd_options(rdpSettings* settings, const COMMAND_LINE_ARGUMENT_
if (!tmp)
rc = COMMAND_LINE_ERROR_MEMORY;
else
- _snprintf(tmp, tlen, "%s,%s", old, now);
+ (void)_snprintf(tmp, tlen, "%s,%s", old, now);
free(now);
now = tmp;
}
diff --git a/client/common/file.c b/client/common/file.c
index 3ebb3378c..1d544bd93 100644
--- a/client/common/file.c
+++ b/client/common/file.c
@@ -1028,7 +1028,7 @@ BOOL freerdp_client_parse_rdp_file_ex(rdpFile* file, const char* name, rdp_file_
if (file_size < 1)
{
WLog_ERR(TAG, "RDP file %s is empty", name);
- fclose(fp);
+ (void)fclose(fp);
return FALSE;
}
@@ -1036,7 +1036,7 @@ BOOL freerdp_client_parse_rdp_file_ex(rdpFile* file, const char* name, rdp_file_
if (!buffer)
{
- fclose(fp);
+ (void)fclose(fp);
return FALSE;
}
@@ -1048,7 +1048,7 @@ BOOL freerdp_client_parse_rdp_file_ex(rdpFile* file, const char* name, rdp_file_
read_size = (size_t)file_size;
}
- fclose(fp);
+ (void)fclose(fp);
if (read_size < 1)
{
@@ -1390,7 +1390,7 @@ BOOL freerdp_client_write_rdp_file(const rdpFile* file, const char* name, BOOL u
if (!unicodestr)
{
free(buffer);
- fclose(fp);
+ (void)fclose(fp);
return FALSE;
}
@@ -1400,7 +1400,7 @@ BOOL freerdp_client_write_rdp_file(const rdpFile* file, const char* name, BOOL u
{
free(buffer);
free(unicodestr);
- fclose(fp);
+ (void)fclose(fp);
return FALSE;
}
@@ -1411,12 +1411,12 @@ BOOL freerdp_client_write_rdp_file(const rdpFile* file, const char* name, BOOL u
if (fwrite(buffer, 1, (size_t)size, fp) != (size_t)size)
{
free(buffer);
- fclose(fp);
+ (void)fclose(fp);
return FALSE;
}
}
- fflush(fp);
+ (void)fflush(fp);
status = fclose(fp);
}
@@ -1652,7 +1652,7 @@ static ADDIN_ARGV* rdp_file_to_args(const char* channel, const char* values)
if (!str)
goto fail;
- _snprintf(str, len, "device:%s", val);
+ (void)_snprintf(str, len, "device:%s", val);
rc = freerdp_addin_argv_add_argument(args, str);
free(str);
if (!rc)
diff --git a/client/common/man/generate_argument_docbook.c b/client/common/man/generate_argument_docbook.c
index a591dd0f6..4f6034f86 100644
--- a/client/common/man/generate_argument_docbook.c
+++ b/client/common/man/generate_argument_docbook.c
@@ -12,8 +12,9 @@ static char* resize(char** buffer, size_t* size, size_t increment)
char* tmp = realloc(*buffer, nsize);
if (!tmp)
{
- fprintf(stderr, "Could not reallocate string buffer from %" PRIuz " to %" PRIuz " bytes.\n",
- *size, nsize);
+ (void)fprintf(stderr,
+ "Could not reallocate string buffer from %" PRIuz " to %" PRIuz " bytes.\n",
+ *size, nsize);
free(*buffer);
return NULL;
}
@@ -113,24 +114,24 @@ int main(int argc, char* argv[])
size_t elements = sizeof(global_cmd_args) / sizeof(global_cmd_args[0]);
const char* fname = "freerdp-argument.1.xml";
- fprintf(stdout, "Generating docbook file '%s'\n", fname);
+ (void)fprintf(stdout, "Generating docbook file '%s'\n", fname);
FILE* fp = fopen(fname, "w");
if (NULL == fp)
{
- fprintf(stderr, "Could not open '%s' for writing.\n", fname);
+ (void)fprintf(stderr, "Could not open '%s' for writing.\n", fname);
return -1;
}
/* The tag used as header in the manpage */
- fprintf(fp, "\n");
- fprintf(fp, "\tOptions\n");
- fprintf(fp, "\t\t\n");
+ (void)fprintf(fp, "\n");
+ (void)fprintf(fp, "\tOptions\n");
+ (void)fprintf(fp, "\t\t\n");
/* Iterate over argument struct and write data to docbook 4.5
* compatible XML */
if (elements < 2)
{
- fprintf(stderr, "The argument array 'args' is empty, writing an empty file.\n");
+ (void)fprintf(stderr, "The argument array 'args' is empty, writing an empty file.\n");
elements = 1;
}
@@ -141,31 +142,31 @@ int main(int argc, char* argv[])
char* alias = tr_esc_str(arg->Alias, FALSE);
char* format = tr_esc_str(arg->Format, TRUE);
char* text = tr_esc_str(arg->Text, FALSE);
- fprintf(fp, "\t\t\t\n");
+ (void)fprintf(fp, "\t\t\t\n");
do
{
- fprintf(fp, "\t\t\t\t", name);
if (format)
{
if (arg->Flags == COMMAND_LINE_VALUE_OPTIONAL)
- fprintf(fp, "[");
+ (void)fprintf(fp, "[");
- fprintf(fp, ":%s", format);
+ (void)fprintf(fp, ":%s", format);
if (arg->Flags == COMMAND_LINE_VALUE_OPTIONAL)
- fprintf(fp, "]");
+ (void)fprintf(fp, "]");
}
- fprintf(fp, "\n");
+ (void)fprintf(fp, "\n");
if (alias == name)
break;
@@ -176,36 +177,36 @@ int main(int argc, char* argv[])
if (text)
{
- fprintf(fp, "\t\t\t\t\n");
- fprintf(fp, "\t\t\t\t\t");
+ (void)fprintf(fp, "\t\t\t\t\n");
+ (void)fprintf(fp, "\t\t\t\t\t");
if (text)
- fprintf(fp, "%s", text);
+ (void)fprintf(fp, "%s", text);
if (arg->Flags & COMMAND_LINE_VALUE_BOOL &&
(!arg->Default || arg->Default == BoolValueTrue))
- fprintf(fp, " (default:%s)", arg->Default ? "on" : "off");
+ (void)fprintf(fp, " (default:%s)", arg->Default ? "on" : "off");
else if (arg->Default)
{
char* value = tr_esc_str(arg->Default, FALSE);
- fprintf(fp, " (default:%s)", value);
+ (void)fprintf(fp, " (default:%s)", value);
free(value);
}
- fprintf(fp, "\n");
- fprintf(fp, "\t\t\t\t\n");
+ (void)fprintf(fp, "\n");
+ (void)fprintf(fp, "\t\t\t\t\n");
}
- fprintf(fp, "\t\t\t\n");
+ (void)fprintf(fp, "\t\t\t\n");
free(name);
free(format);
free(text);
}
- fprintf(fp, "\t\t\n");
- fprintf(fp, "\t\n");
- fclose(fp);
+ (void)fprintf(fp, "\t\t\n");
+ (void)fprintf(fp, "\t\n");
+ (void)fclose(fp);
- fprintf(stdout, "successfully generated '%s'\n", fname);
+ (void)fprintf(stdout, "successfully generated '%s'\n", fname);
return 0;
}
diff --git a/client/common/test/TestClientCmdLine.c b/client/common/test/TestClientCmdLine.c
index ba0cfe620..d7ed102c4 100644
--- a/client/common/test/TestClientCmdLine.c
+++ b/client/common/test/TestClientCmdLine.c
@@ -10,22 +10,22 @@ typedef BOOL (*validate_settings_pr)(rdpSettings* settings);
#define printref() printf("%s:%d: in function %-40s:", __FILE__, __LINE__, __func__)
-#define TEST_ERROR(format, ...) \
- do \
- { \
- fprintf(stderr, format, ##__VA_ARGS__); \
- printref(); \
- printf(format, ##__VA_ARGS__); \
- fflush(stdout); \
+#define TEST_ERROR(format, ...) \
+ do \
+ { \
+ (void)fprintf(stderr, format, ##__VA_ARGS__); \
+ printref(); \
+ (void)printf(format, ##__VA_ARGS__); \
+ (void)fflush(stdout); \
} while (0)
-#define TEST_FAILURE(format, ...) \
- do \
- { \
- printref(); \
- printf(" FAILURE "); \
- printf(format, ##__VA_ARGS__); \
- fflush(stdout); \
+#define TEST_FAILURE(format, ...) \
+ do \
+ { \
+ printref(); \
+ (void)printf(" FAILURE "); \
+ (void)printf(format, ##__VA_ARGS__); \
+ (void)fflush(stdout); \
} while (0)
static void print_test_title(int argc, char** argv)
@@ -223,7 +223,7 @@ static void check_modified_arguments(const test* test, char** command_line, int*
printref();
printf("Failure: overridden argument %d is %s but it should be %s\n", index,
actual_argument, expected_argument);
- fflush(stdout);
+ (void)fflush(stdout);
*rc = -1;
}
}
diff --git a/libfreerdp/cache/persistent.c b/libfreerdp/cache/persistent.c
index b14ee4e97..62e352f7a 100644
--- a/libfreerdp/cache/persistent.c
+++ b/libfreerdp/cache/persistent.c
@@ -263,7 +263,7 @@ static int persistent_cache_open_read(rdpPersistentCache* persistent)
else
persistent->version = 2;
- fseek(persistent->fp, 0, SEEK_SET);
+ (void)fseek(persistent->fp, 0, SEEK_SET);
if (persistent->version == 3)
{
@@ -281,7 +281,7 @@ static int persistent_cache_open_read(rdpPersistentCache* persistent)
offset = 0;
}
- fseek(persistent->fp, offset, SEEK_SET);
+ (void)fseek(persistent->fp, offset, SEEK_SET);
return status;
}
@@ -336,7 +336,7 @@ int persistent_cache_close(rdpPersistentCache* persistent)
WINPR_ASSERT(persistent);
if (persistent->fp)
{
- fclose(persistent->fp);
+ (void)fclose(persistent->fp);
persistent->fp = NULL;
}
diff --git a/libfreerdp/codec/interleaved.c b/libfreerdp/codec/interleaved.c
index ae3950bc1..d037ebd34 100644
--- a/libfreerdp/codec/interleaved.c
+++ b/libfreerdp/codec/interleaved.c
@@ -149,7 +149,7 @@ static const char* rle_code_str(UINT32 code)
static const char* rle_code_str_buffer(UINT32 code, char* buffer, size_t size)
{
const char* str = rle_code_str(code);
- _snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, code);
+ (void)_snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, code);
return buffer;
}
diff --git a/libfreerdp/codec/test/TestFreeRDPCodecClear.c b/libfreerdp/codec/test/TestFreeRDPCodecClear.c
index ee4bc3b1b..10f2ac7c4 100644
--- a/libfreerdp/codec/test/TestFreeRDPCodecClear.c
+++ b/libfreerdp/codec/test/TestFreeRDPCodecClear.c
@@ -59,8 +59,8 @@ static BOOL test_ClearDecompressExample(UINT32 nr, UINT32 width, UINT32 height,
status = clear_decompress(clear, pSrcData, SrcSize, width, height, pDstData,
PIXEL_FORMAT_XRGB32, 0, 0, 0, width, height, NULL);
- printf("clear_decompress example %" PRIu32 " status: %d\n", nr, status);
- fflush(stdout);
+ (void)printf("clear_decompress example %" PRIu32 " status: %d\n", nr, status);
+ (void)fflush(stdout);
rc = (status == 0);
fail:
clear_context_free(clear);
diff --git a/libfreerdp/codec/test/TestFreeRDPCodecCopy.c b/libfreerdp/codec/test/TestFreeRDPCodecCopy.c
index da32fa4b7..01725b6b9 100644
--- a/libfreerdp/codec/test/TestFreeRDPCodecCopy.c
+++ b/libfreerdp/codec/test/TestFreeRDPCodecCopy.c
@@ -35,9 +35,10 @@ static BOOL TestFreeRDPImageCopy(UINT32 w, UINT32 h, UINT32 srcFormat, UINT32 ds
double ms = end - start;
ms /= 1000000.0;
- fprintf(stdout, "[%s] copied %" PRIu32 "x%" PRIu32 " [%-20s] -> [%-20s] in %lf ms [%s]\n",
- __func__, w, h, FreeRDPGetColorFormatName(srcFormat),
- FreeRDPGetColorFormatName(dstFormat), ms, rc ? "success" : "failure");
+ (void)fprintf(stdout,
+ "[%s] copied %" PRIu32 "x%" PRIu32 " [%-20s] -> [%-20s] in %lf ms [%s]\n",
+ __func__, w, h, FreeRDPGetColorFormatName(srcFormat),
+ FreeRDPGetColorFormatName(dstFormat), ms, rc ? "success" : "failure");
if (!rc)
break;
}
@@ -72,9 +73,10 @@ static BOOL TestFreeRDPImageCopy_no_overlap(UINT32 w, UINT32 h, UINT32 srcFormat
double ms = end - start;
ms /= 1000000.0;
- fprintf(stdout, "[%s] copied %" PRIu32 "x%" PRIu32 " [%-20s] -> [%-20s] in %lf ms [%s]\n",
- __func__, w, h, FreeRDPGetColorFormatName(srcFormat),
- FreeRDPGetColorFormatName(dstFormat), ms, rc ? "success" : "failure");
+ (void)fprintf(stdout,
+ "[%s] copied %" PRIu32 "x%" PRIu32 " [%-20s] -> [%-20s] in %lf ms [%s]\n",
+ __func__, w, h, FreeRDPGetColorFormatName(srcFormat),
+ FreeRDPGetColorFormatName(dstFormat), ms, rc ? "success" : "failure");
if (!rc)
break;
}
@@ -106,8 +108,8 @@ int TestFreeRDPCodecCopy(int argc, char* argv[])
if ((errno != 0) || (width == 0) || (height == 0))
{
char buffer[128] = { 0 };
- fprintf(stderr, "%s failed: width=%" PRIu32 ", height=%" PRIu32 ", errno=%s\n",
- __func__, width, height, winpr_strerror(errno, buffer, sizeof(buffer)));
+ (void)fprintf(stderr, "%s failed: width=%" PRIu32 ", height=%" PRIu32 ", errno=%s\n",
+ __func__, width, height, winpr_strerror(errno, buffer, sizeof(buffer)));
return -1;
}
}
diff --git a/libfreerdp/codec/test/TestFreeRDPCodecPlanar.c b/libfreerdp/codec/test/TestFreeRDPCodecPlanar.c
index ba4c5c63f..1d892cece 100644
--- a/libfreerdp/codec/test/TestFreeRDPCodecPlanar.c
+++ b/libfreerdp/codec/test/TestFreeRDPCodecPlanar.c
@@ -5509,9 +5509,9 @@ static BOOL RunTestPlanar(BITMAP_PLANAR_CONTEXT* planar, const BYTE* srcBitmap,
BYTE* compressedBitmap = freerdp_bitmap_compress_planar(planar, srcBitmap, srcFormat, width,
height, 0, NULL, &dstSize);
BYTE* decompressedBitmap = (BYTE*)calloc(height, width * FreeRDPGetBytesPerPixel(dstFormat));
- printf("%s [%s] --> [%s]: ", __func__, FreeRDPGetColorFormatName(srcFormat),
- FreeRDPGetColorFormatName(dstFormat));
- fflush(stdout);
+ (void)printf("%s [%s] --> [%s]: ", __func__, FreeRDPGetColorFormatName(srcFormat),
+ FreeRDPGetColorFormatName(dstFormat));
+ (void)fflush(stdout);
printf("TODO: Skipping unfinished test!");
rc = TRUE;
goto fail;
@@ -5539,8 +5539,8 @@ static BOOL RunTestPlanar(BITMAP_PLANAR_CONTEXT* planar, const BYTE* srcBitmap,
fail:
free(compressedBitmap);
free(decompressedBitmap);
- printf("\n");
- fflush(stdout);
+ (void)printf("\n");
+ (void)fflush(stdout);
return rc;
}
@@ -5548,9 +5548,9 @@ static BOOL RunTestPlanarSingleColor(BITMAP_PLANAR_CONTEXT* planar, const UINT32
const UINT32 dstFormat)
{
BOOL rc = FALSE;
- printf("%s: [%s] --> [%s]: ", __func__, FreeRDPGetColorFormatName(srcFormat),
- FreeRDPGetColorFormatName(dstFormat));
- fflush(stdout);
+ (void)printf("%s: [%s] --> [%s]: ", __func__, FreeRDPGetColorFormatName(srcFormat),
+ FreeRDPGetColorFormatName(dstFormat));
+ (void)fflush(stdout);
for (UINT32 j = 0; j < 32; j += 8)
{
@@ -5610,11 +5610,11 @@ static BOOL RunTestPlanarSingleColor(BITMAP_PLANAR_CONTEXT* planar, const UINT32
}
}
- printf("SUCCESS");
+ (void)printf("SUCCESS");
rc = TRUE;
fail:
- printf("\n");
- fflush(stdout);
+ (void)printf("\n");
+ (void)fflush(stdout);
return rc;
}
diff --git a/libfreerdp/codec/test/TestFreeRDPCodecProgressive.c b/libfreerdp/codec/test/TestFreeRDPCodecProgressive.c
index b5b7c9885..ef7d1e0ee 100644
--- a/libfreerdp/codec/test/TestFreeRDPCodecProgressive.c
+++ b/libfreerdp/codec/test/TestFreeRDPCodecProgressive.c
@@ -296,18 +296,18 @@ static BYTE* test_progressive_load_file(const char* path, const char* file, size
if (!buffer)
{
- fclose(fp);
+ (void)fclose(fp);
return NULL;
}
if (fread(buffer, *size, 1, fp) != 1)
{
free(buffer);
- fclose(fp);
+ (void)fclose(fp);
return NULL;
}
- fclose(fp);
+ (void)fclose(fp);
return buffer;
}
@@ -1171,14 +1171,14 @@ static void free_cmd(RDPGFX_SURFACE_COMMAND* cmd)
static WINPR_NORETURN(void usage(const char* name))
{
FILE* fp = stdout;
- fprintf(fp, "%s \n", name);
+ (void)fprintf(fp, "%s \n", name);
exit(-1);
}
static void print_codec_stats(const char* name, UINT64 timeNS)
{
const double dectimems = timeNS / 1000000.0;
- fprintf(stderr, "[%s] took %lf ms to decode\n", name, dectimems);
+ (void)fprintf(stderr, "[%s] took %lf ms to decode\n", name, dectimems);
}
static int test_dump(int argc, char* argv[])
@@ -1259,7 +1259,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
CAPROGRESSIVE_dectime += diff;
}
break;
@@ -1280,7 +1281,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
UNCOMPRESSED_dectime += diff;
}
break;
@@ -1294,7 +1296,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
CAVIDEO_dectime += diff;
}
break;
@@ -1314,7 +1317,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
CLEARCODEC_dectime += diff;
}
break;
@@ -1337,7 +1341,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
PLANAR_dectime += diff;
}
break;
@@ -1348,7 +1353,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
AVC420_dectime += diff;
success = -1;
}
@@ -1360,7 +1366,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
ALPHA_dectime += diff;
success = -1;
}
@@ -1372,7 +1379,8 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
AVC444_dectime += diff;
success = -1;
}
@@ -1384,14 +1392,15 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId, ddiff);
+ (void)fprintf(stderr, "frame [%s] %" PRIu32 " took %lf ms\n", cname, frameId,
+ ddiff);
AVC444v2_dectime += diff;
success = -1;
}
break;
default:
- fprintf(stderr, "unexpected codec %s [0x%08" PRIx32 "]",
- rdpgfx_get_codec_id_string(cmd.codecId), cmd.codecId);
+ (void)fprintf(stderr, "unexpected codec %s [0x%08" PRIx32 "]",
+ rdpgfx_get_codec_id_string(cmd.codecId), cmd.codecId);
success = -1;
break;
}
@@ -1415,13 +1424,13 @@ static int test_dump(int argc, char* argv[])
const UINT64 end = winpr_GetTickCount64NS();
const UINT64 diff = end - start;
const double ddiff = diff / 1000000.0;
- fprintf(stderr, "frame %" PRIu32 " copy took %lf ms\n", frameId, ddiff);
+ (void)fprintf(stderr, "frame %" PRIu32 " copy took %lf ms\n", frameId, ddiff);
copytime += diff;
}
region16_clear(&invalid);
}
free_cmd(&cmd);
- fclose(fp);
+ (void)fclose(fp);
}
fail:
@@ -1464,11 +1473,11 @@ int TestFreeRDPCodecProgressive(int argc, char* argv[])
WINPR_UNUSED(argv);
GetSystemTime(&systemTime);
- sprintf_s(name, sizeof(name),
- "EGFX_PROGRESSIVE_MS_SAMPLE-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
- "%02" PRIu16 "%02" PRIu16 "%04" PRIu16,
- systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
- systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
+ (void)sprintf_s(name, sizeof(name),
+ "EGFX_PROGRESSIVE_MS_SAMPLE-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
+ "%02" PRIu16 "%02" PRIu16 "%04" PRIu16,
+ systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
+ systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
ms_sample_path = _strdup(CMAKE_CURRENT_SOURCE_DIR);
if (!ms_sample_path)
diff --git a/libfreerdp/codec/test/TestFreeRDPRegion.c b/libfreerdp/codec/test/TestFreeRDPRegion.c
index 6f753200d..1a14ed03d 100644
--- a/libfreerdp/codec/test/TestFreeRDPRegion.c
+++ b/libfreerdp/codec/test/TestFreeRDPRegion.c
@@ -28,11 +28,11 @@ static BOOL compareRectangles(const RECTANGLE_16* src1, const RECTANGLE_16* src2
{
if (memcmp(src1, src2, sizeof(RECTANGLE_16)))
{
- fprintf(stderr,
- "expecting rect %d (%" PRIu16 ",%" PRIu16 "-%" PRIu16 ",%" PRIu16
- ") and have (%" PRIu16 ",%" PRIu16 "-%" PRIu16 ",%" PRIu16 ")\n",
- i, src2->left, src2->top, src2->right, src2->bottom, src1->left, src1->top,
- src1->right, src1->bottom);
+ (void)fprintf(stderr,
+ "expecting rect %d (%" PRIu16 ",%" PRIu16 "-%" PRIu16 ",%" PRIu16
+ ") and have (%" PRIu16 ",%" PRIu16 "-%" PRIu16 ",%" PRIu16 ")\n",
+ i, src2->left, src2->top, src2->right, src2->bottom, src1->left,
+ src1->top, src1->right, src1->bottom);
return FALSE;
}
}
@@ -709,57 +709,57 @@ static int test_norbert2_case(void)
if (!region16_union_rect(®ion, ®ion, &rect1))
{
- fprintf(stderr, "%s: Error 1 - region16_union_rect failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 1 - region16_union_rect failed\n", __func__);
goto out;
}
if (!(rects = region16_rects(®ion, &nbRects)))
{
- fprintf(stderr, "%s: Error 2 - region16_rects failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 2 - region16_rects failed\n", __func__);
goto out;
}
if (nbRects != 1)
{
- fprintf(stderr, "%s: Error 3 - expected nbRects == 1 but got %" PRIu32 "\n", __func__,
- nbRects);
+ (void)fprintf(stderr, "%s: Error 3 - expected nbRects == 1 but got %" PRIu32 "\n", __func__,
+ nbRects);
goto out;
}
if (!compareRectangles(&rects[0], &rect1, 1))
{
- fprintf(stderr, "%s: Error 4 - compare failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 4 - compare failed\n", __func__);
goto out;
}
if (!region16_union_rect(®ion, ®ion, &rect2))
{
- fprintf(stderr, "%s: Error 5 - region16_union_rect failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 5 - region16_union_rect failed\n", __func__);
goto out;
}
if (!(rects = region16_rects(®ion, &nbRects)))
{
- fprintf(stderr, "%s: Error 6 - region16_rects failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 6 - region16_rects failed\n", __func__);
goto out;
}
if (nbRects != 2)
{
- fprintf(stderr, "%s: Error 7 - expected nbRects == 2 but got %" PRIu32 "\n", __func__,
- nbRects);
+ (void)fprintf(stderr, "%s: Error 7 - expected nbRects == 2 but got %" PRIu32 "\n", __func__,
+ nbRects);
goto out;
}
if (!compareRectangles(&rects[0], &rect2, 1))
{
- fprintf(stderr, "%s: Error 8 - compare failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 8 - compare failed\n", __func__);
goto out;
}
if (!compareRectangles(&rects[1], &rect1, 1))
{
- fprintf(stderr, "%s: Error 9 - compare failed\n", __func__);
+ (void)fprintf(stderr, "%s: Error 9 - compare failed\n", __func__);
goto out;
}
@@ -849,7 +849,7 @@ int TestFreeRDPRegion(int argc, char* argv[])
for (int i = 0; tests[i].func; i++)
{
testNb++;
- fprintf(stderr, "%d: %s\n", testNb, tests[i].name);
+ (void)fprintf(stderr, "%d: %s\n", testNb, tests[i].name);
retCode = tests[i].func();
if (retCode < 0)
@@ -857,7 +857,7 @@ int TestFreeRDPRegion(int argc, char* argv[])
}
if (retCode < 0)
- fprintf(stderr, "failed for test %d\n", testNb);
+ (void)fprintf(stderr, "failed for test %d\n", testNb);
return retCode;
}
diff --git a/libfreerdp/common/addin.c b/libfreerdp/common/addin.c
index 9c5cd1fad..d4c7208cc 100644
--- a/libfreerdp/common/addin.c
+++ b/libfreerdp/common/addin.c
@@ -187,8 +187,8 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_addin(LPCSTR pszFileName, LPCSTR pszPa
if (!pszAddinFile)
goto fail;
- sprintf_s(pszAddinFile, cchAddinFile, FREERDP_SHARED_LIBRARY_PREFIX "%s%s", pszFileName,
- pszExt);
+ (void)sprintf_s(pszAddinFile, cchAddinFile, FREERDP_SHARED_LIBRARY_PREFIX "%s%s",
+ pszFileName, pszExt);
}
cchAddinFile = strlen(pszAddinFile);
@@ -202,7 +202,7 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_addin(LPCSTR pszFileName, LPCSTR pszPa
if (!pszRelativeFilePath)
goto fail;
- sprintf_s(pszRelativeFilePath, relPathLen, "%s", pszPath);
+ (void)sprintf_s(pszRelativeFilePath, relPathLen, "%s", pszPath);
const HRESULT hr = NativePathCchAppendA(pszRelativeFilePath, relPathLen, pszAddinFile);
if (FAILED(hr))
goto fail;
@@ -277,7 +277,8 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_channel_addin_entry(LPCSTR pszName, LP
if (!pszFileName)
return NULL;
- sprintf_s(pszFileName, cchFileName, "%s-client-%s-%s", pszName, pszSubsystem, pszType);
+ (void)sprintf_s(pszFileName, cchFileName, "%s-client-%s-%s", pszName, pszSubsystem,
+ pszType);
}
else if (pszName && pszSubsystem)
{
@@ -287,7 +288,7 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_channel_addin_entry(LPCSTR pszName, LP
if (!pszFileName)
return NULL;
- sprintf_s(pszFileName, cchFileName, "%s-client-%s", pszName, pszSubsystem);
+ (void)sprintf_s(pszFileName, cchFileName, "%s-client-%s", pszName, pszSubsystem);
}
else if (pszName)
{
@@ -297,7 +298,7 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_channel_addin_entry(LPCSTR pszName, LP
if (!pszFileName)
return NULL;
- sprintf_s(pszFileName, cchFileName, "%s-client", pszName);
+ (void)sprintf_s(pszFileName, cchFileName, "%s-client", pszName);
}
else
{
@@ -339,7 +340,8 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_channel_addin_entry(LPCSTR pszName, LP
return NULL;
}
- sprintf_s(pszEntryName, cchEntryName + 1, "freerdp_%s_client_subsystem_entry", pszName);
+ (void)sprintf_s(pszEntryName, cchEntryName + 1, "freerdp_%s_client_subsystem_entry",
+ pszName);
entry = freerdp_load_dynamic_addin(pszFileName, NULL, pszEntryName);
free(pszEntryName);
free(pszFileName);
diff --git a/libfreerdp/common/assistance.c b/libfreerdp/common/assistance.c
index 34e10f036..0f43286fd 100644
--- a/libfreerdp/common/assistance.c
+++ b/libfreerdp/common/assistance.c
@@ -791,8 +791,8 @@ char* freerdp_assistance_construct_expert_blob(const char* name, const char* pas
if (!ExpertBlob)
return NULL;
- sprintf_s(ExpertBlob, size, "%" PRIdz ";NAME=%s%" PRIdz ";PASS=%s", nameLength, name,
- passLength, pass);
+ (void)sprintf_s(ExpertBlob, size, "%" PRIdz ";NAME=%s%" PRIdz ";PASS=%s", nameLength, name,
+ passLength, pass);
return ExpertBlob;
}
@@ -1243,7 +1243,7 @@ int freerdp_assistance_parse_file(rdpAssistanceFile* file, const char* name, con
if (fileSize.i64 < 1)
{
WLog_ERR(TAG, "Failed to read ASSISTANCE file %s ", name);
- fclose(fp);
+ (void)fclose(fp);
return -1;
}
@@ -1251,7 +1251,7 @@ int freerdp_assistance_parse_file(rdpAssistanceFile* file, const char* name, con
if (!buffer)
{
- fclose(fp);
+ (void)fclose(fp);
return -1;
}
@@ -1263,7 +1263,7 @@ int freerdp_assistance_parse_file(rdpAssistanceFile* file, const char* name, con
readSize = fileSize.s;
}
- fclose(fp);
+ (void)fclose(fp);
if (readSize < 1)
{
diff --git a/libfreerdp/common/settings.c b/libfreerdp/common/settings.c
index eb8e8093c..d8a438183 100644
--- a/libfreerdp/common/settings.c
+++ b/libfreerdp/common/settings.c
@@ -146,7 +146,7 @@ int freerdp_addin_set_argument_value(ADDIN_ARGV* args, const char* option, const
if (!str)
return -1;
- sprintf_s(str, length + 1, "%s:%s", option, value);
+ (void)sprintf_s(str, length + 1, "%s:%s", option, value);
for (int i = 0; i < args->argc; i++)
{
@@ -184,7 +184,7 @@ int freerdp_addin_replace_argument_value(ADDIN_ARGV* args, const char* previous,
if (!str)
return -1;
- sprintf_s(str, length + 1, "%s:%s", option, value);
+ (void)sprintf_s(str, length + 1, "%s:%s", option, value);
for (int i = 0; i < args->argc; i++)
{
@@ -1977,7 +1977,7 @@ char* freerdp_rail_support_flags_to_string(UINT32 flags, char* buffer, size_t le
if ((flags & ~mask) != 0)
{
char tbuffer[64] = { 0 };
- _snprintf(tbuffer, sizeof(tbuffer), "RAIL_FLAG_UNKNOWN 0x%08" PRIx32, flags & mask);
+ (void)_snprintf(tbuffer, sizeof(tbuffer), "RAIL_FLAG_UNKNOWN 0x%08" PRIx32, flags & mask);
winpr_str_append(tbuffer, buffer, length, "|");
}
return buffer;
@@ -2181,11 +2181,11 @@ const char* freerdp_supported_color_depths_string(UINT16 mask, char* buffer, siz
if (invalid != 0)
{
char str[32] = { 0 };
- _snprintf(str, sizeof(str), "RNS_UD_INVALID[0x%04" PRIx32 "]", invalid);
+ (void)_snprintf(str, sizeof(str), "RNS_UD_INVALID[0x%04" PRIx32 "]", invalid);
winpr_str_append(str, buffer, size, "|");
}
char hex[32] = { 0 };
- _snprintf(hex, sizeof(hex), "[0x%04" PRIx16 "]", mask);
+ (void)_snprintf(hex, sizeof(hex), "[0x%04" PRIx16 "]", mask);
return buffer;
}
diff --git a/libfreerdp/core/activation.c b/libfreerdp/core/activation.c
index 562853393..fae161f2a 100644
--- a/libfreerdp/core/activation.c
+++ b/libfreerdp/core/activation.c
@@ -805,6 +805,6 @@ const char* rdp_ctrlaction_string(UINT16 action, char* buffer, size_t size)
break;
}
- _snprintf(buffer, size, "%s [0x%04" PRIx16 "]", actstr, action);
+ (void)_snprintf(buffer, size, "%s [0x%04" PRIx16 "]", actstr, action);
return buffer;
}
diff --git a/libfreerdp/core/autodetect.c b/libfreerdp/core/autodetect.c
index 9673d0eef..a9bd64e44 100644
--- a/libfreerdp/core/autodetect.c
+++ b/libfreerdp/core/autodetect.c
@@ -78,7 +78,7 @@ static const char* autodetect_header_type_string(UINT8 headerType, char* buffer,
break;
}
- _snprintf(buffer, size, "%s [0x%08" PRIx8 "]", str, headerType);
+ (void)_snprintf(buffer, size, "%s [0x%08" PRIx8 "]", str, headerType);
return buffer;
}
@@ -125,7 +125,7 @@ static const char* autodetect_request_type_to_string_buffer(UINT32 requestType,
size_t size)
{
const char* str = autodetect_request_type_to_string(requestType);
- _snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, requestType);
+ (void)_snprintf(buffer, size, "%s [0x%08" PRIx32 "]", str, requestType);
return buffer;
}
diff --git a/libfreerdp/core/capabilities.c b/libfreerdp/core/capabilities.c
index f9299ad6d..d45b7970a 100644
--- a/libfreerdp/core/capabilities.c
+++ b/libfreerdp/core/capabilities.c
@@ -4884,7 +4884,7 @@ const char* rdp_input_flag_string(UINT16 flags, char* buffer, size_t len)
{
char prefix[16] = { 0 };
- _snprintf(prefix, sizeof(prefix), "[0x%04" PRIx16 "][", flags);
+ (void)_snprintf(prefix, sizeof(prefix), "[0x%04" PRIx16 "][", flags);
winpr_str_append(prefix, buffer, len, "");
if ((flags & INPUT_FLAG_SCANCODES) != 0)
winpr_str_append("INPUT_FLAG_SCANCODES", buffer, len, "|");
diff --git a/libfreerdp/core/credssp_auth.c b/libfreerdp/core/credssp_auth.c
index 0fa545a2b..ee951f857 100644
--- a/libfreerdp/core/credssp_auth.c
+++ b/libfreerdp/core/credssp_auth.c
@@ -947,7 +947,7 @@ BOOL credssp_auth_set_spn(rdpCredsspAuth* auth, const char* service, const char*
if (!spn)
return FALSE;
- sprintf_s(spn, length, "%s/%s", service, hostname);
+ (void)sprintf_s(spn, length, "%s/%s", service, hostname);
}
if (!spn)
return FALSE;
diff --git a/libfreerdp/core/freerdp.c b/libfreerdp/core/freerdp.c
index 0487f8c54..5377a9d60 100644
--- a/libfreerdp/core/freerdp.c
+++ b/libfreerdp/core/freerdp.c
@@ -1081,7 +1081,7 @@ void freerdp_set_last_error_ex(rdpContext* context, UINT32 lastError, const char
const char* freerdp_get_logon_error_info_type_ex(UINT32 type, char* buffer, size_t size)
{
const char* str = freerdp_get_logon_error_info_type(type);
- _snprintf(buffer, size, "%s(0x%04" PRIx32 ")", str, type);
+ (void)_snprintf(buffer, size, "%s(0x%04" PRIx32 ")", str, type);
return buffer;
}
@@ -1136,7 +1136,7 @@ const char* freerdp_get_logon_error_info_data(UINT32 data)
const char* freerdp_get_logon_error_info_data_ex(UINT32 data, char* buffer, size_t size)
{
const char* str = freerdp_get_logon_error_info_data(data);
- _snprintf(buffer, size, "%s(0x%04" PRIx32 ")", str, data);
+ (void)_snprintf(buffer, size, "%s(0x%04" PRIx32 ")", str, data);
return buffer;
}
@@ -1275,7 +1275,7 @@ void setChannelError(rdpContext* context, UINT errorNum, WINPR_FORMAT_ARG const
WINPR_ASSERT(context);
context->channelErrorNum = errorNum;
- vsnprintf(context->errorDescription, 499, format, ap);
+ (void)vsnprintf(context->errorDescription, 499, format, ap);
va_end(ap);
SetEvent(context->channelErrorEvent);
}
diff --git a/libfreerdp/core/gateway/http.c b/libfreerdp/core/gateway/http.c
index 98ed5003a..1e14abbe8 100644
--- a/libfreerdp/core/gateway/http.c
+++ b/libfreerdp/core/gateway/http.c
@@ -373,7 +373,7 @@ static char* guid2str(const GUID* guid)
if (rpcStatus != RPC_S_OK)
return NULL;
- sprintf_s(bracedGuid, sizeof(bracedGuid), "{%s}", strguid);
+ (void)sprintf_s(bracedGuid, sizeof(bracedGuid), "{%s}", strguid);
RpcStringFreeA(&strguid);
return _strdup(bracedGuid);
}
diff --git a/libfreerdp/core/gateway/rdg.c b/libfreerdp/core/gateway/rdg.c
index 656eba84d..03d3f185d 100644
--- a/libfreerdp/core/gateway/rdg.c
+++ b/libfreerdp/core/gateway/rdg.c
@@ -216,7 +216,7 @@ static const char* flags_to_string(UINT32 flags, const t_flag_mapping* map, size
winpr_str_append(cur->name, buffer, sizeof(buffer), "|");
}
- sprintf_s(fields, ARRAYSIZE(fields), " [%04" PRIx32 "]", flags);
+ (void)sprintf_s(fields, ARRAYSIZE(fields), " [%04" PRIx32 "]", flags);
winpr_str_append(fields, buffer, sizeof(buffer), NULL);
return buffer;
}
@@ -294,7 +294,7 @@ static BOOL rdg_write_chunked(BIO* bio, wStream* sPacket)
int status = 0;
wStream* sChunk = NULL;
char chunkSize[11];
- sprintf_s(chunkSize, sizeof(chunkSize), "%" PRIXz "\r\n", Stream_Length(sPacket));
+ (void)sprintf_s(chunkSize, sizeof(chunkSize), "%" PRIXz "\r\n", Stream_Length(sPacket));
sChunk = Stream_New(NULL, strnlen(chunkSize, sizeof(chunkSize)) + Stream_Length(sPacket) + 2);
if (!sChunk)
@@ -1716,7 +1716,7 @@ static int rdg_write_chunked_data_packet(rdpRdg* rdg, const BYTE* buf, int isize
if (size < 1)
return 0;
- sprintf_s(chunkSize, sizeof(chunkSize), "%" PRIxz "\r\n", packetSize);
+ (void)sprintf_s(chunkSize, sizeof(chunkSize), "%" PRIxz "\r\n", packetSize);
sChunk = Stream_New(NULL, strnlen(chunkSize, sizeof(chunkSize)) + packetSize + 2);
if (!sChunk)
diff --git a/libfreerdp/core/gateway/rpc_fault.c b/libfreerdp/core/gateway/rpc_fault.c
index adf6a0907..267ea8c07 100644
--- a/libfreerdp/core/gateway/rpc_fault.c
+++ b/libfreerdp/core/gateway/rpc_fault.c
@@ -361,7 +361,7 @@ const char* rpc_error_to_string(UINT32 code)
const RPC_FAULT_CODE* const current = &RPC_FAULT_CODES[index];
if (current->code == code)
{
- sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
goto out;
}
}
@@ -371,7 +371,7 @@ const char* rpc_error_to_string(UINT32 code)
const RPC_FAULT_CODE* const current = &RPC_TSG_FAULT_CODES[index];
if (current->code == code)
{
- sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
goto out;
}
}
@@ -381,12 +381,12 @@ const char* rpc_error_to_string(UINT32 code)
const RPC_FAULT_CODE* const current = &RPC_TSG_FAULT_CODES[index];
if (current->code == HRESULT_CODE(code))
{
- sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), "%s", current->name);
goto out;
}
}
- sprintf_s(buffer, ARRAYSIZE(buffer), "%s [0x%08" PRIX32 "]", "UNKNOWN", code);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), "%s [0x%08" PRIX32 "]", "UNKNOWN", code);
out:
return buffer;
}
diff --git a/libfreerdp/core/gateway/rts.c b/libfreerdp/core/gateway/rts.c
index 2ba757815..4012743b1 100644
--- a/libfreerdp/core/gateway/rts.c
+++ b/libfreerdp/core/gateway/rts.c
@@ -103,7 +103,7 @@ static const char* rts_command_to_string(UINT32 cmd, char* buffer, size_t len)
#undef ENTRY
- _snprintf(buffer, len, "%s [0x%08" PRIx32 "]", str, cmd);
+ (void)_snprintf(buffer, len, "%s [0x%08" PRIx32 "]", str, cmd);
return buffer;
}
diff --git a/libfreerdp/core/gateway/tsg.c b/libfreerdp/core/gateway/tsg.c
index 60ccdc5a6..4d7790de3 100644
--- a/libfreerdp/core/gateway/tsg.c
+++ b/libfreerdp/core/gateway/tsg.c
@@ -285,7 +285,7 @@ static const char* tsg_component_id_to_string(UINT16 ComponentId, char* buffer,
}
#undef ENTRY
- _snprintf(buffer, bytelen, "%s [0x%04" PRIx16 "]", str, ComponentId);
+ (void)_snprintf(buffer, bytelen, "%s [0x%04" PRIx16 "]", str, ComponentId);
return buffer;
}
@@ -925,18 +925,18 @@ static const char* tsg_redirection_flags_to_string(char* buffer, size_t size,
WINPR_ASSERT(buffer || (size == 0));
WINPR_ASSERT(flags);
- _snprintf(buffer, size,
- "enableAllRedirections=%s, disableAllRedirections=%s, driveRedirectionDisabled=%s, "
- "printerRedirectionDisabled=%s, portRedirectionDisabled=%s, reserved=%s, "
- "clipboardRedirectionDisabled=%s, pnpRedirectionDisabled=%s",
- tsg_bool_to_string(flags->enableAllRedirections),
- tsg_bool_to_string(flags->disableAllRedirections),
- tsg_bool_to_string(flags->driveRedirectionDisabled),
- tsg_bool_to_string(flags->printerRedirectionDisabled),
- tsg_bool_to_string(flags->portRedirectionDisabled),
- tsg_bool_to_string(flags->reserved),
- tsg_bool_to_string(flags->clipboardRedirectionDisabled),
- tsg_bool_to_string(flags->pnpRedirectionDisabled));
+ (void)_snprintf(
+ buffer, size,
+ "enableAllRedirections=%s, disableAllRedirections=%s, driveRedirectionDisabled=%s, "
+ "printerRedirectionDisabled=%s, portRedirectionDisabled=%s, reserved=%s, "
+ "clipboardRedirectionDisabled=%s, pnpRedirectionDisabled=%s",
+ tsg_bool_to_string(flags->enableAllRedirections),
+ tsg_bool_to_string(flags->disableAllRedirections),
+ tsg_bool_to_string(flags->driveRedirectionDisabled),
+ tsg_bool_to_string(flags->printerRedirectionDisabled),
+ tsg_bool_to_string(flags->portRedirectionDisabled), tsg_bool_to_string(flags->reserved),
+ tsg_bool_to_string(flags->clipboardRedirectionDisabled),
+ tsg_bool_to_string(flags->pnpRedirectionDisabled));
return buffer;
}
diff --git a/libfreerdp/core/gcc.c b/libfreerdp/core/gcc.c
index b5e04d68e..fbbc33ae5 100644
--- a/libfreerdp/core/gcc.c
+++ b/libfreerdp/core/gcc.c
@@ -157,10 +157,10 @@ static char* rdp_early_server_caps_string(UINT32 flags, char* buffer, size_t siz
if (unknown != 0)
{
- _snprintf(msg, sizeof(msg), "RNS_UD_SC_UNKNOWN[0x%08" PRIx32 "]", unknown);
+ (void)_snprintf(msg, sizeof(msg), "RNS_UD_SC_UNKNOWN[0x%08" PRIx32 "]", unknown);
winpr_str_append(msg, buffer, size, "|");
}
- _snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
+ (void)_snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
winpr_str_append(msg, buffer, size, "|");
return buffer;
}
@@ -204,10 +204,10 @@ static const char* rdp_early_client_caps_string(UINT32 flags, char* buffer, size
if (unknown != 0)
{
- _snprintf(msg, sizeof(msg), "RNS_UD_CS_UNKNOWN[0x%08" PRIx32 "]", unknown);
+ (void)_snprintf(msg, sizeof(msg), "RNS_UD_CS_UNKNOWN[0x%08" PRIx32 "]", unknown);
winpr_str_append(msg, buffer, size, "|");
}
- _snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
+ (void)_snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
winpr_str_append(msg, buffer, size, "|");
return buffer;
}
@@ -744,49 +744,49 @@ char* gcc_block_type_string(UINT16 type, char* buffer, size_t size)
switch (type)
{
case CS_CORE:
- _snprintf(buffer, size, "CS_CORE [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_CORE [0x%04" PRIx16 "]", type);
break;
case CS_SECURITY:
- _snprintf(buffer, size, "CS_SECURITY [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_SECURITY [0x%04" PRIx16 "]", type);
break;
case CS_NET:
- _snprintf(buffer, size, "CS_NET [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_NET [0x%04" PRIx16 "]", type);
break;
case CS_CLUSTER:
- _snprintf(buffer, size, "CS_CLUSTER [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_CLUSTER [0x%04" PRIx16 "]", type);
break;
case CS_MONITOR:
- _snprintf(buffer, size, "CS_MONITOR [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_MONITOR [0x%04" PRIx16 "]", type);
break;
case CS_MCS_MSGCHANNEL:
- _snprintf(buffer, size, "CS_MONITOR [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_MONITOR [0x%04" PRIx16 "]", type);
break;
case CS_MONITOR_EX:
- _snprintf(buffer, size, "CS_MONITOR_EX [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_MONITOR_EX [0x%04" PRIx16 "]", type);
break;
case CS_UNUSED1:
- _snprintf(buffer, size, "CS_UNUSED1 [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_UNUSED1 [0x%04" PRIx16 "]", type);
break;
case CS_MULTITRANSPORT:
- _snprintf(buffer, size, "CS_MONITOR_EX [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "CS_MONITOR_EX [0x%04" PRIx16 "]", type);
break;
case SC_CORE:
- _snprintf(buffer, size, "SC_CORE [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "SC_CORE [0x%04" PRIx16 "]", type);
break;
case SC_SECURITY:
- _snprintf(buffer, size, "SC_SECURITY [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "SC_SECURITY [0x%04" PRIx16 "]", type);
break;
case SC_NET:
- _snprintf(buffer, size, "SC_NET [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "SC_NET [0x%04" PRIx16 "]", type);
break;
case SC_MCS_MSGCHANNEL:
- _snprintf(buffer, size, "SC_MCS_MSGCHANNEL [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "SC_MCS_MSGCHANNEL [0x%04" PRIx16 "]", type);
break;
case SC_MULTITRANSPORT:
- _snprintf(buffer, size, "SC_MULTITRANSPORT [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "SC_MULTITRANSPORT [0x%04" PRIx16 "]", type);
break;
default:
- _snprintf(buffer, size, "UNKNOWN [0x%04" PRIx16 "]", type);
+ (void)_snprintf(buffer, size, "UNKNOWN [0x%04" PRIx16 "]", type);
break;
}
return buffer;
diff --git a/libfreerdp/core/license.c b/libfreerdp/core/license.c
index aeb7bb2a8..970716625 100644
--- a/libfreerdp/core/license.c
+++ b/libfreerdp/core/license.c
@@ -236,7 +236,7 @@ static const char* license_preferred_key_exchange_alg_string(UINT32 alg, char* b
break;
}
- _snprintf(buffer, size, "%s [0x%08" PRIx32 "]", name, alg);
+ (void)_snprintf(buffer, size, "%s [0x%08" PRIx32 "]", name, alg);
return buffer;
}
@@ -491,7 +491,7 @@ static BOOL computeCalHash(const char* hostname, char* hashStr, size_t len)
goto out;
for (size_t i = 0; i < sizeof(hash); i++, hashStr += 2)
- sprintf_s(hashStr, 3, "%.2x", hash[i]);
+ (void)sprintf_s(hashStr, 3, "%.2x", hash[i]);
ret = TRUE;
out:
@@ -548,8 +548,8 @@ static BOOL saveCal(const rdpSettings* settings, const BYTE* data, size_t length
if (!computeCalHash(hostname, hash, sizeof(hash)))
goto out;
- sprintf_s(filename, sizeof(filename) - 1, "%s.cal", hash);
- sprintf_s(filenameNew, sizeof(filenameNew) - 1, "%s.cal.new", hash);
+ (void)sprintf_s(filename, sizeof(filename) - 1, "%s.cal", hash);
+ (void)sprintf_s(filenameNew, sizeof(filenameNew) - 1, "%s.cal.new", hash);
if (!(filepath = GetCombinedPath(licenseStorePath, filename)))
{
@@ -571,7 +571,7 @@ static BOOL saveCal(const rdpSettings* settings, const BYTE* data, size_t length
}
written = fwrite(data, length, 1, fp);
- fclose(fp);
+ (void)fclose(fp);
if (written != 1)
{
@@ -612,7 +612,7 @@ static BYTE* loadCalFile(const rdpSettings* settings, const char* hostname, size
return NULL;
}
- sprintf_s(calFilename, sizeof(calFilename) - 1, "%s.cal", hash);
+ (void)sprintf_s(calFilename, sizeof(calFilename) - 1, "%s.cal", hash);
if (!(licenseStorePath = GetCombinedPath(
freerdp_settings_get_string(settings, FreeRDP_ConfigPath), licenseStore)))
@@ -641,7 +641,7 @@ static BYTE* loadCalFile(const rdpSettings* settings, const char* hostname, size
*dataLen = (size_t)length;
- fclose(fp);
+ (void)fclose(fp);
free(calPath);
free(licenseStorePath);
return ret;
diff --git a/libfreerdp/core/nego.c b/libfreerdp/core/nego.c
index e89a3dd86..ff0f6466f 100644
--- a/libfreerdp/core/nego.c
+++ b/libfreerdp/core/nego.c
@@ -1282,7 +1282,7 @@ static const char* nego_rdp_neg_rsp_flags_str(UINT32 flags)
{
static char buffer[1024] = { 0 };
- _snprintf(buffer, ARRAYSIZE(buffer), "[0x%02" PRIx32 "] ", flags);
+ (void)_snprintf(buffer, ARRAYSIZE(buffer), "[0x%02" PRIx32 "] ", flags);
if (flags & EXTENDED_CLIENT_DATA_SUPPORTED)
winpr_str_append("EXTENDED_CLIENT_DATA_SUPPORTED", buffer, sizeof(buffer), "|");
if (flags & DYNVC_GFX_PROTOCOL_SUPPORTED)
diff --git a/libfreerdp/core/orders.c b/libfreerdp/core/orders.c
index bef1b45c0..d799d4da4 100644
--- a/libfreerdp/core/orders.c
+++ b/libfreerdp/core/orders.c
@@ -466,7 +466,7 @@ static const char* primary_order_string(UINT32 orderType)
if (orderType < ARRAYSIZE(orders))
fmt = orders[orderType];
- sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
return buffer;
}
static const char* secondary_order_string(UINT32 orderType)
@@ -486,7 +486,7 @@ static const char* secondary_order_string(UINT32 orderType)
if (orderType < ARRAYSIZE(orders))
fmt = orders[orderType];
- sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
return buffer;
}
static const char* altsec_order_string(BYTE orderType)
@@ -506,7 +506,7 @@ static const char* altsec_order_string(BYTE orderType)
if (orderType < ARRAYSIZE(orders))
fmt = orders[orderType];
- sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
+ (void)sprintf_s(buffer, ARRAYSIZE(buffer), fmt, orderType);
return buffer;
}
diff --git a/libfreerdp/core/proxy.c b/libfreerdp/core/proxy.c
index 15d8802f0..ece684ff8 100644
--- a/libfreerdp/core/proxy.c
+++ b/libfreerdp/core/proxy.c
@@ -568,7 +568,7 @@ static BOOL http_proxy_connect(BIO* bufferedBio, const char* proxyUsername,
const char basic[] = CRLF "Proxy-Authorization: Basic ";
char* base64 = NULL;
- sprintf_s(creds, size, "%s:%s", proxyUsername, proxyPassword);
+ (void)sprintf_s(creds, size, "%s:%s", proxyUsername, proxyPassword);
base64 = crypto_base64_encode((const BYTE*)creds, size - 1);
if (!base64 || !Stream_EnsureRemainingCapacity(s, strlen(basic) + strlen(base64)))
diff --git a/libfreerdp/core/rdp.c b/libfreerdp/core/rdp.c
index 0172f3035..0e220c138 100644
--- a/libfreerdp/core/rdp.c
+++ b/libfreerdp/core/rdp.c
@@ -1566,7 +1566,7 @@ const char* pdu_type_to_str(UINT16 pduType, char* buffer, size_t length)
winpr_str_append(str, buffer, length, "");
{
char msg[32] = { 0 };
- _snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", pduType);
+ (void)_snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", pduType);
winpr_str_append(msg, buffer, length, "");
}
return buffer;
@@ -2244,7 +2244,7 @@ rdpRdp* rdp_new(rdpContext* context)
rdp->log = WLog_Get(RDP_TAG);
WINPR_ASSERT(rdp->log);
- _snprintf(rdp->log_context, sizeof(rdp->log_context), "%p", (void*)context);
+ (void)_snprintf(rdp->log_context, sizeof(rdp->log_context), "%p", (void*)context);
WLog_SetContext(rdp->log, NULL, rdp->log_context);
InitializeCriticalSection(&rdp->critical);
@@ -2581,7 +2581,7 @@ const char* rdp_finalize_flags_to_str(UINT32 flags, char* buffer, size_t size)
winpr_str_append("UNKNOWN_FLAG", buffer, size, "|");
if (flags == 0)
winpr_str_append("NO_FLAG_SET", buffer, size, "|");
- _snprintf(number, sizeof(number), " [0x%08" PRIx32 "]", flags);
+ (void)_snprintf(number, sizeof(number), " [0x%08" PRIx32 "]", flags);
winpr_str_append(number, buffer, size, "");
return buffer;
}
@@ -2687,7 +2687,7 @@ const char* rdp_security_flag_string(UINT32 securityFlags, char* buffer, size_t
{
char msg[32] = { 0 };
- _snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", securityFlags);
+ (void)_snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", securityFlags);
winpr_str_append(msg, buffer, size, "");
}
return buffer;
diff --git a/libfreerdp/core/settings.c b/libfreerdp/core/settings.c
index 09142adca..bed0abbb9 100644
--- a/libfreerdp/core/settings.c
+++ b/libfreerdp/core/settings.c
@@ -161,8 +161,8 @@ static void settings_client_load_hkey_local_machine(rdpSettings* settings)
TCHAR numentries[64] = { 0 };
TCHAR persist[64] = { 0 };
BITMAP_CACHE_V2_CELL_INFO cache = { 0 };
- _sntprintf(numentries, ARRAYSIZE(numentries), _T("Cell%uNumEntries"), x);
- _sntprintf(persist, ARRAYSIZE(persist), _T("Cell%uPersistent"), x);
+ (void)_sntprintf(numentries, ARRAYSIZE(numentries), _T("Cell%uNumEntries"), x);
+ (void)_sntprintf(persist, ARRAYSIZE(persist), _T("Cell%uPersistent"), x);
if (!settings_reg_query_dword_val(hKey, numentries, &val) ||
!settings_reg_query_bool_val(hKey, persist, &cache.persistent) ||
!freerdp_settings_set_pointer_array(settings, FreeRDP_BitmapCacheV2CellInfo, x,
@@ -189,8 +189,8 @@ static void settings_client_load_hkey_local_machine(rdpSettings* settings)
GLYPH_CACHE_DEFINITION cache = { 0 };
TCHAR numentries[64] = { 0 };
TCHAR maxsize[64] = { 0 };
- _sntprintf(numentries, ARRAYSIZE(numentries), _T("Cache%uNumEntries"), x);
- _sntprintf(maxsize, ARRAYSIZE(maxsize), _T("Cache%uMaxCellSize"), x);
+ (void)_sntprintf(numentries, ARRAYSIZE(numentries), _T("Cache%uNumEntries"), x);
+ (void)_sntprintf(maxsize, ARRAYSIZE(maxsize), _T("Cache%uMaxCellSize"), x);
settings_reg_query_word_val(hKey, numentries, &cache.cacheEntries);
settings_reg_query_word_val(hKey, maxsize, &cache.cacheMaximumCellSize);
@@ -1274,7 +1274,7 @@ const char* freerdp_settings_glyph_level_string(UINT32 level, char* buffer, size
break;
}
- _snprintf(buffer, size, "%s[0x%08" PRIx32 "]", str, level);
+ (void)_snprintf(buffer, size, "%s[0x%08" PRIx32 "]", str, level);
return buffer;
}
diff --git a/libfreerdp/core/smartcardlogon.c b/libfreerdp/core/smartcardlogon.c
index 98c4d9925..87c0e5f65 100644
--- a/libfreerdp/core/smartcardlogon.c
+++ b/libfreerdp/core/smartcardlogon.c
@@ -68,7 +68,7 @@ static void delete_file(char* path)
break;
}
- fclose(fp);
+ (void)fclose(fp);
}
}
@@ -577,7 +577,7 @@ static BOOL smartcard_hw_enumerateCerts(const rdpSettings* settings, LPCWSTR csp
if (!scopeStr)
goto out;
- _snprintf(scopeStr, readerSz + 5, "\\\\.\\%s\\", reader);
+ (void)_snprintf(scopeStr, readerSz + 5, "\\\\.\\%s\\", reader);
scope = ConvertUtf8NToWCharAlloc(scopeStr, readerSz + 5, NULL);
free(scopeStr);
@@ -664,7 +664,7 @@ static BOOL smartcard_hw_enumerateCerts(const rdpSettings* settings, LPCWSTR csp
if (ConvertWCharToUtf8(name->pszName, providerNameStr, ARRAYSIZE(providerNameStr)) < 0)
{
- _snprintf(providerNameStr, sizeof(providerNameStr), "");
+ (void)_snprintf(providerNameStr, sizeof(providerNameStr), "");
WLog_ERR(TAG, "unable to convert provider name to char*, will show it as '%s'",
providerNameStr);
}
diff --git a/libfreerdp/core/state.c b/libfreerdp/core/state.c
index 7054e5182..a11bfd333 100644
--- a/libfreerdp/core/state.c
+++ b/libfreerdp/core/state.c
@@ -74,7 +74,7 @@ const char* state_run_result_string(state_run_t status, char* buffer, size_t buf
break;
}
- _snprintf(buffer, buffersize, "%s [%d]", name, status);
+ (void)_snprintf(buffer, buffersize, "%s [%d]", name, status);
return buffer;
}
diff --git a/libfreerdp/core/streamdump.c b/libfreerdp/core/streamdump.c
index 8d86893ae..921380454 100644
--- a/libfreerdp/core/streamdump.c
+++ b/libfreerdp/core/streamdump.c
@@ -223,7 +223,7 @@ SSIZE_T stream_dump_append(const rdpContext* context, UINT32 flags, wStream* s,
*offset = (size_t)rc;
fail:
if (fp)
- fclose(fp);
+ (void)fclose(fp);
return rc;
}
@@ -249,7 +249,7 @@ SSIZE_T stream_dump_get(const rdpContext* context, UINT32* flags, wStream* s, si
rc = _ftelli64(fp);
fail:
if (fp)
- fclose(fp);
+ (void)fclose(fp);
return rc;
}
diff --git a/libfreerdp/core/tcp.c b/libfreerdp/core/tcp.c
index 78f9d0251..3f2236b38 100644
--- a/libfreerdp/core/tcp.c
+++ b/libfreerdp/core/tcp.c
@@ -694,7 +694,7 @@ char* freerdp_tcp_address_to_string(const struct sockaddr_storage* addr, BOOL* p
break;
case AF_UNIX:
- sprintf_s(ipAddress, ARRAYSIZE(ipAddress), "127.0.0.1");
+ (void)sprintf_s(ipAddress, ARRAYSIZE(ipAddress), "127.0.0.1");
break;
default:
@@ -779,7 +779,7 @@ struct addrinfo* freerdp_tcp_resolve_host(const char* hostname, int port, int ai
if (port >= 0)
{
- sprintf_s(port_str, sizeof(port_str) - 1, "%d", port);
+ (void)sprintf_s(port_str, sizeof(port_str) - 1, "%d", port);
service = port_str;
}
diff --git a/libfreerdp/core/test/TestConnect.c b/libfreerdp/core/test/TestConnect.c
index 4a3b89acf..306c824c6 100644
--- a/libfreerdp/core/test/TestConnect.c
+++ b/libfreerdp/core/test/TestConnect.c
@@ -78,7 +78,7 @@ static int testTimeout(int port)
char arg1[] = "/v:192.0.2.1:XXXXX";
char* argv[] = { "test", "/v:192.0.2.1:XXXXX" };
int rc = 0;
- _snprintf(arg1, 18, "/v:192.0.2.1:%d", port);
+ (void)_snprintf(arg1, 18, "/v:192.0.2.1:%d", port);
argv[1] = arg1;
start = GetTickCount();
rc = runInstance(ARRAYSIZE(argv), argv, NULL, timeout);
@@ -111,7 +111,7 @@ static DWORD WINAPI testThread(LPVOID arg)
char* argv[] = { "test", "/v:192.0.2.1:XXXXX" };
int rc = 0;
struct testThreadArgs* args = arg;
- _snprintf(arg1, 18, "/v:192.0.2.1:%d", args->port);
+ (void)_snprintf(arg1, 18, "/v:192.0.2.1:%d", args->port);
argv[1] = arg1;
rc = runInstance(ARRAYSIZE(argv), argv, args->arg, 5000);
@@ -216,7 +216,7 @@ static BOOL prepare_certificates(const char* path)
"winpr-makecert" CMAKE_EXECUTABLE_SUFFIX);
if (!exe)
return FALSE;
- _snprintf(commandLine, sizeof(commandLine), "%s -format crt -path . -n server", exe);
+ (void)_snprintf(commandLine, sizeof(commandLine), "%s -format crt -path . -n server", exe);
rc = CreateProcessA(exe, commandLine, NULL, NULL, TRUE, 0, NULL, path, &si, &process);
free(exe);
@@ -246,7 +246,7 @@ static int testSuccess(int port)
char* path = NULL;
char* wpath = NULL;
char* exe = GetCombinedPath(TESTING_OUTPUT_DIRECTORY, "server");
- _snprintf(arg1, 18, "/v:127.0.0.1:%d", port);
+ (void)_snprintf(arg1, 18, "/v:127.0.0.1:%d", port);
clientArgs[1] = arg1;
if (!exe)
@@ -281,7 +281,7 @@ static int testSuccess(int port)
if (!commandLine)
goto fail;
- _snprintf(commandLine, commandLineLen, "%s --port=%d", exe, port);
+ (void)_snprintf(commandLine, commandLineLen, "%s --port=%d", exe, port);
si.cb = sizeof(si);
if (!CreateProcessA(NULL, commandLine, NULL, NULL, FALSE, 0, NULL, wpath, &si, &process))
diff --git a/libfreerdp/core/test/TestSettings.c b/libfreerdp/core/test/TestSettings.c
index ea21cb3e5..08754e29b 100644
--- a/libfreerdp/core/test/TestSettings.c
+++ b/libfreerdp/core/test/TestSettings.c
@@ -9,7 +9,7 @@
static BOOL log_result(BOOL value, const char* fkt)
{
- fprintf(stderr, "TestSettings [%s] returned %s\n", fkt, value ? "TRUE" : "FALSE");
+ (void)fprintf(stderr, "TestSettings [%s] returned %s\n", fkt, value ? "TRUE" : "FALSE");
return value;
}
@@ -305,19 +305,19 @@ static BOOL format_uint(char* buffer, size_t size, UINT64 value, UINT16 intType,
switch (intType)
{
case 0:
- _snprintf(buffer, size, "%" PRIu64, lvalue);
+ (void)_snprintf(buffer, size, "%" PRIu64, lvalue);
return TRUE;
case 1:
- _snprintf(buffer, size, "0x%" PRIx64, lvalue);
+ (void)_snprintf(buffer, size, "0x%" PRIx64, lvalue);
return TRUE;
case 2:
if (max < UINT64_MAX)
- _snprintf(buffer, size, "%" PRIu64, max + 1);
+ (void)_snprintf(buffer, size, "%" PRIu64, max + 1);
else
- _snprintf(buffer, size, "too large a number");
+ (void)_snprintf(buffer, size, "too large a number");
return FALSE;
default:
- _snprintf(buffer, size, "not a number value");
+ (void)_snprintf(buffer, size, "not a number value");
return FALSE;
}
}
@@ -327,16 +327,16 @@ static BOOL print_negative(char* buffer, size_t size, INT64 value, INT64 min)
switch (min)
{
case INT16_MIN:
- _snprintf(buffer, size, "%" PRId16, (INT16)value);
+ (void)_snprintf(buffer, size, "%" PRId16, (INT16)value);
return FALSE;
case INT32_MIN:
- _snprintf(buffer, size, "%" PRId32, (INT32)value);
+ (void)_snprintf(buffer, size, "%" PRId32, (INT32)value);
return FALSE;
case INT64_MIN:
- _snprintf(buffer, size, "%" PRId64, (INT64)value);
+ (void)_snprintf(buffer, size, "%" PRId64, (INT64)value);
return FALSE;
default:
- _snprintf(buffer, size, "too small a number");
+ (void)_snprintf(buffer, size, "too small a number");
return FALSE;
}
}
@@ -345,23 +345,23 @@ static BOOL print_xpositive(char* buffer, size_t size, INT64 value, INT64 max)
{
if (value < 0)
{
- _snprintf(buffer, size, "%" PRId64, value);
+ (void)_snprintf(buffer, size, "%" PRId64, value);
return TRUE;
}
switch (max)
{
case INT16_MAX:
- _snprintf(buffer, size, "%" PRIx16, (INT16)value);
+ (void)_snprintf(buffer, size, "%" PRIx16, (INT16)value);
return FALSE;
case INT32_MAX:
- _snprintf(buffer, size, "%" PRIx32, (INT32)value);
+ (void)_snprintf(buffer, size, "%" PRIx32, (INT32)value);
return FALSE;
case INT64_MAX:
- _snprintf(buffer, size, "%" PRIx64, (INT64)value);
+ (void)_snprintf(buffer, size, "%" PRIx64, (INT64)value);
return FALSE;
default:
- _snprintf(buffer, size, "too small a number");
+ (void)_snprintf(buffer, size, "too small a number");
return FALSE;
}
}
@@ -374,25 +374,25 @@ static BOOL format_int(char* buffer, size_t size, INT64 value, UINT16 intType, I
switch (intType)
{
case 0:
- _snprintf(buffer, size, "%" PRId64, lvalue);
+ (void)_snprintf(buffer, size, "%" PRId64, lvalue);
return TRUE;
case 1:
print_xpositive(buffer, size, lvalue, max);
return TRUE;
case 2:
if (max < INT64_MAX)
- _snprintf(buffer, size, "%" PRId64, max + 1);
+ (void)_snprintf(buffer, size, "%" PRId64, max + 1);
else
- _snprintf(buffer, size, "too large a number");
+ (void)_snprintf(buffer, size, "too large a number");
return FALSE;
case 3:
if (min < INT64_MIN)
print_negative(buffer, size, min - 1, INT64_MIN);
else
- _snprintf(buffer, size, "too small a number");
+ (void)_snprintf(buffer, size, "too small a number");
return FALSE;
default:
- _snprintf(buffer, size, "not a number value");
+ (void)_snprintf(buffer, size, "not a number value");
return FALSE;
}
}
@@ -403,37 +403,37 @@ static BOOL format_bool(char* buffer, size_t size, UINT16 intType)
switch (intType)
{
case 0:
- _snprintf(buffer, size, "FALSE");
+ (void)_snprintf(buffer, size, "FALSE");
return TRUE;
case 1:
- _snprintf(buffer, size, "FaLsE");
+ (void)_snprintf(buffer, size, "FaLsE");
return TRUE;
case 2:
- _snprintf(buffer, size, "False");
+ (void)_snprintf(buffer, size, "False");
return TRUE;
case 3:
- _snprintf(buffer, size, "false");
+ (void)_snprintf(buffer, size, "false");
return TRUE;
case 4:
- _snprintf(buffer, size, "falseentry");
+ (void)_snprintf(buffer, size, "falseentry");
return FALSE;
case 5:
- _snprintf(buffer, size, "TRUE");
+ (void)_snprintf(buffer, size, "TRUE");
return TRUE;
case 6:
- _snprintf(buffer, size, "TrUe");
+ (void)_snprintf(buffer, size, "TrUe");
return TRUE;
case 7:
- _snprintf(buffer, size, "True");
+ (void)_snprintf(buffer, size, "True");
return TRUE;
case 8:
- _snprintf(buffer, size, "true");
+ (void)_snprintf(buffer, size, "true");
return TRUE;
case 9:
- _snprintf(buffer, size, "someentry");
+ (void)_snprintf(buffer, size, "someentry");
return FALSE;
default:
- _snprintf(buffer, size, "ok");
+ (void)_snprintf(buffer, size, "ok");
return FALSE;
}
}
@@ -574,7 +574,7 @@ static BOOL check_key_helpers(size_t key, const char* stype)
break;
case RDP_SETTINGS_TYPE_STRING:
expect = TRUE;
- _snprintf(value, sizeof(value), "somerandomstring");
+ (void)_snprintf(value, sizeof(value), "somerandomstring");
break;
case RDP_SETTINGS_TYPE_POINTER:
expect = FALSE;
diff --git a/libfreerdp/core/test/TestStreamDump.c b/libfreerdp/core/test/TestStreamDump.c
index 9124a84ac..b54cae9e3 100644
--- a/libfreerdp/core/test/TestStreamDump.c
+++ b/libfreerdp/core/test/TestStreamDump.c
@@ -27,11 +27,11 @@ static BOOL test_entry_read_write(void)
winpr_RAND(tmp, sizeof(tmp));
for (size_t x = 0; x < sizeof(tmp); x++)
- _snprintf(&tmp2[x * 2], sizeof(tmp2) - 2 * x, "%02" PRIx8, tmp[x]);
+ (void)_snprintf(&tmp2[x * 2], sizeof(tmp2) - 2 * x, "%02" PRIx8, tmp[x]);
name = GetKnownSubPath(KNOWN_PATH_TEMP, tmp2);
if (!name)
{
- fprintf(stderr, "[%s] Could not create temporary path\n", __func__);
+ (void)fprintf(stderr, "[%s] Could not create temporary path\n", __func__);
goto fail;
}
@@ -39,8 +39,8 @@ static BOOL test_entry_read_write(void)
sr = Stream_New(NULL, 1024);
if (!sr || !sw)
{
- fprintf(stderr, "[%s] Could not create iostreams sw=%p, sr=%p\n", __func__, (void*)sw,
- (void*)sr);
+ (void)fprintf(stderr, "[%s] Could not create iostreams sw=%p, sr=%p\n", __func__, (void*)sw,
+ (void*)sr);
goto fail;
}
@@ -53,7 +53,7 @@ static BOOL test_entry_read_write(void)
goto fail;
if (!stream_dump_write_line(fp, 0, sw))
goto fail;
- fclose(fp);
+ (void)fclose(fp);
fp = fopen(name, "rb");
if (!fp)
@@ -63,21 +63,21 @@ static BOOL test_entry_read_write(void)
if (entrysize != offset)
{
- fprintf(stderr, "[%s] offset %" PRIuz " bytes, entrysize %" PRIuz " bytes\n", __func__,
- offset, entrysize);
+ (void)fprintf(stderr, "[%s] offset %" PRIuz " bytes, entrysize %" PRIuz " bytes\n",
+ __func__, offset, entrysize);
goto fail;
}
if (Stream_Length(sr) != Stream_Capacity(sw))
{
- fprintf(stderr, "[%s] Written %" PRIuz " bytes, read %" PRIuz " bytes\n", __func__,
- Stream_Length(sr), Stream_Capacity(sw));
+ (void)fprintf(stderr, "[%s] Written %" PRIuz " bytes, read %" PRIuz " bytes\n", __func__,
+ Stream_Length(sr), Stream_Capacity(sw));
goto fail;
}
if (memcmp(Stream_Buffer(sw), Stream_Buffer(sr), Stream_Capacity(sw)) != 0)
{
- fprintf(stderr, "[%s] Written data does not match data read back\n", __func__);
+ (void)fprintf(stderr, "[%s] Written data does not match data read back\n", __func__);
goto fail;
}
rc = TRUE;
@@ -85,11 +85,11 @@ fail:
Stream_Free(sr, TRUE);
Stream_Free(sw, TRUE);
if (fp)
- fclose(fp);
+ (void)fclose(fp);
if (name)
DeleteFileA(name);
free(name);
- fprintf(stderr, "xxxxxxxxxxxxx %d\n", rc);
+ (void)fprintf(stderr, "xxxxxxxxxxxxx %d\n", rc);
return rc;
}
diff --git a/libfreerdp/core/utils.c b/libfreerdp/core/utils.c
index 874647d01..1b105d85a 100644
--- a/libfreerdp/core/utils.c
+++ b/libfreerdp/core/utils.c
@@ -457,7 +457,7 @@ char* utils_redir_flags_to_string(UINT32 flags, char* buffer, size_t size)
winpr_str_append("DISABLE_PNP", buffer, size, "|");
char fbuffer[16] = { 0 };
- _snprintf(fbuffer, sizeof(fbuffer), "[0x%08" PRIx32 "]", flags);
+ (void)_snprintf(fbuffer, sizeof(fbuffer), "[0x%08" PRIx32 "]", flags);
winpr_str_append(fbuffer, buffer, size, " ");
winpr_str_append("{", buffer, size, "}");
diff --git a/libfreerdp/core/window.c b/libfreerdp/core/window.c
index cd1e2151c..7abe0c067 100644
--- a/libfreerdp/core/window.c
+++ b/libfreerdp/core/window.c
@@ -532,13 +532,13 @@ static BOOL window_order_supported(const rdpSettings* settings, UINT32 fieldFlag
}
}
-#define DUMP_APPEND(buffer, size, ...) \
- do \
- { \
- char* b = (buffer); \
- size_t s = (size); \
- size_t pos = strnlen(b, s); \
- _snprintf(&b[pos], s - pos, __VA_ARGS__); \
+#define DUMP_APPEND(buffer, size, ...) \
+ do \
+ { \
+ char* b = (buffer); \
+ size_t s = (size); \
+ size_t pos = strnlen(b, s); \
+ (void)_snprintf(&b[pos], s - pos, __VA_ARGS__); \
} while (0)
static void dump_window_state_order(wLog* log, const char* msg, const WINDOW_ORDER_INFO* order,
@@ -547,7 +547,7 @@ static void dump_window_state_order(wLog* log, const char* msg, const WINDOW_ORD
char buffer[3000] = { 0 };
const size_t bufferSize = sizeof(buffer) - 1;
- _snprintf(buffer, bufferSize, "%s windowId=0x%" PRIu32 "", msg, order->windowId);
+ (void)_snprintf(buffer, bufferSize, "%s windowId=0x%" PRIu32 "", msg, order->windowId);
if (order->fieldFlags & WINDOW_ORDER_FIELD_OWNER)
DUMP_APPEND(buffer, bufferSize, " owner=0x%" PRIx32 "", state->ownerWindowId);
diff --git a/libfreerdp/crypto/certificate.c b/libfreerdp/crypto/certificate.c
index 03e52dd01..d7dc74188 100644
--- a/libfreerdp/crypto/certificate.c
+++ b/libfreerdp/crypto/certificate.c
@@ -1373,7 +1373,7 @@ char* freerdp_certificate_get_fingerprint_by_hash_ex(const rdpCertificate* cert,
pos += (size_t)rc;
}
- sprintf_s(&fp_buffer[pos], size - pos, "%02" PRIx8 "", fp[i]);
+ (void)sprintf_s(&fp_buffer[pos], size - pos, "%02" PRIx8 "", fp[i]);
free(fp);
diff --git a/libfreerdp/crypto/certificate_data.c b/libfreerdp/crypto/certificate_data.c
index 79b38284f..ca95fcfef 100644
--- a/libfreerdp/crypto/certificate_data.c
+++ b/libfreerdp/crypto/certificate_data.c
@@ -64,7 +64,7 @@ static char* ensure_lowercase(char* str, size_t length)
static const char* freerdp_certificate_data_hash_(const char* hostname, UINT16 port, char* name,
size_t length)
{
- _snprintf(name, length, "%s_%" PRIu16 ".pem", hostname, port);
+ (void)_snprintf(name, length, "%s_%" PRIu16 ".pem", hostname, port);
return ensure_lowercase(name, length);
}
diff --git a/libfreerdp/crypto/certificate_store.c b/libfreerdp/crypto/certificate_store.c
index d66e15b02..7349e39e8 100644
--- a/libfreerdp/crypto/certificate_store.c
+++ b/libfreerdp/crypto/certificate_store.c
@@ -116,12 +116,12 @@ BOOL freerdp_certificate_store_save_data(rdpCertificateStore* store, const rdpCe
if (!fp)
goto fail;
- fprintf(fp, "%s", freerdp_certificate_data_get_pem_ex(data, FALSE));
+ (void)fprintf(fp, "%s", freerdp_certificate_data_get_pem_ex(data, FALSE));
rc = TRUE;
fail:
if (fp)
- fclose(fp);
+ (void)fclose(fp);
free(path);
return rc;
}
diff --git a/libfreerdp/crypto/crypto.c b/libfreerdp/crypto/crypto.c
index 04f1aa06e..705be74a2 100644
--- a/libfreerdp/crypto/crypto.c
+++ b/libfreerdp/crypto/crypto.c
@@ -219,7 +219,7 @@ char* crypto_read_pem(const char* WINPR_RESTRICT filename, size_t* WINPR_RESTRIC
if (plength)
*plength = (size_t)strnlen(pem, size);
- fclose(fp);
+ (void)fclose(fp);
return pem;
fail:
@@ -229,7 +229,7 @@ fail:
winpr_strerror(errno, buffer, sizeof(buffer)));
}
if (fp)
- fclose(fp);
+ (void)fclose(fp);
free(pem);
return NULL;
}
@@ -249,7 +249,7 @@ BOOL crypto_write_pem(const char* WINPR_RESTRICT filename, const char* WINPR_RES
if (!fp)
goto fail;
rc = fwrite(pem, 1, size, fp);
- fclose(fp);
+ (void)fclose(fp);
fail:
if (rc == 0)
{
diff --git a/libfreerdp/crypto/test/TestBase64.c b/libfreerdp/crypto/test/TestBase64.c
index d13363756..cb330c692 100644
--- a/libfreerdp/crypto/test/TestBase64.c
+++ b/libfreerdp/crypto/test/TestBase64.c
@@ -58,7 +58,7 @@ int TestBase64(int argc, char* argv[])
WINPR_UNUSED(argc);
WINPR_UNUSED(argv);
testNb++;
- fprintf(stderr, "%d:encode base64...", testNb);
+ (void)fprintf(stderr, "%d:encode base64...", testNb);
for (int i = 0; encodeTests_base64[i].input; i++)
{
@@ -67,16 +67,16 @@ int TestBase64(int argc, char* argv[])
if (strcmp(encodeTests_base64[i].output, encoded))
{
- fprintf(stderr, "ko, error for string %d\n", i);
+ (void)fprintf(stderr, "ko, error for string %d\n", i);
return -1;
}
free(encoded);
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
testNb++;
- fprintf(stderr, "%d:encode base64url...", testNb);
+ (void)fprintf(stderr, "%d:encode base64url...", testNb);
for (int i = 0; encodeTests_base64url[i].input; i++)
{
@@ -85,16 +85,16 @@ int TestBase64(int argc, char* argv[])
if (strcmp(encodeTests_base64url[i].output, encoded))
{
- fprintf(stderr, "ko, error for string %d\n", i);
+ (void)fprintf(stderr, "ko, error for string %d\n", i);
return -1;
}
free(encoded);
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
testNb++;
- fprintf(stderr, "%d:decode base64...", testNb);
+ (void)fprintf(stderr, "%d:decode base64...", testNb);
for (int i = 0; encodeTests_base64[i].input; i++)
{
@@ -104,16 +104,16 @@ int TestBase64(int argc, char* argv[])
if (!decoded || (outLen != encodeTests_base64[i].len) ||
memcmp(encodeTests_base64[i].input, decoded, outLen))
{
- fprintf(stderr, "ko, error for string %d\n", i);
+ (void)fprintf(stderr, "ko, error for string %d\n", i);
return -1;
}
free(decoded);
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
testNb++;
- fprintf(stderr, "%d:decode base64url...", testNb);
+ (void)fprintf(stderr, "%d:decode base64url...", testNb);
for (int i = 0; encodeTests_base64url[i].input; i++)
{
@@ -123,21 +123,21 @@ int TestBase64(int argc, char* argv[])
if (!decoded || (outLen != encodeTests_base64url[i].len) ||
memcmp(encodeTests_base64url[i].input, decoded, outLen))
{
- fprintf(stderr, "ko, error for string %d\n", i);
+ (void)fprintf(stderr, "ko, error for string %d\n", i);
return -1;
}
free(decoded);
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
testNb++;
- fprintf(stderr, "%d:decode base64 errors...", testNb);
+ (void)fprintf(stderr, "%d:decode base64 errors...", testNb);
crypto_base64_decode("000", 3, &decoded, &outLen);
if (decoded)
{
- fprintf(stderr, "ko, badly padded string\n");
+ (void)fprintf(stderr, "ko, badly padded string\n");
return -1;
}
@@ -145,7 +145,7 @@ int TestBase64(int argc, char* argv[])
if (decoded)
{
- fprintf(stderr, "ko, = in a wrong place\n");
+ (void)fprintf(stderr, "ko, = in a wrong place\n");
return -1;
}
@@ -153,14 +153,14 @@ int TestBase64(int argc, char* argv[])
if (decoded)
{
- fprintf(stderr, "ko, = in a wrong place\n");
+ (void)fprintf(stderr, "ko, = in a wrong place\n");
return -1;
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
testNb++;
/* test the encode_ex version that will add \r\n */
- fprintf(stderr, "%d:encode base64 with crLf...", testNb);
+ (void)fprintf(stderr, "%d:encode base64 with crLf...", testNb);
const char* longStr = "01234567890123456789012345678901234567890123456789";
const char* longStrExpected =
"MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3\r\nODk=\r\n";
@@ -168,11 +168,11 @@ int TestBase64(int argc, char* argv[])
char* encoded = crypto_base64_encode_ex((const BYTE*)longStr, strlen(longStr), TRUE);
if (!encoded || strcmp(encoded, longStrExpected) != 0)
{
- fprintf(stderr, "problem with encode with CRLF\n");
+ (void)fprintf(stderr, "problem with encode with CRLF\n");
return -1;
}
free(encoded);
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
return 0;
}
diff --git a/libfreerdp/crypto/test/TestKnownHosts.c b/libfreerdp/crypto/test/TestKnownHosts.c
index e3a4264fb..d6fbedbca 100644
--- a/libfreerdp/crypto/test/TestKnownHosts.c
+++ b/libfreerdp/crypto/test/TestKnownHosts.c
@@ -139,7 +139,7 @@ static int prepare(const char* currentFileV2)
finish:
if (fc)
- fclose(fc);
+ (void)fclose(fc);
return rc;
}
@@ -158,11 +158,11 @@ static BOOL setup_config(rdpSettings** settings)
goto fail;
GetSystemTime(&systemTime);
- sprintf_s(sname, sizeof(sname),
- "TestKnownHostsCurrent-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
- "%02" PRIu16 "%04" PRIu16,
- systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
- systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
+ (void)sprintf_s(sname, sizeof(sname),
+ "TestKnownHostsCurrent-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
+ "%02" PRIu16 "%02" PRIu16 "%04" PRIu16,
+ systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
+ systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
path = GetKnownSubPath(KNOWN_PATH_TEMP, sname);
if (!path)
@@ -171,7 +171,7 @@ static BOOL setup_config(rdpSettings** settings)
{
if (!CreateDirectoryA(path, NULL))
{
- fprintf(stderr, "Could not create %s!\n", path);
+ (void)fprintf(stderr, "Could not create %s!\n", path);
goto fail;
}
}
diff --git a/libfreerdp/crypto/test/Test_x509_utils.c b/libfreerdp/crypto/test/Test_x509_utils.c
index 7d90e3816..255f6d01a 100644
--- a/libfreerdp/crypto/test/Test_x509_utils.c
+++ b/libfreerdp/crypto/test/Test_x509_utils.c
@@ -36,7 +36,7 @@ static char* certificate_path(const char* filename)
char* result = calloc(1, flen);
if (!result)
return NULL;
- _snprintf(result, flen, "%s%c%s", file, dirsep, filename);
+ (void)_snprintf(result, flen, "%s%c%s", file, dirsep, filename);
return result;
#else
const char* file = __FILE__;
diff --git a/libfreerdp/crypto/tls.c b/libfreerdp/crypto/tls.c
index 8a64092ea..180010aff 100644
--- a/libfreerdp/crypto/tls.c
+++ b/libfreerdp/crypto/tls.c
@@ -710,9 +710,9 @@ static void SSLCTX_keylog_cb(const SSL* ssl, const char* line)
FILE* f = winpr_fopen(dfile, "a+");
if (f)
{
- fwrite(line, strlen(line), 1, f);
- fwrite("\n", 1, 1, f);
- fclose(f);
+ (void)fwrite(line, strlen(line), 1, f);
+ (void)fwrite("\n", 1, 1, f);
+ (void)fclose(f);
}
}
}
diff --git a/libfreerdp/crypto/x509_utils.c b/libfreerdp/crypto/x509_utils.c
index 05c5892d7..48ed48a3a 100644
--- a/libfreerdp/crypto/x509_utils.c
+++ b/libfreerdp/crypto/x509_utils.c
@@ -130,7 +130,7 @@ static const char* general_name_type_label(int general_name_type)
else
{
static char buffer[80];
- sprintf(buffer, "Unknown general name type (%d)", general_name_type);
+ (void)sprintf(buffer, "Unknown general name type (%d)", general_name_type);
return buffer;
}
}
diff --git a/libfreerdp/emu/scard/smartcard_emulate.c b/libfreerdp/emu/scard/smartcard_emulate.c
index e12b7ff33..cc93bb869 100644
--- a/libfreerdp/emu/scard/smartcard_emulate.c
+++ b/libfreerdp/emu/scard/smartcard_emulate.c
@@ -54,11 +54,11 @@ static char* card_id_and_name_a(const UUID* CardIdentifier, LPCSTR LookupName)
if (!id)
return NULL;
- snprintf(id, len, "%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X\\%s", CardIdentifier->Data1,
- CardIdentifier->Data2, CardIdentifier->Data3, CardIdentifier->Data4[0],
- CardIdentifier->Data4[1], CardIdentifier->Data4[2], CardIdentifier->Data4[3],
- CardIdentifier->Data4[4], CardIdentifier->Data4[5], CardIdentifier->Data4[6],
- CardIdentifier->Data4[7], LookupName);
+ (void)snprintf(id, len, "%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X\\%s",
+ CardIdentifier->Data1, CardIdentifier->Data2, CardIdentifier->Data3,
+ CardIdentifier->Data4[0], CardIdentifier->Data4[1], CardIdentifier->Data4[2],
+ CardIdentifier->Data4[3], CardIdentifier->Data4[4], CardIdentifier->Data4[5],
+ CardIdentifier->Data4[6], CardIdentifier->Data4[7], LookupName);
return id;
}
diff --git a/libfreerdp/gdi/region.c b/libfreerdp/gdi/region.c
index 31d638f42..58493a9e4 100644
--- a/libfreerdp/gdi/region.c
+++ b/libfreerdp/gdi/region.c
@@ -40,9 +40,9 @@ static char* gdi_rect_str(char* buffer, size_t size, const HGDI_RECT rect)
if (!buffer || (size < 1) || !rect)
return NULL;
- _snprintf(buffer, size - 1,
- "[top/left=%" PRId32 "x%" PRId32 "-bottom/right%" PRId32 "x%" PRId32 "]", rect->top,
- rect->left, rect->bottom, rect->right);
+ (void)_snprintf(buffer, size - 1,
+ "[top/left=%" PRId32 "x%" PRId32 "-bottom/right%" PRId32 "x%" PRId32 "]",
+ rect->top, rect->left, rect->bottom, rect->right);
buffer[size - 1] = '\0';
return buffer;
@@ -53,8 +53,8 @@ static char* gdi_regn_str(char* buffer, size_t size, const HGDI_RGN rgn)
if (!buffer || (size < 1) || !rgn)
return NULL;
- _snprintf(buffer, size - 1, "[%" PRId32 "x%" PRId32 "-%" PRId32 "x%" PRId32 "]", rgn->x, rgn->y,
- rgn->w, rgn->h);
+ (void)_snprintf(buffer, size - 1, "[%" PRId32 "x%" PRId32 "-%" PRId32 "x%" PRId32 "]", rgn->x,
+ rgn->y, rgn->w, rgn->h);
buffer[size - 1] = '\0';
return buffer;
diff --git a/libfreerdp/gdi/test/TestGdiBitBlt.c b/libfreerdp/gdi/test/TestGdiBitBlt.c
index ba746d509..5363abb85 100644
--- a/libfreerdp/gdi/test/TestGdiBitBlt.c
+++ b/libfreerdp/gdi/test/TestGdiBitBlt.c
@@ -565,9 +565,9 @@ int TestGdiBitBlt(int argc, char* argv[])
{
if (!test_gdi_BitBlt(formatList[x], formatList[y]))
{
- fprintf(stderr, "test_gdi_BitBlt(SrcFormat=%s, DstFormat=%s) failed!\n",
- FreeRDPGetColorFormatName(formatList[x]),
- FreeRDPGetColorFormatName(formatList[y]));
+ (void)fprintf(stderr, "test_gdi_BitBlt(SrcFormat=%s, DstFormat=%s) failed!\n",
+ FreeRDPGetColorFormatName(formatList[x]),
+ FreeRDPGetColorFormatName(formatList[y]));
rc = -1;
}
}
diff --git a/libfreerdp/gdi/test/TestGdiClip.c b/libfreerdp/gdi/test/TestGdiClip.c
index bfef3cdde..41ba07a03 100644
--- a/libfreerdp/gdi/test/TestGdiClip.c
+++ b/libfreerdp/gdi/test/TestGdiClip.c
@@ -331,12 +331,12 @@ int TestGdiClip(int argc, char* argv[])
{
WINPR_UNUSED(argc);
WINPR_UNUSED(argv);
- fprintf(stderr, "test_gdi_ClipCoords()\n");
+ (void)fprintf(stderr, "test_gdi_ClipCoords()\n");
if (test_gdi_ClipCoords() < 0)
return -1;
- fprintf(stderr, "test_gdi_InvalidateRegion()\n");
+ (void)fprintf(stderr, "test_gdi_InvalidateRegion()\n");
if (test_gdi_InvalidateRegion() < 0)
return -1;
diff --git a/libfreerdp/gdi/test/TestGdiCreate.c b/libfreerdp/gdi/test/TestGdiCreate.c
index e6594ea82..d68dd08bd 100644
--- a/libfreerdp/gdi/test/TestGdiCreate.c
+++ b/libfreerdp/gdi/test/TestGdiCreate.c
@@ -518,67 +518,67 @@ int TestGdiCreate(int argc, char* argv[])
{
WINPR_UNUSED(argc);
WINPR_UNUSED(argv);
- fprintf(stderr, "test_gdi_GetDC()\n");
+ (void)fprintf(stderr, "test_gdi_GetDC()\n");
if (test_gdi_GetDC() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateCompatibleDC()\n");
+ (void)fprintf(stderr, "test_gdi_CreateCompatibleDC()\n");
if (test_gdi_CreateCompatibleDC() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateBitmap()\n");
+ (void)fprintf(stderr, "test_gdi_CreateBitmap()\n");
if (test_gdi_CreateBitmap() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateCompatibleBitmap()\n");
+ (void)fprintf(stderr, "test_gdi_CreateCompatibleBitmap()\n");
if (test_gdi_CreateCompatibleBitmap() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreatePen()\n");
+ (void)fprintf(stderr, "test_gdi_CreatePen()\n");
if (test_gdi_CreatePen() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateSolidBrush()\n");
+ (void)fprintf(stderr, "test_gdi_CreateSolidBrush()\n");
if (test_gdi_CreateSolidBrush() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreatePatternBrush()\n");
+ (void)fprintf(stderr, "test_gdi_CreatePatternBrush()\n");
if (test_gdi_CreatePatternBrush() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateRectRgn()\n");
+ (void)fprintf(stderr, "test_gdi_CreateRectRgn()\n");
if (test_gdi_CreateRectRgn() < 0)
return -1;
- fprintf(stderr, "test_gdi_CreateRect()\n");
+ (void)fprintf(stderr, "test_gdi_CreateRect()\n");
if (test_gdi_CreateRect() < 0)
return -1;
- fprintf(stderr, "test_gdi_GetPixel()\n");
+ (void)fprintf(stderr, "test_gdi_GetPixel()\n");
if (!test_gdi_GetPixel())
return -1;
- fprintf(stderr, "test_gdi_SetPixel()\n");
+ (void)fprintf(stderr, "test_gdi_SetPixel()\n");
if (!test_gdi_SetPixel())
return -1;
- fprintf(stderr, "test_gdi_SetROP2()\n");
+ (void)fprintf(stderr, "test_gdi_SetROP2()\n");
if (test_gdi_SetROP2() < 0)
return -1;
- fprintf(stderr, "test_gdi_MoveToEx()\n");
+ (void)fprintf(stderr, "test_gdi_MoveToEx()\n");
if (test_gdi_MoveToEx() < 0)
return -1;
diff --git a/libfreerdp/gdi/test/TestGdiRop3.c b/libfreerdp/gdi/test/TestGdiRop3.c
index 27566330b..4c9183785 100644
--- a/libfreerdp/gdi/test/TestGdiRop3.c
+++ b/libfreerdp/gdi/test/TestGdiRop3.c
@@ -168,7 +168,7 @@ static char* gdi_convert_postfix_to_infix(const char* postfix)
cl = 1;
dl = al + bl + cl + 3;
d = malloc(dl + 1);
- sprintf_s(d, dl, "(%s%s%s)", b ? b : "", c, a);
+ (void)sprintf_s(d, dl, "(%s%s%s)", b ? b : "", c, a);
Stack_Push(stack, d);
free(a);
free(b);
diff --git a/libfreerdp/gdi/test/helpers.c b/libfreerdp/gdi/test/helpers.c
index b04b47639..2f237bc4e 100644
--- a/libfreerdp/gdi/test/helpers.c
+++ b/libfreerdp/gdi/test/helpers.c
@@ -81,7 +81,7 @@ static void test_dump_data(unsigned char* p, int len, int width, const char* nam
}
printf("\n");
- fflush(stdout);
+ (void)fflush(stdout);
}
void test_dump_bitmap(HGDI_BITMAP hBmp, const char* name)
@@ -128,8 +128,8 @@ BOOL test_assert_bitmaps_equal(HGDI_BITMAP hBmpActual, HGDI_BITMAP hBmpExpected,
FreeRDPGetColorFormatName(hBmpExpected->format));
test_dump_bitmap(hBmpActual, "Actual");
test_dump_bitmap(hBmpExpected, "Expected");
- fflush(stdout);
- fflush(stderr);
+ (void)fflush(stdout);
+ (void)fflush(stderr);
return TRUE; // TODO: Fix test cases
}
diff --git a/libfreerdp/locale/locale.c b/libfreerdp/locale/locale.c
index 02489f8a5..36addb57d 100644
--- a/libfreerdp/locale/locale.c
+++ b/libfreerdp/locale/locale.c
@@ -774,7 +774,7 @@ static const SYSTEM_LOCALE* get_locale_from_str(const char* name)
char buffer[LOCALE_LANGUAGE_LEN + LOCALE_COUNTRY_LEN + 2] = { 0 };
const SYSTEM_LOCALE* current = &SYSTEM_LOCALE_TABLE[i];
- _snprintf(buffer, sizeof(buffer), "%s_%s", current->language, current->country);
+ (void)_snprintf(buffer, sizeof(buffer), "%s_%s", current->language, current->country);
/* full match, e.g. en_US */
if ((strcmp(name, buffer) == 0))
return current;
diff --git a/libfreerdp/primitives/test/TestPrimitivesYUV.c b/libfreerdp/primitives/test/TestPrimitivesYUV.c
index f679c075d..e3e79d3e4 100644
--- a/libfreerdp/primitives/test/TestPrimitivesYUV.c
+++ b/libfreerdp/primitives/test/TestPrimitivesYUV.c
@@ -24,8 +24,8 @@ static BOOL similar(const BYTE* src, const BYTE* dst, size_t size)
if (abs(diff) > 4)
{
- fprintf(stderr, "%" PRIuz " %02" PRIX8 " : %02" PRIX8 " diff=%d\n", x, src[x], dst[x],
- abs(diff));
+ (void)fprintf(stderr, "%" PRIuz " %02" PRIX8 " : %02" PRIX8 " diff=%d\n", x, src[x],
+ dst[x], abs(diff));
return FALSE;
}
}
@@ -62,7 +62,7 @@ static BOOL similarRGB(const BYTE* src, const BYTE* dst, size_t size, UINT32 for
if ((labs(sR - dR) > maxDiff) || (labs(sG - dG) > maxDiff) || (labs(sB - dB) > maxDiff))
{
- fprintf(
+ (void)fprintf(
stderr,
"Color value mismatch R[%02X %02X], G[%02X %02X], B[%02X %02X] at position %" PRIuz
"\n",
@@ -72,7 +72,7 @@ static BOOL similarRGB(const BYTE* src, const BYTE* dst, size_t size, UINT32 for
if (dA != fill)
{
- fprintf(
+ (void)fprintf(
stderr,
"[%s] Invalid destination alpha value 0x%02X [expected 0x%02X] at position %" PRIuz
"\n",
@@ -119,9 +119,10 @@ static BOOL check_padding(const BYTE* psrc, size_t size, size_t padding, const c
while ((x < halfPad) && (*esrc++ != 'A'))
x++;
- fprintf(stderr,
- "Buffer underflow detected %02" PRIx8 " != %02X %s [%" PRIuz "-%" PRIuz "]\n",
- d, 'A', buffer, start, x);
+ (void)fprintf(stderr,
+ "Buffer underflow detected %02" PRIx8 " != %02X %s [%" PRIuz "-%" PRIuz
+ "]\n",
+ d, 'A', buffer, start, x);
return FALSE;
}
@@ -132,9 +133,10 @@ static BOOL check_padding(const BYTE* psrc, size_t size, size_t padding, const c
while ((x < halfPad) && (*esrc++ != 'A'))
x++;
- fprintf(stderr,
- "Buffer overflow detected %02" PRIx8 " != %02X %s [%" PRIuz "-%" PRIuz "]\n", d,
- 'A', buffer, start, x);
+ (void)fprintf(stderr,
+ "Buffer overflow detected %02" PRIx8 " != %02X %s [%" PRIuz "-%" PRIuz
+ "]\n",
+ d, 'A', buffer, start, x);
return FALSE;
}
}
@@ -202,9 +204,10 @@ static BOOL TestPrimitiveYUVCombine(primitives_t* prims, prim_size_t roi)
PROFILER_DEFINE(yuvSplit)
awidth = roi.width + 16 - roi.width % 16;
aheight = roi.height + 16 - roi.height % 16;
- fprintf(stderr,
- "Running YUVCombine on frame size %" PRIu32 "x%" PRIu32 " [%" PRIu32 "x%" PRIu32 "]\n",
- roi.width, roi.height, awidth, aheight);
+ (void)fprintf(stderr,
+ "Running YUVCombine on frame size %" PRIu32 "x%" PRIu32 " [%" PRIu32 "x%" PRIu32
+ "]\n",
+ roi.width, roi.height, awidth, aheight);
PROFILER_CREATE(yuvCombine, "YUV420CombineToYUV444")
PROFILER_CREATE(yuvSplit, "YUV444SplitToYUV420")
rect.left = 0;
@@ -432,8 +435,8 @@ static BOOL TestPrimitiveYUV(primitives_t* prims, prim_size_t roi, BOOL use444)
return FALSE;
}
- fprintf(stderr, "Running AVC%s on frame size %" PRIu32 "x%" PRIu32 "\n", use444 ? "444" : "420",
- roi.width, roi.height);
+ (void)fprintf(stderr, "Running AVC%s on frame size %" PRIu32 "x%" PRIu32 "\n",
+ use444 ? "444" : "420", roi.width, roi.height);
/* Test RGB to YUV444 conversion and vice versa */
if (!(rgb = set_padding(size * sizeof(UINT32), padding)))
@@ -648,7 +651,7 @@ static BOOL check_for_mismatches(const BYTE* planeA, const BYTE* planeB, UINT32
if (fabsf((float)a - (float)b) > 2.0f)
{
rc = TRUE;
- fprintf(stderr, "[%08x] %02x != %02x\n", x, a, b);
+ (void)fprintf(stderr, "[%08x] %02x != %02x\n", x, a, b);
}
}
@@ -665,19 +668,19 @@ static BOOL compare_yuv420(BYTE** planesA, BYTE** planesB, UINT32 width, UINT32
if (check_for_mismatches(planesA[0], planesB[0], size))
{
- fprintf(stderr, "Mismatch in Y planes!");
+ (void)fprintf(stderr, "Mismatch in Y planes!");
rc = FALSE;
}
if (check_for_mismatches(planesA[1], planesB[1], uvsize))
{
- fprintf(stderr, "Mismatch in U planes!");
+ (void)fprintf(stderr, "Mismatch in U planes!");
rc = FALSE;
}
if (check_for_mismatches(planesA[2], planesB[2], uvsize))
{
- fprintf(stderr, "Mismatch in V planes!");
+ (void)fprintf(stderr, "Mismatch in V planes!");
rc = FALSE;
}
@@ -743,8 +746,8 @@ static BOOL TestPrimitiveRgbToLumaChroma(primitives_t* prims, prim_size_t roi, U
if (!fkt || !gen)
return FALSE;
- fprintf(stderr, "Running AVC444 on frame size %" PRIu32 "x%" PRIu32 "\n", roi.width,
- roi.height);
+ (void)fprintf(stderr, "Running AVC444 on frame size %" PRIu32 "x%" PRIu32 "\n", roi.width,
+ roi.height);
/* Test RGB to YUV444 conversion and vice versa */
if (!(rgb = set_padding(size * sizeof(UINT32), padding)))
diff --git a/libfreerdp/primitives/test/prim_test.c b/libfreerdp/primitives/test/prim_test.c
index 5ec85f85e..8dcf29231 100644
--- a/libfreerdp/primitives/test/prim_test.c
+++ b/libfreerdp/primitives/test/prim_test.c
@@ -57,19 +57,19 @@ void measure_floatprint(float t, char* output)
i = ((int)(t / f + 0.5f)) * (int)f;
if (t < 0.0f)
- sprintf(output, "%f", t);
+ (void)sprintf(output, "%f", t);
else if (i == 0)
- sprintf(output, "%d", (int)(t + 0.5f));
+ (void)sprintf(output, "%d", (int)(t + 0.5f));
else if (t < 1e+3f)
- sprintf(output, "%3d", i);
+ (void)sprintf(output, "%3d", i);
else if (t < 1e+6f)
- sprintf(output, "%3d,%03d", i / 1000, i % 1000);
+ (void)sprintf(output, "%3d,%03d", i / 1000, i % 1000);
else if (t < 1e+9f)
- sprintf(output, "%3d,%03d,000", i / 1000000, (i % 1000000) / 1000);
+ (void)sprintf(output, "%3d,%03d,000", i / 1000000, (i % 1000000) / 1000);
else if (t < 1e+12f)
- sprintf(output, "%3d,%03d,000,000", i / 1000000000, (i % 1000000000) / 1000000);
+ (void)sprintf(output, "%3d,%03d,000,000", i / 1000000000, (i % 1000000000) / 1000000);
else
- sprintf(output, "%f", t);
+ (void)sprintf(output, "%f", t);
}
void prim_test_setup(BOOL performance)
diff --git a/libfreerdp/utils/http.c b/libfreerdp/utils/http.c
index 5c344394e..0f50823b8 100644
--- a/libfreerdp/utils/http.c
+++ b/libfreerdp/utils/http.c
@@ -387,6 +387,6 @@ const char* freerdp_http_status_string(long status)
char* freerdp_http_status_string_format(long status, char* buffer, size_t size)
{
const char* code = freerdp_http_status_string(status);
- _snprintf(buffer, size, "%s [%ld]", code, status);
+ (void)_snprintf(buffer, size, "%s [%ld]", code, status);
return buffer;
}
diff --git a/libfreerdp/utils/passphrase.c b/libfreerdp/utils/passphrase.c
index 511bf0b88..7570f9660 100644
--- a/libfreerdp/utils/passphrase.c
+++ b/libfreerdp/utils/passphrase.c
@@ -171,8 +171,8 @@ char* freerdp_passphrase_read_tty(rdpContext* context, const char* prompt, char*
if (!fp)
goto error;
- fprintf(fout, "%s", prompt);
- fflush(fout);
+ (void)fprintf(fout, "%s", prompt);
+ (void)fflush(fout);
char* ptr = NULL;
size_t ptr_len = 0;
@@ -206,7 +206,7 @@ error:
if (terminal_fildes != STDIN_FILENO)
{
if (fp)
- fclose(fp);
+ (void)fclose(fp);
}
errno = saved_errno;
return NULL;
diff --git a/libfreerdp/utils/pcap.c b/libfreerdp/utils/pcap.c
index c18caf296..538e1325e 100644
--- a/libfreerdp/utils/pcap.c
+++ b/libfreerdp/utils/pcap.c
@@ -250,7 +250,7 @@ void pcap_flush(rdpPcap* pcap)
}
if (pcap->fp != NULL)
- fflush(pcap->fp);
+ (void)fflush(pcap->fp);
}
void pcap_close(rdpPcap* pcap)
@@ -261,7 +261,7 @@ void pcap_close(rdpPcap* pcap)
pcap_flush(pcap);
if (pcap->fp != NULL)
- fclose(pcap->fp);
+ (void)fclose(pcap->fp);
free(pcap->name);
free(pcap);
diff --git a/libfreerdp/utils/signal.c b/libfreerdp/utils/signal.c
index 487b9b0f8..4048d3db7 100644
--- a/libfreerdp/utils/signal.c
+++ b/libfreerdp/utils/signal.c
@@ -135,7 +135,7 @@ static void fatal_handler(int signum)
sigemptyset(&this_mask);
sigaddset(&this_mask, signum);
pthread_sigmask(SIG_UNBLOCK, &this_mask, NULL);
- raise(signum);
+ (void)raise(signum);
}
static const int term_signals[] = { SIGINT, SIGKILL, SIGQUIT, SIGSTOP, SIGTERM };
@@ -204,7 +204,7 @@ int freerdp_handle_signals(void)
goto fail;
/* Ignore SIGPIPE signal. */
- signal(SIGPIPE, SIG_IGN);
+ (void)signal(SIGPIPE, SIG_IGN);
handlers_registered = TRUE;
rc = 0;
fail:
diff --git a/libfreerdp/utils/string.c b/libfreerdp/utils/string.c
index 3ee73f1f6..4e520ea1d 100644
--- a/libfreerdp/utils/string.c
+++ b/libfreerdp/utils/string.c
@@ -98,7 +98,7 @@ char* rdp_cluster_info_flags_to_string(UINT32 flags, char* buffer, size_t size)
winpr_str_append(str, buffer, size, "|");
{
char msg[32] = { 0 };
- _snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
+ (void)_snprintf(msg, sizeof(msg), "[0x%08" PRIx32 "]", flags);
winpr_str_append(msg, buffer, size, "");
}
return buffer;
diff --git a/libfreerdp/utils/test/TestEncodedTypes.c b/libfreerdp/utils/test/TestEncodedTypes.c
index f051d9c67..b059d3bfe 100644
--- a/libfreerdp/utils/test/TestEncodedTypes.c
+++ b/libfreerdp/utils/test/TestEncodedTypes.c
@@ -38,23 +38,24 @@ static BOOL test_signed_integer_read_write_equal(INT32 value)
if (!freerdp_write_four_byte_signed_integer(s, value))
{
- fprintf(stderr, "[%s(%" PRId32 ")] failed to write to stream\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%" PRId32 ")] failed to write to stream\n", __func__, value);
return FALSE;
}
if (!Stream_SetPosition(s, 0))
{
- fprintf(stderr, "[%s(%" PRId32 ")] failed to reset stream position\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%" PRId32 ")] failed to reset stream position\n", __func__,
+ value);
return FALSE;
}
if (!freerdp_read_four_byte_signed_integer(s, &rvalue))
{
- fprintf(stderr, "[%s(%" PRId32 ")] failed to read from stream\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%" PRId32 ")] failed to read from stream\n", __func__, value);
return FALSE;
}
if (value != rvalue)
{
- fprintf(stderr, "[%s(%" PRId32 ")] read invalid value %" PRId32 " from stream\n", __func__,
- value, rvalue);
+ (void)fprintf(stderr, "[%s(%" PRId32 ")] read invalid value %" PRId32 " from stream\n",
+ __func__, value, rvalue);
return FALSE;
}
return TRUE;
@@ -69,8 +70,9 @@ static BOOL test_signed_integer_write_oor(INT32 value)
if (freerdp_write_four_byte_signed_integer(s, value))
{
- fprintf(stderr, "[%s(%" PRId32 ")] out of range value not detected and written to stream\n",
- __func__, value);
+ (void)fprintf(stderr,
+ "[%s(%" PRId32 ")] out of range value not detected and written to stream\n",
+ __func__, value);
return FALSE;
}
return TRUE;
@@ -120,24 +122,25 @@ static BOOL test_float_read_write_equal(double value)
if (!freerdp_write_four_byte_float(s, value))
{
- fprintf(stderr, "[%s(%lf)] failed to write to stream\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%lf)] failed to write to stream\n", __func__, value);
return FALSE;
}
if (!Stream_SetPosition(s, 0))
{
- fprintf(stderr, "[%s(%lf)] failed to reset stream position\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%lf)] failed to reset stream position\n", __func__, value);
return FALSE;
}
if (!freerdp_read_four_byte_float_exp(s, &rvalue, &exp))
{
- fprintf(stderr, "[%s(%lf)] failed to read from stream\n", __func__, value);
+ (void)fprintf(stderr, "[%s(%lf)] failed to read from stream\n", __func__, value);
return FALSE;
}
const double diff = fabs(value - rvalue);
const UINT64 expdiff = diff * pow(10, exp);
if (expdiff > 0)
{
- fprintf(stderr, "[%s(%lf)] read invalid value %lf from stream\n", __func__, value, rvalue);
+ (void)fprintf(stderr, "[%s(%lf)] read invalid value %lf from stream\n", __func__, value,
+ rvalue);
return FALSE;
}
return TRUE;
@@ -152,8 +155,8 @@ static BOOL test_floag_write_oor(double value)
if (freerdp_write_four_byte_float(s, value))
{
- fprintf(stderr, "[%s(%lf)] out of range value not detected and written to stream\n",
- __func__, value);
+ (void)fprintf(stderr, "[%s(%lf)] out of range value not detected and written to stream\n",
+ __func__, value);
return FALSE;
}
return TRUE;
diff --git a/libfreerdp/utils/test/TestRingBuffer.c b/libfreerdp/utils/test/TestRingBuffer.c
index 8e88a65fb..e19b3b3b8 100644
--- a/libfreerdp/utils/test/TestRingBuffer.c
+++ b/libfreerdp/utils/test/TestRingBuffer.c
@@ -91,7 +91,7 @@ int TestRingBuffer(int argc, char* argv[])
if (!ringbuffer_init(&ringBuffer, 10))
{
- fprintf(stderr, "unable to initialize ringbuffer\n");
+ (void)fprintf(stderr, "unable to initialize ringbuffer\n");
return -1;
}
@@ -102,24 +102,24 @@ int TestRingBuffer(int argc, char* argv[])
for (int i = 0; i < 50; i++)
tmpBuf[i] = (char)i;
- fprintf(stderr, "%d: basic tests...", ++testNo);
+ (void)fprintf(stderr, "%d: basic tests...", ++testNo);
if (!ringbuffer_write(&ringBuffer, tmpBuf, 5) || !ringbuffer_write(&ringBuffer, tmpBuf, 5) ||
!ringbuffer_write(&ringBuffer, tmpBuf, 5))
{
- fprintf(stderr, "error when writing bytes\n");
+ (void)fprintf(stderr, "error when writing bytes\n");
return -1;
}
if (ringbuffer_used(&ringBuffer) != 15)
{
- fprintf(stderr, "invalid used size got %" PRIuz " when I would expect 15\n",
- ringbuffer_used(&ringBuffer));
+ (void)fprintf(stderr, "invalid used size got %" PRIuz " when I would expect 15\n",
+ ringbuffer_used(&ringBuffer));
return -1;
}
if (ringbuffer_peek(&ringBuffer, chunks, 10) != 1 || chunks[0].size != 10)
{
- fprintf(stderr, "error when reading bytes\n");
+ (void)fprintf(stderr, "error when reading bytes\n");
return -1;
}
ringbuffer_commit_read_bytes(&ringBuffer, chunks[0].size);
@@ -129,16 +129,16 @@ int TestRingBuffer(int argc, char* argv[])
{
if (chunks[0].data[i] != i % 5)
{
- fprintf(stderr, "invalid byte at %d, got %" PRIu8 " instead of %d\n", i,
- chunks[0].data[i], i % 5);
+ (void)fprintf(stderr, "invalid byte at %d, got %" PRIu8 " instead of %d\n", i,
+ chunks[0].data[i], i % 5);
return -1;
}
}
if (ringbuffer_used(&ringBuffer) != 5)
{
- fprintf(stderr, "invalid used size after read got %" PRIuz " when I would expect 5\n",
- ringbuffer_used(&ringBuffer));
+ (void)fprintf(stderr, "invalid used size after read got %" PRIuz " when I would expect 5\n",
+ ringbuffer_used(&ringBuffer));
return -1;
}
@@ -147,28 +147,28 @@ int TestRingBuffer(int argc, char* argv[])
ringbuffer_peek(&ringBuffer, chunks, 11) != 2 || chunks[0].size != 10 ||
chunks[1].size != 1)
{
- fprintf(stderr, "invalid read of splitted data\n");
+ (void)fprintf(stderr, "invalid read of splitted data\n");
return -1;
}
ringbuffer_commit_read_bytes(&ringBuffer, 11);
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
- fprintf(stderr, "%d: peek with nothing to read...", ++testNo);
+ (void)fprintf(stderr, "%d: peek with nothing to read...", ++testNo);
if (ringbuffer_peek(&ringBuffer, chunks, 10))
{
- fprintf(stderr, "peek returns some chunks\n");
+ (void)fprintf(stderr, "peek returns some chunks\n");
return -1;
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
- fprintf(stderr, "%d: ensure_linear_write / read() shouldn't grow...", ++testNo);
+ (void)fprintf(stderr, "%d: ensure_linear_write / read() shouldn't grow...", ++testNo);
for (int i = 0; i < 1000; i++)
{
rb_ptr = ringbuffer_ensure_linear_write(&ringBuffer, 50);
if (!rb_ptr)
{
- fprintf(stderr, "ringbuffer_ensure_linear_write() error\n");
+ (void)fprintf(stderr, "ringbuffer_ensure_linear_write() error\n");
return -1;
}
@@ -176,7 +176,7 @@ int TestRingBuffer(int argc, char* argv[])
if (!ringbuffer_commit_written_bytes(&ringBuffer, 50))
{
- fprintf(stderr, "ringbuffer_commit_written_bytes() error, i=%d\n", i);
+ (void)fprintf(stderr, "ringbuffer_commit_written_bytes() error, i=%d\n", i);
return -1;
}
@@ -191,34 +191,34 @@ int TestRingBuffer(int argc, char* argv[])
if (ringbuffer_capacity(&ringBuffer) != 10)
{
- fprintf(stderr, "not the expected capacity, have %" PRIuz " and expects 10\n",
- ringbuffer_capacity(&ringBuffer));
+ (void)fprintf(stderr, "not the expected capacity, have %" PRIuz " and expects 10\n",
+ ringbuffer_capacity(&ringBuffer));
return -1;
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
- fprintf(stderr, "%d: free size is correctly computed...", ++testNo);
+ (void)fprintf(stderr, "%d: free size is correctly computed...", ++testNo);
for (int i = 0; i < 1000; i++)
{
ringbuffer_ensure_linear_write(&ringBuffer, 50);
if (!ringbuffer_commit_written_bytes(&ringBuffer, 50))
{
- fprintf(stderr, "ringbuffer_commit_written_bytes() error, i=%d\n", i);
+ (void)fprintf(stderr, "ringbuffer_commit_written_bytes() error, i=%d\n", i);
return -1;
}
}
ringbuffer_commit_read_bytes(&ringBuffer, 50 * 1000);
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
ringbuffer_destroy(&ringBuffer);
- fprintf(stderr, "%d: specific overlaps test...", ++testNo);
+ (void)fprintf(stderr, "%d: specific overlaps test...", ++testNo);
if (!test_overlaps())
{
- fprintf(stderr, "ko\n");
+ (void)fprintf(stderr, "ko\n");
return -1;
}
- fprintf(stderr, "ok\n");
+ (void)fprintf(stderr, "ok\n");
ringbuffer_destroy(&ringBuffer);
free(tmpBuf);
diff --git a/rdtk/librdtk/rdtk_font.c b/rdtk/librdtk/rdtk_font.c
index c44e95256..899bc9cf8 100644
--- a/rdtk/librdtk/rdtk_font.c
+++ b/rdtk/librdtk/rdtk_font.c
@@ -167,7 +167,7 @@ static char* rdtk_font_load_descriptor_file(const char* filename, size_t* pSize)
if (fileSize.i64 < 1)
{
- fclose(fp);
+ (void)fclose(fp);
return NULL;
}
@@ -175,7 +175,7 @@ static char* rdtk_font_load_descriptor_file(const char* filename, size_t* pSize)
if (!buffer)
{
- fclose(fp);
+ (void)fclose(fp);
return NULL;
}
@@ -186,7 +186,7 @@ static char* rdtk_font_load_descriptor_file(const char* filename, size_t* pSize)
readSize = fileSize.s;
}
- fclose(fp);
+ (void)fclose(fp);
if (readSize < 1)
{
diff --git a/server/Sample/sfreerdp.c b/server/Sample/sfreerdp.c
index b61057791..c95b50f1f 100644
--- a/server/Sample/sfreerdp.c
+++ b/server/Sample/sfreerdp.c
@@ -1327,16 +1327,16 @@ static void print_entry(FILE* fp, WINPR_FORMAT_ARG const char* fmt, const char*
{
char buffer[32] = { 0 };
strncpy(buffer, what, MIN(size, sizeof(buffer) - 1));
- fprintf(fp, fmt, buffer);
+ (void)fprintf(fp, fmt, buffer);
}
static WINPR_NORETURN(void usage(const char* app, const char* invalid))
{
FILE* fp = stdout;
- fprintf(fp, "Invalid argument '%s'\n", invalid);
- fprintf(fp, "Usage: %s [ ...]\n", app);
- fprintf(fp, "Arguments:\n");
+ (void)fprintf(fp, "Invalid argument '%s'\n", invalid);
+ (void)fprintf(fp, "Usage: %s [ ...]\n", app);
+ (void)fprintf(fp, "Arguments:\n");
print_entry(fp, "\t%s\n", options.spcap, sizeof(options.spcap));
print_entry(fp, "\t%s\n", options.scert, sizeof(options.scert));
print_entry(fp, "\t%s\n", options.skey, sizeof(options.skey));
@@ -1420,7 +1420,7 @@ int main(int argc, char* argv[])
goto fail;
/* Open the server socket and start listening. */
- sprintf_s(name, sizeof(name), "tfreerdp-server.%ld", port);
+ (void)sprintf_s(name, sizeof(name), "tfreerdp-server.%ld", port);
file = GetKnownSubPath(KNOWN_PATH_TEMP, name);
if (!file)
diff --git a/server/proxy/cli/freerdp_proxy.c b/server/proxy/cli/freerdp_proxy.c
index ff0b3d5c6..1ee25b8c9 100644
--- a/server/proxy/cli/freerdp_proxy.c
+++ b/server/proxy/cli/freerdp_proxy.c
@@ -51,7 +51,7 @@ static const char* strsignal(int signum)
static void cleanup_handler(int signum)
{
- printf("\n");
+ (void)printf("\n");
WLog_INFO(TAG, "caught signal %s [%d], starting cleanup...", strsignal(signum), signum);
WLog_INFO(TAG, "stopping all connections.");
@@ -60,11 +60,11 @@ static void cleanup_handler(int signum)
static void pf_server_register_signal_handlers(void)
{
- signal(SIGINT, cleanup_handler);
- signal(SIGTERM, cleanup_handler);
+ (void)signal(SIGINT, cleanup_handler);
+ (void)signal(SIGTERM, cleanup_handler);
#ifndef _WIN32
- signal(SIGQUIT, cleanup_handler);
- signal(SIGKILL, cleanup_handler);
+ (void)signal(SIGQUIT, cleanup_handler);
+ (void)signal(SIGKILL, cleanup_handler);
#endif
}
diff --git a/server/proxy/modules/dyn-channel-dump/dyn-channel-dump.cpp b/server/proxy/modules/dyn-channel-dump/dyn-channel-dump.cpp
index ededc2e00..bca617aa7 100644
--- a/server/proxy/modules/dyn-channel-dump/dyn-channel-dump.cpp
+++ b/server/proxy/modules/dyn-channel-dump/dyn-channel-dump.cpp
@@ -95,7 +95,7 @@ class ChannelData
: _base(base), _channels_to_dump(list), _session_id(sessionid)
{
char str[64] = {};
- _snprintf(str, sizeof(str), "session-%016" PRIx64, _session_id);
+ (void)_snprintf(str, sizeof(str), "session-%016" PRIx64, _session_id);
_base /= str;
}
@@ -176,7 +176,7 @@ class ChannelData
{
auto name = idstr(channel, back);
char cstr[32] = {};
- _snprintf(cstr, sizeof(cstr), "%016" PRIx64 "-", count);
+ (void)_snprintf(cstr, sizeof(cstr), "%016" PRIx64 "-", count);
auto path = _base / cstr;
path += name;
path += ".dump";
diff --git a/server/proxy/pf_modules.c b/server/proxy/pf_modules.c
index e3447cbc3..53ea49dbf 100644
--- a/server/proxy/pf_modules.c
+++ b/server/proxy/pf_modules.c
@@ -597,8 +597,8 @@ proxyModule* pf_modules_new(const char* root_dir, const char** modules, size_t c
{
char name[8192] = { 0 };
char* fullpath = NULL;
- _snprintf(name, sizeof(name), "proxy-%s-plugin%s", modules[i],
- FREERDP_SHARED_LIBRARY_SUFFIX);
+ (void)_snprintf(name, sizeof(name), "proxy-%s-plugin%s", modules[i],
+ FREERDP_SHARED_LIBRARY_SUFFIX);
fullpath = GetCombinedPath(path, name);
pf_modules_load_module(fullpath, module, NULL);
free(fullpath);
diff --git a/server/shadow/X11/x11_shadow.c b/server/shadow/X11/x11_shadow.c
index 2649b0af3..bddbaa7a3 100644
--- a/server/shadow/X11/x11_shadow.c
+++ b/server/shadow/X11/x11_shadow.c
@@ -135,10 +135,10 @@ static BOOL x11_shadow_pam_get_service_name(SHADOW_PAM_AUTH_INFO* info)
for (size_t x = 0; x < ARRAYSIZE(hints); x++)
{
- char path[MAX_PATH];
+ char path[MAX_PATH] = { 0 };
const char* hint = hints[x];
- _snprintf(path, sizeof(path), "%s/%s", base, hint);
+ (void)_snprintf(path, sizeof(path), "%s/%s", base, hint);
if (winpr_PathFileExists(path))
{
diff --git a/server/shadow/shadow_server.c b/server/shadow/shadow_server.c
index 6442ab715..5377dbc23 100644
--- a/server/shadow/shadow_server.c
+++ b/server/shadow/shadow_server.c
@@ -91,8 +91,8 @@ static int shadow_server_print_command_line_help(int argc, char** argv,
if (!str)
return -1;
- sprintf_s(str, length + 1, "%s:%s", arg->Name, arg->Format);
- printf("%-20s\n", str);
+ (void)sprintf_s(str, length + 1, "%s:%s", arg->Name, arg->Format);
+ (void)printf("%-20s\n", str);
free(str);
}
else
@@ -110,11 +110,12 @@ static int shadow_server_print_command_line_help(int argc, char** argv,
if (!str)
return -1;
- sprintf_s(str, length + 1, "%s (default:%s)", arg->Name, arg->Default ? "on" : "off");
- printf(" %s", arg->Default ? "-" : "+");
- printf("%-20s\n", str);
+ (void)sprintf_s(str, length + 1, "%s (default:%s)", arg->Name,
+ arg->Default ? "on" : "off");
+ (void)printf(" %s", arg->Default ? "-" : "+");
+ (void)printf("%-20s\n", str);
free(str);
- printf("\t%s\n", arg->Text);
+ (void)printf("\t%s\n", arg->Text);
}
} while ((arg = CommandLineFindNextArgumentA(arg)) != NULL);
@@ -640,7 +641,7 @@ int shadow_server_start(rdpShadowServer* server)
return -1;
#ifndef _WIN32
- signal(SIGPIPE, SIG_IGN);
+ (void)signal(SIGPIPE, SIG_IGN);
#endif
server->screen = shadow_screen_new(server);
diff --git a/uwac/libuwac/uwac-clipboard.c b/uwac/libuwac/uwac-clipboard.c
index 2ff96042f..430603bc2 100644
--- a/uwac/libuwac/uwac-clipboard.c
+++ b/uwac/libuwac/uwac-clipboard.c
@@ -54,7 +54,7 @@ static void data_offer_offer(void* data, struct wl_data_offer* data_offer,
else
{
event->seat = seat;
- snprintf(event->mime, sizeof(event->mime), "%s", offered_mime_type);
+ (void)snprintf(event->mime, sizeof(event->mime), "%s", offered_mime_type);
}
}
}
diff --git a/uwac/libuwac/uwac-display.c b/uwac/libuwac/uwac-display.c
index 91b2d6261..070edc515 100644
--- a/uwac/libuwac/uwac-display.c
+++ b/uwac/libuwac/uwac-display.c
@@ -56,7 +56,7 @@ static bool uwac_default_error_handler(UwacDisplay* display, UwacReturnCode code
{
va_list args;
va_start(args, msg);
- vfprintf(stderr, "%s", args);
+ (void)vfprintf(stderr, "%s", args);
va_end(args);
return false;
}
@@ -402,7 +402,8 @@ UwacDisplay* UwacOpenDisplay(const char* name, UwacReturnCode* err)
if (ret->display == NULL)
{
- fprintf(stderr, "failed to connect to Wayland display %s: %s\n", name, strerror(errno));
+ (void)fprintf(stderr, "failed to connect to Wayland display %s: %s\n", name,
+ strerror(errno));
*err = UWAC_ERROR_UNABLE_TO_CONNECT;
goto out_free;
}
diff --git a/uwac/libuwac/uwac-input.c b/uwac/libuwac/uwac-input.c
index b11b1a422..7af7c1795 100644
--- a/uwac/libuwac/uwac-input.c
+++ b/uwac/libuwac/uwac-input.c
@@ -75,8 +75,8 @@ static struct wl_buffer* create_pointer_buffer(UwacSeat* seat, const void* src,
wl_shm_pool_destroy(pool);
if (munmap(data, size) < 0)
- fprintf(stderr, "%s: munmap(%p, %zu) failed with [%d] %s\n", __func__, data, size, errno,
- strerror(errno));
+ (void)fprintf(stderr, "%s: munmap(%p, %zu) failed with [%d] %s\n", __func__, data, size,
+ errno, strerror(errno));
error_mmap:
close(fd);
@@ -1103,7 +1103,7 @@ UwacSeat* UwacSeatNew(UwacDisplay* d, uint32_t id, uint32_t version)
ret->xkb_context = xkb_context_new(0);
if (!ret->xkb_context)
{
- fprintf(stderr, "%s: unable to allocate a xkb_context\n", __func__);
+ (void)fprintf(stderr, "%s: unable to allocate a xkb_context\n", __func__);
goto fail;
}
@@ -1114,13 +1114,13 @@ UwacSeat* UwacSeatNew(UwacDisplay* d, uint32_t id, uint32_t version)
ret->repeat_timer_fd = timerfd_create(CLOCK_MONOTONIC, TFD_CLOEXEC | TFD_NONBLOCK);
if (ret->repeat_timer_fd < 0)
{
- fprintf(stderr, "%s: error creating repeat timer\n", __func__);
+ (void)fprintf(stderr, "%s: error creating repeat timer\n", __func__);
goto fail;
}
ret->repeat_task.run = keyboard_repeat_func;
if (UwacDisplayWatchFd(d, ret->repeat_timer_fd, EPOLLIN, &ret->repeat_task) < 0)
{
- fprintf(stderr, "%s: error polling repeat timer\n", __func__);
+ (void)fprintf(stderr, "%s: error polling repeat timer\n", __func__);
goto fail;
}
diff --git a/uwac/libuwac/uwac-os.c b/uwac/libuwac/uwac-os.c
index c51c5a223..d53daf8f2 100644
--- a/uwac/libuwac/uwac-os.c
+++ b/uwac/libuwac/uwac-os.c
@@ -258,7 +258,7 @@ int uwac_create_anonymous_file(off_t size)
if (!name)
return -1;
- snprintf(name, length, "%s%s", path, template);
+ (void)snprintf(name, length, "%s%s", path, template);
fd = create_tmpfile_cloexec(name);
free(name);
}
diff --git a/uwac/libuwac/uwac-utils.c b/uwac/libuwac/uwac-utils.c
index f93b5f771..a3adc0209 100644
--- a/uwac/libuwac/uwac-utils.c
+++ b/uwac/libuwac/uwac-utils.c
@@ -39,7 +39,7 @@ static void* fail_on_null(void* p)
{
if (p == NULL)
{
- fprintf(stderr, "out of memory\n");
+ (void)fprintf(stderr, "out of memory\n");
exit(EXIT_FAILURE);
}
diff --git a/winpr/libwinpr/clipboard/synthetic.c b/winpr/libwinpr/clipboard/synthetic.c
index cae510674..a928731cc 100644
--- a/winpr/libwinpr/clipboard/synthetic.c
+++ b/winpr/libwinpr/clipboard/synthetic.c
@@ -507,19 +507,19 @@ static void* clipboard_synthesize_html_format(wClipboard* clipboard, UINT32 form
if (!pDstData)
goto fail;
- sprintf_s(pDstData, DstSize,
- "Version:0.9\r\n"
- "StartHTML:0000000000\r\n"
- "EndHTML:0000000000\r\n"
- "StartFragment:0000000000\r\n"
- "EndFragment:0000000000\r\n");
+ (void)sprintf_s(pDstData, DstSize,
+ "Version:0.9\r\n"
+ "StartHTML:0000000000\r\n"
+ "EndHTML:0000000000\r\n"
+ "StartFragment:0000000000\r\n"
+ "EndFragment:0000000000\r\n");
body = strstr(pSrcData.cpc, "", pDstData, DstSize, NULL))
@@ -552,7 +552,7 @@ static void* clipboard_synthesize_html_format(wClipboard* clipboard, UINT32 form
}
/* EndHTML */
- sprintf_s(num, sizeof(num), "%010" PRIuz "", strnlen(pDstData, DstSize));
+ (void)sprintf_s(num, sizeof(num), "%010" PRIuz "", strnlen(pDstData, DstSize));
CopyMemory(&pDstData[43], num, 10);
*pSize = (UINT32)strnlen(pDstData, DstSize) + 1;
}
diff --git a/winpr/libwinpr/clipboard/synthetic_file.c b/winpr/libwinpr/clipboard/synthetic_file.c
index 4290d2a0f..283c56b50 100644
--- a/winpr/libwinpr/clipboard/synthetic_file.c
+++ b/winpr/libwinpr/clipboard/synthetic_file.c
@@ -775,7 +775,7 @@ static void* convert_filedescriptors_to_file_list(wClipboard* clipboard, UINT32
if (!dst)
return NULL;
- _snprintf(&dst[0], alloc, "%s", header);
+ (void)_snprintf(&dst[0], alloc, "%s", header);
pos = header_len;
diff --git a/winpr/libwinpr/clipboard/test/TestClipboardFormats.c b/winpr/libwinpr/clipboard/test/TestClipboardFormats.c
index 74cec0779..cde602b43 100644
--- a/winpr/libwinpr/clipboard/test/TestClipboardFormats.c
+++ b/winpr/libwinpr/clipboard/test/TestClipboardFormats.c
@@ -26,7 +26,7 @@ int TestClipboardFormats(int argc, char* argv[])
{
const char* mime = mime_types[x];
UINT32 id = ClipboardRegisterFormat(clipboard, mime);
- fprintf(stderr, "ClipboardRegisterFormat(%s) -> 0x%08" PRIx32 "\n", mime, id);
+ (void)fprintf(stderr, "ClipboardRegisterFormat(%s) -> 0x%08" PRIx32 "\n", mime, id);
if (id == 0)
goto fail;
}
@@ -39,7 +39,7 @@ int TestClipboardFormats(int argc, char* argv[])
{
UINT32 formatId = pFormatIds[index];
formatName = ClipboardGetFormatName(clipboard, formatId);
- fprintf(stderr, "Format: 0x%08" PRIX32 " %s\n", formatId, formatName);
+ (void)fprintf(stderr, "Format: 0x%08" PRIX32 " %s\n", formatId, formatName);
}
free(pFormatIds);
@@ -54,10 +54,10 @@ int TestClipboardFormats(int argc, char* argv[])
SrcSize = (UINT32)(strnlen(pSrcData, ARRAYSIZE(pSrcData)) + 1);
bSuccess = ClipboardSetData(clipboard, utf8StringFormatId, pSrcData, SrcSize);
- fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
+ (void)fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
DstSize = 0;
pDstData = (char*)ClipboardGetData(clipboard, utf8StringFormatId, &DstSize);
- fprintf(stderr, "ClipboardGetData: %s\n", pDstData);
+ (void)fprintf(stderr, "ClipboardGetData: %s\n", pDstData);
free(pDstData);
}
@@ -70,7 +70,7 @@ int TestClipboardFormats(int argc, char* argv[])
pDstData = (WCHAR*)ClipboardGetData(clipboard, CF_UNICODETEXT, &DstSize);
pSrcData = ConvertWCharNToUtf8Alloc(pDstData, DstSize / sizeof(WCHAR), NULL);
- fprintf(stderr, "ClipboardGetData (synthetic): %s\n", pSrcData);
+ (void)fprintf(stderr, "ClipboardGetData (synthetic): %s\n", pSrcData);
free(pDstData);
free(pSrcData);
}
@@ -82,7 +82,7 @@ int TestClipboardFormats(int argc, char* argv[])
{
UINT32 formatId = pFormatIds[index];
formatName = ClipboardGetFormatName(clipboard, formatId);
- fprintf(stderr, "Format: 0x%08" PRIX32 " %s\n", formatId, formatName);
+ (void)fprintf(stderr, "Format: 0x%08" PRIX32 " %s\n", formatId, formatName);
}
if (1)
@@ -104,7 +104,7 @@ int TestClipboardFormats(int argc, char* argv[])
size_t bmpsize = 0;
void* data = winpr_image_write_buffer(img, WINPR_IMAGE_BITMAP, &bmpsize);
bSuccess = ClipboardSetData(clipboard, idBmp, data, bmpsize);
- fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
+ (void)fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
free(data);
winpr_image_free(img, TRUE);
@@ -116,7 +116,8 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [CF_DIB] %p [%" PRIu32 "]\n", pDstData, DstSize);
+ (void)fprintf(stderr, "ClipboardGetData: [CF_DIB] %p [%" PRIu32 "]\n", pDstData,
+ DstSize);
if (!pDstData)
goto fail;
bSuccess = ClipboardSetData(clipboard, id, pDstData, DstSize);
@@ -129,7 +130,8 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [image/bmp] %p [%" PRIu32 "]\n", pDstData, DstSize);
+ (void)fprintf(stderr, "ClipboardGetData: [image/bmp] %p [%" PRIu32 "]\n", pDstData,
+ DstSize);
if (!pDstData)
goto fail;
free(pDstData);
@@ -143,7 +145,7 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [image/png] %p\n", pDstData);
+ (void)fprintf(stderr, "ClipboardGetData: [image/png] %p\n", pDstData);
if (!pDstData)
goto fail;
free(pDstData);
@@ -166,7 +168,7 @@ int TestClipboardFormats(int argc, char* argv[])
size_t bmpsize = 0;
void* data = winpr_image_write_buffer(img, WINPR_IMAGE_PNG, &bmpsize);
bSuccess = ClipboardSetData(clipboard, idBmp, data, bmpsize);
- fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
+ (void)fprintf(stderr, "ClipboardSetData: %" PRId32 "\n", bSuccess);
free(data);
winpr_image_free(img, TRUE);
@@ -178,7 +180,8 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [CF_DIB] %p [%" PRIu32 "]\n", pDstData, DstSize);
+ (void)fprintf(stderr, "ClipboardGetData: [CF_DIB] %p [%" PRIu32 "]\n", pDstData,
+ DstSize);
if (!pDstData)
goto fail;
bSuccess = ClipboardSetData(clipboard, id, pDstData, DstSize);
@@ -194,7 +197,7 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [image/webp] %p\n", pDstData);
+ (void)fprintf(stderr, "ClipboardGetData: [image/webp] %p\n", pDstData);
if (!pDstData)
goto fail;
free(pDstData);
@@ -207,7 +210,7 @@ int TestClipboardFormats(int argc, char* argv[])
UINT32 DstSize = 0;
void* pDstData = ClipboardGetData(clipboard, id, &DstSize);
- fprintf(stderr, "ClipboardGetData: [image/jpeg] %p\n", pDstData);
+ (void)fprintf(stderr, "ClipboardGetData: [image/jpeg] %p\n", pDstData);
if (!pDstData)
goto fail;
free(pDstData);
diff --git a/winpr/libwinpr/crt/conversion.c b/winpr/libwinpr/crt/conversion.c
index 0a3d1e1c6..0eb354cf8 100644
--- a/winpr/libwinpr/crt/conversion.c
+++ b/winpr/libwinpr/crt/conversion.c
@@ -38,7 +38,7 @@ errno_t _itoa_s(int value, char* buffer, size_t sizeInCharacters, int radix)
if (sizeInCharacters < (size_t)length)
return -1;
- sprintf_s(buffer, length + 1, "%d", value);
+ (void)sprintf_s(buffer, length + 1, "%d", value);
return 0;
}
diff --git a/winpr/libwinpr/crt/test/TestFormatSpecifiers.c b/winpr/libwinpr/crt/test/TestFormatSpecifiers.c
index 5ae6a40a6..dcdc36eb5 100644
--- a/winpr/libwinpr/crt/test/TestFormatSpecifiers.c
+++ b/winpr/libwinpr/crt/test/TestFormatSpecifiers.c
@@ -16,13 +16,13 @@ int TestFormatSpecifiers(int argc, char* argv[])
size_t arg = 0xabcd;
const char* chk = "uz:43981 oz:125715 xz:abcd Xz:ABCD";
- sprintf_s(fmt, sizeof(fmt), "uz:%" PRIuz " oz:%" PRIoz " xz:%" PRIxz " Xz:%" PRIXz "", arg,
- arg, arg, arg);
+ (void)sprintf_s(fmt, sizeof(fmt), "uz:%" PRIuz " oz:%" PRIoz " xz:%" PRIxz " Xz:%" PRIXz "",
+ arg, arg, arg, arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed size_t test: got [%s] instead of [%s]\n", __func__, fmt,
- chk);
+ (void)fprintf(stderr, "%s failed size_t test: got [%s] instead of [%s]\n", __func__,
+ fmt, chk);
errors++;
}
}
@@ -32,12 +32,13 @@ int TestFormatSpecifiers(int argc, char* argv[])
INT8 arg = -16;
const char* chk = "d8:-16 x8:f0 X8:F0";
- sprintf_s(fmt, sizeof(fmt), "d8:%" PRId8 " x8:%" PRIx8 " X8:%" PRIX8 "", arg, (UINT8)arg,
- (UINT8)arg);
+ (void)sprintf_s(fmt, sizeof(fmt), "d8:%" PRId8 " x8:%" PRIx8 " X8:%" PRIX8 "", arg,
+ (UINT8)arg, (UINT8)arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed INT8 test: got [%s] instead of [%s]\n", __func__, fmt, chk);
+ (void)fprintf(stderr, "%s failed INT8 test: got [%s] instead of [%s]\n", __func__, fmt,
+ chk);
errors++;
}
}
@@ -47,12 +48,14 @@ int TestFormatSpecifiers(int argc, char* argv[])
UINT8 arg = 0xFE;
const char* chk = "u8:254 o8:376 x8:fe X8:FE";
- sprintf_s(fmt, sizeof(fmt), "u8:%" PRIu8 " o8:%" PRIo8 " x8:%" PRIx8 " X8:%" PRIX8 "", arg,
- arg, arg, arg);
+ (void)(void)sprintf_s(fmt, sizeof(fmt),
+ "u8:%" PRIu8 " o8:%" PRIo8 " x8:%" PRIx8 " X8:%" PRIX8 "", arg, arg,
+ arg, arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed UINT8 test: got [%s] instead of [%s]\n", __func__, fmt, chk);
+ (void)fprintf(stderr, "%s failed UINT8 test: got [%s] instead of [%s]\n", __func__, fmt,
+ chk);
errors++;
}
}
@@ -62,12 +65,13 @@ int TestFormatSpecifiers(int argc, char* argv[])
INT16 arg = -16;
const char* chk = "d16:-16 x16:fff0 X16:FFF0";
- sprintf_s(fmt, sizeof(fmt), "d16:%" PRId16 " x16:%" PRIx16 " X16:%" PRIX16 "", arg,
- (UINT16)arg, (UINT16)arg);
+ (void)sprintf_s(fmt, sizeof(fmt), "d16:%" PRId16 " x16:%" PRIx16 " X16:%" PRIX16 "", arg,
+ (UINT16)arg, (UINT16)arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed INT16 test: got [%s] instead of [%s]\n", __func__, fmt, chk);
+ (void)fprintf(stderr, "%s failed INT16 test: got [%s] instead of [%s]\n", __func__, fmt,
+ chk);
errors++;
}
}
@@ -77,14 +81,14 @@ int TestFormatSpecifiers(int argc, char* argv[])
UINT16 arg = 0xFFFE;
const char* chk = "u16:65534 o16:177776 x16:fffe X16:FFFE";
- sprintf_s(fmt, sizeof(fmt),
- "u16:%" PRIu16 " o16:%" PRIo16 " x16:%" PRIx16 " X16:%" PRIX16 "", arg, arg, arg,
- arg);
+ (void)sprintf_s(fmt, sizeof(fmt),
+ "u16:%" PRIu16 " o16:%" PRIo16 " x16:%" PRIx16 " X16:%" PRIX16 "", arg, arg,
+ arg, arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed UINT16 test: got [%s] instead of [%s]\n", __func__, fmt,
- chk);
+ (void)fprintf(stderr, "%s failed UINT16 test: got [%s] instead of [%s]\n", __func__,
+ fmt, chk);
errors++;
}
}
@@ -94,12 +98,13 @@ int TestFormatSpecifiers(int argc, char* argv[])
INT32 arg = -16;
const char* chk = "d32:-16 x32:fffffff0 X32:FFFFFFF0";
- sprintf_s(fmt, sizeof(fmt), "d32:%" PRId32 " x32:%" PRIx32 " X32:%" PRIX32 "", arg,
- (UINT32)arg, (UINT32)arg);
+ (void)sprintf_s(fmt, sizeof(fmt), "d32:%" PRId32 " x32:%" PRIx32 " X32:%" PRIX32 "", arg,
+ (UINT32)arg, (UINT32)arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed INT32 test: got [%s] instead of [%s]\n", __func__, fmt, chk);
+ (void)fprintf(stderr, "%s failed INT32 test: got [%s] instead of [%s]\n", __func__, fmt,
+ chk);
errors++;
}
}
@@ -109,14 +114,14 @@ int TestFormatSpecifiers(int argc, char* argv[])
UINT32 arg = 0xFFFFFFFE;
const char* chk = "u32:4294967294 o32:37777777776 x32:fffffffe X32:FFFFFFFE";
- sprintf_s(fmt, sizeof(fmt),
- "u32:%" PRIu32 " o32:%" PRIo32 " x32:%" PRIx32 " X32:%" PRIX32 "", arg, arg, arg,
- arg);
+ (void)sprintf_s(fmt, sizeof(fmt),
+ "u32:%" PRIu32 " o32:%" PRIo32 " x32:%" PRIx32 " X32:%" PRIX32 "", arg, arg,
+ arg, arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed UINT16 test: got [%s] instead of [%s]\n", __func__, fmt,
- chk);
+ (void)fprintf(stderr, "%s failed UINT16 test: got [%s] instead of [%s]\n", __func__,
+ fmt, chk);
errors++;
}
}
@@ -126,12 +131,13 @@ int TestFormatSpecifiers(int argc, char* argv[])
INT64 arg = -16;
const char* chk = "d64:-16 x64:fffffffffffffff0 X64:FFFFFFFFFFFFFFF0";
- sprintf_s(fmt, sizeof(fmt), "d64:%" PRId64 " x64:%" PRIx64 " X64:%" PRIX64 "", arg,
- (UINT64)arg, (UINT64)arg);
+ (void)sprintf_s(fmt, sizeof(fmt), "d64:%" PRId64 " x64:%" PRIx64 " X64:%" PRIX64 "", arg,
+ (UINT64)arg, (UINT64)arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed INT64 test: got [%s] instead of [%s]\n", __func__, fmt, chk);
+ (void)fprintf(stderr, "%s failed INT64 test: got [%s] instead of [%s]\n", __func__, fmt,
+ chk);
errors++;
}
}
@@ -142,21 +148,21 @@ int TestFormatSpecifiers(int argc, char* argv[])
const char* chk = "u64:18446744073709551614 o64:1777777777777777777776 "
"x64:fffffffffffffffe X64:FFFFFFFFFFFFFFFE";
- sprintf_s(fmt, sizeof(fmt),
- "u64:%" PRIu64 " o64:%" PRIo64 " x64:%016" PRIx64 " X64:%016" PRIX64 "", arg, arg,
- arg, arg);
+ (void)sprintf_s(fmt, sizeof(fmt),
+ "u64:%" PRIu64 " o64:%" PRIo64 " x64:%016" PRIx64 " X64:%016" PRIX64 "",
+ arg, arg, arg, arg);
if (strcmp(fmt, chk))
{
- fprintf(stderr, "%s failed UINT64 test: got [%s] instead of [%s]\n", __func__, fmt,
- chk);
+ (void)fprintf(stderr, "%s failed UINT64 test: got [%s] instead of [%s]\n", __func__,
+ fmt, chk);
errors++;
}
}
if (errors)
{
- fprintf(stderr, "%s produced %u errors\n", __func__, errors);
+ (void)fprintf(stderr, "%s produced %u errors\n", __func__, errors);
return -1;
}
diff --git a/winpr/libwinpr/crt/test/TestTypes.c b/winpr/libwinpr/crt/test/TestTypes.c
index 734da0631..906032638 100644
--- a/winpr/libwinpr/crt/test/TestTypes.c
+++ b/winpr/libwinpr/crt/test/TestTypes.c
@@ -43,12 +43,12 @@
#define EXPECTED_SIZEOF_LONG_PTR sizeof(void*)
#define EXPECTED_SIZEOF_ULONG_PTR sizeof(void*)
-#define TEST_SIZEOF_TYPE(_name) \
- if (sizeof(_name) != EXPECTED_SIZEOF_##_name) \
- { \
- fprintf(stderr, "sizeof(%s) mismatch: Actual: %" PRIuz ", Expected: %" PRIuz "\n", #_name, \
- sizeof(_name), (size_t)EXPECTED_SIZEOF_##_name); \
- status = -1; \
+#define TEST_SIZEOF_TYPE(_name) \
+ if (sizeof(_name) != EXPECTED_SIZEOF_##_name) \
+ { \
+ (void)fprintf(stderr, "sizeof(%s) mismatch: Actual: %" PRIuz ", Expected: %" PRIuz "\n", \
+ #_name, sizeof(_name), (size_t)EXPECTED_SIZEOF_##_name); \
+ status = -1; \
}
int TestTypes(int argc, char* argv[])
diff --git a/winpr/libwinpr/crt/test/TestUnicodeConversion.c b/winpr/libwinpr/crt/test/TestUnicodeConversion.c
index eb0acb7c9..54a35e793 100644
--- a/winpr/libwinpr/crt/test/TestUnicodeConversion.c
+++ b/winpr/libwinpr/crt/test/TestUnicodeConversion.c
@@ -35,10 +35,10 @@ static const testcase_t unit_testcases[] = {
static void create_prefix(char* prefix, size_t prefixlen, size_t buffersize, SSIZE_T rc,
SSIZE_T inputlen, const testcase_t* test, const char* fkt, size_t line)
{
- _snprintf(prefix, prefixlen,
- "[%s:%" PRIuz "] '%s' [utf8: %" PRIuz ", utf16: %" PRIuz "] buffersize: %" PRIuz
- ", rc: %" PRIdz ", inputlen: %" PRIdz ":: ",
- fkt, line, test->utf8, test->utf8len, test->utf16len, buffersize, rc, inputlen);
+ (void)_snprintf(prefix, prefixlen,
+ "[%s:%" PRIuz "] '%s' [utf8: %" PRIuz ", utf16: %" PRIuz "] buffersize: %" PRIuz
+ ", rc: %" PRIdz ", inputlen: %" PRIdz ":: ",
+ fkt, line, test->utf8, test->utf8len, test->utf16len, buffersize, rc, inputlen);
}
static BOOL check_short_buffer(const char* prefix, int rc, size_t buffersize,
@@ -53,20 +53,20 @@ static BOOL check_short_buffer(const char* prefix, int rc, size_t buffersize,
if (buffersize > len)
{
- fprintf(stderr,
- "%s length does not match buffersize: %" PRId32 " != %" PRIuz
- ",but is large enough to hold result\n",
- prefix, rc, buffersize);
+ (void)fprintf(stderr,
+ "%s length does not match buffersize: %" PRId32 " != %" PRIuz
+ ",but is large enough to hold result\n",
+ prefix, rc, buffersize);
return FALSE;
}
const DWORD err = GetLastError();
if (err != ERROR_INSUFFICIENT_BUFFER)
{
- fprintf(stderr,
- "%s length does not match buffersize: %" PRId32 " != %" PRIuz
- ", unexpected GetLastError() 0x08%" PRIx32 "\n",
- prefix, rc, buffersize, err);
+ (void)fprintf(stderr,
+ "%s length does not match buffersize: %" PRId32 " != %" PRIuz
+ ", unexpected GetLastError() 0x08%" PRIx32 "\n",
+ prefix, rc, buffersize, err);
return FALSE;
}
else
@@ -89,8 +89,9 @@ static BOOL compare_utf16_int(const WCHAR* what, size_t buffersize, SSIZE_T rc,
{
if ((rc < 0) || ((size_t)rc != welen))
{
- fprintf(stderr, "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
- prefix, rc, welen);
+ (void)fprintf(stderr,
+ "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
+ prefix, rc, welen);
return FALSE;
}
}
@@ -105,8 +106,8 @@ static BOOL compare_utf16_int(const WCHAR* what, size_t buffersize, SSIZE_T rc,
const size_t wlen = _wcsnlen(what, buffersize);
if ((rc < 0) || (wlen > (size_t)rc))
{
- fprintf(stderr, "%s length does not match wcslen: %" PRIdz " < %" PRIuz "\n", prefix,
- rc, wlen);
+ (void)fprintf(stderr, "%s length does not match wcslen: %" PRIdz " < %" PRIuz "\n",
+ prefix, rc, wlen);
return FALSE;
}
}
@@ -115,8 +116,8 @@ static BOOL compare_utf16_int(const WCHAR* what, size_t buffersize, SSIZE_T rc,
{
if (memcmp(test->utf16, what, rc * sizeof(WCHAR)) != 0)
{
- fprintf(stderr, "%s contents does not match expectations: TODO '%s' != '%s'\n", prefix,
- test->utf8, test->utf8);
+ (void)fprintf(stderr, "%s contents does not match expectations: TODO '%s' != '%s'\n",
+ prefix, test->utf8, test->utf8);
return FALSE;
}
}
@@ -142,8 +143,9 @@ static BOOL compare_utf8_int(const char* what, size_t buffersize, SSIZE_T rc, SS
{
if ((rc < 0) || ((size_t)rc != slen))
{
- fprintf(stderr, "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
- prefix, rc, slen);
+ (void)fprintf(stderr,
+ "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
+ prefix, rc, slen);
return FALSE;
}
}
@@ -158,8 +160,8 @@ static BOOL compare_utf8_int(const char* what, size_t buffersize, SSIZE_T rc, SS
const size_t wlen = strnlen(what, buffersize);
if (wlen != (size_t)rc)
{
- fprintf(stderr, "%s length does not match strnlen: %" PRIdz " != %" PRIuz "\n", prefix,
- rc, wlen);
+ (void)fprintf(stderr, "%s length does not match strnlen: %" PRIdz " != %" PRIuz "\n",
+ prefix, rc, wlen);
return FALSE;
}
}
@@ -168,8 +170,8 @@ static BOOL compare_utf8_int(const char* what, size_t buffersize, SSIZE_T rc, SS
{
if (memcmp(test->utf8, what, rc) != 0)
{
- fprintf(stderr, "%s contents does not match expectations: '%s' != '%s'\n", prefix, what,
- test->utf8);
+ (void)fprintf(stderr, "%s contents does not match expectations: '%s' != '%s'\n", prefix,
+ what, test->utf8);
return FALSE;
}
}
@@ -191,8 +193,9 @@ static BOOL test_convert_to_utf16(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, -1, test, __func__, __LINE__);
- fprintf(stderr, "%s ConvertUtf8ToWChar(%s, NULL, 0) expected %" PRIuz ", got %" PRIdz "\n",
- prefix, test->utf8, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s ConvertUtf8ToWChar(%s, NULL, 0) expected %" PRIuz ", got %" PRIdz "\n",
+ prefix, test->utf8, wlen, rc2);
return FALSE;
}
for (size_t x = 0; x < max; x++)
@@ -218,10 +221,10 @@ static BOOL test_convert_to_utf16_n(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, test->utf8len, test, __func__, __LINE__);
- fprintf(stderr,
- "%s ConvertUtf8NToWChar(%s, %" PRIuz ", NULL, 0) expected %" PRIuz ", got %" PRIdz
- "\n",
- prefix, test->utf8, test->utf8len, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s ConvertUtf8NToWChar(%s, %" PRIuz ", NULL, 0) expected %" PRIuz
+ ", got %" PRIdz "\n",
+ prefix, test->utf8, test->utf8len, wlen, rc2);
return FALSE;
}
@@ -254,8 +257,9 @@ static BOOL test_convert_to_utf8(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, -1, test, __func__, __LINE__);
- fprintf(stderr, "%s ConvertWCharToUtf8(%s, NULL, 0) expected %" PRIuz ", got %" PRIdz "\n",
- prefix, test->utf8, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s ConvertWCharToUtf8(%s, NULL, 0) expected %" PRIuz ", got %" PRIdz "\n",
+ prefix, test->utf8, wlen, rc2);
return FALSE;
}
@@ -282,10 +286,10 @@ static BOOL test_convert_to_utf8_n(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, test->utf16len, test, __func__, __LINE__);
- fprintf(stderr,
- "%s ConvertWCharNToUtf8(%s, %" PRIuz ", NULL, 0) expected %" PRIuz ", got %" PRIdz
- "\n",
- prefix, test->utf8, test->utf16len, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s ConvertWCharNToUtf8(%s, %" PRIuz ", NULL, 0) expected %" PRIuz
+ ", got %" PRIdz "\n",
+ prefix, test->utf8, test->utf16len, wlen, rc2);
return FALSE;
}
@@ -351,14 +355,14 @@ static BOOL compare_win_utf16_int(const WCHAR* what, size_t buffersize, int rc,
{
if ((inputlen >= 0) && (rc > buffersize))
{
- fprintf(stderr, "%s length does not match expectation: %d > %" PRIuz "\n", prefix, rc,
- buffersize);
+ (void)fprintf(stderr, "%s length does not match expectation: %d > %" PRIuz "\n", prefix,
+ rc, buffersize);
return FALSE;
}
else if ((inputlen < 0) && (rc != welen))
{
- fprintf(stderr, "%s length does not match expectation: %d != %" PRIuz "\n", prefix, rc,
- welen);
+ (void)fprintf(stderr, "%s length does not match expectation: %d != %" PRIuz "\n",
+ prefix, rc, welen);
return FALSE;
}
}
@@ -375,13 +379,14 @@ static BOOL compare_win_utf16_int(const WCHAR* what, size_t buffersize, int rc,
wlen++;
if ((inputlen >= 0) && (buffersize < rc))
{
- fprintf(stderr, "%s length does not match wcslen: %d > %" PRIuz "\n", prefix, rc,
- buffersize);
+ (void)fprintf(stderr, "%s length does not match wcslen: %d > %" PRIuz "\n", prefix, rc,
+ buffersize);
return FALSE;
}
else if ((inputlen < 0) && (welen > rc))
{
- fprintf(stderr, "%s length does not match wcslen: %d < %" PRIuz "\n", prefix, rc, wlen);
+ (void)fprintf(stderr, "%s length does not match wcslen: %d < %" PRIuz "\n", prefix, rc,
+ wlen);
return FALSE;
}
}
@@ -389,8 +394,8 @@ static BOOL compare_win_utf16_int(const WCHAR* what, size_t buffersize, int rc,
const size_t cmp_size = MIN(rc, test->utf16len) * sizeof(WCHAR);
if (memcmp(test->utf16, what, cmp_size) != 0)
{
- fprintf(stderr, "%s contents does not match expectations: TODO '%s' != '%s'\n", prefix,
- test->utf8, test->utf8);
+ (void)fprintf(stderr, "%s contents does not match expectations: TODO '%s' != '%s'\n",
+ prefix, test->utf8, test->utf8);
return FALSE;
}
@@ -422,14 +427,15 @@ static BOOL compare_win_utf8_int(const char* what, size_t buffersize, SSIZE_T rc
{
if ((inputlen >= 0) && (rc > buffersize))
{
- fprintf(stderr, "%s length does not match expectation: %" PRIdz " > %" PRIuz "\n",
- prefix, rc, buffersize);
+ (void)fprintf(stderr, "%s length does not match expectation: %" PRIdz " > %" PRIuz "\n",
+ prefix, rc, buffersize);
return FALSE;
}
else if ((inputlen < 0) && (rc != slen))
{
- fprintf(stderr, "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
- prefix, rc, slen);
+ (void)fprintf(stderr,
+ "%s length does not match expectation: %" PRIdz " != %" PRIuz "\n",
+ prefix, rc, slen);
return FALSE;
}
}
@@ -447,8 +453,8 @@ static BOOL compare_win_utf8_int(const char* what, size_t buffersize, SSIZE_T rc
if (wlen > rc)
{
- fprintf(stderr, "%s length does not match wcslen: %" PRIdz " < %" PRIuz "\n", prefix,
- rc, wlen);
+ (void)fprintf(stderr, "%s length does not match wcslen: %" PRIdz " < %" PRIuz "\n",
+ prefix, rc, wlen);
return FALSE;
}
}
@@ -456,8 +462,8 @@ static BOOL compare_win_utf8_int(const char* what, size_t buffersize, SSIZE_T rc
const size_t cmp_size = MIN(test->utf8len, rc);
if (memcmp(test->utf8, what, cmp_size) != 0)
{
- fprintf(stderr, "%s contents does not match expectations: '%s' != '%s'\n", prefix, what,
- test->utf8);
+ (void)fprintf(stderr, "%s contents does not match expectations: '%s' != '%s'\n", prefix,
+ what, test->utf8);
return FALSE;
}
printf("%s success\n", prefix);
@@ -479,10 +485,10 @@ static BOOL test_win_convert_to_utf16(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, -1, test, __func__, __LINE__);
- fprintf(stderr,
- "%s MultiByteToWideChar(CP_UTF8, 0, %s, [-1], NULL, 0) expected %" PRIuz
- ", got %d\n",
- prefix, test->utf8, wlen + 1, rc2);
+ (void)fprintf(stderr,
+ "%s MultiByteToWideChar(CP_UTF8, 0, %s, [-1], NULL, 0) expected %" PRIuz
+ ", got %d\n",
+ prefix, test->utf8, wlen + 1, rc2);
return FALSE;
}
for (size_t x = 0; x < max; x++)
@@ -512,10 +518,10 @@ static BOOL test_win_convert_to_utf16_n(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, test->utf8len, test, __func__, __LINE__);
- fprintf(stderr,
- "%s MultiByteToWideChar(CP_UTF8, 0, %s, %" PRIuz ", NULL, 0) expected %" PRIuz
- ", got %d\n",
- prefix, test->utf8, test->utf8len, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s MultiByteToWideChar(CP_UTF8, 0, %s, %" PRIuz ", NULL, 0) expected %" PRIuz
+ ", got %d\n",
+ prefix, test->utf8, test->utf8len, wlen, rc2);
return FALSE;
}
@@ -552,10 +558,11 @@ static BOOL test_win_convert_to_utf8(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, -1, test, __func__, __LINE__);
- fprintf(stderr,
- "%s WideCharToMultiByte(CP_UTF8, 0, %s, -1, NULL, 0, NULL, NULL) expected %" PRIuz
- ", got %d\n",
- prefix, test->utf8, wlen, rc2);
+ (void)fprintf(
+ stderr,
+ "%s WideCharToMultiByte(CP_UTF8, 0, %s, -1, NULL, 0, NULL, NULL) expected %" PRIuz
+ ", got %d\n",
+ prefix, test->utf8, wlen, rc2);
return FALSE;
}
@@ -587,10 +594,10 @@ static BOOL test_win_convert_to_utf8_n(const testcase_t* test)
{
char prefix[8192] = { 0 };
create_prefix(prefix, ARRAYSIZE(prefix), 0, rc2, test->utf16len, test, __func__, __LINE__);
- fprintf(stderr,
- "%s WideCharToMultiByte(CP_UTF8, 0, %s, %" PRIuz
- ", NULL, 0, NULL, NULL) expected %" PRIuz ", got %d\n",
- prefix, test->utf8, test->utf16len, wlen, rc2);
+ (void)fprintf(stderr,
+ "%s WideCharToMultiByte(CP_UTF8, 0, %s, %" PRIuz
+ ", NULL, 0, NULL, NULL) expected %" PRIuz ", got %d\n",
+ prefix, test->utf8, test->utf16len, wlen, rc2);
return FALSE;
}
@@ -959,23 +966,23 @@ static BOOL test_ConvertFromUnicode_wrapper(void)
i = ConvertFromUnicode(CP_UTF8, 0, (const WCHAR*)src1, 16, &dst, 0, NULL, NULL);
if (i != 16)
{
- fprintf(stderr, "ConvertFromUnicode failure A1: unexpectedly returned %d instead of 16\n",
- i);
+ (void)fprintf(stderr,
+ "ConvertFromUnicode failure A1: unexpectedly returned %d instead of 16\n", i);
goto fail;
}
if (dst == NULL)
{
- fprintf(stderr, "ConvertFromUnicode failure A2: destination ist NULL\n");
+ (void)fprintf(stderr, "ConvertFromUnicode failure A2: destination ist NULL\n");
goto fail;
}
if ((i = strlen(dst)) != 16)
{
- fprintf(stderr, "ConvertFromUnicode failure A3: dst length is %d instead of 16\n", i);
+ (void)fprintf(stderr, "ConvertFromUnicode failure A3: dst length is %d instead of 16\n", i);
goto fail;
}
if (strcmp(dst, cmp0))
{
- fprintf(stderr, "ConvertFromUnicode failure A4: data mismatch\n");
+ (void)fprintf(stderr, "ConvertFromUnicode failure A4: data mismatch\n");
goto fail;
}
printf("Output UTF8 String:\n");
@@ -992,23 +999,23 @@ static BOOL test_ConvertFromUnicode_wrapper(void)
i = ConvertFromUnicode(CP_UTF8, 0, (const WCHAR*)src2, -1, &dst, 0, NULL, NULL);
if (i != 17)
{
- fprintf(stderr, "ConvertFromUnicode failure B1: unexpectedly returned %d instead of 17\n",
- i);
+ (void)fprintf(stderr,
+ "ConvertFromUnicode failure B1: unexpectedly returned %d instead of 17\n", i);
goto fail;
}
if (dst == NULL)
{
- fprintf(stderr, "ConvertFromUnicode failure B2: destination ist NULL\n");
+ (void)fprintf(stderr, "ConvertFromUnicode failure B2: destination ist NULL\n");
goto fail;
}
if ((i = strlen(dst)) != 16)
{
- fprintf(stderr, "ConvertFromUnicode failure B3: dst length is %d instead of 16\n", i);
+ (void)fprintf(stderr, "ConvertFromUnicode failure B3: dst length is %d instead of 16\n", i);
goto fail;
}
if (strcmp(dst, cmp0))
{
- fprintf(stderr, "ConvertFromUnicode failure B: data mismatch\n");
+ (void)fprintf(stderr, "ConvertFromUnicode failure B: data mismatch\n");
goto fail;
}
printf("Output UTF8 String:\n");
@@ -1074,24 +1081,25 @@ static BOOL test_ConvertToUnicode_wrapper(void)
ii = ConvertToUnicode(CP_UTF8, 0, src1, 16, &dst, 0);
if (ii != 16)
{
- fprintf(stderr, "ConvertToUnicode failure A1: unexpectedly returned %d instead of 16\n",
- ii);
+ (void)fprintf(stderr,
+ "ConvertToUnicode failure A1: unexpectedly returned %d instead of 16\n", ii);
goto fail;
}
i = (size_t)ii;
if (dst == NULL)
{
- fprintf(stderr, "ConvertToUnicode failure A2: destination ist NULL\n");
+ (void)fprintf(stderr, "ConvertToUnicode failure A2: destination ist NULL\n");
goto fail;
}
if ((i = _wcslen(dst)) != 16)
{
- fprintf(stderr, "ConvertToUnicode failure A3: dst length is %" PRIuz " instead of 16\n", i);
+ (void)fprintf(stderr,
+ "ConvertToUnicode failure A3: dst length is %" PRIuz " instead of 16\n", i);
goto fail;
}
if (_wcscmp(dst, (const WCHAR*)cmp0))
{
- fprintf(stderr, "ConvertToUnicode failure A4: data mismatch\n");
+ (void)fprintf(stderr, "ConvertToUnicode failure A4: data mismatch\n");
goto fail;
}
printf("Output UTF16 String:\n");
@@ -1108,23 +1116,25 @@ static BOOL test_ConvertToUnicode_wrapper(void)
i = ConvertToUnicode(CP_UTF8, 0, src2, -1, &dst, 0);
if (i != 17)
{
- fprintf(stderr,
- "ConvertToUnicode failure B1: unexpectedly returned %" PRIuz " instead of 17\n", i);
+ (void)fprintf(
+ stderr, "ConvertToUnicode failure B1: unexpectedly returned %" PRIuz " instead of 17\n",
+ i);
goto fail;
}
if (dst == NULL)
{
- fprintf(stderr, "ConvertToUnicode failure B2: destination ist NULL\n");
+ (void)fprintf(stderr, "ConvertToUnicode failure B2: destination ist NULL\n");
goto fail;
}
if ((i = _wcslen(dst)) != 16)
{
- fprintf(stderr, "ConvertToUnicode failure B3: dst length is %" PRIuz " instead of 16\n", i);
+ (void)fprintf(stderr,
+ "ConvertToUnicode failure B3: dst length is %" PRIuz " instead of 16\n", i);
goto fail;
}
if (_wcscmp(dst, (const WCHAR*)cmp0))
{
- fprintf(stderr, "ConvertToUnicode failure B: data mismatch\n");
+ (void)fprintf(stderr, "ConvertToUnicode failure B: data mismatch\n");
goto fail;
}
printf("Output UTF16 String:\n");
diff --git a/winpr/libwinpr/crypto/test/TestCryptoCipher.c b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
index 518b443d0..560055b8c 100644
--- a/winpr/libwinpr/crypto/test/TestCryptoCipher.c
+++ b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
@@ -22,7 +22,7 @@ static BOOL test_crypto_cipher_aes_128_cbc(void)
if (!(ctx = winpr_Cipher_New(WINPR_CIPHER_AES_128_CBC, WINPR_ENCRYPT, key, iv)))
{
- fprintf(stderr, "%s: winpr_Cipher_New (encrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_New (encrypt) failed\n", __func__);
return FALSE;
}
@@ -35,22 +35,22 @@ static BOOL test_crypto_cipher_aes_128_cbc(void)
if (!winpr_Cipher_Update(ctx, ibuf, ilen, obuf, &olen))
{
- fprintf(stderr, "%s: winpr_Cipher_New (encrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_New (encrypt) failed\n", __func__);
goto out;
}
xlen += olen;
if (!winpr_Cipher_Final(ctx, obuf + xlen, &olen))
{
- fprintf(stderr, "%s: winpr_Cipher_Final (encrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_Final (encrypt) failed\n", __func__);
goto out;
}
xlen += olen;
if (xlen != ilen)
{
- fprintf(stderr, "%s: error, xlen (%" PRIuz ") != ilen (%" PRIuz ") (encrypt)\n", __func__,
- xlen, ilen);
+ (void)fprintf(stderr, "%s: error, xlen (%" PRIuz ") != ilen (%" PRIuz ") (encrypt)\n",
+ __func__, xlen, ilen);
goto out;
}
@@ -60,7 +60,7 @@ static BOOL test_crypto_cipher_aes_128_cbc(void)
if (!(ctx = winpr_Cipher_New(WINPR_CIPHER_AES_128_CBC, WINPR_DECRYPT, key, iv)))
{
- fprintf(stderr, "%s: winpr_Cipher_New (decrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_New (decrypt) failed\n", __func__);
return FALSE;
}
@@ -74,28 +74,28 @@ static BOOL test_crypto_cipher_aes_128_cbc(void)
if (!winpr_Cipher_Update(ctx, ibuf, ilen, obuf, &olen))
{
- fprintf(stderr, "%s: winpr_Cipher_New (decrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_New (decrypt) failed\n", __func__);
goto out;
}
xlen += olen;
if (!winpr_Cipher_Final(ctx, obuf + xlen, &olen))
{
- fprintf(stderr, "%s: winpr_Cipher_Final (decrypt) failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Cipher_Final (decrypt) failed\n", __func__);
goto out;
}
xlen += olen;
if (xlen != ilen)
{
- fprintf(stderr, "%s: error, xlen (%" PRIuz ") != ilen (%" PRIuz ") (decrypt)\n", __func__,
- xlen, ilen);
+ (void)fprintf(stderr, "%s: error, xlen (%" PRIuz ") != ilen (%" PRIuz ") (decrypt)\n",
+ __func__, xlen, ilen);
goto out;
}
if (strcmp((const char*)obuf, plaintext))
{
- fprintf(stderr, "%s: error, decrypted data does not match plaintext\n", __func__);
+ (void)fprintf(stderr, "%s: error, decrypted data does not match plaintext\n", __func__);
goto out;
}
@@ -121,21 +121,22 @@ static BOOL test_crypto_cipher_rc4(void)
if (!(text = (BYTE*)calloc(1, len)))
{
- fprintf(stderr, "%s: failed to allocate text buffer (len=%" PRIuz ")\n", __func__, len);
+ (void)fprintf(stderr, "%s: failed to allocate text buffer (len=%" PRIuz ")\n", __func__,
+ len);
goto out;
}
if ((ctx = winpr_RC4_New(TEST_RC4_KEY,
strnlen((const char*)TEST_RC4_KEY, sizeof(TEST_RC4_KEY)))) == NULL)
{
- fprintf(stderr, "%s: winpr_RC4_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_RC4_New failed\n", __func__);
goto out;
}
rc = winpr_RC4_Update(ctx, len, (const BYTE*)TEST_RC4_PLAINTEXT, text);
winpr_RC4_Free(ctx);
if (!rc)
{
- fprintf(stderr, "%s: winpr_RC4_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_RC4_Update failed\n", __func__);
goto out;
}
@@ -147,8 +148,8 @@ static BOOL test_crypto_cipher_rc4(void)
actual = winpr_BinToHexString(text, len, FALSE);
expected = winpr_BinToHexString(TEST_RC4_CIPHERTEXT, len, FALSE);
- fprintf(stderr, "%s: unexpected RC4 ciphertext: Actual: %s Expected: %s\n", __func__,
- actual, expected);
+ (void)fprintf(stderr, "%s: unexpected RC4 ciphertext: Actual: %s Expected: %s\n", __func__,
+ actual, expected);
free(actual);
free(expected);
@@ -198,9 +199,10 @@ static BOOL test_crypto_cipher_key(void)
aivstr = winpr_BinToHexString(iv, 16, 0);
eivstr = winpr_BinToHexString(TEST_CIPHER_IV, 16, 0);
- fprintf(stderr, "Unexpected EVP_BytesToKey Key: Actual: %s, Expected: %s\n", akstr, ekstr);
- fprintf(stderr, "Unexpected EVP_BytesToKey IV : Actual: %s, Expected: %s\n", aivstr,
- eivstr);
+ (void)fprintf(stderr, "Unexpected EVP_BytesToKey Key: Actual: %s, Expected: %s\n", akstr,
+ ekstr);
+ (void)fprintf(stderr, "Unexpected EVP_BytesToKey IV : Actual: %s, Expected: %s\n", aivstr,
+ eivstr);
free(akstr);
free(ekstr);
diff --git a/winpr/libwinpr/crypto/test/TestCryptoHash.c b/winpr/libwinpr/crypto/test/TestCryptoHash.c
index 3057b9fa8..2d068855e 100644
--- a/winpr/libwinpr/crypto/test/TestCryptoHash.c
+++ b/winpr/libwinpr/crypto/test/TestCryptoHash.c
@@ -16,23 +16,23 @@ static BOOL test_crypto_hash_md5(void)
if (!(ctx = winpr_Digest_New()))
{
- fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
return FALSE;
}
if (!winpr_Digest_Init(ctx, WINPR_MD_MD5))
{
- fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
goto out;
}
if (!winpr_Digest_Update(ctx, (const BYTE*)TEST_MD5_DATA,
strnlen(TEST_MD5_DATA, sizeof(TEST_MD5_DATA))))
{
- fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
goto out;
}
if (!winpr_Digest_Final(ctx, hash, sizeof(hash)))
{
- fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
goto out;
}
if (memcmp(hash, TEST_MD5_HASH, WINPR_MD5_DIGEST_LENGTH) != 0)
@@ -43,7 +43,7 @@ static BOOL test_crypto_hash_md5(void)
actual = winpr_BinToHexString(hash, WINPR_MD5_DIGEST_LENGTH, FALSE);
expected = winpr_BinToHexString(TEST_MD5_HASH, WINPR_MD5_DIGEST_LENGTH, FALSE);
- fprintf(stderr, "unexpected MD5 hash: Actual: %s Expected: %s\n", actual, expected);
+ (void)fprintf(stderr, "unexpected MD5 hash: Actual: %s Expected: %s\n", actual, expected);
free(actual);
free(expected);
@@ -69,23 +69,23 @@ static BOOL test_crypto_hash_md4(void)
if (!(ctx = winpr_Digest_New()))
{
- fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
return FALSE;
}
if (!winpr_Digest_Init(ctx, WINPR_MD_MD4))
{
- fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
goto out;
}
if (!winpr_Digest_Update(ctx, (const BYTE*)TEST_MD4_DATA,
strnlen(TEST_MD4_DATA, sizeof(TEST_MD4_DATA))))
{
- fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
goto out;
}
if (!winpr_Digest_Final(ctx, hash, sizeof(hash)))
{
- fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
goto out;
}
if (memcmp(hash, TEST_MD4_HASH, WINPR_MD4_DIGEST_LENGTH) != 0)
@@ -96,7 +96,7 @@ static BOOL test_crypto_hash_md4(void)
actual = winpr_BinToHexString(hash, WINPR_MD4_DIGEST_LENGTH, FALSE);
expected = winpr_BinToHexString(TEST_MD4_HASH, WINPR_MD4_DIGEST_LENGTH, FALSE);
- fprintf(stderr, "unexpected MD4 hash: Actual: %s Expected: %s\n", actual, expected);
+ (void)fprintf(stderr, "unexpected MD4 hash: Actual: %s Expected: %s\n", actual, expected);
free(actual);
free(expected);
@@ -122,23 +122,23 @@ static BOOL test_crypto_hash_sha1(void)
if (!(ctx = winpr_Digest_New()))
{
- fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_New failed\n", __func__);
return FALSE;
}
if (!winpr_Digest_Init(ctx, WINPR_MD_SHA1))
{
- fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Init failed\n", __func__);
goto out;
}
if (!winpr_Digest_Update(ctx, (const BYTE*)TEST_SHA1_DATA,
strnlen(TEST_SHA1_DATA, sizeof(TEST_SHA1_DATA))))
{
- fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Update failed\n", __func__);
goto out;
}
if (!winpr_Digest_Final(ctx, hash, sizeof(hash)))
{
- fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_Digest_Final failed\n", __func__);
goto out;
}
@@ -150,7 +150,7 @@ static BOOL test_crypto_hash_sha1(void)
actual = winpr_BinToHexString(hash, WINPR_SHA1_DIGEST_LENGTH, FALSE);
expected = winpr_BinToHexString(TEST_SHA1_HASH, WINPR_SHA1_DIGEST_LENGTH, FALSE);
- fprintf(stderr, "unexpected SHA1 hash: Actual: %s Expected: %s\n", actual, expected);
+ (void)fprintf(stderr, "unexpected SHA1 hash: Actual: %s Expected: %s\n", actual, expected);
free(actual);
free(expected);
@@ -178,30 +178,30 @@ static BOOL test_crypto_hash_hmac_md5(void)
if (!(ctx = winpr_HMAC_New()))
{
- fprintf(stderr, "%s: winpr_HMAC_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_New failed\n", __func__);
return FALSE;
}
if (!winpr_HMAC_Init(ctx, WINPR_MD_MD5, TEST_HMAC_MD5_KEY, WINPR_MD5_DIGEST_LENGTH))
{
- fprintf(stderr, "%s: winpr_HMAC_Init failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Init failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Update(ctx, (const BYTE*)TEST_HMAC_MD5_DATA,
strnlen(TEST_HMAC_MD5_DATA, sizeof(TEST_HMAC_MD5_DATA))))
{
- fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Update(ctx, (const BYTE*)TEST_HMAC_MD5_DATA,
strnlen(TEST_HMAC_MD5_DATA, sizeof(TEST_HMAC_MD5_DATA))))
{
- fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Final(ctx, hash, sizeof(hash)))
{
- fprintf(stderr, "%s: winpr_HMAC_Final failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Final failed\n", __func__);
goto out;
}
@@ -213,7 +213,8 @@ static BOOL test_crypto_hash_hmac_md5(void)
actual = winpr_BinToHexString(hash, WINPR_MD5_DIGEST_LENGTH, FALSE);
expected = winpr_BinToHexString(TEST_HMAC_MD5_HASH, WINPR_MD5_DIGEST_LENGTH, FALSE);
- fprintf(stderr, "unexpected HMAC-MD5 hash: Actual: %s Expected: %s\n", actual, expected);
+ (void)fprintf(stderr, "unexpected HMAC-MD5 hash: Actual: %s Expected: %s\n", actual,
+ expected);
free(actual);
free(expected);
@@ -241,30 +242,30 @@ static BOOL test_crypto_hash_hmac_sha1(void)
if (!(ctx = winpr_HMAC_New()))
{
- fprintf(stderr, "%s: winpr_HMAC_New failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_New failed\n", __func__);
return FALSE;
}
if (!winpr_HMAC_Init(ctx, WINPR_MD_SHA1, TEST_HMAC_SHA1_KEY, WINPR_SHA1_DIGEST_LENGTH))
{
- fprintf(stderr, "%s: winpr_HMAC_Init failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Init failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Update(ctx, (const BYTE*)TEST_HMAC_SHA1_DATA,
strnlen(TEST_HMAC_SHA1_DATA, sizeof(TEST_HMAC_SHA1_DATA))))
{
- fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Update(ctx, (const BYTE*)TEST_HMAC_SHA1_DATA,
strnlen(TEST_HMAC_SHA1_DATA, sizeof(TEST_HMAC_SHA1_DATA))))
{
- fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Update failed\n", __func__);
goto out;
}
if (!winpr_HMAC_Final(ctx, hash, sizeof(hash)))
{
- fprintf(stderr, "%s: winpr_HMAC_Final failed\n", __func__);
+ (void)fprintf(stderr, "%s: winpr_HMAC_Final failed\n", __func__);
goto out;
}
@@ -276,7 +277,8 @@ static BOOL test_crypto_hash_hmac_sha1(void)
actual = winpr_BinToHexString(hash, WINPR_SHA1_DIGEST_LENGTH, FALSE);
expected = winpr_BinToHexString(TEST_HMAC_SHA1_HASH, WINPR_SHA1_DIGEST_LENGTH, FALSE);
- fprintf(stderr, "unexpected HMAC-SHA1 hash: Actual: %s Expected: %s\n", actual, expected);
+ (void)fprintf(stderr, "unexpected HMAC-SHA1 hash: Actual: %s Expected: %s\n", actual,
+ expected);
free(actual);
free(expected);
diff --git a/winpr/libwinpr/dsparse/dsparse.c b/winpr/libwinpr/dsparse/dsparse.c
index e1e41321f..fd8bbfb22 100644
--- a/winpr/libwinpr/dsparse/dsparse.c
+++ b/winpr/libwinpr/dsparse/dsparse.c
@@ -134,7 +134,7 @@ DWORD DsMakeSpnA(LPCSTR ServiceClass, LPCSTR ServiceName, LPCSTR InstanceName, U
return ERROR_BUFFER_OVERFLOW;
}
- sprintf_s(pszSpn, *pcSpnLength, "%s/%s", ServiceClass, ServiceName);
+ (void)sprintf_s(pszSpn, *pcSpnLength, "%s/%s", ServiceClass, ServiceName);
return ERROR_SUCCESS;
}
diff --git a/winpr/libwinpr/environment/environment.c b/winpr/libwinpr/environment/environment.c
index c6df6bd2d..191027c48 100644
--- a/winpr/libwinpr/environment/environment.c
+++ b/winpr/libwinpr/environment/environment.c
@@ -563,7 +563,7 @@ BOOL SetEnvironmentVariableEBA(LPSTR* envBlock, LPCSTR lpName, LPCSTR lpValue)
if (!envstr)
return FALSE;
- sprintf_s(envstr, length, "%s=%s", lpName, lpValue);
+ (void)sprintf_s(envstr, length, "%s=%s", lpName, lpValue);
}
else
{
@@ -573,7 +573,7 @@ BOOL SetEnvironmentVariableEBA(LPSTR* envBlock, LPCSTR lpName, LPCSTR lpValue)
if (!envstr)
return FALSE;
- sprintf_s(envstr, length, "%s=", lpName);
+ (void)sprintf_s(envstr, length, "%s=", lpName);
}
envstr[length] = '\0';
diff --git a/winpr/libwinpr/file/file.c b/winpr/libwinpr/file/file.c
index a016beb13..07e7eb6f1 100644
--- a/winpr/libwinpr/file/file.c
+++ b/winpr/libwinpr/file/file.c
@@ -83,7 +83,7 @@ static BOOL FileCloseHandle(HANDLE handle)
/* Don't close stdin/stdout/stderr */
if (fileno(file->fp) > 2)
{
- fclose(file->fp);
+ (void)fclose(file->fp);
file->fp = NULL;
}
}
@@ -916,7 +916,7 @@ static HANDLE FileCreateFileA(LPCSTR lpFileName, DWORD dwDesiredAccess, DWORD dw
return INVALID_HANDLE_VALUE;
}
- setvbuf(fp, NULL, _IONBF, 0);
+ (void)setvbuf(fp, NULL, _IONBF, 0);
#ifdef __sun
lock.l_start = 0;
@@ -986,7 +986,7 @@ static WINPR_FILE* FileHandle_New(FILE* fp)
WINPR_FILE* pFile = NULL;
char name[MAX_PATH] = { 0 };
- _snprintf(name, sizeof(name), "device_%d", fileno(fp));
+ (void)_snprintf(name, sizeof(name), "device_%d", fileno(fp));
pFile = (WINPR_FILE*)calloc(1, sizeof(WINPR_FILE));
if (!pFile)
{
@@ -1454,7 +1454,7 @@ HANDLE GetFileHandleForFileDescriptor(int fd)
if (!fp)
return INVALID_HANDLE_VALUE;
- setvbuf(fp, NULL, _IONBF, 0);
+ (void)setvbuf(fp, NULL, _IONBF, 0);
pFile = FileHandle_New(fp);
if (!pFile)
diff --git a/winpr/libwinpr/file/generic.c b/winpr/libwinpr/file/generic.c
index c750739f2..dab4541ac 100644
--- a/winpr/libwinpr/file/generic.c
+++ b/winpr/libwinpr/file/generic.c
@@ -604,7 +604,7 @@ static const char* flagsToStr(char* buffer, size_t size, DWORD flags)
if (flags & FILE_ATTRIBUTE_VIRTUAL)
append(buffer, size, "FILE_ATTRIBUTE_VIRTUAL");
- _snprintf(strflags, sizeof(strflags), " [0x%08" PRIx32 "]", flags);
+ (void)_snprintf(strflags, sizeof(strflags), " [0x%08" PRIx32 "]", flags);
winpr_str_append(strflags, buffer, size, NULL);
return buffer;
}
diff --git a/winpr/libwinpr/file/namedPipeClient.c b/winpr/libwinpr/file/namedPipeClient.c
index fbfeb35ea..56a411336 100644
--- a/winpr/libwinpr/file/namedPipeClient.c
+++ b/winpr/libwinpr/file/namedPipeClient.c
@@ -197,7 +197,7 @@ static HANDLE NamedPipeClientCreateFileA(LPCSTR lpFileName, DWORD dwDesiredAcces
pNamedPipe->serverfd = -1;
pNamedPipe->ServerMode = FALSE;
s.sun_family = AF_UNIX;
- sprintf_s(s.sun_path, ARRAYSIZE(s.sun_path), "%s", pNamedPipe->lpFilePath);
+ (void)sprintf_s(s.sun_path, ARRAYSIZE(s.sun_path), "%s", pNamedPipe->lpFilePath);
status = connect(pNamedPipe->clientfd, (struct sockaddr*)&s, sizeof(struct sockaddr_un));
pNamedPipe->common.ops = &ops;
diff --git a/winpr/libwinpr/file/test/TestFileCreateFile.c b/winpr/libwinpr/file/test/TestFileCreateFile.c
index a939416c2..7d6595d63 100644
--- a/winpr/libwinpr/file/test/TestFileCreateFile.c
+++ b/winpr/libwinpr/file/test/TestFileCreateFile.c
@@ -21,11 +21,11 @@ int TestFileCreateFile(int argc, char* argv[])
WINPR_UNUSED(argc);
WINPR_UNUSED(argv);
GetSystemTime(&systemTime);
- sprintf_s(sname, sizeof(sname),
- "CreateFile-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
- "%02" PRIu16 "%04" PRIu16,
- systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
- systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
+ (void)sprintf_s(sname, sizeof(sname),
+ "CreateFile-%04" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16 "%02" PRIu16
+ "%02" PRIu16 "%04" PRIu16,
+ systemTime.wYear, systemTime.wMonth, systemTime.wDay, systemTime.wHour,
+ systemTime.wMinute, systemTime.wSecond, systemTime.wMilliseconds);
name = GetKnownSubPath(KNOWN_PATH_TEMP, sname);
if (!name)
diff --git a/winpr/libwinpr/file/test/TestFileFindFirstFile.c b/winpr/libwinpr/file/test/TestFileFindFirstFile.c
index 0e5de4483..4242f39c8 100644
--- a/winpr/libwinpr/file/test/TestFileFindFirstFile.c
+++ b/winpr/libwinpr/file/test/TestFileFindFirstFile.c
@@ -18,7 +18,7 @@ static BOOL create_layout_files(size_t level, const char* BasePath, wArrayList*
strncpy(FilePath, BasePath, ARRAYSIZE(FilePath));
CHAR name[64] = { 0 };
- _snprintf(name, ARRAYSIZE(name), "%zd-TestFile%zd", level, x);
+ (void)_snprintf(name, ARRAYSIZE(name), "%zd-TestFile%zd", level, x);
NativePathCchAppendA(FilePath, PATHCCH_MAX_CCH, name);
HANDLE hdl =
@@ -55,7 +55,7 @@ static BOOL create_layout_directories(size_t level, size_t max_level, const char
PathCchConvertStyleA(CurFilePath, ARRAYSIZE(CurFilePath), PATH_STYLE_NATIVE);
CHAR name[64] = { 0 };
- _snprintf(name, ARRAYSIZE(name), "%zd-TestPath%zd", level, x);
+ (void)_snprintf(name, ARRAYSIZE(name), "%zd-TestPath%zd", level, x);
NativePathCchAppendA(CurFilePath, PATHCCH_MAX_CCH, name);
if (!create_layout_directories(level + 1, max_level, CurFilePath, files))
diff --git a/winpr/libwinpr/file/test/TestFileGetStdHandle.c b/winpr/libwinpr/file/test/TestFileGetStdHandle.c
index 79ce4ae20..b61eb9d9d 100644
--- a/winpr/libwinpr/file/test/TestFileGetStdHandle.c
+++ b/winpr/libwinpr/file/test/TestFileGetStdHandle.c
@@ -34,13 +34,13 @@ int TestFileGetStdHandle(int argc, char* argv[])
so = GetStdHandle(STD_OUTPUT_HANDLE);
if (so == INVALID_HANDLE_VALUE)
{
- fprintf(stderr, "GetStdHandle failed ;(\n");
+ (void)fprintf(stderr, "GetStdHandle failed ;(\n");
return -1;
}
WriteFile(so, buf, strnlen(buf, sizeof(buf)), &bytesWritten, FALSE);
if (bytesWritten != strnlen(buf, sizeof(buf)))
{
- fprintf(stderr, "write failed\n");
+ (void)fprintf(stderr, "write failed\n");
return -1;
}
CloseHandle(so);
diff --git a/winpr/libwinpr/library/library.c b/winpr/libwinpr/library/library.c
index 0fa1fd1f2..476c178b8 100644
--- a/winpr/libwinpr/library/library.c
+++ b/winpr/libwinpr/library/library.c
@@ -275,7 +275,7 @@ DWORD GetModuleFileNameA(HMODULE hModule, LPSTR lpFilename, DWORD nSize)
if (!hModule)
{
char buffer[4096] = { 0 };
- sprintf_s(path, ARRAYSIZE(path), "/proc/%d/exe", getpid());
+ (void)sprintf_s(path, ARRAYSIZE(path), "/proc/%d/exe", getpid());
status = readlink(path, buffer, ARRAYSIZE(buffer) - 1);
if ((status < 0) || (status >= ARRAYSIZE(buffer)))
diff --git a/winpr/libwinpr/ncrypt/ncrypt_pkcs11.c b/winpr/libwinpr/ncrypt/ncrypt_pkcs11.c
index d2bcf2dbc..5103aec48 100644
--- a/winpr/libwinpr/ncrypt/ncrypt_pkcs11.c
+++ b/winpr/libwinpr/ncrypt/ncrypt_pkcs11.c
@@ -333,7 +333,7 @@ static const char* CK_RV_error_string(CK_RV rv)
ERR_ENTRY(CKR_MUTEX_NOT_LOCKED);
ERR_ENTRY(CKR_FUNCTION_REJECTED);
default:
- snprintf(generic_buffer, sizeof(generic_buffer), "unknown 0x%lx", rv);
+ (void)snprintf(generic_buffer, sizeof(generic_buffer), "unknown 0x%lx", rv);
return generic_buffer;
}
#undef ERR_ENTRY
@@ -552,13 +552,13 @@ static void wprintKeyName(LPWSTR str, CK_SLOT_ID slotId, CK_BYTE* id, CK_ULONG i
bytePtr = ((CK_BYTE*)&slotId);
for (CK_ULONG i = 0; i < sizeof(slotId); i++, bytePtr++, ptr += 2)
- snprintf(ptr, 3, "%.2x", *bytePtr);
+ (void)snprintf(ptr, 3, "%.2x", *bytePtr);
*ptr = '\\';
ptr++;
for (CK_ULONG i = 0; i < idLen; i++, id++, ptr += 2)
- snprintf(ptr, 3, "%.2x", *id);
+ (void)snprintf(ptr, 3, "%.2x", *id);
ConvertUtf8NToWChar(asciiName, ARRAYSIZE(asciiName), str,
strnlen(asciiName, ARRAYSIZE(asciiName)) + 1);
@@ -906,10 +906,10 @@ static SECURITY_STATUS get_piv_container_name(NCryptP11KeyHandle* key, const BYT
p = Stream_Buffer(&s);
/* Construct the value Windows would use for a PIV key's container name */
- snprintf(container_name, PIV_CONTAINER_NAME_LEN + 1,
- "%.2x%.2x%.2x%.2x-%.2x%.2x-%.2x%.2x-%.2x%.2x-%.2x%.2x%.2x%.2x%.2x%.2x", p[3], p[2],
- p[1], p[0], p[5], p[4], p[7], p[6], p[8], p[9], p[10], p[11], p[12], piv_tag[0],
- piv_tag[1], piv_tag[2]);
+ (void)snprintf(container_name, PIV_CONTAINER_NAME_LEN + 1,
+ "%.2x%.2x%.2x%.2x-%.2x%.2x-%.2x%.2x-%.2x%.2x-%.2x%.2x%.2x%.2x%.2x%.2x", p[3],
+ p[2], p[1], p[0], p[5], p[4], p[7], p[6], p[8], p[9], p[10], p[11], p[12],
+ piv_tag[0], piv_tag[1], piv_tag[2]);
/* And convert it to UTF-16 */
union
diff --git a/winpr/libwinpr/path/shell.c b/winpr/libwinpr/path/shell.c
index a1e7b4e77..9fd60624d 100644
--- a/winpr/libwinpr/path/shell.c
+++ b/winpr/libwinpr/path/shell.c
@@ -153,7 +153,7 @@ static char* GetPath_XDG_DATA_HOME(void)
return NULL;
}
- sprintf_s(path, size, "%s%s", home, "/.local/share");
+ (void)sprintf_s(path, size, "%s%s", home, "/.local/share");
free(home);
#endif
return path;
@@ -209,7 +209,7 @@ static char* GetPath_XDG_CONFIG_HOME(void)
return NULL;
}
- sprintf_s(path, size, "%s%s", home, "/.config");
+ (void)sprintf_s(path, size, "%s%s", home, "/.config");
free(home);
#endif
return path;
@@ -263,7 +263,7 @@ static char* GetPath_XDG_CACHE_HOME(void)
return NULL;
}
- sprintf_s(path, size, "%s%s", home, "/.cache");
+ (void)sprintf_s(path, size, "%s%s", home, "/.cache");
free(home);
#endif
return path;
diff --git a/winpr/libwinpr/path/test/TestPathMakePath.c b/winpr/libwinpr/path/test/TestPathMakePath.c
index 488cab3c6..af4f3fff1 100644
--- a/winpr/libwinpr/path/test/TestPathMakePath.c
+++ b/winpr/libwinpr/path/test/TestPathMakePath.c
@@ -21,7 +21,7 @@ int TestPathMakePath(int argc, char* argv[])
if (!base)
{
- fprintf(stderr, "Failed to get temporary directory!\n");
+ (void)fprintf(stderr, "Failed to get temporary directory!\n");
return -1;
}
@@ -30,13 +30,13 @@ int TestPathMakePath(int argc, char* argv[])
for (int x = 0; x < 5; x++)
{
- sprintf_s(tmp, ARRAYSIZE(tmp), "%08X", rand());
+ (void)sprintf_s(tmp, ARRAYSIZE(tmp), "%08X", rand());
path = GetCombinedPath(base, tmp);
free(base);
if (!path)
{
- fprintf(stderr, "GetCombinedPath failed!\n");
+ (void)fprintf(stderr, "GetCombinedPath failed!\n");
return -1;
}
@@ -48,7 +48,7 @@ int TestPathMakePath(int argc, char* argv[])
if (!success)
{
- fprintf(stderr, "MakePath failed!\n");
+ (void)fprintf(stderr, "MakePath failed!\n");
free(path);
return -1;
}
@@ -57,7 +57,7 @@ int TestPathMakePath(int argc, char* argv[])
if (!success)
{
- fprintf(stderr, "MakePath lied about success!\n");
+ (void)fprintf(stderr, "MakePath lied about success!\n");
free(path);
return -1;
}
@@ -66,7 +66,7 @@ int TestPathMakePath(int argc, char* argv[])
{
if (!winpr_RemoveDirectory(path))
{
- fprintf(stderr, "winpr_RemoveDirectory %s failed!\n", path);
+ (void)fprintf(stderr, "winpr_RemoveDirectory %s failed!\n", path);
free(path);
return -1;
}
diff --git a/winpr/libwinpr/path/test/TestPathShell.c b/winpr/libwinpr/path/test/TestPathShell.c
index 1925fea78..87af3f2eb 100644
--- a/winpr/libwinpr/path/test/TestPathShell.c
+++ b/winpr/libwinpr/path/test/TestPathShell.c
@@ -29,7 +29,7 @@ int TestPathShell(int argc, char* argv[])
if (!path)
{
- fprintf(stderr, "GetKnownPath(%d) failed\n", id);
+ (void)fprintf(stderr, "GetKnownPath(%d) failed\n", id);
rc = -1;
}
else
@@ -43,7 +43,7 @@ int TestPathShell(int argc, char* argv[])
if (!path)
{
- fprintf(stderr, "GetKnownSubPath(%d) failed\n", id);
+ (void)fprintf(stderr, "GetKnownSubPath(%d) failed\n", id);
rc = -1;
}
else
diff --git a/winpr/libwinpr/pipe/pipe.c b/winpr/libwinpr/pipe/pipe.c
index dba1bf3e5..d95df5a3e 100644
--- a/winpr/libwinpr/pipe/pipe.c
+++ b/winpr/libwinpr/pipe/pipe.c
@@ -653,7 +653,7 @@ HANDLE CreateNamedPipeA(LPCSTR lpName, DWORD dwOpenMode, DWORD dwPipeMode, DWORD
}
s.sun_family = AF_UNIX;
- sprintf_s(s.sun_path, ARRAYSIZE(s.sun_path), "%s", pNamedPipe->lpFilePath);
+ (void)sprintf_s(s.sun_path, ARRAYSIZE(s.sun_path), "%s", pNamedPipe->lpFilePath);
if (bind(serverfd, (struct sockaddr*)&s, sizeof(struct sockaddr_un)) == -1)
{
diff --git a/winpr/libwinpr/pipe/test/TestPipeCreateNamedPipe.c b/winpr/libwinpr/pipe/test/TestPipeCreateNamedPipe.c
index 8c8ead2c0..81f68e5f8 100644
--- a/winpr/libwinpr/pipe/test/TestPipeCreateNamedPipe.c
+++ b/winpr/libwinpr/pipe/test/TestPipeCreateNamedPipe.c
@@ -302,7 +302,7 @@ static DWORD WINAPI named_pipe_single_thread(LPVOID arg)
char sndbuf[PIPE_BUFFER_SIZE] = { 0 };
char rcvbuf[PIPE_BUFFER_SIZE] = { 0 };
/* Test writing from clients to servers */
- sprintf_s(sndbuf, sizeof(sndbuf), "CLIENT->SERVER ON PIPE #%05d", i);
+ (void)sprintf_s(sndbuf, sizeof(sndbuf), "CLIENT->SERVER ON PIPE #%05d", i);
if (!WriteFile(clients[i], sndbuf, sizeof(sndbuf), &dwWritten, NULL) ||
dwWritten != sizeof(sndbuf))
@@ -329,7 +329,7 @@ static DWORD WINAPI named_pipe_single_thread(LPVOID arg)
char rcvbuf[PIPE_BUFFER_SIZE] = { 0 };
/* Test writing from servers to clients */
- sprintf_s(sndbuf, sizeof(sndbuf), "SERVER->CLIENT ON PIPE #%05d", i);
+ (void)sprintf_s(sndbuf, sizeof(sndbuf), "SERVER->CLIENT ON PIPE #%05d", i);
if (!WriteFile(servers[i], sndbuf, sizeof(sndbuf), &dwWritten, NULL) ||
dwWritten != sizeof(sndbuf))
@@ -478,7 +478,7 @@ int TestPipeCreateNamedPipe(int argc, char* argv[])
}
#ifndef _WIN32
- signal(SIGPIPE, SIG_IGN);
+ (void)signal(SIGPIPE, SIG_IGN);
#endif
if (!(ReadyEvent = CreateEvent(NULL, TRUE, FALSE, NULL)))
{
diff --git a/winpr/libwinpr/registry/registry_reg.c b/winpr/libwinpr/registry/registry_reg.c
index a1803b649..a3b384aa5 100644
--- a/winpr/libwinpr/registry/registry_reg.c
+++ b/winpr/libwinpr/registry/registry_reg.c
@@ -531,7 +531,7 @@ void reg_close(Reg* reg)
{
reg_unload(reg);
if (reg->fp)
- fclose(reg->fp);
+ (void)fclose(reg->fp);
free(reg);
}
}
diff --git a/winpr/libwinpr/rpc/rpc.c b/winpr/libwinpr/rpc/rpc.c
index 99c2c7ebd..10328c672 100644
--- a/winpr/libwinpr/rpc/rpc.c
+++ b/winpr/libwinpr/rpc/rpc.c
@@ -717,9 +717,10 @@ RPC_STATUS UuidToStringA(const UUID* Uuid, RPC_CSTR* StringUuid)
* Format is 32 hex digits partitioned in 5 groups:
* xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
*/
- sprintf_s((char*)*StringUuid, 36 + 1, "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
- Uuid->Data1, Uuid->Data2, Uuid->Data3, Uuid->Data4[0], Uuid->Data4[1], Uuid->Data4[2],
- Uuid->Data4[3], Uuid->Data4[4], Uuid->Data4[5], Uuid->Data4[6], Uuid->Data4[7]);
+ (void)sprintf_s((char*)*StringUuid, 36 + 1, "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
+ Uuid->Data1, Uuid->Data2, Uuid->Data3, Uuid->Data4[0], Uuid->Data4[1],
+ Uuid->Data4[2], Uuid->Data4[3], Uuid->Data4[4], Uuid->Data4[5], Uuid->Data4[6],
+ Uuid->Data4[7]);
return RPC_S_OK;
}
diff --git a/winpr/libwinpr/shell/shell.c b/winpr/libwinpr/shell/shell.c
index 244ab7ade..8ff8d2f64 100644
--- a/winpr/libwinpr/shell/shell.c
+++ b/winpr/libwinpr/shell/shell.c
@@ -93,7 +93,7 @@ BOOL GetUserProfileDirectoryA(HANDLE hToken, LPSTR lpProfileDir, LPDWORD lpcchSi
}
ZeroMemory(lpProfileDir, *lpcchSize);
- sprintf_s(lpProfileDir, *lpcchSize, "%s", pw->pw_dir);
+ (void)sprintf_s(lpProfileDir, *lpcchSize, "%s", pw->pw_dir);
*lpcchSize = cchDirSize;
free(buf);
return TRUE;
diff --git a/winpr/libwinpr/smartcard/smartcard_pcsc.c b/winpr/libwinpr/smartcard/smartcard_pcsc.c
index 72b789e47..fd48ca9d4 100644
--- a/winpr/libwinpr/smartcard/smartcard_pcsc.c
+++ b/winpr/libwinpr/smartcard/smartcard_pcsc.c
@@ -2752,11 +2752,11 @@ static char* card_id_and_name_a(const UUID* CardIdentifier, LPCSTR LookupName)
if (!id)
return NULL;
- snprintf(id, len, "%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X\\%s", CardIdentifier->Data1,
- CardIdentifier->Data2, CardIdentifier->Data3, CardIdentifier->Data4[0],
- CardIdentifier->Data4[1], CardIdentifier->Data4[2], CardIdentifier->Data4[3],
- CardIdentifier->Data4[4], CardIdentifier->Data4[5], CardIdentifier->Data4[6],
- CardIdentifier->Data4[7], LookupName);
+ (void)snprintf(id, len, "%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X\\%s",
+ CardIdentifier->Data1, CardIdentifier->Data2, CardIdentifier->Data3,
+ CardIdentifier->Data4[0], CardIdentifier->Data4[1], CardIdentifier->Data4[2],
+ CardIdentifier->Data4[3], CardIdentifier->Data4[4], CardIdentifier->Data4[5],
+ CardIdentifier->Data4[6], CardIdentifier->Data4[7], LookupName);
return id;
}
diff --git a/winpr/libwinpr/sspi/NTLM/ntlm.c b/winpr/libwinpr/sspi/NTLM/ntlm.c
index bc16a40e4..bc91b49f1 100644
--- a/winpr/libwinpr/sspi/NTLM/ntlm.c
+++ b/winpr/libwinpr/sspi/NTLM/ntlm.c
@@ -1419,7 +1419,7 @@ char* ntlm_negotiate_flags_string(char* buffer, size_t size, UINT32 flags)
if (!buffer || (size == 0))
return buffer;
- _snprintf(buffer, size, "[0x%08" PRIx32 "] ", flags);
+ (void)_snprintf(buffer, size, "[0x%08" PRIx32 "] ", flags);
for (int x = 0; x < 31; x++)
{
diff --git a/winpr/libwinpr/sspi/test/TestNTLM.c b/winpr/libwinpr/sspi/test/TestNTLM.c
index 2ab33731d..9c3a79404 100644
--- a/winpr/libwinpr/sspi/test/TestNTLM.c
+++ b/winpr/libwinpr/sspi/test/TestNTLM.c
@@ -111,8 +111,8 @@ static int test_ntlm_client_init(TEST_NTLM_CLIENT* ntlm, const char* user, const
if (status != SEC_E_OK)
{
- fprintf(stderr, "QuerySecurityPackageInfo status: %s (0x%08" PRIX32 ")\n",
- GetSecurityStatusString(status), status);
+ (void)fprintf(stderr, "QuerySecurityPackageInfo status: %s (0x%08" PRIX32 ")\n",
+ GetSecurityStatusString(status), status);
return -1;
}
@@ -123,8 +123,8 @@ static int test_ntlm_client_init(TEST_NTLM_CLIENT* ntlm, const char* user, const
if (status != SEC_E_OK)
{
- fprintf(stderr, "AcquireCredentialsHandle status: %s (0x%08" PRIX32 ")\n",
- GetSecurityStatusString(status), status);
+ (void)fprintf(stderr, "AcquireCredentialsHandle status: %s (0x%08" PRIX32 ")\n",
+ GetSecurityStatusString(status), status);
return -1;
}
@@ -237,7 +237,7 @@ static int test_ntlm_client_authenticate(TEST_NTLM_CLIENT* ntlm)
if ((!ntlm) || (!ntlm->table))
{
- fprintf(stderr, "ntlm_authenticate: invalid ntlm context\n");
+ (void)fprintf(stderr, "ntlm_authenticate: invalid ntlm context\n");
return -1;
}
@@ -323,8 +323,8 @@ static int test_ntlm_server_init(TEST_NTLM_SERVER* ntlm)
if (status != SEC_E_OK)
{
- fprintf(stderr, "QuerySecurityPackageInfo status: %s (0x%08" PRIX32 ")\n",
- GetSecurityStatusString(status), status);
+ (void)fprintf(stderr, "QuerySecurityPackageInfo status: %s (0x%08" PRIX32 ")\n",
+ GetSecurityStatusString(status), status);
return -1;
}
@@ -335,8 +335,8 @@ static int test_ntlm_server_init(TEST_NTLM_SERVER* ntlm)
if (status != SEC_E_OK)
{
- fprintf(stderr, "AcquireCredentialsHandle status: %s (0x%08" PRIX32 ")\n",
- GetSecurityStatusString(status), status);
+ (void)fprintf(stderr, "AcquireCredentialsHandle status: %s (0x%08" PRIX32 ")\n",
+ GetSecurityStatusString(status), status);
return -1;
}
@@ -430,8 +430,8 @@ static int test_ntlm_server_authenticate(TEST_NTLM_SERVER* ntlm)
if ((status != SEC_E_OK) && (status != SEC_I_CONTINUE_NEEDED))
{
- fprintf(stderr, "AcceptSecurityContext status: %s (0x%08" PRIX32 ")\n",
- GetSecurityStatusString(status), status);
+ (void)fprintf(stderr, "AcceptSecurityContext status: %s (0x%08" PRIX32 ")\n",
+ GetSecurityStatusString(status), status);
return -1; /* Access Denied */
}
@@ -556,7 +556,7 @@ static BOOL test_default(void)
CopyMemory(pSecBuffer->pvBuffer, TEST_NTLM_NEGOTIATE, pSecBuffer->cbBuffer);
}
- fprintf(stderr, "NTLM_NEGOTIATE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
+ (void)fprintf(stderr, "NTLM_NEGOTIATE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
winpr_HexDump("sspi.test", WLOG_DEBUG, (BYTE*)pSecBuffer->pvBuffer, pSecBuffer->cbBuffer);
/**
* Server <- Negotiate Message
@@ -621,7 +621,7 @@ static BOOL test_default(void)
sizeof(SecPkgContext_AuthNtlmMessage));
}
- fprintf(stderr, "NTLM_CHALLENGE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
+ (void)fprintf(stderr, "NTLM_CHALLENGE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
winpr_HexDump("sspi.test", WLOG_DEBUG, (BYTE*)pSecBuffer->pvBuffer, pSecBuffer->cbBuffer);
/**
* Client <- Challenge Message
@@ -655,7 +655,7 @@ static BOOL test_default(void)
CopyMemory(pSecBuffer->pvBuffer, TEST_NTLM_AUTHENTICATE, pSecBuffer->cbBuffer);
}
- fprintf(stderr, "NTLM_AUTHENTICATE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
+ (void)fprintf(stderr, "NTLM_AUTHENTICATE (length = %" PRIu32 "):\n", pSecBuffer->cbBuffer);
winpr_HexDump("sspi.test", WLOG_DEBUG, (BYTE*)pSecBuffer->pvBuffer, pSecBuffer->cbBuffer);
/**
* Server <- Authenticate Message
diff --git a/winpr/libwinpr/synch/test/TestSynchBarrier.c b/winpr/libwinpr/synch/test/TestSynchBarrier.c
index b1c91c9a5..5bca01964 100644
--- a/winpr/libwinpr/synch/test/TestSynchBarrier.c
+++ b/winpr/libwinpr/synch/test/TestSynchBarrier.c
@@ -197,7 +197,7 @@ int TestSynchBarrier(int argc, char* argv[])
/* Test invalid parameters */
if (InitializeSynchronizationBarrier(&gBarrier, 0, -1))
{
- fprintf(
+ (void)fprintf(
stderr,
"%s: InitializeSynchronizationBarrier unecpectedly succeeded with lTotalThreads = 0\n",
__func__);
@@ -206,7 +206,7 @@ int TestSynchBarrier(int argc, char* argv[])
if (InitializeSynchronizationBarrier(&gBarrier, -1, -1))
{
- fprintf(
+ (void)fprintf(
stderr,
"%s: InitializeSynchronizationBarrier unecpectedly succeeded with lTotalThreads = -1\n",
__func__);
@@ -215,7 +215,7 @@ int TestSynchBarrier(int argc, char* argv[])
if (InitializeSynchronizationBarrier(&gBarrier, 1, -2))
{
- fprintf(
+ (void)fprintf(
stderr,
"%s: InitializeSynchronizationBarrier unecpectedly succeeded with lSpinCount = -2\n",
__func__);
@@ -226,29 +226,30 @@ int TestSynchBarrier(int argc, char* argv[])
if (!TestSynchBarrierWithFlags(0, dwMaxThreads, dwNumLoops))
{
- fprintf(stderr,
- "%s: TestSynchBarrierWithFlags(0) unecpectedly succeeded with lTotalThreads = -1\n",
- __func__);
+ (void)fprintf(
+ stderr,
+ "%s: TestSynchBarrierWithFlags(0) unecpectedly succeeded with lTotalThreads = -1\n",
+ __func__);
return -1;
}
if (!TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_SPIN_ONLY, dwMinThreads,
dwNumLoops))
{
- fprintf(stderr,
- "%s: TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_SPIN_ONLY) "
- "unecpectedly succeeded with lTotalThreads = -1\n",
- __func__);
+ (void)fprintf(stderr,
+ "%s: TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_SPIN_ONLY) "
+ "unecpectedly succeeded with lTotalThreads = -1\n",
+ __func__);
return -1;
}
if (!TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY, dwMaxThreads,
dwNumLoops))
{
- fprintf(stderr,
- "%s: TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY) "
- "unecpectedly succeeded with lTotalThreads = -1\n",
- __func__);
+ (void)fprintf(stderr,
+ "%s: TestSynchBarrierWithFlags(SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY) "
+ "unecpectedly succeeded with lTotalThreads = -1\n",
+ __func__);
return -1;
}
diff --git a/winpr/libwinpr/synch/test/TestSynchInit.c b/winpr/libwinpr/synch/test/TestSynchInit.c
index 20da41515..582a5cdf4 100644
--- a/winpr/libwinpr/synch/test/TestSynchInit.c
+++ b/winpr/libwinpr/synch/test/TestSynchInit.c
@@ -35,7 +35,7 @@ static BOOL CALLBACK TestOnceFunction(PINIT_ONCE once, PVOID param, PVOID* conte
{
return TRUE;
}
- fprintf(stderr, "%s: error: called again after success\n", __func__);
+ (void)fprintf(stderr, "%s: error: called again after success\n", __func__);
InterlockedIncrement(pErrors);
return FALSE;
}
@@ -50,7 +50,7 @@ static DWORD WINAPI TestThreadFunction(LPVOID lpParam)
InterlockedIncrement(pTestThreadFunctionCalls);
if (WaitForSingleObject(hStartEvent, INFINITE) != WAIT_OBJECT_0)
{
- fprintf(stderr, "%s: error: failed to wait for start event\n", __func__);
+ (void)fprintf(stderr, "%s: error: failed to wait for start event\n", __func__);
InterlockedIncrement(pErrors);
return 0;
}
@@ -59,7 +59,7 @@ static DWORD WINAPI TestThreadFunction(LPVOID lpParam)
calls = InterlockedIncrement(pInitOnceExecuteOnceCalls);
if (!ok && calls > TEST_NUM_FAILURES)
{
- fprintf(stderr, "%s: InitOnceExecuteOnce failed unexpectedly\n", __func__);
+ (void)fprintf(stderr, "%s: InitOnceExecuteOnce failed unexpectedly\n", __func__);
InterlockedIncrement(pErrors);
}
return 0;
@@ -82,7 +82,7 @@ int TestSynchInit(int argc, char* argv[])
if (!pErrors || !pTestThreadFunctionCalls || !pTestOnceFunctionCalls ||
!pInitOnceExecuteOnceCalls)
{
- fprintf(stderr, "error: _aligned_malloc failed\n");
+ (void)fprintf(stderr, "error: _aligned_malloc failed\n");
goto out;
}
@@ -93,7 +93,7 @@ int TestSynchInit(int argc, char* argv[])
if (!(hStartEvent = CreateEvent(NULL, TRUE, FALSE, NULL)))
{
- fprintf(stderr, "error creating start event\n");
+ (void)fprintf(stderr, "error creating start event\n");
InterlockedIncrement(pErrors);
goto out;
}
@@ -102,7 +102,7 @@ int TestSynchInit(int argc, char* argv[])
{
if (!(hThreads[i] = CreateThread(NULL, 0, TestThreadFunction, NULL, 0, NULL)))
{
- fprintf(stderr, "error creating thread #%" PRIu32 "\n", i);
+ (void)fprintf(stderr, "error creating thread #%" PRIu32 "\n", i);
InterlockedIncrement(pErrors);
goto out;
}
@@ -116,7 +116,7 @@ int TestSynchInit(int argc, char* argv[])
{
if (WaitForSingleObject(hThreads[i], INFINITE) != WAIT_OBJECT_0)
{
- fprintf(stderr, "error: error waiting for thread #%" PRIu32 "\n", i);
+ (void)fprintf(stderr, "error: error waiting for thread #%" PRIu32 "\n", i);
InterlockedIncrement(pErrors);
goto out;
}
@@ -130,15 +130,15 @@ int TestSynchInit(int argc, char* argv[])
}
out:
- fprintf(stderr, "Test result: %s\n", result ? "OK" : "ERROR");
- fprintf(stderr, "Error count: %" PRId32 "\n", pErrors ? *pErrors : -1);
- fprintf(stderr, "Threads created: %" PRIu32 "\n", dwCreatedThreads);
- fprintf(stderr, "TestThreadFunctionCalls: %" PRId32 "\n",
- pTestThreadFunctionCalls ? *pTestThreadFunctionCalls : -1);
- fprintf(stderr, "InitOnceExecuteOnceCalls: %" PRId32 "\n",
- pInitOnceExecuteOnceCalls ? *pInitOnceExecuteOnceCalls : -1);
- fprintf(stderr, "TestOnceFunctionCalls: %" PRId32 "\n",
- pTestOnceFunctionCalls ? *pTestOnceFunctionCalls : -1);
+ (void)fprintf(stderr, "Test result: %s\n", result ? "OK" : "ERROR");
+ (void)fprintf(stderr, "Error count: %" PRId32 "\n", pErrors ? *pErrors : -1);
+ (void)fprintf(stderr, "Threads created: %" PRIu32 "\n", dwCreatedThreads);
+ (void)fprintf(stderr, "TestThreadFunctionCalls: %" PRId32 "\n",
+ pTestThreadFunctionCalls ? *pTestThreadFunctionCalls : -1);
+ (void)fprintf(stderr, "InitOnceExecuteOnceCalls: %" PRId32 "\n",
+ pInitOnceExecuteOnceCalls ? *pInitOnceExecuteOnceCalls : -1);
+ (void)fprintf(stderr, "TestOnceFunctionCalls: %" PRId32 "\n",
+ pTestOnceFunctionCalls ? *pTestOnceFunctionCalls : -1);
winpr_aligned_free(pErrors);
winpr_aligned_free(pTestThreadFunctionCalls);
diff --git a/winpr/libwinpr/synch/test/TestSynchMutex.c b/winpr/libwinpr/synch/test/TestSynchMutex.c
index 296c3714a..509d3b949 100644
--- a/winpr/libwinpr/synch/test/TestSynchMutex.c
+++ b/winpr/libwinpr/synch/test/TestSynchMutex.c
@@ -109,7 +109,7 @@ static DWORD WINAPI test_mutex_thread1(LPVOID lpParam)
if (WaitForSingleObject(hStartEvent, INFINITE) != WAIT_OBJECT_0)
{
- fprintf(stderr, "%s: failed to wait for start event\n", __func__);
+ (void)fprintf(stderr, "%s: failed to wait for start event\n", __func__);
return 0;
}
@@ -125,10 +125,10 @@ static DWORD WINAPI test_mutex_thread1(LPVOID lpParam)
if (rc != WAIT_TIMEOUT)
{
- fprintf(stderr,
- "%s: WaitForSingleObject on thread1_mutex1 unexpectedly returned %" PRIu32
- " instead of WAIT_TIMEOUT (%u)\n",
- __func__, rc, WAIT_TIMEOUT);
+ (void)fprintf(stderr,
+ "%s: WaitForSingleObject on thread1_mutex1 unexpectedly returned %" PRIu32
+ " instead of WAIT_TIMEOUT (%u)\n",
+ __func__, rc, WAIT_TIMEOUT);
return 0;
}
@@ -136,16 +136,16 @@ static DWORD WINAPI test_mutex_thread1(LPVOID lpParam)
if (rc != WAIT_OBJECT_0)
{
- fprintf(stderr,
- "%s: WaitForSingleObject on thread1_mutex2 unexpectedly returned %" PRIu32
- " instead of WAIT_OBJECT_0\n",
- __func__, rc);
+ (void)fprintf(stderr,
+ "%s: WaitForSingleObject on thread1_mutex2 unexpectedly returned %" PRIu32
+ " instead of WAIT_OBJECT_0\n",
+ __func__, rc);
return 0;
}
if (!ReleaseMutex(thread1_mutex2))
{
- fprintf(stderr, "%s: ReleaseMutex failed on thread1_mutex2\n", __func__);
+ (void)fprintf(stderr, "%s: ReleaseMutex failed on thread1_mutex2\n", __func__);
return 0;
}
@@ -172,7 +172,7 @@ static BOOL test_mutex_threading(void)
if (!(hStartEvent = CreateEvent(NULL, TRUE, FALSE, NULL)))
{
- fprintf(stderr, "%s: error creating start event\n", __func__);
+ (void)fprintf(stderr, "%s: error creating start event\n", __func__);
goto fail;
}
@@ -180,7 +180,7 @@ static BOOL test_mutex_threading(void)
if (!(hThread = CreateThread(NULL, 0, test_mutex_thread1, (LPVOID)hStartEvent, 0, NULL)))
{
- fprintf(stderr, "%s: error creating test_mutex_thread_1\n", __func__);
+ (void)fprintf(stderr, "%s: error creating test_mutex_thread_1\n", __func__);
goto fail;
}
@@ -188,7 +188,7 @@ static BOOL test_mutex_threading(void)
if (!thread1_failed)
{
- fprintf(stderr, "%s: thread1 premature success\n", __func__);
+ (void)fprintf(stderr, "%s: thread1 premature success\n", __func__);
goto fail;
}
@@ -196,13 +196,13 @@ static BOOL test_mutex_threading(void)
if (WaitForSingleObject(hThread, 2000) != WAIT_OBJECT_0)
{
- fprintf(stderr, "%s: thread1 premature success\n", __func__);
+ (void)fprintf(stderr, "%s: thread1 premature success\n", __func__);
goto fail;
}
if (thread1_failed)
{
- fprintf(stderr, "%s: thread1 has not reported success\n", __func__);
+ (void)fprintf(stderr, "%s: thread1 has not reported success\n", __func__);
goto fail;
}
diff --git a/winpr/libwinpr/sysinfo/test/TestGetComputerName.c b/winpr/libwinpr/sysinfo/test/TestGetComputerName.c
index 444405637..12310da03 100644
--- a/winpr/libwinpr/sysinfo/test/TestGetComputerName.c
+++ b/winpr/libwinpr/sysinfo/test/TestGetComputerName.c
@@ -38,15 +38,16 @@ static BOOL Test_GetComputerName(void)
dwSize = 0;
if (GetComputerNameA(NULL, &dwSize) == TRUE)
{
- fprintf(stderr, "%s: (1) GetComputerNameA unexpectedly succeeded with null buffer\n",
- __func__);
+ (void)fprintf(stderr, "%s: (1) GetComputerNameA unexpectedly succeeded with null buffer\n",
+ __func__);
return FALSE;
}
if ((dwError = GetLastError()) != ERROR_BUFFER_OVERFLOW)
{
- fprintf(stderr,
- "%s: (2) GetLastError returned 0x%08" PRIX32 " (expected ERROR_BUFFER_OVERFLOW)\n",
- __func__, dwError);
+ (void)fprintf(stderr,
+ "%s: (2) GetLastError returned 0x%08" PRIX32
+ " (expected ERROR_BUFFER_OVERFLOW)\n",
+ __func__, dwError);
return FALSE;
}
@@ -54,26 +55,27 @@ static BOOL Test_GetComputerName(void)
dwSize = 0;
if (GetComputerNameA(netbiosName1, &dwSize) == TRUE)
{
- fprintf(stderr,
- "%s: (3) GetComputerNameA unexpectedly succeeded with zero size parameter\n",
- __func__);
+ (void)fprintf(stderr,
+ "%s: (3) GetComputerNameA unexpectedly succeeded with zero size parameter\n",
+ __func__);
return FALSE;
}
if ((dwError = GetLastError()) != ERROR_BUFFER_OVERFLOW)
{
- fprintf(stderr,
- "%s: (4) GetLastError returned 0x%08" PRIX32 " (expected ERROR_BUFFER_OVERFLOW)\n",
- __func__, dwError);
+ (void)fprintf(stderr,
+ "%s: (4) GetLastError returned 0x%08" PRIX32
+ " (expected ERROR_BUFFER_OVERFLOW)\n",
+ __func__, dwError);
return FALSE;
}
/* check if returned size is valid: must be the size of the buffer required, including the
* terminating null character in this case */
if (dwSize < 2 || dwSize > netbiosBufferSize)
{
- fprintf(stderr,
- "%s: (5) GetComputerNameA returned wrong size %" PRIu32
- " (expected something in the range from 2 to %" PRIu32 ")\n",
- __func__, dwSize, netbiosBufferSize);
+ (void)fprintf(stderr,
+ "%s: (5) GetComputerNameA returned wrong size %" PRIu32
+ " (expected something in the range from 2 to %" PRIu32 ")\n",
+ __func__, dwSize, netbiosBufferSize);
return FALSE;
}
dwNameLength = dwSize - 1;
@@ -81,22 +83,23 @@ static BOOL Test_GetComputerName(void)
/* test with returned size */
if (GetComputerNameA(netbiosName1, &dwSize) == FALSE)
{
- fprintf(stderr, "%s: (6) GetComputerNameA failed with error: 0x%08" PRIX32 "\n", __func__,
- GetLastError());
+ (void)fprintf(stderr, "%s: (6) GetComputerNameA failed with error: 0x%08" PRIX32 "\n",
+ __func__, GetLastError());
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength)
{
- fprintf(stderr,
- "%s: (7) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32 ")\n",
- __func__, dwSize, dwNameLength);
+ (void)fprintf(stderr,
+ "%s: (7) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32
+ ")\n",
+ __func__, dwSize, dwNameLength);
return FALSE;
}
/* check if string is correctly terminated */
if (netbiosName1[dwSize] != 0)
{
- fprintf(stderr, "%s: (8) string termination error\n", __func__);
+ (void)fprintf(stderr, "%s: (8) string termination error\n", __func__);
return FALSE;
}
@@ -104,30 +107,30 @@ static BOOL Test_GetComputerName(void)
dwSize = netbiosBufferSize;
if (GetComputerNameA(netbiosName2, &dwSize) == FALSE)
{
- fprintf(stderr, "%s: (9) GetComputerNameA failed with error: 0x%08" PRIX32 "\n", __func__,
- GetLastError());
+ (void)fprintf(stderr, "%s: (9) GetComputerNameA failed with error: 0x%08" PRIX32 "\n",
+ __func__, GetLastError());
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength)
{
- fprintf(stderr,
- "%s: (10) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32
- ")\n",
- __func__, dwSize, dwNameLength);
+ (void)fprintf(stderr,
+ "%s: (10) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32
+ ")\n",
+ __func__, dwSize, dwNameLength);
return FALSE;
}
/* check if string is correctly terminated */
if (netbiosName2[dwSize] != 0)
{
- fprintf(stderr, "%s: (11) string termination error\n", __func__);
+ (void)fprintf(stderr, "%s: (11) string termination error\n", __func__);
return FALSE;
}
/* compare the results */
if (strcmp(netbiosName1, netbiosName2))
{
- fprintf(stderr, "%s: (12) string compare mismatch\n", __func__);
+ (void)fprintf(stderr, "%s: (12) string compare mismatch\n", __func__);
return FALSE;
}
@@ -135,18 +138,18 @@ static BOOL Test_GetComputerName(void)
dwSize = dwNameLength;
if (GetComputerNameA(netbiosName1, &dwSize) == TRUE)
{
- fprintf(stderr,
- "%s: (13) GetComputerNameA unexpectedly succeeded with limited buffer size\n",
- __func__);
+ (void)fprintf(stderr,
+ "%s: (13) GetComputerNameA unexpectedly succeeded with limited buffer size\n",
+ __func__);
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength + 1)
{
- fprintf(stderr,
- "%s: (14) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32
- ")\n",
- __func__, dwSize, dwNameLength + 1);
+ (void)fprintf(stderr,
+ "%s: (14) GetComputerNameA returned wrong size %" PRIu32 " (expected %" PRIu32
+ ")\n",
+ __func__, dwSize, dwNameLength + 1);
return FALSE;
}
@@ -213,15 +216,16 @@ static BOOL Test_GetComputerNameEx_Format(COMPUTER_NAME_FORMAT format)
dwSize = 0;
if (GetComputerNameExA(format, NULL, &dwSize) == TRUE)
{
- fprintf(stderr, "%s: (1/%d) GetComputerNameExA unexpectedly succeeded with null buffer\n",
- __func__, format);
+ (void)fprintf(stderr,
+ "%s: (1/%d) GetComputerNameExA unexpectedly succeeded with null buffer\n",
+ __func__, format);
return FALSE;
}
if ((dwError = GetLastError()) != ERROR_MORE_DATA)
{
- fprintf(stderr,
- "%s: (2/%d) GetLastError returned 0x%08" PRIX32 " (expected ERROR_MORE_DATA)\n",
- __func__, format, dwError);
+ (void)fprintf(
+ stderr, "%s: (2/%d) GetLastError returned 0x%08" PRIX32 " (expected ERROR_MORE_DATA)\n",
+ __func__, format, dwError);
return FALSE;
}
@@ -229,26 +233,27 @@ static BOOL Test_GetComputerNameEx_Format(COMPUTER_NAME_FORMAT format)
dwSize = 0;
if (GetComputerNameExA(format, computerName1, &dwSize) == TRUE)
{
- fprintf(stderr,
- "%s: (3/%d) GetComputerNameExA unexpectedly succeeded with zero size parameter\n",
- __func__, format);
+ (void)fprintf(
+ stderr,
+ "%s: (3/%d) GetComputerNameExA unexpectedly succeeded with zero size parameter\n",
+ __func__, format);
return FALSE;
}
if ((dwError = GetLastError()) != ERROR_MORE_DATA)
{
- fprintf(stderr,
- "%s: (4/%d) GetLastError returned 0x%08" PRIX32 " (expected ERROR_MORE_DATA)\n",
- __func__, format, dwError);
+ (void)fprintf(
+ stderr, "%s: (4/%d) GetLastError returned 0x%08" PRIX32 " (expected ERROR_MORE_DATA)\n",
+ __func__, format, dwError);
return FALSE;
}
/* check if returned size is valid: must be the size of the buffer required, including the
* terminating null character in this case */
if (dwSize < dwMinSize || dwSize > nameBufferSize)
{
- fprintf(stderr,
- "%s: (5/%d) GetComputerNameExA returned wrong size %" PRIu32
- " (expected something in the range from %" PRIu32 " to %" PRIu32 ")\n",
- __func__, format, dwSize, dwMinSize, nameBufferSize);
+ (void)fprintf(stderr,
+ "%s: (5/%d) GetComputerNameExA returned wrong size %" PRIu32
+ " (expected something in the range from %" PRIu32 " to %" PRIu32 ")\n",
+ __func__, format, dwSize, dwMinSize, nameBufferSize);
return FALSE;
}
dwNameLength = dwSize - 1;
@@ -256,23 +261,23 @@ static BOOL Test_GetComputerNameEx_Format(COMPUTER_NAME_FORMAT format)
/* test with returned size */
if (GetComputerNameExA(format, computerName1, &dwSize) == FALSE)
{
- fprintf(stderr, "%s: (6/%d) GetComputerNameExA failed with error: 0x%08" PRIX32 "\n",
- __func__, format, GetLastError());
+ (void)fprintf(stderr, "%s: (6/%d) GetComputerNameExA failed with error: 0x%08" PRIX32 "\n",
+ __func__, format, GetLastError());
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength)
{
- fprintf(stderr,
- "%s: (7/%d) GetComputerNameExA returned wrong size %" PRIu32 " (expected %" PRIu32
- ")\n",
- __func__, format, dwSize, dwNameLength);
+ (void)fprintf(stderr,
+ "%s: (7/%d) GetComputerNameExA returned wrong size %" PRIu32
+ " (expected %" PRIu32 ")\n",
+ __func__, format, dwSize, dwNameLength);
return FALSE;
}
/* check if string is correctly terminated */
if (computerName1[dwSize] != 0)
{
- fprintf(stderr, "%s: (8/%d) string termination error\n", __func__, format);
+ (void)fprintf(stderr, "%s: (8/%d) string termination error\n", __func__, format);
return FALSE;
}
@@ -280,30 +285,30 @@ static BOOL Test_GetComputerNameEx_Format(COMPUTER_NAME_FORMAT format)
dwSize = nameBufferSize;
if (GetComputerNameExA(format, computerName2, &dwSize) == FALSE)
{
- fprintf(stderr, "%s: (9/%d) GetComputerNameExA failed with error: 0x%08" PRIX32 "\n",
- __func__, format, GetLastError());
+ (void)fprintf(stderr, "%s: (9/%d) GetComputerNameExA failed with error: 0x%08" PRIX32 "\n",
+ __func__, format, GetLastError());
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength)
{
- fprintf(stderr,
- "%s: (10/%d) GetComputerNameExA returned wrong size %" PRIu32 " (expected %" PRIu32
- ")\n",
- __func__, format, dwSize, dwNameLength);
+ (void)fprintf(stderr,
+ "%s: (10/%d) GetComputerNameExA returned wrong size %" PRIu32
+ " (expected %" PRIu32 ")\n",
+ __func__, format, dwSize, dwNameLength);
return FALSE;
}
/* check if string is correctly terminated */
if (computerName2[dwSize] != 0)
{
- fprintf(stderr, "%s: (11/%d) string termination error\n", __func__, format);
+ (void)fprintf(stderr, "%s: (11/%d) string termination error\n", __func__, format);
return FALSE;
}
/* compare the results */
if (strcmp(computerName1, computerName2))
{
- fprintf(stderr, "%s: (12/%d) string compare mismatch\n", __func__, format);
+ (void)fprintf(stderr, "%s: (12/%d) string compare mismatch\n", __func__, format);
return FALSE;
}
@@ -311,18 +316,19 @@ static BOOL Test_GetComputerNameEx_Format(COMPUTER_NAME_FORMAT format)
dwSize = dwNameLength;
if (GetComputerNameExA(format, computerName1, &dwSize) == TRUE)
{
- fprintf(stderr,
- "%s: (13/%d) GetComputerNameExA unexpectedly succeeded with limited buffer size\n",
- __func__, format);
+ (void)fprintf(
+ stderr,
+ "%s: (13/%d) GetComputerNameExA unexpectedly succeeded with limited buffer size\n",
+ __func__, format);
return FALSE;
}
/* check if returned size is valid */
if (dwSize != dwNameLength + 1)
{
- fprintf(stderr,
- "%s: (14/%d) GetComputerNameExA returned wrong size %" PRIu32 " (expected %" PRIu32
- ")\n",
- __func__, format, dwSize, dwNameLength + 1);
+ (void)fprintf(stderr,
+ "%s: (14/%d) GetComputerNameExA returned wrong size %" PRIu32
+ " (expected %" PRIu32 ")\n",
+ __func__, format, dwSize, dwNameLength + 1);
return FALSE;
}
diff --git a/winpr/libwinpr/thread/test/TestThreadExitThread.c b/winpr/libwinpr/thread/test/TestThreadExitThread.c
index 015bb85f4..46d81fa7f 100644
--- a/winpr/libwinpr/thread/test/TestThreadExitThread.c
+++ b/winpr/libwinpr/thread/test/TestThreadExitThread.c
@@ -29,7 +29,7 @@ int TestThreadExitThread(int argc, char* argv[])
if (thread == INVALID_HANDLE_VALUE)
{
- fprintf(stderr, "Got an invalid thread!\n");
+ (void)fprintf(stderr, "Got an invalid thread!\n");
return -1;
}
@@ -42,8 +42,8 @@ int TestThreadExitThread(int argc, char* argv[])
* the end of the thread. Therefore WaitForSingleObject
* never get the signal.
*/
- fprintf(stderr,
- "300ms should have been enough for the thread to be in a signaled state\n");
+ (void)fprintf(
+ stderr, "300ms should have been enough for the thread to be in a signaled state\n");
return -1;
}
diff --git a/winpr/libwinpr/timezone/timezone.c b/winpr/libwinpr/timezone/timezone.c
index 081516bce..4348ead59 100644
--- a/winpr/libwinpr/timezone/timezone.c
+++ b/winpr/libwinpr/timezone/timezone.c
@@ -253,7 +253,7 @@ static char* winpr_get_unix_timezone_identifier_from_file(void)
return NULL;
tzid = winpr_read_unix_timezone_identifier_from_file(fp);
- fclose(fp);
+ (void)fclose(fp);
if (tzid != NULL)
WLog_DBG(TAG, "tzid: %s", tzid);
return tzid;
@@ -578,14 +578,14 @@ static char* systemtime2str(const SYSTEMTIME* t, char* buffer, size_t len)
const SYSTEMTIME empty = { 0 };
if (memcmp(t, &empty, sizeof(SYSTEMTIME)) == 0)
- _snprintf(buffer, len, "{ not set }");
+ (void)_snprintf(buffer, len, "{ not set }");
else
{
- _snprintf(buffer, len,
- "{ %" PRIu16 "-%" PRIu16 "-%" PRIu16 " [%s] %" PRIu16 ":%" PRIu16 ":%" PRIu16
- ".%" PRIu16 "}",
- t->wYear, t->wMonth, t->wDay, weekday2str(t->wDayOfWeek), t->wHour, t->wMinute,
- t->wSecond, t->wMilliseconds);
+ (void)_snprintf(buffer, len,
+ "{ %" PRIu16 "-%" PRIu16 "-%" PRIu16 " [%s] %" PRIu16 ":%" PRIu16
+ ":%" PRIu16 ".%" PRIu16 "}",
+ t->wYear, t->wMonth, t->wDay, weekday2str(t->wDayOfWeek), t->wHour,
+ t->wMinute, t->wSecond, t->wMilliseconds);
}
return buffer;
}
diff --git a/winpr/libwinpr/utils/cmdline.c b/winpr/libwinpr/utils/cmdline.c
index a524d62db..64b223c89 100644
--- a/winpr/libwinpr/utils/cmdline.c
+++ b/winpr/libwinpr/utils/cmdline.c
@@ -699,7 +699,7 @@ char** CommandLineParseCommaSeparatedValuesEx(const char* name, const char* list
{
char* dst = (char*)&p[1];
p[0] = dst;
- sprintf_s(dst, clen + 1, "%s", name);
+ (void)sprintf_s(dst, clen + 1, "%s", name);
*count = 1;
success = TRUE;
goto fail;
diff --git a/winpr/libwinpr/utils/collections/StreamPool.c b/winpr/libwinpr/utils/collections/StreamPool.c
index c447c8cbe..b278a789a 100644
--- a/winpr/libwinpr/utils/collections/StreamPool.c
+++ b/winpr/libwinpr/utils/collections/StreamPool.c
@@ -400,9 +400,10 @@ char* StreamPool_GetStatistics(wStreamPool* pool, char* buffer, size_t size)
if (!buffer || (size < 1))
return NULL;
- _snprintf(buffer, size - 1,
- "aSize =%" PRIuz ", uSize =%" PRIuz "aCapacity=%" PRIuz ", uCapacity=%" PRIuz,
- pool->aSize, pool->uSize, pool->aCapacity, pool->uCapacity);
+ (void)_snprintf(buffer, size - 1,
+ "aSize =%" PRIuz ", uSize =%" PRIuz "aCapacity=%" PRIuz
+ ", uCapacity=%" PRIuz,
+ pool->aSize, pool->uSize, pool->aCapacity, pool->uCapacity);
buffer[size - 1] = '\0';
return buffer;
}
diff --git a/winpr/libwinpr/utils/debug.c b/winpr/libwinpr/utils/debug.c
index 42d916e0d..c62ad7834 100644
--- a/winpr/libwinpr/utils/debug.c
+++ b/winpr/libwinpr/utils/debug.c
@@ -229,7 +229,7 @@ char* winpr_strerror(DWORD dw, char* dmsg, size_t size)
#elif defined(WINPR_HAVE_STRERROR_R)
strerror_r(dw, dmsg, size);
#else
- _snprintf(dmsg, size, "%s", strerror(dw));
+ (void)_snprintf(dmsg, size, "%s", strerror(dw));
#endif
return dmsg;
}
diff --git a/winpr/libwinpr/utils/image.c b/winpr/libwinpr/utils/image.c
index 4aee2278f..c4d6a957c 100644
--- a/winpr/libwinpr/utils/image.c
+++ b/winpr/libwinpr/utils/image.c
@@ -325,7 +325,7 @@ int winpr_bitmap_write_ex(const char* filename, const BYTE* data, size_t stride,
fail:
if (fp)
- fclose(fp);
+ (void)fclose(fp);
free(bmpdata);
return ret;
}
@@ -341,7 +341,7 @@ static int write_and_free(const char* filename, void* data, size_t size)
goto fail;
size_t w = fwrite(data, 1, size, fp);
- fclose(fp);
+ (void)fclose(fp);
status = (w == size) ? 1 : -1;
fail:
@@ -479,9 +479,9 @@ int winpr_image_read(wImage* image, const char* filename)
return -1;
}
- fseek(fp, 0, SEEK_END);
+ (void)fseek(fp, 0, SEEK_END);
INT64 pos = _ftelli64(fp);
- fseek(fp, 0, SEEK_SET);
+ (void)fseek(fp, 0, SEEK_SET);
if (pos > 0)
{
@@ -496,7 +496,7 @@ int winpr_image_read(wImage* image, const char* filename)
}
free(buffer);
}
- fclose(fp);
+ (void)fclose(fp);
return status;
}
diff --git a/winpr/libwinpr/utils/ini.c b/winpr/libwinpr/utils/ini.c
index 5ebac34cc..17beef264 100644
--- a/winpr/libwinpr/utils/ini.c
+++ b/winpr/libwinpr/utils/ini.c
@@ -131,7 +131,7 @@ static BOOL IniFile_Load_String(wIniFile* ini, const char* iniString)
static void IniFile_Close_File(FILE* fp)
{
if (fp)
- fclose(fp);
+ (void)fclose(fp);
}
static FILE* IniFile_Open_File(wIniFile* ini, const char* filename)
@@ -706,7 +706,7 @@ int IniFile_SetKeyValueInt(wIniFile* ini, const char* section, const char* key,
WINPR_ASSERT(ini);
- sprintf_s(strVal, sizeof(strVal), "%d", value);
+ (void)sprintf_s(strVal, sizeof(strVal), "%d", value);
pSection = IniFile_GetSection(ini, section);
if (!pSection)
@@ -756,17 +756,17 @@ char* IniFile_WriteBuffer(wIniFile* ini)
for (size_t i = 0; i < ini->nSections; i++)
{
wIniFileSection* section = ini->sections[i];
- sprintf_s(&buffer[offset], size - offset, "[%s]\n", section->name);
+ (void)sprintf_s(&buffer[offset], size - offset, "[%s]\n", section->name);
offset += (strlen(section->name) + 3);
for (size_t j = 0; j < section->nKeys; j++)
{
wIniFileKey* key = section->keys[j];
- sprintf_s(&buffer[offset], size - offset, "%s=%s\n", key->name, key->value);
+ (void)sprintf_s(&buffer[offset], size - offset, "%s=%s\n", key->name, key->value);
offset += (strlen(key->name) + strlen(key->value) + 2);
}
- sprintf_s(&buffer[offset], size - offset, "\n");
+ (void)sprintf_s(&buffer[offset], size - offset, "\n");
offset += 1;
}
diff --git a/winpr/libwinpr/utils/sam.c b/winpr/libwinpr/utils/sam.c
index 31163d9df..40973d26f 100644
--- a/winpr/libwinpr/utils/sam.c
+++ b/winpr/libwinpr/utils/sam.c
@@ -105,7 +105,7 @@ WINPR_SAM* SamOpen(const char* filename, BOOL readOnly)
if (!sam)
{
- fclose(fp);
+ (void)fclose(fp);
return NULL;
}
@@ -360,7 +360,7 @@ void SamClose(WINPR_SAM* sam)
if (sam != NULL)
{
if (sam->fp)
- fclose(sam->fp);
+ (void)fclose(sam->fp);
free(sam);
}
}
diff --git a/winpr/libwinpr/utils/ssl.c b/winpr/libwinpr/utils/ssl.c
index 87649695f..2f85206ed 100644
--- a/winpr/libwinpr/utils/ssl.c
+++ b/winpr/libwinpr/utils/ssl.c
@@ -337,7 +337,7 @@ static BOOL CALLBACK winpr_openssl_initialize(PINIT_ONCE once, PVOID param, PVOI
}
#endif
- atexit(winpr_openssl_cleanup);
+ (void)atexit(winpr_openssl_cleanup);
g_winpr_openssl_initialized_by_winpr = TRUE;
return TRUE;
}
diff --git a/winpr/libwinpr/utils/stream.c b/winpr/libwinpr/utils/stream.c
index 4c7696f74..b8eaea5dc 100644
--- a/winpr/libwinpr/utils/stream.c
+++ b/winpr/libwinpr/utils/stream.c
@@ -355,7 +355,7 @@ BOOL Stream_CheckAndLogRequiredCapacityWLogExVa(wLog* log, DWORD level, wStream*
{
char prefix[1024] = { 0 };
- vsnprintf(prefix, sizeof(prefix), fmt, args);
+ (void)vsnprintf(prefix, sizeof(prefix), fmt, args);
WLog_Print(log, level,
"[%s] invalid remaining capacity, got %" PRIuz ", require at least %" PRIu64
@@ -451,7 +451,7 @@ BOOL Stream_CheckAndLogRequiredLengthWLogExVa(wLog* log, DWORD level, wStream* s
{
char prefix[1024] = { 0 };
- vsnprintf(prefix, sizeof(prefix), fmt, args);
+ (void)vsnprintf(prefix, sizeof(prefix), fmt, args);
WLog_Print(log, level,
"[%s] invalid length, got %" PRIuz ", require at least %" PRIuz
diff --git a/winpr/libwinpr/utils/strlst.c b/winpr/libwinpr/utils/strlst.c
index c83e29cfe..48112443c 100644
--- a/winpr/libwinpr/utils/strlst.c
+++ b/winpr/libwinpr/utils/strlst.c
@@ -67,8 +67,8 @@ void string_list_print(FILE* out, const char* const* string_list)
{
for (int j = 0; string_list[j]; j++)
{
- fprintf(out, "[%2d]: %s\n", j, string_list[j]);
+ (void)fprintf(out, "[%2d]: %s\n", j, string_list[j]);
}
- fflush(out);
+ (void)fflush(out);
}
diff --git a/winpr/libwinpr/utils/test/TestBacktrace.c b/winpr/libwinpr/utils/test/TestBacktrace.c
index 5fea333ec..6d1d91d61 100644
--- a/winpr/libwinpr/utils/test/TestBacktrace.c
+++ b/winpr/libwinpr/utils/test/TestBacktrace.c
@@ -13,7 +13,7 @@ int TestBacktrace(int argc, char* argv[])
if (!stack)
{
- fprintf(stderr, "winpr_backtrace failed!\n");
+ (void)fprintf(stderr, "winpr_backtrace failed!\n");
return -1;
}
diff --git a/winpr/libwinpr/utils/test/TestImage.c b/winpr/libwinpr/utils/test/TestImage.c
index 8635fa1aa..a19dc1bcf 100644
--- a/winpr/libwinpr/utils/test/TestImage.c
+++ b/winpr/libwinpr/utils/test/TestImage.c
@@ -23,17 +23,17 @@ static BOOL test_equal_to(const wImage* bmp, const char* name, UINT32 format)
goto fail;
char path[MAX_PATH] = { 0 };
- _snprintf(path, sizeof(path), "%s.%s", name, winpr_image_format_extension(format));
+ (void)_snprintf(path, sizeof(path), "%s.%s", name, winpr_image_format_extension(format));
const int cmpSize = winpr_image_read(cmp, path);
if (cmpSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, path);
+ (void)fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, path);
goto fail;
}
rc = test_image_equal(bmp, cmp);
if (!rc)
- fprintf(stderr, "[%s] winpr_image_eqal failed", __func__);
+ (void)fprintf(stderr, "[%s] winpr_image_eqal failed", __func__);
fail:
winpr_image_free(cmp, TRUE);
@@ -49,13 +49,13 @@ static BOOL test_equal(void)
goto fail;
char path[MAX_PATH] = { 0 };
- _snprintf(path, sizeof(path), "%s.bmp", test_src_filename);
+ (void)_snprintf(path, sizeof(path), "%s.bmp", test_src_filename);
PathCchConvertStyleA(path, sizeof(path), PATH_STYLE_NATIVE);
const int bmpSize = winpr_image_read(bmp, path);
if (bmpSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, path);
+ (void)fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, path);
goto fail;
}
@@ -87,12 +87,12 @@ static BOOL test_read_write_compare(const char* tname, const char* tdst, UINT32
char dpath[MAX_PATH] = { 0 };
char bpath1[MAX_PATH] = { 0 };
char bpath2[MAX_PATH] = { 0 };
- _snprintf(spath, sizeof(spath), "%s.%s", tname, winpr_image_format_extension(format));
- _snprintf(dpath, sizeof(dpath), "%s.%s", tdst, winpr_image_format_extension(format));
- _snprintf(bpath1, sizeof(bpath1), "%s.src.%s", dpath,
- winpr_image_format_extension(WINPR_IMAGE_BITMAP));
- _snprintf(bpath2, sizeof(bpath2), "%s.bin.%s", dpath,
- winpr_image_format_extension(WINPR_IMAGE_BITMAP));
+ (void)_snprintf(spath, sizeof(spath), "%s.%s", tname, winpr_image_format_extension(format));
+ (void)_snprintf(dpath, sizeof(dpath), "%s.%s", tdst, winpr_image_format_extension(format));
+ (void)_snprintf(bpath1, sizeof(bpath1), "%s.src.%s", dpath,
+ winpr_image_format_extension(WINPR_IMAGE_BITMAP));
+ (void)_snprintf(bpath2, sizeof(bpath2), "%s.bin.%s", dpath,
+ winpr_image_format_extension(WINPR_IMAGE_BITMAP));
PathCchConvertStyleA(spath, sizeof(spath), PATH_STYLE_NATIVE);
PathCchConvertStyleA(dpath, sizeof(dpath), PATH_STYLE_NATIVE);
PathCchConvertStyleA(bpath1, sizeof(bpath1), PATH_STYLE_NATIVE);
@@ -101,28 +101,28 @@ static BOOL test_read_write_compare(const char* tname, const char* tdst, UINT32
const int bmpRSize = winpr_image_read(bmp1, spath);
if (bmpRSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, spath);
+ (void)fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, spath);
goto fail;
}
const int bmpWSize = winpr_image_write(bmp1, dpath);
if (bmpWSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_write failed for %s", __func__, dpath);
+ (void)fprintf(stderr, "[%s] winpr_image_write failed for %s", __func__, dpath);
goto fail;
}
const int bmp2RSize = winpr_image_read(bmp2, dpath);
if (bmp2RSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, dpath);
+ (void)fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, dpath);
goto fail;
}
const int bmpSrcWSize = winpr_image_write_ex(bmp1, WINPR_IMAGE_BITMAP, bpath1);
if (bmpSrcWSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_write_ex failed for %s", __func__, bpath1);
+ (void)fprintf(stderr, "[%s] winpr_image_write_ex failed for %s", __func__, bpath1);
goto fail;
}
@@ -131,14 +131,14 @@ static BOOL test_read_write_compare(const char* tname, const char* tdst, UINT32
const int bmpBinWSize = winpr_image_write_ex(bmp2, WINPR_IMAGE_BITMAP, bpath2);
if (bmpBinWSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_write_ex failed for %s", __func__, bpath2);
+ (void)fprintf(stderr, "[%s] winpr_image_write_ex failed for %s", __func__, bpath2);
goto fail;
}
const int bmp3RSize = winpr_image_read(bmp3, bpath2);
if (bmp3RSize <= 0)
{
- fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, bpath2);
+ (void)fprintf(stderr, "[%s] winpr_image_read failed for %s", __func__, bpath2);
goto fail;
}
@@ -146,7 +146,7 @@ static BOOL test_read_write_compare(const char* tname, const char* tdst, UINT32
WINPR_IMAGE_CMP_IGNORE_DEPTH | WINPR_IMAGE_CMP_IGNORE_ALPHA |
WINPR_IMAGE_CMP_FUZZY))
{
- fprintf(stderr, "[%s] winpr_image_eqal failed bmp1 bmp2", __func__);
+ (void)fprintf(stderr, "[%s] winpr_image_eqal failed bmp1 bmp2", __func__);
goto fail;
}
@@ -154,7 +154,7 @@ static BOOL test_read_write_compare(const char* tname, const char* tdst, UINT32
WINPR_IMAGE_CMP_IGNORE_DEPTH | WINPR_IMAGE_CMP_IGNORE_ALPHA |
WINPR_IMAGE_CMP_FUZZY);
if (!rc)
- fprintf(stderr, "[%s] winpr_image_eqal failed bmp3 bmp2", __func__);
+ (void)fprintf(stderr, "[%s] winpr_image_eqal failed bmp3 bmp2", __func__);
fail:
winpr_image_free(bmp1, TRUE);
winpr_image_free(bmp2, TRUE);
diff --git a/winpr/libwinpr/utils/test/TestWLog.c b/winpr/libwinpr/utils/test/TestWLog.c
index 92f11147e..f75b85d02 100644
--- a/winpr/libwinpr/utils/test/TestWLog.c
+++ b/winpr/libwinpr/utils/test/TestWLog.c
@@ -20,7 +20,7 @@ int TestWLog(int argc, char* argv[])
if (!(tmp_path = GetKnownPath(KNOWN_PATH_TEMP)))
{
- fprintf(stderr, "Failed to get temporary directory!\n");
+ (void)fprintf(stderr, "Failed to get temporary directory!\n");
goto out;
}
diff --git a/winpr/libwinpr/utils/test/TestWLogCallback.c b/winpr/libwinpr/utils/test/TestWLogCallback.c
index 1acbf6586..de4f71263 100644
--- a/winpr/libwinpr/utils/test/TestWLogCallback.c
+++ b/winpr/libwinpr/utils/test/TestWLogCallback.c
@@ -44,7 +44,7 @@ static BOOL check(const wLogMessage* msg)
if (!rc)
{
- fprintf(stderr, "Test failed!\n");
+ (void)fprintf(stderr, "Test failed!\n");
success = FALSE;
}
return rc;
@@ -58,19 +58,19 @@ static BOOL CallbackAppenderMessage(const wLogMessage* msg)
static BOOL CallbackAppenderData(const wLogMessage* msg)
{
- fprintf(stdout, "%s\n", __func__);
+ (void)fprintf(stdout, "%s\n", __func__);
return TRUE;
}
static BOOL CallbackAppenderImage(const wLogMessage* msg)
{
- fprintf(stdout, "%s\n", __func__);
+ (void)fprintf(stdout, "%s\n", __func__);
return TRUE;
}
static BOOL CallbackAppenderPackage(const wLogMessage* msg)
{
- fprintf(stdout, "%s\n", __func__);
+ (void)fprintf(stdout, "%s\n", __func__);
return TRUE;
}
diff --git a/winpr/libwinpr/utils/unwind/debug.c b/winpr/libwinpr/utils/unwind/debug.c
index 314c07d1d..663f7be00 100644
--- a/winpr/libwinpr/utils/unwind/debug.c
+++ b/winpr/libwinpr/utils/unwind/debug.c
@@ -90,7 +90,7 @@ static const char* unwind_reason_str(_Unwind_Reason_Code code)
static const char* unwind_reason_str_buffer(_Unwind_Reason_Code code, char* buffer, size_t size)
{
const char* str = unwind_reason_str(code);
- _snprintf(buffer, size, "%s [0x%02x]", str, code);
+ (void)_snprintf(buffer, size, "%s [0x%02x]", str, code);
return buffer;
}
@@ -177,10 +177,10 @@ char** winpr_unwind_backtrace_symbols(void* buffer, size_t* used)
cnv.cpp[x] = msg;
if (rc == 0)
- _snprintf(msg, UNWIND_MAX_LINE_SIZE, "unresolvable, address=%p", (void*)info->pc);
+ (void)_snprintf(msg, UNWIND_MAX_LINE_SIZE, "unresolvable, address=%p", (void*)info->pc);
else
- _snprintf(msg, UNWIND_MAX_LINE_SIZE, "dli_fname=%s [%p], dli_sname=%s [%p]",
- dlinfo.dli_fname, dlinfo.dli_fbase, dlinfo.dli_sname, dlinfo.dli_saddr);
+ (void)_snprintf(msg, UNWIND_MAX_LINE_SIZE, "dli_fname=%s [%p], dli_sname=%s [%p]",
+ dlinfo.dli_fname, dlinfo.dli_fbase, dlinfo.dli_sname, dlinfo.dli_saddr);
}
return cnv.cpp;
diff --git a/winpr/libwinpr/utils/wlog/Appender.c b/winpr/libwinpr/utils/wlog/Appender.c
index a1cbbd66a..3dbb7fa31 100644
--- a/winpr/libwinpr/utils/wlog/Appender.c
+++ b/winpr/libwinpr/utils/wlog/Appender.c
@@ -126,7 +126,8 @@ static wLogAppender* WLog_Appender_New(wLog* log, DWORD logAppenderType)
appender = (wLogAppender*)WLog_UdpAppender_New(log);
break;
default:
- fprintf(stderr, "%s: unknown handler type %" PRIu32 "\n", __func__, logAppenderType);
+ (void)fprintf(stderr, "%s: unknown handler type %" PRIu32 "\n", __func__,
+ logAppenderType);
appender = NULL;
break;
}
diff --git a/winpr/libwinpr/utils/wlog/BinaryAppender.c b/winpr/libwinpr/utils/wlog/BinaryAppender.c
index e9a440a26..88ba33c86 100644
--- a/winpr/libwinpr/utils/wlog/BinaryAppender.c
+++ b/winpr/libwinpr/utils/wlog/BinaryAppender.c
@@ -50,7 +50,8 @@ static BOOL WLog_BinaryAppender_Open(wLog* log, wLogAppender* appender)
binaryAppender->FileName = (char*)malloc(MAX_PATH);
if (!binaryAppender->FileName)
return FALSE;
- sprintf_s(binaryAppender->FileName, MAX_PATH, "%" PRIu32 ".wlog", GetCurrentProcessId());
+ (void)sprintf_s(binaryAppender->FileName, MAX_PATH, "%" PRIu32 ".wlog",
+ GetCurrentProcessId());
}
if (!binaryAppender->FilePath)
@@ -95,7 +96,7 @@ static BOOL WLog_BinaryAppender_Close(wLog* log, wLogAppender* appender)
return TRUE;
if (binaryAppender->FileDescriptor)
- fclose(binaryAppender->FileDescriptor);
+ (void)fclose(binaryAppender->FileDescriptor);
binaryAppender->FileDescriptor = NULL;
diff --git a/winpr/libwinpr/utils/wlog/ConsoleAppender.c b/winpr/libwinpr/utils/wlog/ConsoleAppender.c
index 0a50ef694..ad8b5e4f6 100644
--- a/winpr/libwinpr/utils/wlog/ConsoleAppender.c
+++ b/winpr/libwinpr/utils/wlog/ConsoleAppender.c
@@ -131,7 +131,7 @@ static BOOL WLog_ConsoleAppender_WriteMessage(wLog* log, wLogAppender* appender,
}
if (message->Level != WLOG_OFF)
- fprintf(fp, "%s%s\n", message->PrefixString, message->TextString);
+ (void)fprintf(fp, "%s%s\n", message->PrefixString, message->TextString);
#endif
return TRUE;
}
diff --git a/winpr/libwinpr/utils/wlog/DataMessage.c b/winpr/libwinpr/utils/wlog/DataMessage.c
index 512fddd23..f1aa4c118 100644
--- a/winpr/libwinpr/utils/wlog/DataMessage.c
+++ b/winpr/libwinpr/utils/wlog/DataMessage.c
@@ -43,6 +43,6 @@ BOOL WLog_DataMessage_Write(const char* filename, const void* data, size_t lengt
if (fwrite(data, length, 1, fp) != 1)
ret = FALSE;
- fclose(fp);
+ (void)fclose(fp);
return ret;
}
diff --git a/winpr/libwinpr/utils/wlog/FileAppender.c b/winpr/libwinpr/utils/wlog/FileAppender.c
index 7afc658cf..9a896f9dc 100644
--- a/winpr/libwinpr/utils/wlog/FileAppender.c
+++ b/winpr/libwinpr/utils/wlog/FileAppender.c
@@ -81,7 +81,7 @@ static BOOL WLog_FileAppender_Open(wLog* log, wLogAppender* appender)
if (!fileAppender->FileName)
return FALSE;
- sprintf_s(fileAppender->FileName, MAX_PATH, "%" PRIu32 ".log", GetCurrentProcessId());
+ (void)sprintf_s(fileAppender->FileName, MAX_PATH, "%" PRIu32 ".log", GetCurrentProcessId());
}
if (!fileAppender->FullFileName)
@@ -121,7 +121,7 @@ static BOOL WLog_FileAppender_Close(wLog* log, wLogAppender* appender)
if (!fileAppender->FileDescriptor)
return TRUE;
- fclose(fileAppender->FileDescriptor);
+ (void)fclose(fileAppender->FileDescriptor);
fileAppender->FileDescriptor = NULL;
return TRUE;
}
@@ -143,8 +143,8 @@ static BOOL WLog_FileAppender_WriteMessage(wLog* log, wLogAppender* appender, wL
message->PrefixString = prefix;
WLog_Layout_GetMessagePrefix(log, appender->Layout, message);
- fprintf(fp, "%s%s\n", message->PrefixString, message->TextString);
- fflush(fp); /* slow! */
+ (void)fprintf(fp, "%s%s\n", message->PrefixString, message->TextString);
+ (void)fflush(fp); /* slow! */
return TRUE;
}
diff --git a/winpr/libwinpr/utils/wlog/JournaldAppender.c b/winpr/libwinpr/utils/wlog/JournaldAppender.c
index 504108bbb..16395a6e7 100644
--- a/winpr/libwinpr/utils/wlog/JournaldAppender.c
+++ b/winpr/libwinpr/utils/wlog/JournaldAppender.c
@@ -104,7 +104,7 @@ static BOOL WLog_JournaldAppender_WriteMessage(wLog* log, wLogAppender* appender
case WLOG_OFF:
return TRUE;
default:
- fprintf(stderr, "%s: unknown level %" PRIu32 "\n", __func__, message->Level);
+ (void)fprintf(stderr, "%s: unknown level %" PRIu32 "\n", __func__, message->Level);
return FALSE;
}
@@ -112,7 +112,8 @@ static BOOL WLog_JournaldAppender_WriteMessage(wLog* log, wLogAppender* appender
WLog_Layout_GetMessagePrefix(log, appender->Layout, message);
if (message->Level != WLOG_OFF)
- fprintf(journaldAppender->stream, formatStr, message->PrefixString, message->TextString);
+ (void)fprintf(journaldAppender->stream, formatStr, message->PrefixString,
+ message->TextString);
return TRUE;
}
@@ -162,7 +163,7 @@ static void WLog_JournaldAppender_Free(wLogAppender* appender)
{
journaldAppender = (wLogJournaldAppender*)appender;
if (journaldAppender->stream)
- fclose(journaldAppender->stream);
+ (void)fclose(journaldAppender->stream);
free(journaldAppender->identifier);
free(journaldAppender);
}
diff --git a/winpr/libwinpr/utils/wlog/Layout.c b/winpr/libwinpr/utils/wlog/Layout.c
index 4813aa965..faf97c072 100644
--- a/winpr/libwinpr/utils/wlog/Layout.c
+++ b/winpr/libwinpr/utils/wlog/Layout.c
@@ -75,7 +75,7 @@ static void WLog_PrintMessagePrefixVA(wLog* log, wLogMessage* message,
WINPR_FORMAT_ARG const char* format, va_list args)
{
WINPR_ASSERT(message);
- vsnprintf(message->PrefixString, WLOG_MAX_PREFIX_SIZE - 1, format, args);
+ (void)vsnprintf(message->PrefixString, WLOG_MAX_PREFIX_SIZE - 1, format, args);
}
WINPR_ATTR_FORMAT_ARG(3, 4)
@@ -98,13 +98,13 @@ static const char* get_tid(void* arg)
#else
tid = (size_t)GetCurrentThreadId();
#endif
- sprintf(str, "%08" PRIxz, tid);
+ (void)sprintf(str, "%08" PRIxz, tid);
return str;
}
static BOOL log_invalid_fmt(const char* what)
{
- fprintf(stderr, "Invalid format string '%s'\n", what);
+ (void)fprintf(stderr, "Invalid format string '%s'\n", what);
return FALSE;
}
@@ -113,10 +113,10 @@ static BOOL check_and_log_format_size(char* format, size_t size, size_t index, s
/* format string must be '\0' terminated, so abort at size - 1 */
if (index + add + 1 >= size)
{
- fprintf(stderr,
- "Format string too long ['%s', max %" PRIuz ", used %" PRIuz ", adding %" PRIuz
- "]\n",
- format, size, index, add);
+ (void)fprintf(stderr,
+ "Format string too long ['%s', max %" PRIuz ", used %" PRIuz
+ ", adding %" PRIuz "]\n",
+ format, size, index, add);
return FALSE;
}
return TRUE;
diff --git a/winpr/libwinpr/utils/wlog/Message.c b/winpr/libwinpr/utils/wlog/Message.c
index bedb5edbb..ab3b5afed 100644
--- a/winpr/libwinpr/utils/wlog/Message.c
+++ b/winpr/libwinpr/utils/wlog/Message.c
@@ -51,9 +51,9 @@ char* WLog_Message_GetOutputFileName(int id, const char* ext)
ProcessId = GetCurrentProcessId();
if (id >= 0)
- sprintf_s(FileName, 256, "%" PRIu32 "-%d.%s", ProcessId, id, ext);
+ (void)sprintf_s(FileName, 256, "%" PRIu32 "-%d.%s", ProcessId, id, ext);
else
- sprintf_s(FileName, 256, "%" PRIu32 ".%s", ProcessId, ext);
+ (void)sprintf_s(FileName, 256, "%" PRIu32 ".%s", ProcessId, ext);
FullFileName = GetCombinedPath(FilePath, FileName);
diff --git a/winpr/libwinpr/utils/wlog/PacketMessage.c b/winpr/libwinpr/utils/wlog/PacketMessage.c
index 17df1ece6..793703f9a 100644
--- a/winpr/libwinpr/utils/wlog/PacketMessage.c
+++ b/winpr/libwinpr/utils/wlog/PacketMessage.c
@@ -217,7 +217,7 @@ wPcap* Pcap_Open(char* name, BOOL write)
out_fail:
if (pcap_fp)
- fclose(pcap_fp);
+ (void)fclose(pcap_fp);
free(pcap);
return NULL;
}
@@ -234,7 +234,7 @@ void Pcap_Flush(wPcap* pcap)
pcap->record = pcap->record->next;
}
- fflush(pcap->fp);
+ (void)fflush(pcap->fp);
return;
}
@@ -244,7 +244,7 @@ void Pcap_Close(wPcap* pcap)
return;
Pcap_Flush(pcap);
- fclose(pcap->fp);
+ (void)fclose(pcap->fp);
free(pcap);
}
@@ -467,6 +467,6 @@ BOOL WLog_PacketMessage_Write(wPcap* pcap, void* data, size_t length, DWORD flag
!WLog_PacketMessage_Write_IPv4Header(pcap, &ipv4) ||
!WLog_PacketMessage_Write_TcpHeader(pcap, &tcp) || !Pcap_Write_RecordContent(pcap, &record))
return FALSE;
- fflush(pcap->fp);
+ (void)fflush(pcap->fp);
return TRUE;
}
diff --git a/winpr/libwinpr/utils/wlog/wlog.c b/winpr/libwinpr/utils/wlog/wlog.c
index 4f064ffb0..5fc21bc56 100644
--- a/winpr/libwinpr/utils/wlog/wlog.c
+++ b/winpr/libwinpr/utils/wlog/wlog.c
@@ -132,7 +132,7 @@ static BOOL CALLBACK WLog_InitializeRoot(PINIT_ONCE InitOnce, PVOID Parameter, P
if (GetEnvironmentVariableA(appender, env, nSize) != nSize - 1)
{
- fprintf(stderr, "%s environment variable modified in my back", appender);
+ (void)fprintf(stderr, "%s environment variable modified in my back", appender);
free(env);
goto fail;
}
@@ -166,7 +166,7 @@ static BOOL CALLBACK WLog_InitializeRoot(PINIT_ONCE InitOnce, PVOID Parameter, P
if (!WLog_ParseFilters(g_RootLog))
goto fail;
- atexit(WLog_Uninit_);
+ (void)atexit(WLog_Uninit_);
return TRUE;
fail:
@@ -868,7 +868,7 @@ wLog* WLog_New(LPCSTR name, wLog* rootLogger)
if (GetEnvironmentVariableA(level, env, nSize) != nSize - 1)
{
- fprintf(stderr, "%s environment variable changed in my back !\n", level);
+ (void)fprintf(stderr, "%s environment variable changed in my back !\n", level);
free(env);
goto out_fail;
}
diff --git a/winpr/test/TestIntrinsics.c b/winpr/test/TestIntrinsics.c
index 2198d6763..e9a657bb1 100644
--- a/winpr/test/TestIntrinsics.c
+++ b/winpr/test/TestIntrinsics.c
@@ -52,31 +52,31 @@ static int test_lzcnt(void)
{
if (lzcnt_s(0x1) != 31)
{
- fprintf(stderr, "__lzcnt(0x1) != 31: %" PRIu32 "\n", __lzcnt(0x1));
+ (void)fprintf(stderr, "__lzcnt(0x1) != 31: %" PRIu32 "\n", __lzcnt(0x1));
return -1;
}
if (lzcnt_s(0xFF) != 24)
{
- fprintf(stderr, "__lzcnt(0xFF) != 24\n");
+ (void)fprintf(stderr, "__lzcnt(0xFF) != 24\n");
return -1;
}
if (lzcnt_s(0xFFFF) != 16)
{
- fprintf(stderr, "__lzcnt(0xFFFF) != 16\n");
+ (void)fprintf(stderr, "__lzcnt(0xFFFF) != 16\n");
return -1;
}
if (lzcnt_s(0xFFFFFF) != 8)
{
- fprintf(stderr, "__lzcnt(0xFFFFFF) != 8\n");
+ (void)fprintf(stderr, "__lzcnt(0xFFFFFF) != 8\n");
return -1;
}
if (lzcnt_s(0xFFFFFFFF) != 0)
{
- fprintf(stderr, "__lzcnt(0xFFFFFFFF) != 0\n");
+ (void)fprintf(stderr, "__lzcnt(0xFFFFFFFF) != 0\n");
return -1;
}
@@ -87,19 +87,19 @@ static int test_lzcnt16(void)
{
if (__lzcnt16(0x1) != 15)
{
- fprintf(stderr, "__lzcnt16(0x1) != 15\n");
+ (void)fprintf(stderr, "__lzcnt16(0x1) != 15\n");
return -1;
}
if (__lzcnt16(0xFF) != 8)
{
- fprintf(stderr, "__lzcnt16(0xFF) != 8\n");
+ (void)fprintf(stderr, "__lzcnt16(0xFF) != 8\n");
return -1;
}
if (__lzcnt16(0xFFFF) != 0)
{
- fprintf(stderr, "__lzcnt16(0xFFFF) != 0\n");
+ (void)fprintf(stderr, "__lzcnt16(0xFFFF) != 0\n");
return -1;
}
diff --git a/winpr/tools/hash-cli/hash.c b/winpr/tools/hash-cli/hash.c
index f1e9261fd..5aed55bc0 100644
--- a/winpr/tools/hash-cli/hash.c
+++ b/winpr/tools/hash-cli/hash.c
@@ -174,7 +174,7 @@ int main(int argc, char* argv[])
if (!NTOWFv2A(Password, (UINT32)PasswordLength, User, (UINT32)UserLength, Domain,
(UINT32)DomainLength, NtHash))
{
- fprintf(stderr, "Hash creation failed\n");
+ (void)fprintf(stderr, "Hash creation failed\n");
return 1;
}
}
@@ -182,7 +182,7 @@ int main(int argc, char* argv[])
{
if (!NTOWFv1A(Password, (UINT32)PasswordLength, NtHash))
{
- fprintf(stderr, "Hash creation failed\n");
+ (void)fprintf(stderr, "Hash creation failed\n");
return 1;
}
}
diff --git a/winpr/tools/makecert/makecert.c b/winpr/tools/makecert/makecert.c
index 0929c1d56..e6fe0c759 100644
--- a/winpr/tools/makecert/makecert.c
+++ b/winpr/tools/makecert/makecert.c
@@ -161,8 +161,8 @@ static int makecert_print_command_line_help(COMMAND_LINE_ARGUMENT_A* args, int a
if (!str)
return -1;
- sprintf_s(str, length + 1, "%s %s", arg->Name, arg->Format);
- printf("%-20s", str);
+ (void)sprintf_s(str, length + 1, "%s %s", arg->Name, arg->Format);
+ (void)printf("%-20s", str);
free(str);
}
else
@@ -479,7 +479,7 @@ int makecert_context_output_certificate_file(MAKECERT_CONTEXT* context, const ch
else
goto out_fail;
- sprintf_s(filename, length + 8, "%s.%s", context->output_file, ext);
+ (void)sprintf_s(filename, length + 8, "%s.%s", context->output_file, ext);
if (path)
fullpath = GetCombinedPath(path, filename);
@@ -594,7 +594,7 @@ out_fail:
BIO_free_all(bio);
if (fp)
- fclose(fp);
+ (void)fclose(fp);
free(x509_str);
free(filename);
@@ -638,7 +638,7 @@ int makecert_context_output_private_key_file(MAKECERT_CONTEXT* context, const ch
if (!filename)
return -1;
- sprintf_s(filename, length + 8, "%s.key", context->output_file);
+ (void)sprintf_s(filename, length + 8, "%s.key", context->output_file);
if (path)
fullpath = GetCombinedPath(path, filename);
@@ -675,7 +675,7 @@ int makecert_context_output_private_key_file(MAKECERT_CONTEXT* context, const ch
out_fail:
if (fp)
- fclose(fp);
+ (void)fclose(fp);
BIO_free_all(bio);
free(x509_str);