github/FreeRDP
7
0
Fork 0
mirror of https://github.com/FreeRDP/FreeRDP.git synced 2025-06-03 00:00:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[channels,rdpdr] improve logging

Browse Source 
* remove error logging in success path
* downgrade non fatal errror message to warning
This commit is contained in:
akallabeth 2025-04-11 09:13:44 +02:00
parent 6d8d5e3ebe
commit b24d13a825
No known key found for this signature in database
GPG Key ID: A49454A3FC909FD5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
channels/rdpdr/client/rdpdr_main.c
View File

@ -1494,7 +1494,7 @@ static UINT dummy_irp_response(rdpdrPlugin* rdpdr, wStream* s)
const uint32_t FileId = Stream_Get_UINT32(s); /* FileId (4 bytes) */ const uint32_t FileId = Stream_Get_UINT32(s); /* FileId (4 bytes) */
const uint32_t CompletionId = Stream_Get_UINT32(s); /* CompletionId (4 bytes) */ const uint32_t CompletionId = Stream_Get_UINT32(s); /* CompletionId (4 bytes) */
WLog_Print(rdpdr->log, WLOG_ERROR, WLog_Print(rdpdr->log, WLOG_WARN,
"Dummy response {DeviceId=%" PRIu32 ", FileId=%" PRIu32 ", CompletionId=%" PRIu32 "Dummy response {DeviceId=%" PRIu32 ", FileId=%" PRIu32 ", CompletionId=%" PRIu32
"}", "}",
DeviceId, FileId, CompletionId); DeviceId, FileId, CompletionId);
@ -1521,13 +1521,13 @@ static UINT rdpdr_process_irp(rdpdrPlugin* rdpdr, wStream* s)
if (!irp) if (!irp)
{ {
WLog_Print(rdpdr->log, WLOG_ERROR, "irp_new failed with %" PRIu32 "!", error); if ((error == CHANNEL_RC_OK) ||
(error == ERROR_DEV_NOT_EXIST && rdpdr->ignoreInvalidDevices))
if (error == CHANNEL_RC_OK || (error == ERROR_DEV_NOT_EXIST && rdpdr->ignoreInvalidDevices))
{ {
return dummy_irp_response(rdpdr, s); return dummy_irp_response(rdpdr, s);
} }
WLog_Print(rdpdr->log, WLOG_ERROR, "irp_new failed with %" PRIu32 "!", error);
return error; return error;
} }