github/FreeRDP
7
0
Fork 0
mirror of https://github.com/FreeRDP/FreeRDP.git synced 2025-06-03 00:00:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mkstemp] set umask

Browse Source
This commit is contained in:
akallabeth 2025-03-11 09:13:22 +01:00
parent 2b26cf74e0
commit ca964f7c7d
No known key found for this signature in database
GPG Key ID: A49454A3FC909FD5
2 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
uwac/libuwac/uwac-os.c
View File

@ -59,6 +59,7 @@
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
#include <sys/epoll.h> #include <sys/epoll.h>
#include <sys/stat.h>
#include <uwac/config.h> #include <uwac/config.h>
@ -178,6 +179,14 @@ int uwac_os_epoll_create_cloexec(void)
return set_cloexec_or_close(fd); return set_cloexec_or_close(fd);
} }
static int secure_mkstemp(char* tmpname)
{
const mode_t mask = umask(S_IRWXU);
int fd = mkstemp(tmpname);
(void)umask(mask);
return fd;
}
static int create_tmpfile_cloexec(char* tmpname) static int create_tmpfile_cloexec(char* tmpname)
{ {
int fd = 0; int fd = 0;
@ -190,7 +199,7 @@ static int create_tmpfile_cloexec(char* tmpname)
unlink(tmpname); unlink(tmpname);
#else #else
fd = mkstemp(tmpname); fd = secure_mkstemp(tmpname);
if (fd >= 0) if (fd >= 0)
{ {

20
winpr/libwinpr/file/test/TestFileDeleteFile.c
View File

@ -5,6 +5,22 @@
#include <winpr/file.h> #include <winpr/file.h>
#include <winpr/windows.h> #include <winpr/windows.h>
#if !defined(_WIN32)
#include <sys/stat.h>
#endif
static int secure_mkstemp(char* tmpname)
{
#if !defined(_WIN32)
const mode_t mask = umask(S_IRWXU);
#endif
int fd = mkstemp(tmpname);
#if !defined(_WIN32)
(void)umask(mask);
#endif
return fd;
}
int TestFileDeleteFile(int argc, char* argv[]) int TestFileDeleteFile(int argc, char* argv[])
{ {
BOOL rc = FALSE; BOOL rc = FALSE;
@ -28,7 +44,7 @@ int TestFileDeleteFile(int argc, char* argv[])
if (rc) if (rc)
return -1; return -1;
fd = mkstemp(validA); fd = secure_mkstemp(validA);
if (fd < 0) if (fd < 0)
return -1; return -1;
@ -36,7 +52,7 @@ int TestFileDeleteFile(int argc, char* argv[])
if (!rc) if (!rc)
return -1; return -1;
fd = mkstemp(validW); fd = secure_mkstemp(validW);
if (fd < 0) if (fd < 0)
return -1; return -1;