akallabeth
74cd8d8fe0
[freerdp,warnings] fix -Wunused-parameter
2025-02-13 15:53:54 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
Armin Novak
6e6559c41a
[settings] fix type mismatch warnings
2023-11-24 14:54:56 +01:00
akallabeth
32b60ae438
[pointer] unify mouse pointer settings
2023-07-03 10:00:29 +02:00
Armin Novak
a4c6b36a19
[build] fix memory sanitizer stack frame warnings
2023-06-07 09:14:45 +02:00
Pascal Nowack
8362b3707e
pointer: Rename position to hotspot position in Color Pointer Update
...
The attributes xPos and yPos for a Color Pointer Update are confusing,
as they may be confused with the xPos and yPos of the pointer bitmap on
the actual screen.
Rename these attributes to what they actually represent, and that is the
hotspot position.
xPos and yPos are still members of the hotspot. However, hotSpotX and
hotSpotY are much more clearer.
In addition to that, the Large Pointer Update uses the same names for
the hotspot coordinates.
2023-04-14 08:31:20 +02:00
akallabeth
adce7378c3
[core,cache] make protocol caches private
...
most protocol internal caches do not need to be exposed. this reduces
the public API and allows us to more easily improve/change this during a
release cycle
2023-02-27 17:31:52 +01:00
Armin Novak
b0c924a98e
[core,cache] fixed default pointer and bitmap new
...
do not overwrite pointer or bitmap data in New callback
2023-01-10 17:38:00 +01:00
akallabeth
de175b7f38
[cache,pointer] ignore pointer cache index violations
...
If a pointer cache index is out of range for the corresponding size
announced by the capability but within range of the total cache size
only print a warning but do not abort.
2022-12-06 09:08:12 +01:00
akallabeth
6e82adea17
[cache,pointer] Fixed cache size checks
...
PointerCache and ColorPointerCache can be of different size
2022-12-06 09:08:12 +01:00
akallabeth
296fe9cfdb
[core,pointer] improve logging
2022-11-22 15:30:31 +01:00
akallabeth
bbbe38c65d
Fixed pointer cache
2022-06-23 07:45:55 +02:00
akallabeth
3d9c972d5c
Replace direct rdpSettings access with getter/setter ( #7867 )
...
* Replace direct rdpSettings access with getter/setter
* Fixed xf_gdi_update_screen const warning
2022-05-02 10:55:44 +02:00
akallabeth
0422cf9892
Fixed invalid argument types
2022-04-29 14:38:41 +02:00
akallabeth
ec699f6c75
scanbuild fixes
2022-04-28 12:37:19 +02:00
Armin Novak
4d03d7c0bf
Freerdp remove #ifdef HAVE_CONFIG_H
2022-03-03 11:26:48 +01:00
Armin Novak
b2ad47a809
Reorganized FreeRDP headers
2022-03-03 11:26:48 +01:00
akallabeth
1ca7e1f7a0
Added option to disable graphics decoding in client code path
2021-09-20 10:59:59 +02:00
akallabeth
1904020d7f
Some code cleanups and WINPR_ASSERT ( #7281 )
2021-09-10 09:06:35 +02:00
Armin Novak
85f1d46eab
Fixed cache issues
...
* Use rdpContext as reference instance
* WINPR_ASSERT what is not otherwise checked
2021-09-09 08:53:20 +02:00
bolt
03ced3d8f0
Add support for -grab-mouse, to prevent the client from moving the user's pointer
2020-11-20 09:40:00 +01:00
akallabeth
dfed4b3b24
Refactored pointer and/xor data copying
...
Using unified function upate_pointer_copy_andxor to copy now.
2020-04-22 14:21:47 +02:00
Armin Novak
182d0ce548
Added RDP 10.7 large pointer support
...
* Implements [MS-RDPBCGR] version 51 large pointer support.
* Logs unknown large pointer capability flags as warning.
Signed-off-by: Armin Novak <armin.novak@thincast.com>
2019-12-19 09:53:40 +01:00
Armin Novak
72ca88f49c
Reformatted to new style
2019-11-07 10:53:54 +01:00
Bernhard Miklautz
7290e3f2b0
fix [cache/pointer]: add missing callback checks
2018-10-19 11:13:21 +02:00
Bernhard Miklautz
e114ee44e4
new [cache/pointer]: don't require pointer functions to be set
...
This as cleanup/rework of PR #4581 .
2018-10-19 10:14:24 +02:00
Ondrej Holy
99c15e5339
cache: Fix wrong condition found by covscan
...
copy_paste_error: "xorMaskData" in "pointer_color->xorMaskData" looks like a copy-paste error.
2018-08-22 13:35:43 +02:00
Armin Novak
e5767f07ac
Refactored order updates
...
Unified order creation/copy/delete to avoid memory leaks.
2018-05-02 08:54:21 +02:00
Mariusz Zaborski
0e25335c8f
Don't assume that the pointer function are set.
2018-04-11 16:12:39 +02:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Armin Novak
bc69730863
Fixed memory leak in pointer free.
2016-10-10 10:42:14 +02:00
Armin Novak
a978ccc0bb
Added argument checks.
2016-10-06 13:43:07 +02:00
Armin Novak
9d5ca34d0d
Fixed pointer initialisation for X11.
2016-10-06 13:43:02 +02:00
Armin Novak
df35c135d1
Fixed color conversion, unified GFX and updated API.
2016-10-06 13:42:58 +02:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
Bernhard Miklautz
515502ffa5
change return types of callbacks to BOOL
...
* change all client/server callbacks to BOOL
* update all clients accordingly
* add multiple return value checks
* small fixes
2015-04-21 14:18:07 +02:00
Bernhard Miklautz
d625edbe97
gfx/pointer: add support to set pointer
...
Extend rdp_pointer with function SetPosition. Can then be used by
clients support setting pointer by server which might be used in
shadowing scenarios.
2015-02-02 10:57:31 +01:00
Armin Novak
2f519d7f16
Replaced logging in libfreerdp with wlog defines.
2014-09-15 08:48:46 +02:00
Armin Novak
f4c133eaf8
Replaced custom logging mechanism with WLog wrapper.
2014-08-07 16:51:24 +02:00
Bernhard Miklautz
1c2506f937
pointer cache: fixed double free
2013-06-28 15:17:37 +02:00
Hardening
7701c9d934
Replace printf(...) by fprintf(stderr, ...)
2013-03-28 23:06:34 +01:00
Marc-André Moreau
8c8a82c31f
libfreerdp-utils: purge old STREAM utils
2013-03-21 16:45:25 -04:00
Marc-André Moreau
a1f23d0f97
libfreerdp-core: cleanup memory management of secondary orders
2013-01-28 18:42:32 -05:00
Marc-André Moreau
8a32de3801
libfreerdp: purged source tree from deprecated memory utils
2012-11-21 21:22:06 -05:00
Marc-André Moreau
5e77cefb08
libfreerdp-utils: removed part of the deprecated calls to xzalloc
2012-11-19 23:49:08 -05:00
Marc-André Moreau
6427c9dd90
libfreerdp-core: rdpSettings refactoring (part 2)
2012-11-07 15:13:14 -05:00
Marc-André Moreau
9d064171a7
freerdp: get rid of old types
2012-10-09 03:26:39 -04:00
