akallabeth
41b0598fc1
[warnings] eliminate dead code
2025-03-04 09:57:46 +01:00
akallabeth
6d541c8691
[warnings] eliminate dead code
2025-03-04 09:53:05 +01:00
Armin Novak
f24a562f1e
[utils,smartcard] check output buffer length
...
check the resulting length to the one preallocated.
2025-02-26 18:24:51 +01:00
akallabeth
74cd8d8fe0
[freerdp,warnings] fix -Wunused-parameter
2025-02-13 15:53:54 +01:00
akallabeth
5b1c254f2d
[utils,smartcard] fix return checks for SCardListReaders
2025-02-13 12:00:12 +01:00
akallabeth
25b5dec23d
[utils,smartcard] return proper list for smartcard listing
2025-02-10 17:32:12 +01:00
akallabeth
44f5b6c409
[warnings] fix various clang warnings
2025-02-04 11:22:00 +01:00
akallabeth
0354dd33e1
[utils,passphrase] fix missing include
2025-01-31 12:17:02 +01:00
akallabeth
ea2022b76b
[clang,tidy] fix warnings
2025-01-15 09:32:52 +01:00
akallabeth
3092313d49
[channes,rdpdr] use NTSTATUS for IoStatus
...
the IoStatus will hold NTSTATUS values but is defined unsigned in
[MS-RDPEFS] whereas NTSTATUS is defined as signed integer. Ignore the
spec here and just treat it as signed (eliminates warnings and twos
complement will ensure the values are equal in bit representation)
2025-01-07 10:11:21 +01:00
akallabeth
cc934795e4
[warnings] fix integer casting
...
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
25521917e2
[utils,passphrase] allow popen
...
silence clang-analyzer as we require popen for FREERDP_ASKPASS
2024-12-10 18:03:42 +01:00
Armin Novak
cc0e1c0910
[utils,ringbuffer] assert arguments
2024-12-10 11:39:59 +01:00
akallabeth
0780628270
[utils,signal] ignore SIGTSTP
...
Ignore keyboard stop signal, do not quit application.
2024-12-09 13:13:44 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
faae38120c
[cmake,format] reformat all cmake files
2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47
spell check with codespell
2024-11-20 16:53:40 -05:00
akallabeth
38dab4b2ab
[utils,test] fix invalid format string
2024-11-19 17:56:45 +01:00
akallabeth
08839a11de
[utils,passphrase] NULL checks
2024-11-12 16:46:04 +01:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default
2024-10-31 11:42:24 +01:00
akallabeth
6b6ae5fa9d
[utils,helpers] revert removed define
...
the define was conditionally unused. guard it now so it does not show up
as unused
2024-10-31 08:51:55 +01:00
akallabeth
dc76879e0b
[warnings] fix some compiler warnings
...
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
24ab4b297f
[utils,string] fix freerdp_extract_key_value
...
reset errno before strtoul to avoid aborting due to a previous errno
value from a different function call
2024-10-29 16:50:00 +01:00
akallabeth
a3aa01214c
[resource root] unify locations
...
unify resource locations in case WITH_BINARY_VERSIONING is set.
2024-10-25 11:40:40 +02:00
Armin Novak
527db6783b
[cmake] split tests
...
* Keep BUILD_TESTING, but only run tests compatible with API (for
packaging)
* Add BUILD_TESTING_INTERNAL for all tests including internal function
tests that modify API to be run on our CI
2024-10-24 09:45:44 +02:00
akallabeth
f346b94835
replace SIZE_T with size_t
2024-10-17 12:40:22 +02:00
akallabeth
dc8d8553e8
[utils,smartcard] ensure '\0' termination for NDR
...
NDR read functions do not exactly know which kind of string is read and
if it contains a '\0', so ensure that we add one large enought to hold a
unicode '\0'
2024-10-10 16:25:41 +02:00
akallabeth
6c8c67b385
Merge pull request #10677 from akallabeth/int-narrow
...
Int narrow
2024-10-03 21:17:56 +02:00
akallabeth
e13273d94d
[utils,test] fix integer narrow
2024-10-03 18:58:44 +02:00
Martin Fleisz
966ddd13df
Merge pull request #10694 from akallabeth/qa-fixes
...
Qa fixes
2024-10-03 13:09:06 +02:00
Armin Novak
dcdb0bb3b2
[utils,helpers] add a function to get FreeRDP config file paths
2024-10-02 23:28:00 +02:00
akallabeth
fe8555a4fd
[warnings] annotate cert-err34-c
2024-10-01 13:05:36 +02:00
akallabeth
f6eb6ad4d7
[utils,string] add freerdp_extract_key_value
...
* Add new function freerdp_extract_key_value to extract key/value pairs
from a string
* replace all sscanf usages with this new function
2024-10-01 13:05:34 +02:00
akallabeth
574742bae8
[warnings] annotate readability-non-const-parameter
2024-10-01 13:05:19 +02:00
akallabeth
8a0194c105
[clang-tidy] annotate suspicious-memory-comparison
2024-10-01 13:05:11 +02:00
akallabeth
47c5070805
Merge pull request #10635 from akallabeth/initialize-variables
...
Initialize variables
2024-09-30 16:04:20 +02:00
akallabeth
f529345d84
[warnings] fix Wcast-qual
2024-09-30 09:31:36 +02:00
akallabeth
89e6f357b5
[utils,smartcard] fix possible integer overflow
2024-09-24 11:34:02 +02:00
akallabeth
239440e28d
[warnings] remove or comment unused macros
2024-09-20 18:49:38 +02:00
Armin Novak
b4755a58dc
[utils,smartcard] return after free
...
In smartcard_ListReadersA_Call first free up memory and then return in
case of an error
2024-09-18 14:32:45 +02:00
Armin Novak
769b225278
[utils,smartcard] fix size checks
2024-09-18 11:47:02 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174
[return checks] fix use of unicode functions
2024-09-16 06:48:26 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results
2024-09-14 21:29:28 +02:00
akallabeth
70b597ce1e
[utils,passphrase] fix unused result warning
2024-09-14 08:24:32 +02:00
akallabeth
afff514ca7
[compiler] add WINPR_ATTR_MALLOC
...
Add WINPR_ATTR_MALLOC checks to allocating functions to help compilers
find memory leaks or allocation mismatches
2024-09-12 20:09:22 +02:00
akallabeth
fb5934007a
[doxygen] add basic documentation for new API
...
* Add basic documentation for new functions/structs/data types since
3.0.0
2024-09-12 20:09:19 +02:00
akallabeth
62e52b30c8
[utils,passphrase] fix missing char to int cast
2024-09-11 20:49:44 +02:00
akallabeth
798421e883
fix missing static for functions
2024-09-04 22:12:32 +02:00
