akallabeth
3dee8895ec
[rdpdr,hotplug] fix passing of device::Id back to caller
2025-05-22 11:17:21 +02:00
Armin Novak
24ea6414bc
[warnings] fix various compile warnings
2025-05-21 11:05:10 +02:00
Armin Novak
f5924a6556
[channels,rdpdr] expose device add/remove/hotplug
...
* Add RdpdrClientContext to OnChannelConnectedEventHandler
* Expose device register/unregister in RdpdrClientContext
* Expose device hotplug poll function in RdpdrClientContext
2025-05-12 17:27:07 +02:00
akallabeth
06564e4bc2
[core,settings] fix freerdp_device_collection_add
...
* Assert usage of DeviceArray, ensure returned values are != NULL if
within DeviceCount
* Only reset newly allocated DeviceArray members on resize
2025-04-25 10:21:37 +02:00
akallabeth
b24d13a825
[channels,rdpdr] improve logging
...
* remove error logging in success path
* downgrade non fatal errror message to warning
2025-04-11 10:16:39 +02:00
akallabeth
7939a44ce5
[channels,rdpdr] relax state checks for PAKID_CORE_CLIENTID_CONFIRM
...
This missage might be sent before PAKID_CORE_SERVER_CAPABILITY by some
servers. Do accept these.
2025-03-28 09:21:27 +01:00
Armin Novak
f67e3ca7db
[channels,rdpdr] improve log message format
2025-03-26 16:58:11 +01:00
akallabeth
2fb216a198
[channels,rdpdr] replace deprecated mac os API
2025-03-21 11:41:46 +01:00
akallabeth
1a5ba989e8
[warnings] fixed integer casts
2025-03-11 17:23:58 +01:00
Michael Tokarev
19f129654e
spelling: dont
2025-03-06 13:24:29 +03:00
akallabeth
44d5461cd5
[warnings] fix -Wunused-but-set-variable
2025-03-06 07:15:20 +01:00
akallabeth
5386c7b83c
[channels,rdpdr] more logging in server channel
2025-03-05 23:51:33 +01:00
akallabeth
f5c5b98284
[channels,rdpdr] add server side logging
2025-03-05 23:49:01 +01:00
Armin Novak
bf5d672766
[channels,rdpdr] clone key values for device list
...
the supplied key value might be allocated on stack, so create a copy
that is valid as long as the entry.
2025-03-05 16:54:40 +01:00
Armin Novak
420cb16012
[ci,alt-arch] deactivate armv6 build
...
The builder fails for unknown reasons with illegal instruction.
Filed an upstream bug report at
https://github.com/uraimo/run-on-arch-action/issues/162 waiting for
a fix.
2025-03-05 16:54:40 +01:00
akallabeth
d4f7fb081b
[warnings] fix -Wunused-function
...
* delete unused functions that are no longer required
* define guard functions only used while debugging
2025-02-27 19:29:46 +01:00
akallabeth
856dd96312
[channel,rdpdr] support general caps V1
...
[MS-RDPEFS] 2.2.2.7.1 General Capability Set (GENERAL_CAPS_SET) requires
that the SpecialTypeDeviceCap element is not available if the version is
GENERAL_CAPABILITY_VERSION_01
2025-02-18 18:40:01 +01:00
akallabeth
2b7d7356c1
[channels,warnings] fix -Wunused-parameter
2025-02-13 15:53:56 +01:00
akallabeth
e7d50d7a70
[channels,rdpdr] handle NULL in rdpdr equal
2025-02-06 11:03:04 +01:00
akallabeth
5fb9f71b3b
[channels,rdpdr] fix int narrowing cast
2025-01-07 21:28:13 +01:00
akallabeth
3092313d49
[channes,rdpdr] use NTSTATUS for IoStatus
...
the IoStatus will hold NTSTATUS values but is defined unsigned in
[MS-RDPEFS] whereas NTSTATUS is defined as signed integer. Ignore the
spec here and just treat it as signed (eliminates warnings and twos
complement will ensure the values are equal in bit representation)
2025-01-07 10:11:21 +01:00
akallabeth
4030eafd15
[channels,rdpdr] fix stream_write sign
2024-12-29 10:23:23 +01:00
akallabeth
be3ba1c425
[warnings,channels] fix integer casts
2024-12-25 13:29:07 +01:00
akallabeth
ac9cf26bce
[cmake] fix define_channel_options
...
* fix usage of default value
* fix defaults of channels
* unify to single CMake function define_channel_options
2024-12-17 16:29:32 +01:00
akallabeth
91ae892f91
[winpr,sysinfo] fix use of GetComputerNameExA
...
The buffer must be large enough to hold MAX_COMPUTERNAME_LENGTH
characters, so the buffer needs to be of size MAX_COMPUTERNAME_LENGTH +
1 or larger to hold the '\0' terminated string.
2024-12-16 17:11:54 +01:00
akallabeth
e375556d07
[winpr,sysinfo] fix GetComputerNameA
...
* Trunctate to at most MAX_COMPUTERNAME_LENGTH characters
* Fix usage of function
2024-12-15 18:09:15 +01:00
akallabeth
344841714c
Merge pull request #10844 from akallabeth/cmake-mulitconfig
...
Cmake multiconfig
2024-12-07 17:43:05 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
ba8fd2ada5
[cmake] force configuration options
...
limit multiconfiguration options to supported types
2024-12-05 09:36:23 +01:00
akallabeth
faae38120c
[cmake,format] reformat all cmake files
2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47
spell check with codespell
2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
cb73d77d6e
Merge pull request #10823 from akallabeth/rdpdr-caps-filter
...
[channels,rdpdr] send only used caps to server
2024-11-08 09:08:32 +01:00
akallabeth
aa371dcdd6
[channels,rdpdr] only reply enabled caps
2024-11-05 19:56:28 +01:00
akallabeth
c4412a92e2
[channels,rdpdr] send only used caps to server
...
* When using RDPDR only send capabilities to server we have activated,
e.g. smartcard, drive, printer, port (serial or parallel) redirection
* Check return value of write functions
2024-11-05 19:44:03 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default
2024-10-31 11:42:24 +01:00
akallabeth
11b7633dc0
[channels] use Stream_BufferAs
...
For WTSVirtualChannelRead and WTSVirtualChannelWrite use Stream_BufferAs
to cast to correct type.
2024-10-01 10:28:13 +02:00
akallabeth
26003e59cc
[va_list] initialize with ={0};
2024-09-24 11:06:18 +02:00
akallabeth
befa4233ad
[warnings] fixed bugprone-not-null-terminated-result
2024-09-16 08:22:42 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
...
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
a4a7019f97
[channels,rdpdr] fix uninitialized warnings
2024-09-15 09:58:41 +02:00
akallabeth
8b6091a007
[winpr,wtsapi] improve API usage
...
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
requierd
2024-09-14 21:29:31 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
edf6ab89f7
[warnings] fix dead store
2024-09-10 14:43:11 +02:00
akallabeth
245afb706c
[function pointers] unify casts with macro
2024-09-04 20:06:45 +02:00
akallabeth
b77d6e8550
[channels] fix function pointer casts
...
* Cast freerdp_load_channel_addin_entry return with a union (removes the
incompatible function pointer cast warnings)
* Typedef function pointers in tables.h
2024-09-03 15:13:58 +02:00
akallabeth
bd637c6cd1
[warnings] fix various clang-tidy warnings
2024-08-29 17:13:50 +02:00
akallabeth
cc626276d0
[warnings] integer cast and checks
2024-08-29 15:49:33 +02:00
