* make deps-update
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* ReourceRequirements -> VolumeResourceRequirements
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* fix calls to controller.Watch()
controller-runtime changed the API!
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* Fix errors with actual openshift/library-go lib
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* make all works now and everything compiles
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* fix "make update-codegen" because generate_groups.sh deprecated
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* run "make generate"
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* fix transfer unittest because of change to controller-runtime
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
---------
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
* Fix progress metric registration and parsing
Use default metric registration. We shouldn't use the controller-runtime
registration as we have no controller here and it will not register the
metric correctly.
Fix the metric parsing to match its new name. Otherwise the DV progress
will not be updated until its 100%.
Regression introduced in #3254
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Add kubevirt_cdi_import_progress_total metric
Use it in the importer instead of kubevirt_cdi_clone_progress_total and
fix metric parsing accordingly.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Move ProgressFromClaim to host-clone
Nobody else is using it.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Add ProgressMetric interface
ProgressReader can now work with either import or clone progress metric.
FIXME: consider removing the direct Add/Get and use only via interface.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Refactor ProgressMetric interface
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Refactor progress parsing
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Refer metric names from the metrics package
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
---------
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* forklift: fix race between prime pvc and pod removal
Because there is time until deletionTimestamp is set on the PVC prime,
and since the populator pod is deleted first we might reconcile again
when the PVC is not yet marked for deletion, causing the populator pod
to be recreated.
This change reorders the operation, to first wait until the PVC is
marked for deletion, and then delete the populator pod.
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
* forklift: add tests
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
---------
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
* clone_progress metric refactor
The clone_progress metric is not in the monitoring package. The metric
is with incorrect name, based on the kubevirt and Prometheus metrics
naming conventions. It's not documented and not located under
/pkg/monitoring. After the code refactoring we should not have
Prometheus metrics in other places in the code, other than the
/monitoring/metrics package, and metrics should be registered using
operator-observability package.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* openstack_populator_progress metric refactor
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* clone_progress metric refactor CR fixes
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* ovirt_progress metric refactor
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Align progress metrics names with linter rules
Also add the metrics to the doc and json generation tools.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
* Remove redundant ListMetrics
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
---------
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
