This change just updates the common package to pass golint. Of course
that has some reaching implications into other packages with renaming of
constants.
I've intentionally kept this patch set to the bare minimum for the lint
test, I do think that we should put some effort into our use of
constants (especially those in common.go) in the future.
Ideally we'd declare constants where they're used, and we wouldn't
export them if they don't need to be. There are some in here that
are only used in one or two packages, and that can be cleaned up pretty
easily however it's likely that there might be plans to use them
elsewhere in the future.
* Make generic function for populating and verifying pvc data
Signed-off-by: David Vossel <davidvossel@gmail.com>
* Add DataVolume PVC source functional tests
Signed-off-by: David Vossel <davidvossel@gmail.com>
* Make DataVolume PVC variable consistent with other sources
Signed-off-by: David Vossel <davidvossel@gmail.com>
* test: fix pvc annotation check
The clone controller uses a slightly different annotation on PVCs. The
test was using the form used by the import controller. Quick fix.
Signed-off-by: Adam Litke <alitke@redhat.com>
* tests: Pods must be polled to determine their node
When checking the node on which a pod is scheduled we must use an
Eventually assertion and poll. Otherwise, tests could flake when pod
scheduling is delayed.
Signed-off-by: Adam Litke <alitke@redhat.com>
- Positive test clone from namespace into same namespace.
- Positive test clone from namespace into other namespace.
Signed-off-by: Alexander Wels <awels@redhat.com>
