/* Copyright 2021 The CDI Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. limitations under the License. See the License for the specific language governing permissions and */ package controller import ( "context" "fmt" "net/url" "reflect" "sort" "strings" "time" "github.com/containers/image/v5/docker/reference" "github.com/go-logr/logr" "github.com/gorhill/cronexpr" imagev1 "github.com/openshift/api/image/v1" "github.com/pkg/errors" "github.com/prometheus/client_golang/prometheus" batchv1 "k8s.io/api/batch/v1" v1beta1 "k8s.io/api/batch/v1beta1" corev1 "k8s.io/api/core/v1" extv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" k8serrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/tools/record" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller" "sigs.k8s.io/controller-runtime/pkg/event" "sigs.k8s.io/controller-runtime/pkg/handler" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/predicate" "sigs.k8s.io/controller-runtime/pkg/reconcile" "sigs.k8s.io/controller-runtime/pkg/source" cdiv1 "kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1" "kubevirt.io/containerized-data-importer/pkg/common" "kubevirt.io/containerized-data-importer/pkg/util" ) const ( prometheusNsLabel = "ns" prometheusCronNameLabel = "cron_name" ) var ( // DataImportCronOutdatedGauge is the metric we use to alert about DataImportCrons failing DataImportCronOutdatedGauge = prometheus.NewGaugeVec( prometheus.GaugeOpts{ Name: "kubevirt_cdi_dataimportcron_outdated", Help: "DataImportCron has an outdated import", }, []string{prometheusNsLabel, prometheusCronNameLabel}, ) ) // DataImportCronReconciler members type DataImportCronReconciler struct { client client.Client uncachedClient client.Client recorder record.EventRecorder scheme *runtime.Scheme log logr.Logger image string pullPolicy string cdiNamespace string installerLabels map[string]string } const ( // AnnSourceDesiredDigest is the digest of the pending updated image AnnSourceDesiredDigest = AnnAPIGroup + "/storage.import.sourceDesiredDigest" // AnnImageStreamDockerRef is the ImageStream Docker reference AnnImageStreamDockerRef = AnnAPIGroup + "/storage.import.imageStreamDockerRef" // AnnNextCronTime is the next time stamp which satisfies the cron expression AnnNextCronTime = AnnAPIGroup + "/storage.import.nextCronTime" // dataImportCronFinalizer ensures CronJob is deleted when DataImportCron is deleted, as there is no cross-namespace OwnerReference dataImportCronFinalizer = "cdi.kubevirt.io/dataImportCronFinalizer" dataImportControllerName = "dataimportcron-controller" digestPrefix = "sha256:" digestDvNameSuffixLength = 12 cronJobUIDSuffixLength = 8 defaultImportsToKeepPerCron = 3 ) // Reconcile loop for DataImportCronReconciler func (r *DataImportCronReconciler) Reconcile(ctx context.Context, req reconcile.Request) (reconcile.Result, error) { dataImportCron := &cdiv1.DataImportCron{} if err := r.client.Get(ctx, req.NamespacedName, dataImportCron); err != nil { if k8serrors.IsNotFound(err) { return reconcile.Result{}, nil } return reconcile.Result{}, err } if dataImportCron.DeletionTimestamp != nil { err := r.cleanup(ctx, dataImportCron) return reconcile.Result{}, err } if err := r.initCron(ctx, dataImportCron); err != nil { return reconcile.Result{}, err } return r.update(ctx, dataImportCron) } func (r *DataImportCronReconciler) initCron(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { if !HasFinalizer(dataImportCron, dataImportCronFinalizer) { crd := &extv1.CustomResourceDefinition{} if err := r.client.Get(context.TODO(), types.NamespacedName{Name: "dataimportcrons.cdi.kubevirt.io"}, crd); err != nil { return err } if crd.DeletionTimestamp != nil { return errors.Errorf("CRD has DeletionTimestamp") } AddFinalizer(dataImportCron, dataImportCronFinalizer) } if isURLSource(dataImportCron) && !r.cronJobExists(ctx, dataImportCron) { cronJob, err := r.newCronJob(dataImportCron) if err != nil { return err } if err := r.client.Create(ctx, cronJob); err != nil { return err } if err := r.client.Create(ctx, r.newInitialJob(dataImportCron, cronJob)); err != nil { return err } } else if isImageStreamSource(dataImportCron) && dataImportCron.Annotations[AnnNextCronTime] == "" { addAnnotation(dataImportCron, AnnNextCronTime, time.Now().Format(time.RFC3339)) } return nil } func (r *DataImportCronReconciler) getImageStream(ctx context.Context, imageStreamName, imageStreamNamespace string) (*imagev1.ImageStream, string, error) { if imageStreamName == "" || imageStreamNamespace == "" { return nil, "", errors.Errorf("Missing ImageStream name or namespace") } imageStream := &imagev1.ImageStream{} name, tag, err := splitImageStreamName(imageStreamName) if err != nil { return nil, "", err } imageStreamNamespacedName := types.NamespacedName{ Namespace: imageStreamNamespace, Name: name, } if err := r.client.Get(ctx, imageStreamNamespacedName, imageStream); err != nil { return nil, "", err } return imageStream, tag, nil } func getImageStreamDigest(imageStream *imagev1.ImageStream, imageStreamTag string) (string, string, error) { if imageStream == nil { return "", "", errors.Errorf("No ImageStream") } tags := imageStream.Status.Tags if len(tags) == 0 { return "", "", errors.Errorf("ImageStream %s has no tags", imageStream.Name) } tagIdx := 0 if len(imageStreamTag) > 0 { tagIdx = -1 for i, tag := range tags { if tag.Tag == imageStreamTag { tagIdx = i break } } } if tagIdx == -1 { return "", "", errors.Errorf("ImageStream %s has no tag %s", imageStream.Name, imageStreamTag) } if len(tags[tagIdx].Items) == 0 { return "", "", errors.Errorf("ImageStream %s tag %s has no items", imageStream.Name, imageStreamTag) } return tags[tagIdx].Items[0].Image, tags[tagIdx].Items[0].DockerImageReference, nil } func splitImageStreamName(imageStreamName string) (string, string, error) { if subs := strings.Split(imageStreamName, ":"); len(subs) == 1 { return imageStreamName, "", nil } else if len(subs) == 2 && len(subs[0]) > 0 && len(subs[1]) > 0 { return subs[0], subs[1], nil } return "", "", errors.Errorf("Illegal ImageStream name %s", imageStreamName) } func (r *DataImportCronReconciler) pollImageStreamDigest(ctx context.Context, dataImportCron *cdiv1.DataImportCron) (reconcile.Result, error) { if nextTimeStr := dataImportCron.Annotations[AnnNextCronTime]; nextTimeStr != "" { nextTime, err := time.Parse(time.RFC3339, nextTimeStr) if err != nil { return reconcile.Result{}, err } if nextTime.Before(time.Now()) { if err := r.updateImageStreamDesiredDigest(ctx, dataImportCron); err != nil { return reconcile.Result{}, err } } } return r.setNextCronTime(dataImportCron) } func (r *DataImportCronReconciler) setNextCronTime(dataImportCron *cdiv1.DataImportCron) (reconcile.Result, error) { now := time.Now() expr, err := cronexpr.Parse(dataImportCron.Spec.Schedule) if err != nil { return reconcile.Result{}, err } nextTime := expr.Next(now) diffSec := time.Duration(nextTime.Sub(now).Seconds()) + 1 res := reconcile.Result{Requeue: true, RequeueAfter: diffSec * time.Second} addAnnotation(dataImportCron, AnnNextCronTime, nextTime.Format(time.RFC3339)) r.log.Info("setNextCronTime", "nextTime", nextTime) return res, err } func isImageStreamSource(dataImportCron *cdiv1.DataImportCron) bool { regSource, err := getCronRegistrySource(dataImportCron) return err == nil && regSource.ImageStream != nil } func isURLSource(dataImportCron *cdiv1.DataImportCron) bool { regSource, err := getCronRegistrySource(dataImportCron) return err == nil && regSource.URL != nil } func getCronRegistrySource(cron *cdiv1.DataImportCron) (*cdiv1.DataVolumeSourceRegistry, error) { source := cron.Spec.Template.Spec.Source if source == nil || source.Registry == nil { return nil, errors.Errorf("Cron with no registry source %s", cron.Name) } return source.Registry, nil } func (r *DataImportCronReconciler) update(ctx context.Context, dataImportCron *cdiv1.DataImportCron) (reconcile.Result, error) { log := r.log.WithName("update") res := reconcile.Result{} now := metav1.Now() dataImportCron.Status.LastExecutionTimestamp = &now importSucceeded := false imports := dataImportCron.Status.CurrentImports if imports != nil { // Get the currently imported DataVolume dataVolume := &cdiv1.DataVolume{} if err := r.client.Get(ctx, types.NamespacedName{Namespace: dataImportCron.Namespace, Name: imports[0].DataVolumeName}, dataVolume); err != nil { if !k8serrors.IsNotFound(err) { return res, err } log.Info("DataVolume not found for some reason, so let's recreate it", "name", imports[0].DataVolumeName) if err := r.createImportDataVolume(ctx, dataImportCron); err != nil { return res, err } } switch dataVolume.Status.Phase { case cdiv1.Succeeded: importSucceeded = true if err := r.updateDataImportCronOnSuccess(ctx, dataImportCron); err != nil { return res, err } updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronProgressing, corev1.ConditionFalse, "No current import", noImport) if err := r.garbageCollectOldImports(ctx, dataImportCron); err != nil { return res, err } case cdiv1.ImportScheduled: updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronProgressing, corev1.ConditionFalse, "Import is scheduled", scheduled) case cdiv1.ImportInProgress: updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronProgressing, corev1.ConditionTrue, "Import is progressing", inProgress) default: dvPhase := string(dataVolume.Status.Phase) updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronProgressing, corev1.ConditionFalse, fmt.Sprintf("Import DataVolume phase %s", dvPhase), dvPhase) } } else { updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronProgressing, corev1.ConditionFalse, "No current import", noImport) } if err := r.updateDataSource(ctx, dataImportCron); err != nil { return res, err } // We use the poller returned reconcile.Result for RequeueAfter if needed var err error if isImageStreamSource(dataImportCron) { res, err = r.pollImageStreamDigest(ctx, dataImportCron) if err != nil { return res, err } } desiredDigest := dataImportCron.Annotations[AnnSourceDesiredDigest] digestUpdated := desiredDigest != "" && (len(imports) == 0 || desiredDigest != imports[0].Digest) if digestUpdated { updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronUpToDate, corev1.ConditionFalse, "Source digest updated since last import", outdated) if importSucceeded || len(imports) == 0 { if err := r.createImportDataVolume(ctx, dataImportCron); err != nil { return res, err } } } else if importSucceeded { updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronUpToDate, corev1.ConditionTrue, "Latest import is up to date", upToDate) } else if len(imports) > 0 { updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronUpToDate, corev1.ConditionFalse, "Import is progressing", inProgress) } else { updateDataImportCronCondition(dataImportCron, cdiv1.DataImportCronUpToDate, corev1.ConditionFalse, "No source digest", noDigest) } if err := r.client.Update(ctx, dataImportCron); err != nil { return res, err } return res, nil } func (r *DataImportCronReconciler) updateImageStreamDesiredDigest(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { regSource, err := getCronRegistrySource(dataImportCron) if err != nil { return err } if regSource.ImageStream == nil { return nil } imageStream, imageStreamTag, err := r.getImageStream(ctx, *regSource.ImageStream, dataImportCron.Namespace) if err != nil { return err } digest, dockerRef, err := getImageStreamDigest(imageStream, imageStreamTag) if err != nil { return err } if digest != "" && dataImportCron.Annotations[AnnSourceDesiredDigest] != digest { r.log.Info("Updated", "digest", digest, "cron", dataImportCron.Name) addAnnotation(dataImportCron, AnnSourceDesiredDigest, digest) addAnnotation(dataImportCron, AnnImageStreamDockerRef, dockerRef) } return nil } func (r *DataImportCronReconciler) updateDataSource(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { log := r.log.WithName("updateDataSource") dataSourceName := dataImportCron.Spec.ManagedDataSource dataSource := &cdiv1.DataSource{} if err := r.client.Get(ctx, types.NamespacedName{Namespace: dataImportCron.Namespace, Name: dataSourceName}, dataSource); err != nil { if k8serrors.IsNotFound(err) { log.Info("Create DataSource", "name", dataSourceName) dataSource = newDataSource(dataImportCron) if err := r.client.Create(ctx, dataSource); err != nil { return err } } else { return err } } dataSourceCopy := dataSource.DeepCopy() util.SetRecommendedLabels(dataSource, r.installerLabels, common.CDIControllerName) dataSource.Labels[common.DataImportCronLabel] = dataImportCron.Name sourcePVC := dataImportCron.Status.LastImportedPVC if sourcePVC != nil { dataSource.Spec.Source.PVC = sourcePVC } if !reflect.DeepEqual(dataSource, dataSourceCopy) { if err := r.client.Update(ctx, dataSource); err != nil { return err } } return nil } func (r *DataImportCronReconciler) updateDataImportCronOnSuccess(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { if dataImportCron.Status.CurrentImports == nil { return errors.Errorf("No CurrentImports in cron %s", dataImportCron.Name) } sourcePVC := &cdiv1.DataVolumeSourcePVC{ Namespace: dataImportCron.Namespace, Name: dataImportCron.Status.CurrentImports[0].DataVolumeName, } if dataImportCron.Status.LastImportedPVC == nil || *dataImportCron.Status.LastImportedPVC != *sourcePVC { dataImportCron.Status.LastImportedPVC = sourcePVC now := metav1.Now() dataImportCron.Status.LastImportTimestamp = &now } return nil } func (r *DataImportCronReconciler) createImportDataVolume(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { dataSourceName := dataImportCron.Spec.ManagedDataSource digest := dataImportCron.Annotations[AnnSourceDesiredDigest] dvName := createDvName(dataSourceName, digest) dv := r.newSourceDataVolume(dataImportCron, dvName) if err := r.client.Create(ctx, dv); err != nil { if !k8serrors.IsAlreadyExists(err) { return err } if err := r.client.Get(ctx, types.NamespacedName{Namespace: dv.Namespace, Name: dv.Name}, dv); err != nil { return err } // Touch the DV Ready condition heartbeat time, so DV wan't be garbage collected if cond := findConditionByType(cdiv1.DataVolumeReady, dv.Status.Conditions); cond != nil { cond.LastHeartbeatTime = metav1.Now() if err := r.client.Update(ctx, dv); err != nil { return err } } } // Update references to current import dataImportCron.Status.CurrentImports = []cdiv1.ImportStatus{{DataVolumeName: dvName, Digest: digest}} return nil } func (r *DataImportCronReconciler) garbageCollectOldImports(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { if dataImportCron.Spec.GarbageCollect != nil && *dataImportCron.Spec.GarbageCollect != cdiv1.DataImportCronGarbageCollectOutdated { return nil } maxDvs := defaultImportsToKeepPerCron importsToKeep := dataImportCron.Spec.ImportsToKeep if importsToKeep != nil && *importsToKeep >= 0 { maxDvs = int(*importsToKeep) } return r.deleteOldImports(ctx, dataImportCron, maxDvs) } func (r *DataImportCronReconciler) deleteOldImports(ctx context.Context, dataImportCron *cdiv1.DataImportCron, maxDvs int) error { log := r.log.WithName("deleteOldImports") selector, err := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{ MatchLabels: map[string]string{ common.DataImportCronLabel: dataImportCron.Name, }, }) if err != nil { return err } dvList := &cdiv1.DataVolumeList{} if err := r.client.List(ctx, dvList, &client.ListOptions{Namespace: dataImportCron.Namespace, LabelSelector: selector}); err != nil { return err } if len(dvList.Items) <= maxDvs { return nil } sort.Slice(dvList.Items, func(i, j int) bool { getDvTimestamp := func(dv cdiv1.DataVolume) time.Time { if cond := findConditionByType(cdiv1.DataVolumeReady, dv.Status.Conditions); cond != nil { return cond.LastHeartbeatTime.Time } return dv.CreationTimestamp.Time } return getDvTimestamp(dvList.Items[i]).After(getDvTimestamp(dvList.Items[j])) }) for _, dv := range dvList.Items[maxDvs:] { if err := r.client.Delete(ctx, &dv); err != nil { if k8serrors.IsNotFound(err) { log.Info("DataVolume not found for deletion", "name", dv.Name) } else { log.Error(err, "Unable to delete DataVolume", "name", dv.Name) } } else { log.Info("DataVolume deleted", "name", dv.Name) } } return nil } func (r *DataImportCronReconciler) cleanup(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { if !HasFinalizer(dataImportCron, dataImportCronFinalizer) { return nil } // Don't keep alerting over a cron thats being deleted, will get set back to 1 again by reconcile loop if needed. DataImportCronOutdatedGauge.With(getPrometheusCronLabels(dataImportCron)).Set(0) if err := r.deleteJobs(ctx, dataImportCron); err != nil { return err } if dataImportCron.Spec.RetentionPolicy != nil && *dataImportCron.Spec.RetentionPolicy == cdiv1.DataImportCronRetainNone { dataSource := &cdiv1.DataSource{ObjectMeta: metav1.ObjectMeta{Namespace: dataImportCron.Namespace, Name: dataImportCron.Spec.ManagedDataSource}} if err := r.client.Delete(ctx, dataSource); IgnoreNotFound(err) != nil { return err } if err := r.deleteOldImports(ctx, dataImportCron, 0); err != nil { return err } } RemoveFinalizer(dataImportCron, dataImportCronFinalizer) if err := r.client.Update(ctx, dataImportCron); err != nil { return err } return nil } func (r *DataImportCronReconciler) deleteJobs(ctx context.Context, dataImportCron *cdiv1.DataImportCron) error { deletePropagationBackground := metav1.DeletePropagationBackground deleteOpts := &client.DeleteOptions{PropagationPolicy: &deletePropagationBackground} cronJob := &v1beta1.CronJob{ObjectMeta: metav1.ObjectMeta{Namespace: r.cdiNamespace, Name: GetCronJobName(dataImportCron)}} if err := r.client.Delete(ctx, cronJob, deleteOpts); IgnoreNotFound(err) != nil { return err } job := &batchv1.Job{ObjectMeta: metav1.ObjectMeta{Namespace: r.cdiNamespace, Name: GetInitialJobName(dataImportCron)}} if err := r.client.Delete(ctx, job, deleteOpts); IgnoreNotFound(err) != nil { return err } return nil } // NewDataImportCronController creates a new instance of the DataImportCron controller func NewDataImportCronController(mgr manager.Manager, log logr.Logger, importerImage, pullPolicy string, installerLabels map[string]string) (controller.Controller, error) { uncachedClient, err := client.New(mgr.GetConfig(), client.Options{ Scheme: mgr.GetScheme(), Mapper: mgr.GetRESTMapper(), }) if err != nil { return nil, err } reconciler := &DataImportCronReconciler{ client: mgr.GetClient(), uncachedClient: uncachedClient, recorder: mgr.GetEventRecorderFor(dataImportControllerName), scheme: mgr.GetScheme(), log: log.WithName(dataImportControllerName), image: importerImage, pullPolicy: pullPolicy, cdiNamespace: util.GetNamespace(), installerLabels: installerLabels, } dataImportCronController, err := controller.New(dataImportControllerName, mgr, controller.Options{Reconciler: reconciler}) if err != nil { return nil, err } if err := addDataImportCronControllerWatches(mgr, dataImportCronController, log); err != nil { return nil, err } log.Info("Initialized DataImportCron controller") return dataImportCronController, nil } func addDataImportCronControllerWatches(mgr manager.Manager, c controller.Controller, log logr.Logger) error { if err := cdiv1.AddToScheme(mgr.GetScheme()); err != nil { return err } if err := imagev1.AddToScheme(mgr.GetScheme()); err != nil { return err } if err := extv1.AddToScheme(mgr.GetScheme()); err != nil { return err } if err := c.Watch(&source.Kind{Type: &cdiv1.DataImportCron{}}, &handler.EnqueueRequestForObject{}); err != nil { return err } getCronName := func(obj client.Object) string { return obj.GetLabels()[common.DataImportCronLabel] } mapToCron := func(obj client.Object) []reconcile.Request { return []reconcile.Request{{NamespacedName: types.NamespacedName{Name: getCronName(obj), Namespace: obj.GetNamespace()}}} } if err := c.Watch(&source.Kind{Type: &cdiv1.DataVolume{}}, handler.EnqueueRequestsFromMapFunc(mapToCron), predicate.Funcs{ CreateFunc: func(e event.CreateEvent) bool { return false }, UpdateFunc: func(e event.UpdateEvent) bool { return getCronName(e.ObjectNew) != "" }, DeleteFunc: func(e event.DeleteEvent) bool { return getCronName(e.Object) != "" }, }, ); err != nil { return err } // Watch only for DataSource deletion if err := c.Watch(&source.Kind{Type: &cdiv1.DataSource{}}, handler.EnqueueRequestsFromMapFunc(mapToCron), predicate.Funcs{ CreateFunc: func(event.CreateEvent) bool { return false }, UpdateFunc: func(event.UpdateEvent) bool { return false }, DeleteFunc: func(e event.DeleteEvent) bool { return getCronName(e.Object) != "" }, }, ); err != nil { return err } return nil } func (r *DataImportCronReconciler) cronJobExists(ctx context.Context, cron *cdiv1.DataImportCron) bool { var cronJob v1beta1.CronJob cronJobNamespacedName := types.NamespacedName{Namespace: r.cdiNamespace, Name: GetCronJobName(cron)} return r.uncachedClient.Get(ctx, cronJobNamespacedName, &cronJob) == nil } func (r *DataImportCronReconciler) newCronJob(cron *cdiv1.DataImportCron) (*v1beta1.CronJob, error) { regSource, err := getCronRegistrySource(cron) if err != nil { return nil, err } if regSource.URL == nil { return nil, errors.Errorf("No URL source in cron %s", cron.Name) } cdiConfig := &cdiv1.CDIConfig{} if err = r.client.Get(context.TODO(), types.NamespacedName{Name: common.ConfigName}, cdiConfig); err != nil { return nil, err } insecureTLS, err := IsInsecureTLS(*regSource.URL, cdiConfig, r.uncachedClient, r.log) if err != nil { return nil, err } container := corev1.Container{ Name: "cdi-source-update-poller", Image: r.image, Command: []string{ "/usr/bin/cdi-source-update-poller", "-ns", cron.Namespace, "-cron", cron.Name, "-url", *regSource.URL, }, ImagePullPolicy: corev1.PullPolicy(r.pullPolicy), } hasCertConfigMap := regSource.CertConfigMap != nil && *regSource.CertConfigMap != "" if hasCertConfigMap { vm := corev1.VolumeMount{ Name: CertVolName, MountPath: common.ImporterCertDir, } container.VolumeMounts = []corev1.VolumeMount{vm} container.Command = append(container.Command, "-certdir", common.ImporterCertDir) } if regSource.SecretRef != nil && *regSource.SecretRef != "" { container.Env = append(container.Env, corev1.EnvVar{ Name: common.ImporterAccessKeyID, ValueFrom: &corev1.EnvVarSource{ SecretKeyRef: &corev1.SecretKeySelector{ LocalObjectReference: corev1.LocalObjectReference{ Name: *regSource.SecretRef, }, Key: common.KeyAccess, }, }, }, corev1.EnvVar{ Name: common.ImporterSecretKey, ValueFrom: &corev1.EnvVarSource{ SecretKeyRef: &corev1.SecretKeySelector{ LocalObjectReference: corev1.LocalObjectReference{ Name: *regSource.SecretRef, }, Key: common.KeySecret, }, }, }, ) } if insecureTLS { container.Env = append(container.Env, corev1.EnvVar{ Name: common.InsecureTLSVar, Value: "true", }, ) } successfulJobsHistoryLimit := int32(0) failedJobsHistoryLimit := int32(0) ttlSecondsAfterFinished := int32(0) backoffLimit := int32(2) gracePeriodSeconds := int64(0) cronJobName := GetCronJobName(cron) cronJob := &v1beta1.CronJob{ ObjectMeta: metav1.ObjectMeta{ Name: cronJobName, Namespace: r.cdiNamespace, }, Spec: v1beta1.CronJobSpec{ Schedule: cron.Spec.Schedule, ConcurrencyPolicy: v1beta1.ForbidConcurrent, SuccessfulJobsHistoryLimit: &successfulJobsHistoryLimit, FailedJobsHistoryLimit: &failedJobsHistoryLimit, JobTemplate: v1beta1.JobTemplateSpec{ Spec: batchv1.JobSpec{ Template: corev1.PodTemplateSpec{ Spec: corev1.PodSpec{ RestartPolicy: corev1.RestartPolicyNever, TerminationGracePeriodSeconds: &gracePeriodSeconds, Containers: []corev1.Container{container}, ServiceAccountName: "cdi-cronjob", }, }, TTLSecondsAfterFinished: &ttlSecondsAfterFinished, BackoffLimit: &backoffLimit, }, }, }, } if hasCertConfigMap { vol := corev1.Volume{ Name: CertVolName, VolumeSource: corev1.VolumeSource{ ConfigMap: &corev1.ConfigMapVolumeSource{ LocalObjectReference: corev1.LocalObjectReference{ Name: *regSource.CertConfigMap, }, }, }, } cronJob.Spec.JobTemplate.Spec.Template.Spec.Volumes = []corev1.Volume{vol} } util.SetRecommendedLabels(cronJob, r.installerLabels, common.CDIControllerName) return cronJob, nil } func (r *DataImportCronReconciler) newInitialJob(cron *cdiv1.DataImportCron, cronJob *v1beta1.CronJob) *batchv1.Job { job := &batchv1.Job{ ObjectMeta: metav1.ObjectMeta{ Name: GetInitialJobName(cron), Namespace: cronJob.Namespace, }, Spec: cronJob.Spec.JobTemplate.Spec, } util.SetRecommendedLabels(job, r.installerLabels, common.CDIControllerName) return job } func (r *DataImportCronReconciler) newSourceDataVolume(cron *cdiv1.DataImportCron, dataVolumeName string) *cdiv1.DataVolume { var digestedURL string dv := cron.Spec.Template.DeepCopy() if isURLSource(cron) { digestedURL = untagDigestedDockerURL(*dv.Spec.Source.Registry.URL + "@" + cron.Annotations[AnnSourceDesiredDigest]) } else if isImageStreamSource(cron) { // No way to import image stream by name when we want speciific digest, so we use its docker reference digestedURL = "docker://" + cron.Annotations[AnnImageStreamDockerRef] dv.Spec.Source.Registry.ImageStream = nil } dv.Spec.Source.Registry.URL = &digestedURL dv.Name = dataVolumeName dv.Namespace = cron.Namespace util.SetRecommendedLabels(dv, r.installerLabels, common.CDIControllerName) dv.Labels[common.DataImportCronLabel] = cron.Name passCronAnnotationToDv(cron, dv, AnnImmediateBinding) passCronAnnotationToDv(cron, dv, AnnPodRetainAfterCompletion) return dv } func untagDigestedDockerURL(dockerURL string) string { if u, err := url.Parse(dockerURL); err == nil { url := u.Host + u.Path subs := reference.ReferenceRegexp.FindStringSubmatch(url) // Check for tag if len(subs) > 2 && len(subs[2]) > 0 { if untaggedRef, err := reference.ParseDockerRef(url); err == nil { return u.Scheme + "://" + untaggedRef.String() } } } return dockerURL } func passCronAnnotationToDv(cron *cdiv1.DataImportCron, dv *cdiv1.DataVolume, ann string) { if val := cron.Annotations[ann]; val != "" { addAnnotation(dv, ann, val) } } func newDataSource(cron *cdiv1.DataImportCron) *cdiv1.DataSource { dataSource := &cdiv1.DataSource{ ObjectMeta: metav1.ObjectMeta{ Name: cron.Spec.ManagedDataSource, Namespace: cron.Namespace, }, } return dataSource } // Create DataVolume name based on the DataSource name + prefix of the digest sha256 func createDvName(prefix, digest string) string { fromIdx := len(digestPrefix) toIdx := fromIdx + digestDvNameSuffixLength return prefix + "-" + digest[fromIdx:toIdx] } // GetCronJobName get CronJob name based on cron name and UID func GetCronJobName(cron *cdiv1.DataImportCron) string { return cron.Name + "-" + string(cron.UID)[:cronJobUIDSuffixLength] } // GetInitialJobName get initial job name based on cron name and UID func GetInitialJobName(cron *cdiv1.DataImportCron) string { return "initial-job-" + GetCronJobName(cron) }