containerized-data-importer/tools
Matthew Arnold 043fe5db9a
[release-1.57] Backport 3385 VDDK: pass snapshot ID through to nbdkit. (#3501)
* nbdkit datapath debug (#3361)

* pkg/image/nbdkit: Enable controlpath debugging

Disabling datapath debugging reduces noise, but controlpath debugging
is actually useful, not very noisy, and usually you would want it to
be enabled.

The difference is explained here:

https://libguestfs.org/nbdkit.1.html#SERVER-DEBUG-FLAGS

Virt-v2v disables datapath debugging but keeps controlpath debugging
enabled.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>

* pkg/image/nbdkit: Enable recommended nbdkit VDDK debugging options

VDDK datapath debugging logs every VDDK read and write which is noisy
and unnecessary.

Enabling VDDK stats gives useful information about how long each VDDK
call took, for virtually no overhead.  This information is printed to
stderr when nbdkit closes the connection.

This matches the upstream recommendations here, and also the flags
used by virt-v2v:

https://libguestfs.org/nbdkit-vddk-plugin.1.html#Troubleshooting-performance-problems

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>

---------

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>

* nbdkit: Use password=+filename to send passwords securely (#3363)

Passing passwords on the command line is not very secure since a user
on the same machine can see them using 'ps' etc.  nbdkit lets you pass
them via several secure mechanisms - for this I used the
password=+filename method.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>

* VDDK: pass snapshot ID through to nbdkit. (#3385)

* VDDK: pass snapshot ID through to nbdkit.

Opening VMware snapshots can sometimes fail with "Error 13 (You do not
have access rights to this file)" if the snapshot MOref is not provided.
This specifically seems to affect Windows VMs with VMware guest tools
installed.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* SonarCloud: Move VDDK plugin arguments to struct.

Adding 'snapshot' exceeded the seven-parameter limit.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Change vddk-test expected snapshot argument count.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Remove "san" from VDDK transports list.

Some versions of the VDDK crash when determining system support for its
"san" transport mode, if there are no SCSI disks present. This transport
mode is active by default, and is not used by CDI, so avoid the crash by
setting the list of allowable transports to not include "san".

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Co-authored-by: rwmjones <rjones@redhat.com>
2024-11-05 15:32:03 +01:00
..
cdi-containerimage-server refactor: move from io/ioutil to io and os packages (#2484) 2022-12-05 19:19:13 +00:00
cdi-func-test-bad-webserver golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
cdi-func-test-file-host-init Start integrate golangci lint into CI (#2675) 2023-04-11 13:59:33 +01:00
cdi-func-test-proxy golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
cdi-func-test-registry-init [release-v1.57] Backport main commits to 1.57 release branch v2 (#2785) 2023-07-06 16:05:38 +02:00
cdi-func-test-sample-populator Add support for volume populators (#2482) 2023-01-17 21:56:15 +01:00
cdi-image-size-detection Split and refactor DV controller (#2483) 2022-12-22 01:03:15 +00:00
cdi-olm-catalog initial bazelification of CDI (#986) 2019-10-15 15:55:44 -04:00
cdi-source-update-poller DataImportCron dusty stuff cleanups (#2723) 2023-05-24 10:04:15 +02:00
crd-generator golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
csv-generator golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
image-io Use centos:stream9 as a base image, cleanup unused code (#1983) 2022-04-20 19:37:51 +02:00
imageio-init Use centos:stream9 as a base image, cleanup unused code (#1983) 2022-04-20 19:37:51 +02:00
manifest-generator golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
metricsdocs Start integrate golangci lint into CI (#2675) 2023-04-11 13:59:33 +01:00
openapi-spec-generator update k8s libs to 1.26. (#2687) 2023-04-18 19:30:40 +01:00
prom-metrics-collector Update metric names to fit metrics naming conventions This fix updated metrics names to meet the metrics naming conventions. The old metrics names will not be available after this fix. (#2850) 2023-08-17 23:39:34 +02:00
util golangci-lint: Enable errcheck (#2696) 2023-04-25 20:40:16 +02:00
vddk-init Use centos:stream9 as a base image, cleanup unused code (#1983) 2022-04-20 19:37:51 +02:00
vddk-test [release-1.57] Backport 3385 VDDK: pass snapshot ID through to nbdkit. (#3501) 2024-11-05 15:32:03 +01:00
BUILD.bazel update k8s deps to 18.6 and controller runtime to 0.6.2 (#1330) 2020-08-07 14:09:52 +02:00