mirror of
https://github.com/kubevirt/containerized-data-importer.git
synced 2025-06-03 06:30:22 +00:00
![]() * nbdkit datapath debug (#3361) * pkg/image/nbdkit: Enable controlpath debugging Disabling datapath debugging reduces noise, but controlpath debugging is actually useful, not very noisy, and usually you would want it to be enabled. The difference is explained here: https://libguestfs.org/nbdkit.1.html#SERVER-DEBUG-FLAGS Virt-v2v disables datapath debugging but keeps controlpath debugging enabled. Signed-off-by: Richard W.M. Jones <rjones@redhat.com> * pkg/image/nbdkit: Enable recommended nbdkit VDDK debugging options VDDK datapath debugging logs every VDDK read and write which is noisy and unnecessary. Enabling VDDK stats gives useful information about how long each VDDK call took, for virtually no overhead. This information is printed to stderr when nbdkit closes the connection. This matches the upstream recommendations here, and also the flags used by virt-v2v: https://libguestfs.org/nbdkit-vddk-plugin.1.html#Troubleshooting-performance-problems Signed-off-by: Richard W.M. Jones <rjones@redhat.com> --------- Signed-off-by: Richard W.M. Jones <rjones@redhat.com> * nbdkit: Use password=+filename to send passwords securely (#3363) Passing passwords on the command line is not very secure since a user on the same machine can see them using 'ps' etc. nbdkit lets you pass them via several secure mechanisms - for this I used the password=+filename method. Signed-off-by: Richard W.M. Jones <rjones@redhat.com> * VDDK: pass snapshot ID through to nbdkit. (#3385) * VDDK: pass snapshot ID through to nbdkit. Opening VMware snapshots can sometimes fail with "Error 13 (You do not have access rights to this file)" if the snapshot MOref is not provided. This specifically seems to affect Windows VMs with VMware guest tools installed. Signed-off-by: Matthew Arnold <marnold@redhat.com> * SonarCloud: Move VDDK plugin arguments to struct. Adding 'snapshot' exceeded the seven-parameter limit. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Change vddk-test expected snapshot argument count. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Remove "san" from VDDK transports list. Some versions of the VDDK crash when determining system support for its "san" transport mode, if there are no SCSI disks present. This transport mode is active by default, and is not used by CDI, so avoid the crash by setting the list of allowable transports to not include "san". Signed-off-by: Matthew Arnold <marnold@redhat.com> --------- Signed-off-by: Matthew Arnold <marnold@redhat.com> --------- Signed-off-by: Richard W.M. Jones <rjones@redhat.com> Signed-off-by: Matthew Arnold <marnold@redhat.com> Co-authored-by: rwmjones <rjones@redhat.com> |
||
---|---|---|
.. | ||
cdi-containerimage-server | ||
cdi-func-test-bad-webserver | ||
cdi-func-test-file-host-init | ||
cdi-func-test-proxy | ||
cdi-func-test-registry-init | ||
cdi-func-test-sample-populator | ||
cdi-image-size-detection | ||
cdi-olm-catalog | ||
cdi-source-update-poller | ||
crd-generator | ||
csv-generator | ||
image-io | ||
imageio-init | ||
manifest-generator | ||
metricsdocs | ||
openapi-spec-generator | ||
prom-metrics-collector | ||
util | ||
vddk-init | ||
vddk-test | ||
BUILD.bazel |