mirror of
https://github.com/kubevirt/containerized-data-importer.git
synced 2025-06-03 06:30:22 +00:00
0bc6a8aeca
* Disable DV GC by default DataVolume garbage collection is a nice feature, but unfortunately it violates fundamental principle of Kubernetes. CR should not be auto-deleted when it completes its role (Job with TTLSecondsAfter- Finished is an exception), and once CR was created we can assume it is there until explicitly deleted. In addition, CR should keep idempotency, so the same CR manifest can be applied multiple times, as long as it is a valid update (e.g. DataVolume validation webhook does not allow updating the spec). When GC is enabled, some systems (e.g GitOps / ArgoCD) may require a workaround (DV annotation deleteAfterCompletion = "false") to prevent GC and function correctly. On the next kubevirt-bot Bump kubevirtci PR (with bump-cdi), it will fail on all kubevirtci lanes with tests referring DVs, as the tests IsDataVolumeGC() looks at CDIConfig Spec.DataVolumeTTLSeconds and assumes default is enabled. This should be fixed there. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix test waiting for PVC deletion with UID Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix clone test assuming DV was GCed Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix DIC controller DV/PVC deletion when snapshot is ready Signed-off-by: Arnon Gilboa <agilboa@redhat.com> --------- Signed-off-by: Arnon Gilboa <agilboa@redhat.com> |
||
|---|---|---|
| .. | ||
| framework | ||
| images | ||
| manifests | ||
| reporters | ||
| utils | ||
| api_validation_test.go | ||
| apiserver_test.go | ||
| badserver_test.go | ||
| basic_sanity_test.go | ||
| BUILD.bazel | ||
| cdiconfig_test.go | ||
| certrotation_test.go | ||
| clone-populator_test.go | ||
| cloner_test.go | ||
| csiclone_test.go | ||
| dataimportcron_test.go | ||
| datasource_test.go | ||
| datavolume_test.go | ||
| explain_test.go | ||
| external_population_test.go | ||
| imageio-inventory.go | ||
| import_proxy_test.go | ||
| import_test.go | ||
| local_volume_test.go | ||
| monitoring_test.go | ||
| operator_test.go | ||
| rbac_test.go | ||
| smartclone_test.go | ||
| static-volume_test.go | ||
| tests_suite_test.go | ||
| transfer_test.go | ||
| transport_test.go | ||
| upgrade_test.go | ||
| upload_test.go | ||
| webhook_test.go | ||