containerized-data-importer/pkg/controller/clone/rebind.go
Michael Henriksen 4ce9272c2c
DataVolume Controller uses VolumeCloneSource Populator (#2750)
* remove CSI clone

bye bye

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* no more smart clone

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* PVC clone same namespace

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* cross namespace pvc clone

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* various fixes to get some functional tests to work

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* delete smart clone controller again

somehow reappeared after rebase

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* mostly pvc clone functional test fixes

make sure size detect pod only runs on kubevirt content type

clone populator was skipping last round op applying pvc' annotations

various func test fixes

review comments

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* more various test fixes

host clone phase should (implicitly) wait for clone source pod to exit

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* remove "smart" clone from snapshot

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* DataVolume clone from snapshot uses populator

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* improve clone populator/datavolume coordination on "running" condition

For host clone, not much changes, values still comming from annotations on host clone PVC

For smart/csi clone the DataVolume will be "running" if not in pending or error phase

Will have the same values for terminal "completed" state regardless of clone type

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* unit tests for pvc/snapshot clone controllers

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* remove skipped test added in https://github.com/kubevirt/containerized-data-importer/pull/2759

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* attempt address AfterSuite and generate-verify failures

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* handle snapshot clone with no target size specified

also add more validation to some snapshot clone tests

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* remove Patch calls

Using the controller runtime Patch API with controller runtime cached client seems to be a pretty bad fit

At least given the way the CR API is designed where an old object is compared to new.

I like patch in theory though and will revisit

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* Clone populator should plan and execute even if PVC is bound

It was possible to miss "preallocation applied" annotation otherwise

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* add long term token to datavolume

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

* Rename ProgressReporter to StatusReporter

Should have been done back when annotations were addded to "progress"

Also, if pvc is bound do not call phase Reconcile functions only Status

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>

---------

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
2023-06-30 00:14:54 +02:00

70 lines
1.6 KiB
Go

package clone
import (
"context"
"fmt"
"github.com/go-logr/logr"
corev1 "k8s.io/api/core/v1"
"k8s.io/client-go/tools/record"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
cc "kubevirt.io/containerized-data-importer/pkg/controller/common"
)
// RebindPhaseName is the name of the rebind phase
const RebindPhaseName = "Rebind"
// RebindPhase binds a PV from one PVC to another
type RebindPhase struct {
SourceNamespace string
SourceName string
TargetNamespace string
TargetName string
Client client.Client
Log logr.Logger
Recorder record.EventRecorder
}
var _ Phase = &RebindPhase{}
// Name returns the name of the phase
func (p *RebindPhase) Name() string {
return RebindPhaseName
}
// Reconcile rebinds a PV
func (p *RebindPhase) Reconcile(ctx context.Context) (*reconcile.Result, error) {
targetClaim := &corev1.PersistentVolumeClaim{}
exists, err := getResource(ctx, p.Client, p.TargetNamespace, p.TargetName, targetClaim)
if err != nil {
return nil, err
}
if !exists {
return nil, fmt.Errorf("target claim does not exist")
}
if targetClaim.Spec.VolumeName != "" {
// guess we're all done
return nil, nil
}
sourceClaim := &corev1.PersistentVolumeClaim{}
exists, err = getResource(ctx, p.Client, p.SourceNamespace, p.SourceName, sourceClaim)
if err != nil {
return nil, err
}
if !exists {
return nil, fmt.Errorf("source claim does not exist")
}
if err := cc.Rebind(ctx, p.Client, sourceClaim, targetClaim); err != nil {
return nil, err
}
return &reconcile.Result{}, nil
}