containerized-data-importer/pkg/controller/import-controller_test.go
zvikorn 7dd334121c Creating blank disk on a block device (#962)
Signed-off-by: tavni <tavni@redhat.com>
2019-09-18 19:06:02 -04:00

522 lines
17 KiB
Go

package controller
import (
"fmt"
"reflect"
"testing"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
. "kubevirt.io/containerized-data-importer/pkg/common"
)
type ImportFixture struct {
ControllerFixture
}
func newImportFixture(t *testing.T) *ImportFixture {
f := &ImportFixture{
ControllerFixture: *newControllerFixture(t),
}
return f
}
func (f *ImportFixture) newImportController() *ImportController {
return &ImportController{
Controller: *f.newController("test/myimage", "Always", "5"),
}
}
func (f *ImportFixture) run(pvcName string) {
f.runController(pvcName, true, false, false)
}
func (f *ImportFixture) runWithExpectation(pvcName string) {
f.runController(pvcName, true, false, true)
}
func (f *ImportFixture) runExpectError(pvcName string) {
f.runController(pvcName, true, true, false)
}
func (f *ImportFixture) runController(pvcName string,
startInformers bool,
expectError bool,
withCreateExpectation bool) {
c := f.newImportController()
if startInformers {
stopCh := make(chan struct{})
defer close(stopCh)
go c.pvcInformer.Run(stopCh)
go c.podInformer.Run(stopCh)
cache.WaitForCacheSync(stopCh, c.pvcInformer.HasSynced)
cache.WaitForCacheSync(stopCh, c.pvcInformer.HasSynced)
}
if withCreateExpectation {
c.expectPodCreate(pvcName)
}
err := c.syncPvc(pvcName)
if !expectError && err != nil {
f.t.Errorf("error syncing pvc: %s: %v", pvcName, err)
} else if expectError && err == nil {
f.t.Error("expected error syncing pvc, got nil")
}
k8sActions := filterActions(f.kubeclient.Actions())
for i, action := range k8sActions {
if len(f.kubeactions) < i+1 {
f.t.Errorf("%d unexpected actions: %+v", len(k8sActions)-len(f.kubeactions), k8sActions[i:])
break
}
expectedAction := f.kubeactions[i]
checkAction(expectedAction, action, f.t)
}
if len(f.kubeactions) > len(k8sActions) {
f.t.Errorf("%d additional expected actions:%+v", len(f.kubeactions)-len(k8sActions), f.kubeactions[len(k8sActions):])
}
}
// Verifies basic pod creation when new PVC with endpoint annotation is discovered
func TestCreatesImportPodForEndpoint(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
expPod := createPod(pvc, DataVolName, nil)
f.expectCreatePodAction(expPod)
f.run(getPvcKey(pvc, t))
}
// Verifies basic pod creation when new PVC (VolumeMode:Block) with endpoint annotation is discovered
func TestCreatesImportPodForEndpointBlockPV(t *testing.T) {
f := newImportFixture(t)
pvc := createBlockPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
expPod := createPod(pvc, DataVolName, nil)
f.expectCreatePodAction(expPod)
f.run(getPvcKey(pvc, t))
}
// Verifies basic pod creation when new PVC with 'blank' annotation is discovered
func TestCreatesImportPodForBlankImage(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnSource: SourceNone}, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
expPod := createPod(pvc, DataVolName, nil)
f.expectCreatePodAction(expPod)
f.run(getPvcKey(pvc, t))
}
// Verifies basic pod creation when new PVC (VolumeMode: Block) with 'blank' annotation is discovered
func TestUpdatePVCWithNoPodForBlankImageBlockPV(t *testing.T) {
f := newImportFixture(t)
pvc := createBlockPvc("testPvc1", "default", map[string]string{AnnSource: SourceNone}, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
expPvc.Annotations[AnnPodPhase] = "Succeeded"
f.expectUpdatePvcAction(expPvc)
f.runWithExpectation(getPvcKey(pvc, t))
}
// Verifies pod creation does not occur when waiting for expectation.
func TestImportPodCreationExpectation(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
f.expectUpdatePvcAction(expPvc)
f.runWithExpectation(getPvcKey(pvc, t))
}
// Verifies pod creation is observed and pvc labels are set.
func TestImportObservePod(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodPending
pod.Status.ContainerStatuses = []corev1.ContainerStatus{
{
State: corev1.ContainerState{
Waiting: &corev1.ContainerStateWaiting{},
},
},
}
pod.Namespace = pvc.Namespace
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
expPvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(corev1.PodPending), AnnEndpoint: "http://test"}
f.expectUpdatePvcAction(expPvc)
f.run(getPvcKey(pvc, t))
}
func TestFailureObserved(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodRunning
pod.Status.ContainerStatuses = []corev1.ContainerStatus{
{
State: corev1.ContainerState{
Waiting: &corev1.ContainerStateWaiting{},
},
},
}
pod.Namespace = pvc.Namespace
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
expPvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(corev1.PodFailed), AnnEndpoint: "http://test"}
f.expectUpdatePvcAction(expPvc)
f.run(getPvcKey(pvc, t))
}
// Verifies pod status updates are reflected in PVC annotations
func TestImportPodStatusUpdatingForEndpoint(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodRunning
pod.Namespace = pvc.Namespace
pvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(corev1.PodPending), AnnEndpoint: "http://test"}
pvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
// expecting pvc's pod status annotation to be updated from pending => running
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(pod.Status.Phase), AnnEndpoint: "http://test"}
f.expectUpdatePvcAction(expPvc)
f.run(getPvcKey(pvc, t))
}
// Verifies pod status updates are reflected in PVC annotations
func TestImportPodStatusUpdatingForBlankImage(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnSource: SourceNone}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodRunning
pod.Namespace = pvc.Namespace
pvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(corev1.PodPending), AnnSource: SourceNone}
pvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
// expecting pvc's pod status annotation to be updated from pending => running
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Annotations = map[string]string{AnnImportPod: pod.Name, AnnPodPhase: string(pod.Status.Phase), AnnSource: SourceNone}
f.expectUpdatePvcAction(expPvc)
f.run(getPvcKey(pvc, t))
}
func TestControllerImporterPodScratchExitCode(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnSource: SourceHTTP}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodFailed
// Create the scratch exit code status.
pod.Status.ContainerStatuses = []corev1.ContainerStatus{
{
LastTerminationState: corev1.ContainerState{
Terminated: &corev1.ContainerStateTerminated{
ExitCode: ScratchSpaceNeededExitCode,
},
},
},
}
pod.Namespace = pvc.Namespace
pvc.ObjectMeta.Annotations = map[string]string{AnnEndpoint: "http://test", AnnImportPod: pod.Name, AnnPodPhase: string(corev1.PodPending), AnnSource: SourceHTTP}
pvc.ObjectMeta.Labels = map[string]string{CDILabelKey: CDILabelValue}
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
// expecting pvc's pod status annotation to be updated from pending => running
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Annotations = map[string]string{AnnRequiresScratch: "true", AnnImportPod: "madeup-name", AnnEndpoint: "http://test", AnnPodPhase: string(corev1.PodPending), AnnSource: SourceHTTP}
f.expectUpdatePvcAction(expPvc)
f.expectDeletePodAction(pod)
f.run(getPvcKey(pvc, t))
}
func TestControllerImporterPodSuccessWithScratch(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnRequiresScratch: "true", AnnImportPod: "madeup-name", AnnEndpoint: "http://test", AnnPodPhase: string(corev1.PodPending), AnnSource: SourceHTTP}, map[string]string{CDILabelKey: CDILabelValue})
scratchPvc := createPvc("testPvc1-scratch", "default", nil, map[string]string{LabelImportPvc: pvc.Name})
pod := createPod(pvc, DataVolName, scratchPvc)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodSucceeded
pod.Namespace = pvc.Namespace
f.pvcLister = append(f.pvcLister, pvc)
f.pvcLister = append(f.pvcLister, scratchPvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, scratchPvc)
f.kubeobjects = append(f.kubeobjects, pod)
expPvc := pvc.DeepCopy()
expPvc.ObjectMeta.Annotations = map[string]string{AnnRequiresScratch: "true", AnnImportPod: "madeup-name", AnnEndpoint: "http://test", AnnPodPhase: string(pod.Status.Phase), AnnSource: SourceHTTP}
f.expectUpdatePvcAction(expPvc)
f.expectDeletePodAction(pod)
f.run(getPvcKey(pvc, t))
}
func TestControllerCreateImporterPodWithScratch(t *testing.T) {
f := newImportFixture(t)
storageClassName := "test"
scratchPvc := createPvcInStorageClass("testPvc-scratch", "default", &storageClassName, nil, nil)
pvc := createPvcInStorageClass("testPvc", "default", &storageClassName, map[string]string{AnnEndpoint: "http://test", AnnSource: SourceHTTP, AnnContentType: "archive"}, nil)
pod := createPod(pvc, DataVolName, scratchPvc)
f.pvcLister = append(f.pvcLister, pvc)
f.pvcLister = append(f.pvcLister, scratchPvc)
controller := f.newImportController()
f.expectCreatePodAction(pod)
if err := controller.createImporterPod(pvc, "testkey"); err != nil {
t.Errorf("Error creating importer pod for http %v", err)
}
}
func TestRequiresScratchSpace(t *testing.T) {
f := newImportFixture(t)
controller := f.newImportController()
if !controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnContentType: "archive"}, nil)) {
t.Errorf("Archive should require scratch space, but found it doesn't")
}
if !controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnSource: SourceRegistry}, nil)) {
t.Errorf("Registry should require scratch space, but found it doesn't")
}
if controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnSource: SourceHTTP}, nil)) {
t.Errorf("http should not require scratch space, but found it does")
}
if controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnSource: SourceNone}, nil)) {
t.Errorf("none should not require scratch space, but found it does")
}
if !controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnContentType: SourceHTTP, AnnRequiresScratch: "true"}, nil)) {
t.Errorf("http with requires scratch should require scratch space, but found it doesn't")
}
if controller.requiresScratchSpace(createPvc("testPvc", "default", map[string]string{AnnEndpoint: "http://test", AnnContentType: SourceHTTP, AnnRequiresScratch: "false"}, nil)) {
t.Errorf("http with requires scratch false should not require scratch space, but found it does")
}
}
func TestImportFindPodInCacheUpdating(t *testing.T) {
f := newImportFixture(t)
tests := []struct {
pvc *corev1.PersistentVolumeClaim
pod *corev1.Pod
}{
{
pvc: createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
},
{
pvc: createPvc("testPvc2", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
},
{
pvc: createPvc("testPvc3", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
},
}
for idx, test := range tests {
test.pod = createPod(test.pvc, DataVolName, nil)
test.pod.Namespace = test.pvc.Namespace
test.pod.Name = fmt.Sprintf("fakename%d", idx)
f.pvcLister = append(f.pvcLister, test.pvc)
f.podLister = append(f.podLister, test.pod)
f.kubeobjects = append(f.kubeobjects, test.pvc)
f.kubeobjects = append(f.kubeobjects, test.pod)
tests[idx] = test
}
controller := f.newImportController()
stopCh := make(chan struct{})
defer close(stopCh)
go controller.pvcInformer.Run(stopCh)
go controller.podInformer.Run(stopCh)
cache.WaitForCacheSync(stopCh, controller.pvcInformer.HasSynced)
cache.WaitForCacheSync(stopCh, controller.pvcInformer.HasSynced)
for _, test := range tests {
foundPod, err := controller.findImportPodFromCache(test.pvc)
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if foundPod == nil {
t.Errorf("didn't find pod for pvc %v", test.pvc)
}
if !reflect.DeepEqual(foundPod, test.pod) {
t.Errorf("wrong pod found.\nfound %v\nwant %v", foundPod, test.pod)
}
}
}
func TestImportFindPvcInCacheUpdating(t *testing.T) {
f := newImportFixture(t)
tests := []struct {
pvc *corev1.PersistentVolumeClaim
scratchPvc *corev1.PersistentVolumeClaim
}{
{
pvc: createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
scratchPvc: createPvc("testPvc1-scratch", "default", nil, map[string]string{LabelImportPvc: "testPvc1"}),
},
{
pvc: createPvc("testPvc2", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
scratchPvc: createPvc("testPvc2-scratch", "default", nil, map[string]string{LabelImportPvc: "testPvc2"}),
},
{
pvc: createPvc("testPvc3", "default", map[string]string{AnnEndpoint: "http://test"}, nil),
scratchPvc: createPvc("testPvc3-scratch", "default", nil, map[string]string{LabelImportPvc: "testPvc3"}),
},
}
for idx, test := range tests {
f.pvcLister = append(f.pvcLister, test.pvc)
f.pvcLister = append(f.pvcLister, test.scratchPvc)
f.kubeobjects = append(f.kubeobjects, test.pvc)
f.kubeobjects = append(f.kubeobjects, test.scratchPvc)
tests[idx] = test
}
controller := f.newImportController()
stopCh := make(chan struct{})
defer close(stopCh)
go controller.pvcInformer.Run(stopCh)
cache.WaitForCacheSync(stopCh, controller.pvcInformer.HasSynced)
for _, test := range tests {
foundPvc, err := controller.findScratchPvcFromCache(test.pvc)
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if foundPvc == nil {
t.Errorf("didn't find pvc %v", test.scratchPvc)
}
if !reflect.DeepEqual(foundPvc, test.scratchPvc) {
t.Errorf("wrong pvc found.\nfound %v\nwant %v", foundPvc, test.scratchPvc)
}
}
}
// verifies no work is done on pvcs without our annotations
func TestImportIgnorePVC(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", nil, nil)
f.pvcLister = append(f.pvcLister, pvc)
f.kubeobjects = append(f.kubeobjects, pvc)
f.runWithExpectation(getPvcKey(pvc, t))
}
// verify error if ownership doesn't match
func TestImportOwnership(t *testing.T) {
f := newImportFixture(t)
pvc := createPvc("testPvc1", "default", map[string]string{AnnEndpoint: "http://test"}, nil)
pod := createPod(pvc, DataVolName, nil)
pod.Name = "madeup-name"
pod.Status.Phase = corev1.PodPending
pod.Namespace = pvc.Namespace
pod.ObjectMeta.OwnerReferences = []metav1.OwnerReference{}
f.pvcLister = append(f.pvcLister, pvc)
f.podLister = append(f.podLister, pod)
f.kubeobjects = append(f.kubeobjects, pvc)
f.kubeobjects = append(f.kubeobjects, pod)
f.runExpectError(getPvcKey(pvc, t))
}