containerized-data-importer/pkg/controller/dataimportcron-conditions.go
Arnon Gilboa afb269737b
Suppress alerts to reduce noise of dependent ones (#3129)
* Suppress alerts to reduce noise of dependent ones

This is a follow-up to #2998 introducing the following changes to alert
rules:

- CDIDefaultStorageClassDegraded - do not fire when no default SC
  (either k8s or virt).
- CDIDataImportCronOutdated - do not fire when no default SC (either
  k8s or virt), as DIC import DVs use default SC.
- CDINoDefaultStorageClass - fire not only when there is a pending DV
  (and PVC) but also when DV has an empty status (waiting for default
  SC etc.)

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* CR fixes

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* Remove expensive func test

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* Refactor updateDataImportCronCondition

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* Add some verify comments

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

* Add IsDataVolumeUsingDefaultStorageClass helper for readability

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>

---------

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
2024-04-07 20:47:51 +02:00

102 lines
3.5 KiB
Go

/*
Copyright 2021 The CDI Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
limitations under the License.
See the License for the specific language governing permissions and
*/
package controller
import (
"strconv"
"github.com/prometheus/client_golang/prometheus"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
cdiv1 "kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1"
"kubevirt.io/containerized-data-importer/pkg/controller/common"
metrics "kubevirt.io/containerized-data-importer/pkg/monitoring/metrics/cdi-controller"
)
const (
noDigest = "NoDigest"
noImport = "NoImport"
outdated = "Outdated"
scheduled = "ImportScheduled"
inProgress = "ImportProgressing"
upToDate = "UpToDate"
)
func updateDataImportCronCondition(cron *cdiv1.DataImportCron, conditionType cdiv1.DataImportCronConditionType, status corev1.ConditionStatus, message, reason string) {
if conditionType == cdiv1.DataImportCronUpToDate {
updateDataImportCronOutdatedMetric(cron, status)
}
if condition := FindDataImportCronConditionByType(cron, conditionType); condition != nil {
updateConditionState(&condition.ConditionState, status, message, reason)
} else {
condition = &cdiv1.DataImportCronCondition{Type: conditionType}
updateConditionState(&condition.ConditionState, status, message, reason)
cron.Status.Conditions = append(cron.Status.Conditions, *condition)
}
}
func updateDataImportCronOutdatedMetric(cron *cdiv1.DataImportCron, status corev1.ConditionStatus) {
isUpToDate := status == corev1.ConditionTrue
isPending := false
// Check if the DataImportCron import DV is pending for default k8s/virt storage class
if !isUpToDate {
_, scExists := cron.Annotations[AnnStorageClass]
isPending = !scExists && common.IsDataVolumeUsingDefaultStorageClass(&cron.Spec.Template)
}
labels := getPrometheusCronLabels(cron.Namespace, cron.Name)
metrics.DeleteDataImportCronOutdated(labels)
labels[metrics.PrometheusCronPendingLabel] = strconv.FormatBool(isPending)
metrics.SetDataImportCronOutdated(labels, !isUpToDate)
}
// FindDataImportCronConditionByType finds DataImportCronCondition by condition type
func FindDataImportCronConditionByType(cron *cdiv1.DataImportCron, conditionType cdiv1.DataImportCronConditionType) *cdiv1.DataImportCronCondition {
for i, condition := range cron.Status.Conditions {
if condition.Type == conditionType {
return &cron.Status.Conditions[i]
}
}
return nil
}
func updateConditionState(condition *cdiv1.ConditionState, status corev1.ConditionStatus, message, reason string) {
conditionStatusUpdated := condition.Status != status
conditionUpdated := conditionStatusUpdated || condition.Message != message || condition.Reason != reason
if conditionUpdated {
now := metav1.Now()
if conditionStatusUpdated {
condition.Status = status
condition.LastTransitionTime = now
}
condition.LastHeartbeatTime = now
condition.Reason = reason
condition.Message = message
}
}
func getPrometheusCronLabels(cronNamespace, cronName string) prometheus.Labels {
return prometheus.Labels{
metrics.PrometheusCronNsLabel: cronNamespace,
metrics.PrometheusCronNameLabel: cronName,
}
}