github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a test for icon opacity crash

Browse Source 
Fixes #2361
This commit is contained in:
Adam Barth 2016-03-03 10:33:57 -08:00
parent 8af3dde3af
commit 00a00deffc
3 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/icon.dart
View File

@ -63,7 +63,7 @@ class Icon extends StatelessComponent {
final double iconOpacity = IconTheme.of(context)?.clampedOpacity ?? 1.0;
Color iconColor = color ?? _getDefaultColor(context);
if (iconOpacity != 1.0)
iconColor = iconColor.withAlpha((255.0 * iconColor.opacity * iconOpacity).round());
iconColor = iconColor.withOpacity(iconColor.opacity * iconOpacity);
return new ExcludeSemantics(
child: new SizedBox(

25
packages/flutter/test/widget/icon_test.dart Normal file
View File

@ -0,0 +1,25 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';
import 'package:test/test.dart';
void main() {
test('Can set opacity for an Icon', () {
testWidgets((WidgetTester tester) {
tester.pumpWidget(
new IconTheme(
data: new IconThemeData(
color: Colors.green[500],
opacity: 0.5
),
child: new Icon(icon: Icons.add)
)
);
Text text = tester.findWidgetOfType(Text);
expect(text.style.color, equals(Colors.green[500].withOpacity(0.5)));
});
});
}

9
packages/flutter_test/lib/src/instrumentation.dart
View File

@ -75,6 +75,15 @@ class Instrumentation {
});
}
/// Returns the first [Widget] of the given [runtimeType], if any. Returns
/// null if there is no matching widget.
Widget findWidgetOfType(Type type) {
Element element = findElement((Element element) {
return element.widget.runtimeType == type;
});
return element?.widget;
}
/// Returns the [State] object of the first element whose state has
/// the given [runtimeType], if any. Returns null if there is no
/// matching element.