From 00bcffd108ffcd5000e35a62aab5488d9650468c Mon Sep 17 00:00:00 2001 From: Gary Qian Date: Thu, 4 Oct 2018 10:57:30 -0700 Subject: [PATCH] Roll engine and update tests (#22643) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit git log 7e3b41dc7ba6..74e68ff8b108 --no-merges --oneline 74e68ff8b Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436) 58fbd1fd1 Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435) 83151d9fc Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434) 5fe7e377d Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432) 5340f4224 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431) 37fd43d43 Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419) 4af077b29 Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429) 165f3dd1c Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427) 34bd0ef87 Don’t build benchmarking binaries on Windows. (#6428) ae4db4469 Ensure setViewIdResourceName has the correct version guard (#6404) 2c5d0c407 [rapidjson] Fix import statements (#6418) c2128fc80 Create a benchmarking target for the shell. (#6420) 30f78af91 Raise errors on non-zero exits while creating artifacts on the bots. (#6424) 191168cec Disable line_height tests on Windows (#6423) 061cc6643 Fix ideographic baseline to match spec. (#6422) 74eac1f56 Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421) 10b45405b Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417) --- bin/internal/engine.version | 2 +- packages/flutter/test/engine/paragraph_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/internal/engine.version b/bin/internal/engine.version index 98f40c3ef33..0c5cb3b1ef1 100644 --- a/bin/internal/engine.version +++ b/bin/internal/engine.version @@ -1 +1 @@ -74662ab695238af0e7402f41c4bf9ad862bd37d2 +74e68ff8b108219e0c0dcb9a904113f943b66b2d diff --git a/packages/flutter/test/engine/paragraph_test.dart b/packages/flutter/test/engine/paragraph_test.dart index d2a98004733..fc7347baa01 100644 --- a/packages/flutter/test/engine/paragraph_test.dart +++ b/packages/flutter/test/engine/paragraph_test.dart @@ -8,7 +8,7 @@ import 'package:flutter_test/flutter_test.dart'; void main() { // Ahem font uses a constant ideographic/alphabetic baseline ratio. - const double kAhemBaselineRatio = 1.1662499904632568; + const double kAhemBaselineRatio = 1.25; test('predictably lays out a single-line paragraph', () { for (double fontSize in [10.0, 20.0, 30.0, 40.0]) {