github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix NPE in Chrome Device (#42813)

Browse Source
This commit is contained in:
Jonah Williams 2019-10-16 15:46:07 -07:00 committed by GitHub
parent fbbc4fa868
commit 01f779e97a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/web/web_device.dart
View File

@ -61,7 +61,7 @@ class ChromeDevice extends Device {
@override
DeviceLogReader getLogReader({ApplicationPackage app}) {
return NoOpDeviceLogReader(app.name);
return NoOpDeviceLogReader(app?.name);
}
@override

1
packages/flutter_tools/test/general.shard/web/devices_test.dart
View File

@ -42,6 +42,7 @@ void main() {
expect(chromeDevice.supportsScreenshot, false);
expect(await chromeDevice.isLocalEmulator, false);
expect(chromeDevice.getLogReader(app: mockWebApplicationPackage), isInstanceOf<NoOpDeviceLogReader>());
expect(chromeDevice.getLogReader(), isInstanceOf<NoOpDeviceLogReader>());
expect(await chromeDevice.portForwarder.forward(1), 1);
});