From 024cebf8f3918b76ec788a4a3085b5f823fd48e9 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Mon, 5 Feb 2018 18:11:07 -0800 Subject: [PATCH] Fix mismatched bracket in Xcode failure diagnostic (#14478) When diagnosing a failed Xcode build, if neither the development team (for automatic provisioning) nor the provisioning profile (for manual provisioning) is set, display the appropriate error message. Previously, this method would not output the appropriate error message if a only a development team was set. --- packages/flutter_tools/lib/src/ios/mac.dart | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/flutter_tools/lib/src/ios/mac.dart b/packages/flutter_tools/lib/src/ios/mac.dart index eead7f3ab95..e9bfc7461b9 100644 --- a/packages/flutter_tools/lib/src/ios/mac.dart +++ b/packages/flutter_tools/lib/src/ios/mac.dart @@ -386,13 +386,13 @@ Future diagnoseXcodeBuildFailure( printError(noProvisioningProfileInstruction, emphasis: true); return; } + // Make sure the user has specified one of: + // * DEVELOPMENT_TEAM (automatic signing) + // * PROVISIONING_PROFILE (manual signing) if (result.xcodeBuildExecution != null && result.xcodeBuildExecution.buildForPhysicalDevice && - // Make sure the user has specified one of: - // DEVELOPMENT_TEAM (automatic signing) - // PROVISIONING_PROFILE (manual signing) - !(app.buildSettings?.containsKey('DEVELOPMENT_TEAM')) == true - || app.buildSettings?.containsKey('PROVISIONING_PROFILE') == true) { + app.buildSettings != null && + !['DEVELOPMENT_TEAM', 'PROVISIONING_PROFILE'].any(app.buildSettings.containsKey)) { printError(noDevelopmentTeamInstruction, emphasis: true); return; }