From 02abd00e9360fd1fb2e92a0def5c926e5fc929fe Mon Sep 17 00:00:00 2001 From: Yegor Date: Fri, 25 Oct 2019 15:03:25 -0700 Subject: [PATCH] Cupertino web tests (#43529) * enable more tests after material fixes * enable some of the Cupertino tests --- dev/bots/test.dart | 30 ++++++++++++------- .../test/material/bottom_sheet_test.dart | 1 - .../flutter/test/widgets/center_test.dart | 1 - 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 731c3601009..cfe23ac65b6 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -59,12 +59,9 @@ const int kWebBatchSize = 20; /// Tests that we don't run on Web for various reasons. // -// TODO(yjbanov): we're getting rid of these blacklists as part of https://github.com/flutter/flutter/projects/60 -const List kWebTestDirectoryBlacklist = [ - 'cupertino', - 'examples', -]; +// TODO(yjbanov): we're getting rid of this blacklist as part of https://github.com/flutter/flutter/projects/60 const List kWebTestFileBlacklist = [ + 'test/examples/sector_layout_test.dart', 'test/widgets/heroes_test.dart', 'test/widgets/text_test.dart', 'test/widgets/selectable_text_test.dart', @@ -74,13 +71,27 @@ const List kWebTestFileBlacklist = [ 'test/widgets/raw_keyboard_listener_test.dart', 'test/widgets/editable_text_test.dart', 'test/widgets/widget_inspector_test.dart', - 'test/widgets/draggable_test.dart', 'test/widgets/shortcuts_test.dart', 'test/material/text_form_field_test.dart', - 'test/material/banner_theme_test.dart', - 'test/material/popup_menu_test.dart', 'test/material/data_table_test.dart', - 'test/material/toggle_buttons_test.dart', + + // TODO(yjbanov): CupertinoDynamicColor breaks the web engine. The fix + // is on the engine side: https://github.com/flutter/engine/pull/13359 + 'test/cupertino/colors_test.dart', + 'test/cupertino/dialog_test.dart', + 'test/cupertino/nav_bar_test.dart', + 'test/cupertino/nav_bar_transition_test.dart', + 'test/cupertino/refresh_test.dart', + 'test/cupertino/switch_test.dart', + 'test/cupertino/text_field_test.dart', + 'test/cupertino/date_picker_test.dart', + 'test/cupertino/slider_test.dart', + 'test/cupertino/text_field_test.dart', + 'test/cupertino/segmented_control_test.dart', + 'test/cupertino/scaffold_test.dart', + 'test/cupertino/route_test.dart', + 'test/cupertino/route_test.dart', + 'test/cupertino/activity_indicator_test.dart', ]; /// When you call this, you can pass additional arguments to pass custom @@ -459,7 +470,6 @@ Future _runWebTests() async { final List allTests = flutterPackageTestDirectory .listSync() .whereType() - .where((Directory directory) => !kWebTestDirectoryBlacklist.contains(path.basename(directory.path))) .expand((Directory directory) => directory .listSync(recursive: true) .where((FileSystemEntity entity) => entity.path.endsWith('_test.dart')) diff --git a/packages/flutter/test/material/bottom_sheet_test.dart b/packages/flutter/test/material/bottom_sheet_test.dart index 19ab0277c5a..b48a922db52 100644 --- a/packages/flutter/test/material/bottom_sheet_test.dart +++ b/packages/flutter/test/material/bottom_sheet_test.dart @@ -2,7 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -@TestOn('!chrome') // flaky on CI import 'package:flutter_test/flutter_test.dart'; import 'package:flutter/material.dart'; import 'package:flutter/widgets.dart'; diff --git a/packages/flutter/test/widgets/center_test.dart b/packages/flutter/test/widgets/center_test.dart index 059077e37c3..dfbd0e54f08 100644 --- a/packages/flutter/test/widgets/center_test.dart +++ b/packages/flutter/test/widgets/center_test.dart @@ -2,7 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -@TestOn('!chrome') // flaky on web import 'package:flutter_test/flutter_test.dart'; import 'package:flutter/widgets.dart';