From 02dc0ab37fcc7ca82c7b95199acfb6d15b6f1e5a Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Wed, 29 Jan 2020 14:27:43 -0800 Subject: [PATCH] Remove unnecessary BuildableIOSApp from "build ios-framework" (#49659) --- .../lib/src/commands/build_ios_framework.dart | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/build_ios_framework.dart b/packages/flutter_tools/lib/src/commands/build_ios_framework.dart index 14a2674439f..cd396c751c8 100644 --- a/packages/flutter_tools/lib/src/commands/build_ios_framework.dart +++ b/packages/flutter_tools/lib/src/commands/build_ios_framework.dart @@ -9,7 +9,6 @@ import 'package:meta/meta.dart'; import 'package:platform/platform.dart'; import '../aot.dart'; -import '../application_package.dart'; import '../artifacts.dart'; import '../base/common.dart'; import '../base/file_system.dart'; @@ -159,16 +158,15 @@ class BuildIOSFrameworkCommand extends BuildSubCommand { throwToolExit('--output is required.'); } - final BuildableIOSApp iosProject = await applicationPackages.getPackageForPlatform(TargetPlatform.ios) as BuildableIOSApp; - - if (iosProject == null) { - throwToolExit("Module's iOS folder missing"); + if (!_project.ios.existsSync()) { + throwToolExit('Module does not support iOS'); } final Directory outputDirectory = globals.fs.directory(globals.fs.path.absolute(globals.fs.path.normalize(outputArgument))); + final String productBundleIdentifier = await _project.ios.productBundleIdentifier; for (final BuildMode mode in buildModes) { - globals.printStatus('Building frameworks for $iosProject in ${getNameForBuildMode(mode)} mode...'); + globals.printStatus('Building frameworks for $productBundleIdentifier in ${getNameForBuildMode(mode)} mode...'); final String xcodeBuildConfiguration = toTitleCase(getNameForBuildMode(mode)); final Directory modeDirectory = outputDirectory.childDirectory(xcodeBuildConfiguration);