github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a race in runFromSource. (#9495)

Browse Source 
There is a race where we could complete a future based on a stream event
and then before we cancel the stream subscription, we get another event
and try and complete the future again.
This commit is contained in:
John McCutchan 2017-04-20 10:05:30 -07:00 committed by GitHub
parent f29dd4f921
commit 03d684be6d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/vmservice.dart
View File

@ -1124,7 +1124,8 @@ class FlutterView extends ServiceObject {
// launch errors.
if (event.kind == ServiceEvent.kIsolateRunnable) {
printTrace('Isolate is runnable.');
completer.complete(null);
if (!completer.isCompleted)
completer.complete(null);
}
});
await owner.vm.runInView(viewId,