mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
Add route settings to CupertinoSheetRoute (#161528)
Adds route settings to the sheet route. From [this comment.](https://github.com/flutter/flutter/pull/157568#issuecomment-2587720636) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
parent
1d38029c3b
commit
067afb7e69
@ -449,7 +449,7 @@ class _CupertinoSheetTransitionState extends State<CupertinoSheetTransition> {
|
|||||||
/// `CupertinoSheetRoute`, with optional nested navigation built in.
|
/// `CupertinoSheetRoute`, with optional nested navigation built in.
|
||||||
class CupertinoSheetRoute<T> extends PageRoute<T> with _CupertinoSheetRouteTransitionMixin<T> {
|
class CupertinoSheetRoute<T> extends PageRoute<T> with _CupertinoSheetRouteTransitionMixin<T> {
|
||||||
/// Creates a page route that displays an iOS styled sheet.
|
/// Creates a page route that displays an iOS styled sheet.
|
||||||
CupertinoSheetRoute({required this.builder});
|
CupertinoSheetRoute({super.settings, required this.builder});
|
||||||
|
|
||||||
/// Builds the primary contents of the sheet route.
|
/// Builds the primary contents of the sheet route.
|
||||||
final WidgetBuilder builder;
|
final WidgetBuilder builder;
|
||||||
|
@ -609,6 +609,46 @@ void main() {
|
|||||||
expect(find.text('Page 2'), findsNothing);
|
expect(find.text('Page 2'), findsNothing);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
testWidgets('sheet has route settings', (WidgetTester tester) async {
|
||||||
|
await tester.pumpWidget(
|
||||||
|
CupertinoApp(
|
||||||
|
initialRoute: '/',
|
||||||
|
onGenerateRoute: (RouteSettings settings) {
|
||||||
|
if (settings.name == '/') {
|
||||||
|
return PageRouteBuilder<void>(
|
||||||
|
pageBuilder: (
|
||||||
|
BuildContext context,
|
||||||
|
Animation<double> animation,
|
||||||
|
Animation<double> secondaryAnimation,
|
||||||
|
) {
|
||||||
|
return CupertinoPageScaffold(
|
||||||
|
navigationBar: const CupertinoNavigationBar(middle: Text('Page 1')),
|
||||||
|
child: Container(),
|
||||||
|
);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return CupertinoSheetRoute<void>(
|
||||||
|
builder: (BuildContext context) {
|
||||||
|
return CupertinoPageScaffold(
|
||||||
|
navigationBar: CupertinoNavigationBar(middle: Text('Page: ${settings.name}')),
|
||||||
|
child: Container(),
|
||||||
|
);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
},
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(find.text('Page 1'), findsOneWidget);
|
||||||
|
expect(find.text('Page 2'), findsNothing);
|
||||||
|
|
||||||
|
tester.state<NavigatorState>(find.byType(Navigator)).pushNamed('/next');
|
||||||
|
await tester.pumpAndSettle();
|
||||||
|
|
||||||
|
expect(find.text('Page: /next'), findsOneWidget);
|
||||||
|
});
|
||||||
|
|
||||||
group('drag dismiss gesture', () {
|
group('drag dismiss gesture', () {
|
||||||
Widget dragGestureApp(GlobalKey homeScaffoldKey, GlobalKey sheetScaffoldKey) {
|
Widget dragGestureApp(GlobalKey homeScaffoldKey, GlobalKey sheetScaffoldKey) {
|
||||||
return CupertinoApp(
|
return CupertinoApp(
|
||||||
|
Loading…
Reference in New Issue
Block a user