diff --git a/packages/flutter/lib/src/rendering/sliver_padding.dart b/packages/flutter/lib/src/rendering/sliver_padding.dart index c5f74b1a57f..648d8d145b0 100644 --- a/packages/flutter/lib/src/rendering/sliver_padding.dart +++ b/packages/flutter/lib/src/rendering/sliver_padding.dart @@ -92,54 +92,6 @@ class RenderSliverPadding extends RenderSliver with RenderObjectWithChildMixin tapped = []; await tester.pumpWidget( - new ScrollableList( - key: new GlobalKey(), + new ListView( itemExtent: 290.0, - scrollAnchor: ViewportAnchor.end, + reverse: true, padding: const EdgeInsets.fromLTRB(5.0, 20.0, 15.0, 10.0), children: items.map((int item) { return new Container( child: new GestureDetector( onTap: () { tapped.add(item); }, - child: new Text('$item') - ) + child: new Text('$item'), + ), ); - }) - ) + }).toList(), + ), ); await tester.tapAt(const Point(200.0, 600.0 - 9.0)); expect(tapped, equals([])); await tester.tapAt(const Point(200.0, 600.0 - 11.0)); - expect(tapped, equals([5])); + expect(tapped, equals([0])); await tester.tapAt(const Point(4.0, 200.0)); - expect(tapped, equals([5])); + expect(tapped, equals([0])); await tester.tapAt(const Point(6.0, 200.0)); - expect(tapped, equals([5, 4])); + expect(tapped, equals([0, 1])); await tester.tapAt(const Point(800.0 - 14.0, 200.0)); - expect(tapped, equals([5, 4])); + expect(tapped, equals([0, 1])); await tester.tapAt(const Point(800.0 - 16.0, 200.0)); - expect(tapped, equals([5, 4, 4])); + expect(tapped, equals([0, 1, 1])); }); testWidgets('Tap immediately following clamped overscroll', (WidgetTester tester) async { diff --git a/packages/flutter/test/widgets/slivers_padding_test.dart b/packages/flutter/test/widgets/slivers_padding_test.dart index cd441f55f20..c88fe291a49 100644 --- a/packages/flutter/test/widgets/slivers_padding_test.dart +++ b/packages/flutter/test/widgets/slivers_padding_test.dart @@ -169,7 +169,6 @@ void main() { ], )); expect(tester.renderObject(find.text('x')).localToGlobal(Point.origin), const Point(0.0, 200.0)); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 100.0); }); testWidgets('Viewport2+SliverPadding changing padding', (WidgetTester tester) async { @@ -182,7 +181,6 @@ void main() { ], )); expect(tester.renderObject(find.text('x')).localToGlobal(Point.origin), const Point(399.0, 0.0)); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 1.0); await tester.pumpWidget(new Viewport2( axisDirection: AxisDirection.left, offset: new ViewportOffset.fixed(0.0), @@ -192,7 +190,6 @@ void main() { ], )); expect(tester.renderObject(find.text('x')).localToGlobal(Point.origin), const Point(409.0, 0.0)); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 1.0); }); testWidgets('Viewport2+SliverPadding changing direction', (WidgetTester tester) async { @@ -203,7 +200,7 @@ void main() { new SliverPadding(padding: const EdgeInsets.fromLTRB(1.0, 2.0, 4.0, 8.0)), ], )); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 1.0); + expect(tester.renderObject(find.byType(SliverPadding)).afterPadding, 2.0); await tester.pumpWidget(new Viewport2( axisDirection: AxisDirection.down, offset: new ViewportOffset.fixed(0.0), @@ -211,7 +208,7 @@ void main() { new SliverPadding(padding: const EdgeInsets.fromLTRB(1.0, 2.0, 4.0, 8.0)), ], )); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 4.0); + expect(tester.renderObject(find.byType(SliverPadding)).afterPadding, 8.0); await tester.pumpWidget(new Viewport2( axisDirection: AxisDirection.right, offset: new ViewportOffset.fixed(0.0), @@ -219,7 +216,7 @@ void main() { new SliverPadding(padding: const EdgeInsets.fromLTRB(1.0, 2.0, 4.0, 8.0)), ], )); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 8.0); + expect(tester.renderObject(find.byType(SliverPadding)).afterPadding, 4.0); await tester.pumpWidget(new Viewport2( axisDirection: AxisDirection.left, offset: new ViewportOffset.fixed(0.0), @@ -227,7 +224,7 @@ void main() { new SliverPadding(padding: const EdgeInsets.fromLTRB(1.0, 2.0, 4.0, 8.0)), ], )); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 2.0); + expect(tester.renderObject(find.byType(SliverPadding)).afterPadding, 1.0); await tester.pumpWidget(new Viewport2( axisDirection: AxisDirection.left, offset: new ViewportOffset.fixed(99999.9), @@ -235,6 +232,6 @@ void main() { new SliverPadding(padding: const EdgeInsets.fromLTRB(1.0, 2.0, 4.0, 8.0)), ], )); - expect(tester.renderObject(find.byType(SliverPadding)).endPadding, 2.0); + expect(tester.renderObject(find.byType(SliverPadding)).afterPadding, 1.0); }); }