github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Init licenses for test bindings (#81961)" (#82337)

Browse Source
This commit is contained in:
Jia Hao 2021-05-14 12:29:03 +08:00 committed by GitHub
parent 93c87e92b3
commit 08154b22ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dev/automated_tests/integration_test/license_expectation.txt
View File

@ -1 +0,0 @@
[0-9]+:[0-9]+ [+]1: All tests passed!

53
dev/automated_tests/integration_test/license_test.dart
View File

@ -1,53 +0,0 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('Can show the license page', (WidgetTester tester) async {
await tester.pumpWidget(const TestApp());
await tester.pump();
final Finder button = find.byType(TextButton);
await tester.tap(button);
await tester.pumpAndSettle();
await tester.scrollUntilVisible(
// Dart should very definitely be in the licenses list.
find.text('dart'),
100,
maxScrolls: 200,
);
expect(find.text('dart'), findsOneWidget);
});
}
class TestApp extends StatelessWidget {
const TestApp({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return const MaterialApp(
home: ShowLicenseButton(),
);
}
}
class ShowLicenseButton extends StatelessWidget {
const ShowLicenseButton({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return TextButton(
onPressed: () => showLicensePage(context: context),
child: const Text(
'Show licenses',
key: Key('show-licenses'),
),
);
}
}

14
packages/flutter_test/lib/src/binding.dart
View File

@ -297,6 +297,13 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
_testTextInput = TestTextInput(onCleared: _resetFocusedEditable);
}
@override
// ignore: MUST_CALL_SUPER
void initLicenses() {
// Do not include any licenses, because we're a test, and the LICENSE file
// doesn't get generated for tests.
}
/// Whether there is currently a test executing.
bool get inTest;
@ -898,13 +905,6 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
binding.mockFlutterAssets();
}
@override
// ignore: MUST_CALL_SUPER
void initLicenses() {
// Do not include any licenses, because we're a test, and the LICENSE file
// doesn't get generated for tests.
}
FakeAsync? _currentFakeAsync; // set in runTest; cleared in postTest
Completer<void>? _pendingAsyncTasks;

4
packages/flutter_tools/test/integration.shard/test_test.dart
View File

@ -209,10 +209,6 @@ void main() {
}
expect(result.exitCode, 0);
});
testWithoutContext('integration test can show the license page', () async {
return _testFile('license', automatedTestsDirectory, integrationTestDirectory, exitCode: isZero, extraArguments: integrationTestExtraArgs);
});
}
Future<void> _testFile(