github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tool] allow disabling profile mode timeline traces (#97622)

Browse Source
This commit is contained in:
Jonah Williams 2022-02-02 16:00:16 -08:00 committed by GitHub
parent 4a7e30f87d
commit 0b72d5ca58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter_tools/lib/src/compile.dart
View File

@ -177,8 +177,12 @@ List<String> buildModeOptions(BuildMode mode, List<String> dartDefines) {
]; ];
case BuildMode.profile: case BuildMode.profile:
return <String>[ return <String>[
'-Ddart.vm.profile=true', // These checks allow the CLI to override the value of this define for
'-Ddart.vm.product=false', // benchmarks with most timeline traces disabled.
if (!dartDefines.any((String define) => define.startsWith('dart.vm.profile')))
'-Ddart.vm.profile=true',
if (!dartDefines.any((String define) => define.startsWith('dart.vm.product')))
'-Ddart.vm.product=false',
]; ];
case BuildMode.release: case BuildMode.release:
return <String>[ return <String>[

15
packages/flutter_tools/test/general.shard/compile_test.dart
View File

@ -89,16 +89,27 @@ void main() {
]); ]);
}); });
testWithoutContext('buildModeOptions removes matching profile define', () { testWithoutContext('buildModeOptions removes matching profile define in debug mode', () {
expect(buildModeOptions(BuildMode.debug, <String>['dart.vm.profile=true']), <String>[ expect(buildModeOptions(BuildMode.debug, <String>['dart.vm.profile=true']), <String>[
'-Ddart.vm.product=false', '-Ddart.vm.product=false',
'--enable-asserts', '--enable-asserts',
]); ]);
}); });
testWithoutContext('buildModeOptions removes both matching profile and release define', () { testWithoutContext('buildModeOptions removes both matching profile and release define in debug mode', () {
expect(buildModeOptions(BuildMode.debug, <String>['dart.vm.profile=true', 'dart.vm.product=true']), <String>[ expect(buildModeOptions(BuildMode.debug, <String>['dart.vm.profile=true', 'dart.vm.product=true']), <String>[
'--enable-asserts', '--enable-asserts',
]); ]);
}); });
testWithoutContext('buildModeOptions removes matching profile define in profile mode', () {
expect(buildModeOptions(BuildMode.profile, <String>['dart.vm.profile=true']), <String>[
'-Ddart.vm.product=false',
]);
});
testWithoutContext('buildModeOptions removes both matching profile and release define in profile mode', () {
expect(buildModeOptions(BuildMode.profile, <String>['dart.vm.profile=false', 'dart.vm.product=true']), <String>[
]);
});
} }