github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure fab semantics end up on top (#34512)

Browse Source
This commit is contained in:
Dan Field 2019-06-14 14:47:54 -07:00 committed by GitHub
parent 8f75d53735
commit 1427fef8f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter/lib/src/material/floating_action_button.dart
View File

@ -462,11 +462,9 @@ class FloatingActionButton extends StatelessWidget {
);
if (tooltip != null) {
result = MergeSemantics(
child: Tooltip(
message: tooltip,
child: result,
),
result = Tooltip(
message: tooltip,
child: result,
);
}
@ -477,7 +475,7 @@ class FloatingActionButton extends StatelessWidget {
);
}
return result;
return MergeSemantics(child: result);
}
@override

16
packages/flutter/test/material/floating_action_button_test.dart
View File

@ -763,6 +763,22 @@ void main() {
paintsExactlyCountTimes(#clipPath, 0),
);
});
testWidgets('Can find FloatingActionButton semantics', (WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
home: FloatingActionButton(onPressed: () {}),
));
expect(
tester.getSemantics(find.byType(FloatingActionButton)),
matchesSemantics(
hasTapAction: true,
hasEnabledState: true,
isButton: true,
isEnabled: true,
),
);
}, semanticsEnabled: true);
}
Offset _rightEdgeOfFab(WidgetTester tester) {