github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use duration not threadDuration for frame duration (#13117)

Browse Source 
1. We want to measure wall-clock duration for the benchmarks, as opposed
   to thread duration (e.g., waiting on a mutex should accrue time) and
   'dur' is the metric to use for that.

2. On Darwin-based systems (macOS and iOS) 'tdur' is the result of a
   mach syscall lookup to thread_info. This call returns unreliable data
   on iOS. Chromium, for example, disables thread time support entirely
   for iOS.
This commit is contained in:
Chris Bracken 2017-11-20 17:37:14 -08:00 committed by GitHub
parent a95b752dc6
commit 14b5cb047e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter_driver/lib/src/timeline_summary.dart
View File

@ -30,19 +30,19 @@ class TimelineSummary {
/// ///
/// Returns null if no frames were recorded. /// Returns null if no frames were recorded.
double computeAverageFrameBuildTimeMillis() { double computeAverageFrameBuildTimeMillis() {
return _averageInMillis(_extractFrameThreadDurations()); return _averageInMillis(_extractFrameDurations());
} }
/// The longest frame build time in milliseconds. /// The longest frame build time in milliseconds.
/// ///
/// Returns null if no frames were recorded. /// Returns null if no frames were recorded.
double computeWorstFrameBuildTimeMillis() { double computeWorstFrameBuildTimeMillis() {
return _maxInMillis(_extractFrameThreadDurations()); return _maxInMillis(_extractFrameDurations());
} }
/// The number of frames that missed the [kBuildBudget] and therefore are /// The number of frames that missed the [kBuildBudget] and therefore are
/// in the danger of missing frames. /// in the danger of missing frames.
int computeMissedFrameBuildBudgetCount([Duration frameBuildBudget = kBuildBudget]) => _extractFrameThreadDurations() int computeMissedFrameBuildBudgetCount([Duration frameBuildBudget = kBuildBudget]) => _extractFrameDurations()
.where((Duration duration) => duration > kBuildBudget) .where((Duration duration) => duration > kBuildBudget)
.length; .length;
@ -67,7 +67,7 @@ class TimelineSummary {
.length; .length;
/// The total number of frames recorded in the timeline. /// The total number of frames recorded in the timeline.
int countFrames() => _extractFrameThreadDurations().length; int countFrames() => _extractFrameDurations().length;
/// Encodes this summary as JSON. /// Encodes this summary as JSON.
Map<String, dynamic> get summaryJson { Map<String, dynamic> get summaryJson {
@ -79,7 +79,7 @@ class TimelineSummary {
'worst_frame_rasterizer_time_millis': computeWorstFrameRasterizerTimeMillis(), 'worst_frame_rasterizer_time_millis': computeWorstFrameRasterizerTimeMillis(),
'missed_frame_rasterizer_budget_count': computeMissedFrameRasterizerBudgetCount(), 'missed_frame_rasterizer_budget_count': computeMissedFrameRasterizerBudgetCount(),
'frame_count': countFrames(), 'frame_count': countFrames(),
'frame_build_times': _extractFrameThreadDurations() 'frame_build_times': _extractFrameDurations()
.map((Duration duration) => duration.inMicroseconds) .map((Duration duration) => duration.inMicroseconds)
.toList(), .toList(),
'frame_rasterizer_times': _extractGpuRasterizerDrawEvents() 'frame_rasterizer_times': _extractGpuRasterizerDrawEvents()
@ -124,9 +124,8 @@ class TimelineSummary {
.toList(); .toList();
} }
List<Duration> _extractThreadDurations(String name) { List<Duration> _extractDurations(String name) {
return _extractNamedEvents(name) return _extractNamedEvents(name).map((TimelineEvent event) => event.duration).toList();
.map((TimelineEvent event) => event.threadDuration).toList();
} }
/// Extracts timed events that are reported as a pair of begin/end events. /// Extracts timed events that are reported as a pair of begin/end events.
@ -171,7 +170,7 @@ class TimelineSummary {
List<TimedEvent> _extractGpuRasterizerDrawEvents() => _extractBeginEndEvents('GPURasterizer::Draw'); List<TimedEvent> _extractGpuRasterizerDrawEvents() => _extractBeginEndEvents('GPURasterizer::Draw');
List<Duration> _extractFrameThreadDurations() => _extractThreadDurations('Frame'); List<Duration> _extractFrameDurations() => _extractDurations('Frame');
Iterable<Duration> _extractDuration(Iterable<TimedEvent> events) { Iterable<Duration> _extractDuration(Iterable<TimedEvent> events) {
return events.map((TimedEvent e) => e.duration); return events.map((TimedEvent e) => e.duration);

2
packages/flutter_driver/test/src/timeline_summary_test.dart
View File

@ -20,7 +20,7 @@ void main() {
} }
Map<String, dynamic> build(int timeStamp, int duration) => <String, dynamic>{ Map<String, dynamic> build(int timeStamp, int duration) => <String, dynamic>{
'name': 'Frame', 'ph': 'X', 'ts': timeStamp, 'tdur': duration 'name': 'Frame', 'ph': 'X', 'ts': timeStamp, 'dur': duration
}; };
Map<String, dynamic> begin(int timeStamp) => <String, dynamic>{ Map<String, dynamic> begin(int timeStamp) => <String, dynamic>{