From 1d24fa8f6088eb6e956a3d0877d2992c2f9f7fb2 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Wed, 20 Nov 2024 17:13:50 -0800 Subject: [PATCH] Un-skip tests that use `flutter build apk`. (#159231) Closes https://github.com/flutter/flutter/issues/158560. I believe but am not sure as of https://github.com/flutter/flutter/pull/159170 merging, many process flakes that were consuming memory and in turn, making Gradle particularly sensitive to timing out or being killing by the OS for low-memory, have been rectified. It is possible there are additional problems, but they aren't visible at the moment. I'd like to re-enable these and keep tracking their stability. --- .../test/integration.shard/isolated/native_assets_test.dart | 3 --- .../isolated/native_assets_without_cbuild_assemble_test.dart | 3 --- 2 files changed, 6 deletions(-) diff --git a/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart b/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart index 8d09e2af7db..e86fea21cea 100644 --- a/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart +++ b/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart @@ -223,9 +223,6 @@ void main() { expectCCompilerIsConfigured(exampleDirectory); }); }, - // TODO(matanlurey): Debug why flutter build apk often timesout. - // See https://github.com/flutter/flutter/issues/158560 for details. - skip: buildSubcommand == 'apk' ? 'flutter build apk times out' : false, // Temporary workaround for https://github.com/flutter/flutter/issues/158560. tags: ['flutter-build-apk'], ); } diff --git a/packages/flutter_tools/test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart b/packages/flutter_tools/test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart index 0b06f436bfa..81b1c050bae 100644 --- a/packages/flutter_tools/test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart +++ b/packages/flutter_tools/test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart @@ -143,9 +143,6 @@ void main(List args) async { expect(await process.exitCode, 0); },); }, - // TODO(matanlurey): Debug why flutter build apk often timesout. - // See https://github.com/flutter/flutter/issues/158560 for details. - skip: buildCommand == 'apk' ? 'flutter build apk times out' : false, // Temporary workaround for https://github.com/flutter/flutter/issues/158560. tags: ['flutter-build-apk'], ); }