github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Appended period remove & Uri parsing fix. (#131293)

Browse Source 
Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.

As for example:
```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log.
``` 

Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode).

```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log
``` 

Fixes:  #131166
This commit is contained in:
Sumit Bikram Maity 2023-08-01 02:12:11 +05:30 committed by GitHub
parent efc9e16ea3
commit 1d59196baf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/reporting/crash_reporting.dart
View File

@ -69,7 +69,7 @@ class CrashReporter {
/// Prints instructions for filing a bug about the crash.
Future<void> informUser(CrashDetails details, File crashFile) async {
_logger.printError('A crash report has been written to ${crashFile.path}.');
_logger.printError('A crash report has been written to ${crashFile.path}');
_logger.printStatus('This crash may already be reported. Check GitHub for similar crashes.', emphasis: true);
final String similarIssuesURL = GitHubTemplateCreator.toolCrashSimilarIssuesURL(details.error.toString());

2
packages/flutter_tools/test/general.shard/crash_reporting_test.dart
View File

@ -100,7 +100,7 @@ void main() {
expect(logger.statusText, contains('NoPIIFakeDoctorText'));
expect(logger.statusText, isNot(contains('Ignored')));
expect(logger.statusText, contains('https://github.com/flutter/flutter/issues/new'));
expect(logger.errorText, contains('A crash report has been written to ${file.path}.'));
expect(logger.errorText.trim(), 'A crash report has been written to ${file.path}');
});
testWithoutContext('suppress analytics', () async {