github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flutter web app not respecting assets path when in non-root folder (#96774)

Browse Source
This commit is contained in:
nicolasvac 2022-03-11 00:50:16 +01:00 committed by GitHub
parent 0d4b73b2e8
commit 201a64c98f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/bots/service_worker_test.dart
View File

@ -136,7 +136,6 @@ Future<void> runWebServiceWorkerTest({
}); });
expectRequestCounts(<String, int>{ expectRequestCounts(<String, int>{
'': 1,
// Even though the server is caching index.html is downloaded twice, // Even though the server is caching index.html is downloaded twice,
// once by the initial page load, and once by the service worker. // once by the initial page load, and once by the service worker.
// Other resources are loaded once only by the service worker. // Other resources are loaded once only by the service worker.
@ -183,7 +182,6 @@ Future<void> runWebServiceWorkerTest({
expectRequestCounts(<String, int>{ expectRequestCounts(<String, int>{
'index.html': 2, 'index.html': 2,
'flutter_service_worker.js': 2, 'flutter_service_worker.js': 2,
'': 1,
'main.dart.js': 1, 'main.dart.js': 1,
'assets/NOTICES': 1, 'assets/NOTICES': 1,
'assets/AssetManifest.json': 1, 'assets/AssetManifest.json': 1,
@ -210,7 +208,6 @@ Future<void> runWebServiceWorkerTest({
}); });
expectRequestCounts(<String, int>{ expectRequestCounts(<String, int>{
'': 1,
'index.html': 2, 'index.html': 2,
// We still download some resources multiple times if the server is non-caching. // We still download some resources multiple times if the server is non-caching.
'main.dart.js': 2, 'main.dart.js': 2,
@ -260,7 +257,6 @@ Future<void> runWebServiceWorkerTest({
'flutter_service_worker.js': 1, 'flutter_service_worker.js': 1,
}); });
expectRequestCounts(<String, int>{ expectRequestCounts(<String, int>{
'': 1,
'index.html': 2, 'index.html': 2,
'flutter_service_worker.js': 2, 'flutter_service_worker.js': 2,
'main.dart.js': 2, 'main.dart.js': 2,

1
packages/flutter_tools/lib/src/build_system/targets/web.dart
View File

@ -518,7 +518,6 @@ class WebServiceWorker extends Target {
final String serviceWorker = generateServiceWorker( final String serviceWorker = generateServiceWorker(
urlToHash, urlToHash,
<String>[ <String>[
'/',
'main.dart.js', 'main.dart.js',
'index.html', 'index.html',
'assets/NOTICES', 'assets/NOTICES',