From 29ffb88f71f8c29eabc62afacd50ac8c9f927f2c Mon Sep 17 00:00:00 2001
From: Koji Wakamiya <koji.wakamiya@gmail.com>
Date: Fri, 24 Jan 2025 00:07:21 +0900
Subject: [PATCH] fix: Call codec.dispose in `dev/` (#161112)

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

PR derived from https://github.com/flutter/flutter/pull/159945.

Added `codec.dispose()` for directories under `dev/`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---
 dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart    | 1 +
 dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart | 1 +
 dev/integration_tests/wide_gamut_test/lib/main.dart       | 4 +++-
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart b/dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart
index 78a3204d60b..36163d87605 100644
--- a/dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart
+++ b/dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart
@@ -10,6 +10,7 @@ Future<ui.Image> loadImage(String asset) async {
   final ui.ImmutableBuffer buffer = await ui.ImmutableBuffer.fromAsset(asset);
   final ui.Codec codec = await PaintingBinding.instance.instantiateImageCodecWithSize(buffer);
   final ui.FrameInfo frameInfo = await codec.getNextFrame();
+  codec.dispose();
   return frameInfo.image;
 }
 
diff --git a/dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart b/dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart
index cc2b6440c65..0b4dd48ec9c 100644
--- a/dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart
+++ b/dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart
@@ -10,6 +10,7 @@ Future<ui.Image> loadImage(String asset) async {
   final ui.ImmutableBuffer buffer = await ui.ImmutableBuffer.fromAsset(asset);
   final ui.Codec codec = await PaintingBinding.instance.instantiateImageCodecWithSize(buffer);
   final ui.FrameInfo frameInfo = await codec.getNextFrame();
+  codec.dispose();
   return frameInfo.image;
 }
 
diff --git a/dev/integration_tests/wide_gamut_test/lib/main.dart b/dev/integration_tests/wide_gamut_test/lib/main.dart
index 7fa5dd25f8c..970f6240760 100644
--- a/dev/integration_tests/wide_gamut_test/lib/main.dart
+++ b/dev/integration_tests/wide_gamut_test/lib/main.dart
@@ -238,7 +238,9 @@ Future<ui.Image> _loadImage() async {
   );
   final ui.ImageDescriptor descriptor = await ui.ImageDescriptor.encoded(buffer);
   final ui.Codec codec = await descriptor.instantiateCodec();
-  return (await codec.getNextFrame()).image;
+  final ui.FrameInfo frameInfo = await codec.getNextFrame();
+  codec.dispose();
+  return frameInfo.image;
 }
 
 class MyHomePage extends StatefulWidget {