github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove out dated todos from integration tests with no issue links (#85461)

Browse Source
This commit is contained in:
Justin McCandless 2021-06-28 13:21:03 -07:00 committed by GitHub
parent af42e7d730
commit 32e6de84db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_gesture_transformable.dart
View File

@ -175,8 +175,8 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
} }
// Get the offset of the current widget from the global screen coordinates. // Get the offset of the current widget from the global screen coordinates.
// TODO(justinmc): Protect against calling this during first build.
static Offset getOffset(BuildContext context) { static Offset getOffset(BuildContext context) {
assert(context.findRenderObject() != null, 'The given context must have a renderObject, such as after the first build has completed.');
final RenderBox renderObject = context.findRenderObject()! as RenderBox; final RenderBox renderObject = context.findRenderObject()! as RenderBox;
return renderObject.localToGlobal(Offset.zero); return renderObject.localToGlobal(Offset.zero);
} }
@ -334,8 +334,6 @@ class _GestureTransformableState extends State<GestureTransformable> with Ticker
Offset(nextTranslation.dx, nextTranslation.dy), Offset(nextTranslation.dx, nextTranslation.dy),
); );
if (!inBoundaries) { if (!inBoundaries) {
// TODO(justinmc): Instead of canceling translation when it goes out of
// bounds, stop translation at boundary.
return matrix; return matrix;
} }

2
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_inertial_motion.dart
View File

@ -9,7 +9,6 @@ import 'package:vector_math/vector_math.dart' show Vector2;
// Provides calculations for an object moving with inertia and friction using // Provides calculations for an object moving with inertia and friction using
// the equation of motion from physics. // the equation of motion from physics.
// https://en.wikipedia.org/wiki/Equations_of_motion#Constant_translational_acceleration_in_a_straight_line // https://en.wikipedia.org/wiki/Equations_of_motion#Constant_translational_acceleration_in_a_straight_line
// TODO(justinmc): Can this be replaced with friction_simulation.dart?
@immutable @immutable
class InertialMotion { class InertialMotion {
const InertialMotion(this._initialVelocity, this._initialPosition); const InertialMotion(this._initialVelocity, this._initialPosition);
@ -30,7 +29,6 @@ class InertialMotion {
// The acceleration opposing the initial velocity in x and y components. // The acceleration opposing the initial velocity in x and y components.
Vector2 get _acceleration { Vector2 get _acceleration {
// TODO(justinmc): Find actual velocity instead of summing?
final double velocityTotal = _initialVelocity.pixelsPerSecond.dx.abs() final double velocityTotal = _initialVelocity.pixelsPerSecond.dx.abs()
+ _initialVelocity.pixelsPerSecond.dy.abs(); + _initialVelocity.pixelsPerSecond.dy.abs();
final double vRatioX = _initialVelocity.pixelsPerSecond.dx / velocityTotal; final double vRatioX = _initialVelocity.pixelsPerSecond.dx / velocityTotal;