github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check that ErrorWidget.builder is not modified after test (#30898)

Browse Source
This commit is contained in:
Dan Field 2019-04-15 12:38:51 -07:00 committed by Jonah Williams
parent 28cb589cd3
commit 330dc94c0f
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/test/widgets/error_widget_builder_test.dart
View File

@ -7,6 +7,7 @@ import 'package:flutter/widgets.dart';
void main() { void main() {
testWidgets('ErrorWidget.builder', (WidgetTester tester) async { testWidgets('ErrorWidget.builder', (WidgetTester tester) async {
final ErrorWidgetBuilder oldBuilder = ErrorWidget.builder;
ErrorWidget.builder = (FlutterErrorDetails details) { ErrorWidget.builder = (FlutterErrorDetails details) {
return const Text('oopsie!', textDirection: TextDirection.ltr); return const Text('oopsie!', textDirection: TextDirection.ltr);
}; };
@ -21,5 +22,6 @@ void main() {
); );
expect(tester.takeException().toString(), 'test'); expect(tester.takeException().toString(), 'test');
expect(find.text('oopsie!'), findsOneWidget); expect(find.text('oopsie!'), findsOneWidget);
ErrorWidget.builder = oldBuilder;
}); });
} }

17
packages/flutter_test/lib/src/binding.dart
View File

@ -584,6 +584,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
final bool autoUpdateGoldensBeforeTest = autoUpdateGoldenFiles; final bool autoUpdateGoldensBeforeTest = autoUpdateGoldenFiles;
final TestExceptionReporter reportTestExceptionBeforeTest = reportTestException; final TestExceptionReporter reportTestExceptionBeforeTest = reportTestException;
final ErrorWidgetBuilder errorWidgetBuilderBeforeTest = ErrorWidget.builder;
// run the test // run the test
await testBody(); await testBody();
@ -598,6 +599,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
invariantTester(); invariantTester();
_verifyAutoUpdateGoldensUnset(autoUpdateGoldensBeforeTest); _verifyAutoUpdateGoldensUnset(autoUpdateGoldensBeforeTest);
_verifyReportTestExceptionUnset(reportTestExceptionBeforeTest); _verifyReportTestExceptionUnset(reportTestExceptionBeforeTest);
_verifyErrorWidgetBuilderUnset(errorWidgetBuilderBeforeTest);
_verifyInvariants(); _verifyInvariants();
} }
@ -667,6 +669,21 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
}()); }());
} }
void _verifyErrorWidgetBuilderUnset(ErrorWidgetBuilder valueBeforeTest) {
assert(() {
if (ErrorWidget.builder != valueBeforeTest) {
FlutterError.reportError(FlutterErrorDetails(
exception: FlutterError(
'The value of ErrorWidget.builder was changed by the test.',
),
stack: StackTrace.current,
library: 'Flutter test framework',
));
}
return true;
}());
}
/// Called by the [testWidgets] function after a test is executed. /// Called by the [testWidgets] function after a test is executed.
void postTest() { void postTest() {
assert(inTest); assert(inTest);