github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Require the diagnotic-port flag on the flutter skia command (#6174)

Browse Source 
The diagnostic port forward can be arbitrarily assigned and typically
is not the default

Fixes https://github.com/flutter/flutter/issues/5867
This commit is contained in:
Jason Simmons 2016-10-03 11:24:18 -07:00 committed by GitHub
parent b371788df1
commit 35de41d648
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_tools/lib/src/commands/skia.dart
View File

@ -7,7 +7,6 @@ import 'dart:io';
import 'package:http/http.dart' as http;
import '../base/common.dart';
import '../globals.dart';
import '../runner/flutter_command.dart';
@ -16,7 +15,6 @@ class SkiaCommand extends FlutterCommand {
argParser.addOption('output-file', help: 'Write the Skia picture file to this path.');
argParser.addOption('skiaserve', help: 'Post the picture to a skiaserve debugger at this URL.');
argParser.addOption('diagnostic-port',
defaultsTo: kDefaultDiagnosticPort.toString(),
help: 'Local port where the diagnostic server is listening.');
}
@ -45,6 +43,10 @@ class SkiaCommand extends FlutterCommand {
printError('Must provide --output-file or --skiaserve');
return 1;
}
if (argResults['diagnostic-port'] == null) {
printError('Must provide --diagnostic-port');
return 1;
}
Uri skpUri = new Uri(scheme: 'http', host: '127.0.0.1',
port: int.parse(argResults['diagnostic-port']),