From 37fafeecb19a00c6b283c9d7e761a9d1de37ab46 Mon Sep 17 00:00:00 2001 From: jcollins-g Date: Fri, 21 Apr 2017 08:11:33 -0700 Subject: [PATCH] Dartdoc bot sanity flexibility (#9496) * Have sanity check pass on old and new versions of flutter --- dev/tools/dartdoc.dart | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/dev/tools/dartdoc.dart b/dev/tools/dartdoc.dart index 64ff8db760f..76ed5ac2f88 100644 --- a/dev/tools/dartdoc.dart +++ b/dev/tools/dartdoc.dart @@ -111,15 +111,32 @@ void createFooter(String footerPath) { } void sanityCheckDocs() { - final List canaries = [ + // TODO(jcollins-g): remove old_sdk_canaries for dartdoc >= 0.10.0 + final List oldSdkCanaries = [ '$kDocRoot/api/dart.io/File-class.html', '$kDocRoot/api/dart.ui/Canvas-class.html', '$kDocRoot/api/dart.ui/Canvas/drawRect.html', + ]; + final List newSdkCanaries = [ + '$kDocRoot/api/dart-io/File-class.html', + '$kDocRoot/api/dart-ui/Canvas-class.html', + '$kDocRoot/api/dart-ui/Canvas/drawRect.html', + ]; + final List canaries = [ '$kDocRoot/api/flutter_test/WidgetTester/pumpWidget.html', '$kDocRoot/api/material/Material-class.html', '$kDocRoot/api/material/Tooltip-class.html', '$kDocRoot/api/widgets/Widget-class.html', ]; + bool oldMissing = false; + for (String canary in oldSdkCanaries) { + if (!new File(canary).existsSync()) { + oldMissing = true; + break; + } + } + if (oldMissing) + canaries.addAll(newSdkCanaries); for (String canary in canaries) { if (!new File(canary).existsSync()) throw new Exception('Missing "$canary", which probably means the documentation failed to build correctly.');