From 3b6e3a693836cf0675355eb009a0455d1e237e1c Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Fri, 19 Aug 2022 11:06:53 -0700 Subject: [PATCH] Temporarily remove a bogus warning until fixed by dwds update (#109793) * Temporarily remove a bogus warning until fixed by dwds update * Addressed CR feedback --- packages/flutter_tools/lib/src/isolated/devfs_web.dart | 7 ++++++- .../test/web.shard/expression_evaluation_web_test.dart | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/isolated/devfs_web.dart b/packages/flutter_tools/lib/src/isolated/devfs_web.dart index de02021eff2..172a3f6d1fa 100644 --- a/packages/flutter_tools/lib/src/isolated/devfs_web.dart +++ b/packages/flutter_tools/lib/src/isolated/devfs_web.dart @@ -1042,7 +1042,12 @@ void log(logging.LogRecord event) { if (event.level >= logging.Level.SEVERE) { globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace); } else if (event.level == logging.Level.WARNING) { - globals.printWarning('${event.loggerName}: ${event.message}$error'); + // Note: Temporary fix for https://github.com/flutter/flutter/issues/109792 + // TODO(annagrin): Remove the condition after the bogus warning is + // removed in dwds: https://github.com/dart-lang/webdev/issues/1722 + if (!event.message.contains('No module for')) { + globals.printWarning('${event.loggerName}: ${event.message}$error'); + } } else { globals.printTrace('${event.loggerName}: ${event.message}$error'); } diff --git a/packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart b/packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart index 3f4564f9f21..737f5e7d4d8 100644 --- a/packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart +++ b/packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart @@ -23,6 +23,7 @@ void main() { flutter = FlutterRunTestDriver(tempDir); flutter.stdout.listen((String line) { expect(line, isNot(contains('Unresolved uri:'))); + expect(line, isNot(contains('No module for'))); }); });