github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tapping a modal bottom sheet should not dismiss it by default (#32528)

Browse Source 
Removed the GestureDetector from the modal bottom sheet that dismissed it on tap and updated several tests to accommodate this change.
This commit is contained in:
Darren Austin 2019-05-15 15:50:39 -07:00 committed by GitHub
parent 20299a2c17
commit 3d93f24c05
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 55 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/flutter_gallery/lib/demo/material/modal_bottom_sheet_demo.dart
View File

@ -24,7 +24,7 @@ class ModalBottomSheetDemo extends StatelessWidget {
return Container( return Container(
child: Padding( child: Padding(
padding: const EdgeInsets.all(32.0), padding: const EdgeInsets.all(32.0),
child: Text('This is the modal bottom sheet. Tap anywhere to dismiss.', child: Text('This is the modal bottom sheet. Slide down to dismiss.',
textAlign: TextAlign.center, textAlign: TextAlign.center,
style: TextStyle( style: TextStyle(
color: Theme.of(context).accentColor, color: Theme.of(context).accentColor,

9
packages/flutter/lib/src/material/bottom_sheet.dart
View File

@ -281,13 +281,7 @@ class _ModalBottomSheetState<T> extends State<_ModalBottomSheet<T>> {
final MaterialLocalizations localizations = MaterialLocalizations.of(context); final MaterialLocalizations localizations = MaterialLocalizations.of(context);
final String routeLabel = _getRouteLabel(localizations); final String routeLabel = _getRouteLabel(localizations);
return GestureDetector( return AnimatedBuilder(
excludeFromSemantics: true,
onTap: () {
if (widget.route.isCurrent)
Navigator.pop(context);
},
child: AnimatedBuilder(
animation: widget.route.animation, animation: widget.route.animation,
builder: (BuildContext context, Widget child) { builder: (BuildContext context, Widget child) {
// Disable the initial animation when accessible navigation is on so // Disable the initial animation when accessible navigation is on so
@ -317,7 +311,6 @@ class _ModalBottomSheetState<T> extends State<_ModalBottomSheet<T>> {
), ),
); );
}, },
),
); );
} }
} }

35
packages/flutter/test/material/modal_bottom_sheet_test.dart → packages/flutter/test/material/bottom_sheet_test.dart
View File

@ -10,7 +10,7 @@ import 'package:flutter/gestures.dart';
import '../widgets/semantics_tester.dart'; import '../widgets/semantics_tester.dart';
void main() { void main() {
testWidgets('Verify that a tap dismisses a modal BottomSheet', (WidgetTester tester) async { testWidgets('Tapping on a modal BottomSheet should not dismiss it', (WidgetTester tester) async {
BuildContext savedContext; BuildContext savedContext;
await tester.pumpWidget(MaterialApp( await tester.pumpWidget(MaterialApp(
@ -33,28 +33,41 @@ void main() {
showBottomSheetThenCalled = true; showBottomSheetThenCalled = true;
}); });
await tester.pump(); // bottom sheet show animation starts await tester.pumpAndSettle();
await tester.pump(const Duration(seconds: 1)); // animation done
expect(find.text('BottomSheet'), findsOneWidget); expect(find.text('BottomSheet'), findsOneWidget);
expect(showBottomSheetThenCalled, isFalse); expect(showBottomSheetThenCalled, isFalse);
// Tap on the bottom sheet itself to dismiss it. // Tap on the bottom sheet itself, it should not be dismissed
await tester.tap(find.text('BottomSheet')); await tester.tap(find.text('BottomSheet'));
await tester.pump(); // bottom sheet dismiss animation starts await tester.pumpAndSettle();
expect(showBottomSheetThenCalled, isTrue); expect(find.text('BottomSheet'), findsOneWidget);
await tester.pump(const Duration(seconds: 1)); // last frame of animation (sheet is entirely off-screen, but still present) expect(showBottomSheetThenCalled, isFalse);
await tester.pump(const Duration(seconds: 1)); // frame after the animation (sheet has been removed) });
testWidgets('Tapping outside a modal BottomSheet should dismiss it', (WidgetTester tester) async {
BuildContext savedContext;
await tester.pumpWidget(MaterialApp(
home: Builder(
builder: (BuildContext context) {
savedContext = context;
return Container();
}
),
));
await tester.pump();
expect(find.text('BottomSheet'), findsNothing); expect(find.text('BottomSheet'), findsNothing);
showBottomSheetThenCalled = false; bool showBottomSheetThenCalled = false;
showModalBottomSheet<void>( showModalBottomSheet<void>(
context: savedContext, context: savedContext,
builder: (BuildContext context) => const Text('BottomSheet'), builder: (BuildContext context) => const Text('BottomSheet'),
).then<void>((void value) { ).then<void>((void value) {
showBottomSheetThenCalled = true; showBottomSheetThenCalled = true;
}); });
await tester.pump(); // bottom sheet show animation starts
await tester.pump(const Duration(seconds: 1)); // animation done await tester.pumpAndSettle();
expect(find.text('BottomSheet'), findsOneWidget); expect(find.text('BottomSheet'), findsOneWidget);
expect(showBottomSheetThenCalled, isFalse); expect(showBottomSheetThenCalled, isFalse);

4
packages/flutter/test/material/persistent_bottom_sheet_test.dart
View File

@ -406,8 +406,8 @@ void main() {
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(find.text('modal bottom sheet'), findsOneWidget); expect(find.text('modal bottom sheet'), findsOneWidget);
// Dismiss the modal bottomSheet // Dismiss the modal bottomSheet by tapping above the sheet
await tester.tap(find.text('modal bottom sheet')); await tester.tapAt(const Offset(20.0, 20.0));
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(find.text('modal bottom sheet'), findsNothing); expect(find.text('modal bottom sheet'), findsNothing);
expect(find.text('showModalBottomSheet'), findsOneWidget); expect(find.text('showModalBottomSheet'), findsOneWidget);