github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return an empty FlutterViews list when the service disappears (#75301)

Browse Source
This commit is contained in:
Jenn Magder 2021-02-03 11:01:03 -08:00 committed by GitHub
parent 9ae10d0fd2
commit 3f163d29a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/vmservice.dart
View File

@ -779,7 +779,10 @@ extension FlutterVmService on vm_service.VmService {
kListViewsMethod, kListViewsMethod,
); );
if (response == null) { if (response == null) {
return null; // The service may have disappeared mid-request.
// Return an empty list now, and let the shutdown logic elsewhere deal
// with cleaning up.
return <FlutterView>[];
} }
final List<Object> rawViews = response.json['views'] as List<Object>; final List<Object> rawViews = response.json['views'] as List<Object>;
final List<FlutterView> views = <FlutterView>[ final List<FlutterView> views = <FlutterView>[

2
packages/flutter_tools/test/general.shard/vmservice_test.dart
View File

@ -356,7 +356,7 @@ void main() {
expect(skSLs, isNull); expect(skSLs, isNull);
final List<FlutterView> views = await fakeVmServiceHost.vmService.getFlutterViews(); final List<FlutterView> views = await fakeVmServiceHost.vmService.getFlutterViews();
expect(views, isNull); expect(views, isEmpty);
final vm_service.Response screenshot = await fakeVmServiceHost.vmService.screenshot(); final vm_service.Response screenshot = await fakeVmServiceHost.vmService.screenshot();
expect(screenshot, isNull); expect(screenshot, isNull);