github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move debug error message from failed pub to logger.printTrace (#118379)

Browse Source 
* Move debug error message from failed pub to logger.printTrace

* Update test
This commit is contained in:
Sigurd Meldgaard 2023-01-12 20:24:20 +01:00 committed by GitHub
parent 27502f6852
commit 40bc6b55e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_tools/lib/src/dart/pub.dart
View File

@ -475,10 +475,8 @@ class _DefaultPub implements Pub {
buffer.writeln('command: "${pubCommand.join(' ')}"'); buffer.writeln('command: "${pubCommand.join(' ')}"');
buffer.write(_stringifyPubEnv(pubEnvironment)); buffer.write(_stringifyPubEnv(pubEnvironment));
buffer.writeln('exit code: $code'); buffer.writeln('exit code: $code');
throwToolExit( _logger.printTrace(buffer.toString());
buffer.toString(), throwToolExit(null, exitCode: code);
exitCode: code,
);
} }
} }

3
packages/flutter_tools/test/general.shard/dart/pub_get_test.dart
View File

@ -555,9 +555,10 @@ exit code: 66
project: FlutterProject.fromDirectoryTest(fileSystem.currentDirectory), project: FlutterProject.fromDirectoryTest(fileSystem.currentDirectory),
context: PubContext.flutterTests, context: PubContext.flutterTests,
), ),
throwsA(isA<ToolExit>().having((ToolExit error) => error.message, 'message', toolExitMessage)), throwsA(isA<ToolExit>().having((ToolExit error) => error.message, 'message', null)),
); );
expect(logger.statusText, isEmpty); expect(logger.statusText, isEmpty);
expect(logger.traceText, contains(toolExitMessage));
expect( expect(
mockStdio.stdout.writes.map(utf8.decode), mockStdio.stdout.writes.map(utf8.decode),
<String>[ <String>[