github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deflake flutter tool logger test (#43800)

Browse Source
This commit is contained in:
Jonah Williams 2019-10-30 13:09:26 -07:00 committed by GitHub
parent e0094eee52
commit 417449e2f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter_tools/lib/src/base/logger.dart
View File

@ -359,12 +359,12 @@ class BufferLogger extends Logger {
class VerboseLogger extends Logger { class VerboseLogger extends Logger {
VerboseLogger(this.parent) : assert(terminal != null) { VerboseLogger(this.parent) : assert(terminal != null) {
stopwatch.start(); _stopwatch.start();
} }
final Logger parent; final Logger parent;
Stopwatch stopwatch = Stopwatch(); final Stopwatch _stopwatch = context.get<Stopwatch>() ?? Stopwatch();
@override @override
bool get isVerbose => true; bool get isVerbose => true;
@ -438,8 +438,8 @@ class VerboseLogger extends Logger {
return; return;
} }
final int millis = stopwatch.elapsedMilliseconds; final int millis = _stopwatch.elapsedMilliseconds;
stopwatch.reset(); _stopwatch.reset();
String prefix; String prefix;
const int prefixWidth = 8; const int prefixWidth = 8;

7
packages/flutter_tools/test/general.shard/base/logger_test.dart
View File

@ -24,6 +24,11 @@ void main() {
final String resetColor = RegExp.escape(AnsiTerminal.resetColor); final String resetColor = RegExp.escape(AnsiTerminal.resetColor);
group('AppContext', () { group('AppContext', () {
FakeStopwatch fakeStopWatch;
setUp(() {
fakeStopWatch = FakeStopwatch();
});
testUsingContext('error', () async { testUsingContext('error', () async {
final BufferLogger mockLogger = BufferLogger(); final BufferLogger mockLogger = BufferLogger();
final VerboseLogger verboseLogger = VerboseLogger(mockLogger); final VerboseLogger verboseLogger = VerboseLogger(mockLogger);
@ -39,6 +44,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
OutputPreferences: () => OutputPreferences(showColor: false), OutputPreferences: () => OutputPreferences(showColor: false),
Platform: _kNoAnsiPlatform, Platform: _kNoAnsiPlatform,
Stopwatch: () => fakeStopWatch,
}); });
testUsingContext('ANSI colored errors', () async { testUsingContext('ANSI colored errors', () async {
@ -60,6 +66,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
OutputPreferences: () => OutputPreferences(showColor: true), OutputPreferences: () => OutputPreferences(showColor: true),
Platform: () => FakePlatform()..stdoutSupportsAnsi = true, Platform: () => FakePlatform()..stdoutSupportsAnsi = true,
Stopwatch: () => fakeStopWatch,
}); });
}); });