mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
Remove flutter engine repo links (#167481)
3 notable places I did not migrate. 1. engine/src/flutter/docs/Engine-disk-footprint.md treemaps and what hash is used for what upload. 1. engine/src/flutter/lib/gpu/pubspec.yaml, I didnt want this pr to update code that could need to be reverted and I didnt know what to do to test that publishing would not break or cause a downstream breakage. 1. engine/src/flutter/build/zip_bundle.gni I wasnt sure how to test my changes. Reviewers: Please let me know if you want a different link or if you would prefer something unmodified. Commits: - **Replace triage links with equivalents, change pull request to generic flutter/flutter, replace code search link with equivalent** - **Change link from flutter/engine to engine folder, modify link text to team** - **replace engine repo link with engine folder, replace text repo with folder** - **replace engine specific security info with flutter generic** - **replace engine roller comment with a skia roller equivalent** - **link to same file in new location** - **Remove comment that some code lives in flutter/flutter and some in flutter/engine** - **Say to bump dart in flutter/flutter without mentioning engine** - **Replace documentation with new locations** - **replace code printed comments with new locations** Partially addresses https://github.com/flutter/flutter/issues/167478 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This commit is contained in:
Reid Baker
GitHub
parent
138b10a68b
commit
46ef0dea2f
@ -78,7 +78,7 @@ Flutter provides multiple functionality through self-service services. Most of t
|
||||
</td>
|
||||
<td><a href="https://github.com/flutter/flutter/blob/main/engine/src/flutter/ci/builders/README.md">Link</a>
|
||||
</td>
|
||||
<td><a href="https://github.com/flutter/engine/tree/main/ci/builders">engine/ci/builders</a> in the <a href="https://github.com/flutter/engine/tree/main">flutter/engine</a> repository contains all the current configuration files.
|
||||
<td><a href="https://github.com/flutter/flutter/tree/main/engine/src/flutter/ci/builders">engine/src/flutter/ci/builders</a> in the <a href="https://github.com/flutter/flutter/tree/main/engine">flutter engine</a> folder contains all the current configuration files.
|
||||
</td>
|
||||
</tr>
|
||||
<tr>
|
||||
@ -114,7 +114,7 @@ Flutter provides multiple functionality through self-service services. Most of t
|
||||
</td>
|
||||
<td>[Link](./engine/release/Code-signing-metadata.md)
|
||||
</td>
|
||||
<td>GN files and global generator scripts in the <a href="https://github.com/flutter/engine">flutter/engine</a> repository.
|
||||
<td>GN files and global generator scripts in the <a href="https://github.com/flutter/flutter/tree/main/engine">flutter engine</a> folder.
|
||||
</td>
|
||||
</tr>
|
||||
<tr>
|
||||
@ -283,9 +283,9 @@ Flutter provides multiple functionality through self-service services. Most of t
|
||||
</td>
|
||||
<td>Flutter organization members
|
||||
</td>
|
||||
<td><a href="https://github.com/flutter/engine/security/code-scanning">Link</a>
|
||||
<td><a href="https://github.com/flutter/flutter/security/code-scanning">Link</a>
|
||||
</td>
|
||||
<td><a href="https://github.com/flutter/engine/security">Engine GitHub security tab</a>.
|
||||
<td><a href="https://github.com/flutter/flutter/security">Flutter GitHub security tab</a>.
|
||||
</td>
|
||||
</tr>
|
||||
<tr>
|
||||
|
||||
@ -12,13 +12,13 @@ The Flutter project has many teams, including, but not limited to:
|
||||
|
||||
* Ecosystem ([flutter/plugins](https://github.com/flutter/plugins), [flutter/packages](https://github.com/flutter/packages), [the plugin infrastructure in flutter/flutter](https://github.com/flutter/flutter/tree/main/packages/flutter/lib/src/services); labels ["plugins"](https://github.com/flutter/flutter/labels/plugins), and ["packages"](https://github.com/flutter/flutter/labels/packages))
|
||||
|
||||
* The Engine ([flutter/engine](https://github.com/flutter/engine) and [flutter/buildroot](https://github.com/flutter/buildroot/); label ["engine"](https://github.com/flutter/flutter/labels/engine))
|
||||
* The Engine ([flutter engine]https://github.com/flutter/flutter/tree/main/engine) and [flutter/buildroot](https://github.com/flutter/buildroot/); label ["engine"](https://github.com/flutter/flutter/labels/engine))
|
||||
|
||||
* Various platform-specific teams including iOS, Android, Windows, Linux, and macOS (some code in flutter/flutter and flutter/engine); labels ["platform-android"](https://github.com/flutter/flutter/labels/platform-android), ["platform-ios"](https://github.com/flutter/flutter/labels/platform-ios), etc).
|
||||
* Various platform-specific teams including iOS, Android, Windows, Linux, and macOS; labels ["platform-android"](https://github.com/flutter/flutter/labels/platform-android), ["platform-ios"](https://github.com/flutter/flutter/labels/platform-ios), etc).
|
||||
|
||||
* Desktop-specific features (some code in flutter/flutter and flutter/engine, ["a: desktop"](https://github.com/flutter/flutter/labels/a%3A%20desktop))
|
||||
* Desktop-specific features (["a: desktop"](https://github.com/flutter/flutter/labels/a%3A%20desktop))
|
||||
|
||||
* Web (some code in flutter/flutter and flutter/engine, label ["platform-web"](https://github.com/flutter/flutter/labels/platform-web))
|
||||
* Web (label ["platform-web"](https://github.com/flutter/flutter/labels/platform-web))
|
||||
|
||||
* Developer experience (e.g. [the devtools package](https://github.com/flutter/devtools/))
|
||||
|
||||
|
||||
@ -1,4 +1,4 @@
|
||||
Flutter combines [a Dart framework](https://github.com/flutter/flutter) with a high-performance [engine](https://github.com/flutter/engine).
|
||||
Flutter combines [a Dart framework](https://github.com/flutter/flutter) with a high-performance [engine](https://github.com/flutter/flutter/tree/main/engine).
|
||||
|
||||
The Flutter Engine is a portable runtime for high-quality cross-platform
|
||||
applications. It implements Flutter's core libraries, including animation and
|
||||
@ -14,7 +14,7 @@ Flutter Engine sits in this stack, highlights API boundaries, and identifies the
|
||||
repositories where the individual pieces live. The legend below clarifies some
|
||||
of the terminology commonly used to describe the pieces of a Flutter app.
|
||||
|
||||
<img src="https://raw.githubusercontent.com/flutter/engine/main/docs/app_anatomy.svg?sanitize=true" alt="Flutter Architecture Diagram" width="40%"/>
|
||||
<img src="https://raw.githubusercontent.com/flutter/flutter/main/engine/src/flutter/docs/app_anatomy.svg?sanitize=true" alt="Flutter Architecture Diagram" width="40%"/>
|
||||
|
||||
#### Dart App
|
||||
|
||||
@ -28,7 +28,7 @@ of the terminology commonly used to describe the pieces of a Flutter app.
|
||||
hit-testing, gesture detection, accessibility, text input, etc.).
|
||||
* Composites the app's widget tree into a scene.
|
||||
|
||||
#### Engine ([source code](https://github.com/flutter/engine/tree/main/shell/common))
|
||||
#### Engine ([source code](https://github.com/flutter/flutter/tree/main/engine/src/flutter/shell/common))
|
||||
|
||||
* Responsible for rasterizing composited scenes.
|
||||
* Provides low-level implementation of Flutter's core APIs (e.g. graphics, text
|
||||
@ -36,7 +36,7 @@ of the terminology commonly used to describe the pieces of a Flutter app.
|
||||
* Exposes its functionality via its **dart:ui API** to the framework.
|
||||
* Integrates with a specific platform via the Engine's **Embedder API**.
|
||||
|
||||
#### Embedder ([source code](https://github.com/flutter/engine/tree/main/shell/platform))
|
||||
#### Embedder ([source code](https://github.com/flutter/flutter/tree/main/engine/src/flutter/shell/platform))
|
||||
|
||||
* Coordinates with the underlying operating system for access to services like
|
||||
rendering surfaces, accessibility, and input.
|
||||
@ -55,10 +55,10 @@ Flutter's engine takes core technologies, Skia, a 2D graphics rendering library,
|
||||
and Dart, a VM for a garbage-collected object-oriented language, and hosts them
|
||||
in a shell. Different platforms have different shells, for example we have
|
||||
shells for
|
||||
[Android](https://github.com/flutter/engine/tree/main/shell/platform/android)
|
||||
and [iOS](https://github.com/flutter/engine/tree/main/shell/platform/darwin). We
|
||||
[Android](https://github.com/flutter/flutter/tree/main/engine/src/flutter/shell/platform/android)
|
||||
and [iOS](https://github.com/flutter/flutter/tree/main/engine/src/flutter/shell/platform/darwin). We
|
||||
also have an [embedder
|
||||
API](https://github.com/flutter/engine/tree/main/shell/platform/embedder) which
|
||||
API](https://github.com/flutter/flutter/tree/main/engine/src/flutter/shell/platform/embedder) which
|
||||
allows Flutter's engine to be used as a library (see [Custom Flutter Engine
|
||||
Embedders](../engine/Custom-Flutter-Engine-Embedders.md)).
|
||||
|
||||
@ -70,7 +70,7 @@ library called `dart:ui` to provide low-level access to Skia features and the
|
||||
shell. The shells can also communicate directly to Dart code via [Platform
|
||||
Channels](https://flutter.io/platform-channels/) which bypass the engine.
|
||||
|
||||
|
||||
|
||||
|
||||
## Threading
|
||||
|
||||
|
||||
@ -84,7 +84,7 @@ _See also: [What should I work on?](What-should-I-work-on.md)_
|
||||
|
||||
## Tests
|
||||
|
||||
Every change in the flutter/engine, flutter/flutter, and flutter/packages repos
|
||||
Every change in the flutter/flutter and flutter/packages repos
|
||||
must be tested; consider using the code coverage tools to check that all your
|
||||
new code is covered by tests (see [Test coverage for package:flutter](./testing/Test-coverage-for-package-flutter.md)).
|
||||
|
||||
@ -369,9 +369,9 @@ behavior, reverting an [auto-roller](../infra/Autorollers.md)
|
||||
(e.g., an engine-roller commit like https://github.com/flutter/flutter/commit/fdcb57b69eff2162e9aead6dec0f8058788e7608)
|
||||
commit could cause some complications:
|
||||
|
||||
1. The auto-roller commit usually include multiple commits of the source repo (e.g., engine-roller
|
||||
commit includes multiple commits of https://github.com/flutter/engine). This can be applied
|
||||
recursively as the engine-roller commit includes a dart-roller commit, or a skia-roller commit.
|
||||
1. The auto-roller commit usually include multiple commits of the source repo (e.g., skia-roller
|
||||
commit includes multiple commits of https://github.com/google/skia). This can be applied
|
||||
recursively as some rollers might include a commit from another roller.
|
||||
Therefore, a roller commit could actually include a ton of leaf-level commits, which makes it
|
||||
really hard to triage which leaf commit actually caused the regression.
|
||||
|
||||
|
||||
@ -2,16 +2,16 @@
|
||||
|
||||
### Runtime assertions
|
||||
|
||||
Unopt builds use [FML_DCHECK](https://cs.opensource.google/flutter/engine/+/master:fml/logging.h;l=86?q=FML_DCHECK&ss=flutter%2Fengine) to enable assertion checks across the engine repository. Assertions on dependencies like Dart VM or Skia are not enabled because local and CI builds would be extremely slow.
|
||||
Unopt builds use [FML_DCHECK](https://cs.opensource.google/flutter/flutter/+/main:engine/src/flutter/fml/logging.h?q=FML_DCHECK&ss=flutter%2Fflutter) to enable assertion checks across the engine repository. Assertions on dependencies like Dart VM or Skia are not enabled because local and CI builds would be extremely slow.
|
||||
Unopt builds are not published or consumed by the flutter/flutter CI to run integration tests or benchmarks.
|
||||
|
||||
### Sanitizers
|
||||
|
||||
[flutter/engine](https://github.com/flutter/engine) supports thread, address, memory, undefined behavior and leak sanitizers. Sanitizers are not enabled by default but they can be enabled on local builds following the [sanitizers with the flutter engine](../engine/Using-Sanitizers-with-the-Flutter-Engine.md) instructions.
|
||||
[flutter/engine](https://github.com/flutter/flutter/tree/main/engine) supports thread, address, memory, undefined behavior and leak sanitizers. Sanitizers are not enabled by default but they can be enabled on local builds following the [sanitizers with the flutter engine](../engine/Using-Sanitizers-with-the-Flutter-Engine.md) instructions.
|
||||
|
||||
### Builds with sanitizers, and tests with assertions enabled
|
||||
|
||||
[flutter/engine](https://github.com/flutter/engine) runs automated builds with sanitizers and testing with assertions. Testing with assertions is enabled in all the supported platforms and sanitizers are enabled only on the Linux platform.
|
||||
[flutter/engine](https://github.com/flutter/flutter/tree/main/engine) runs automated builds with sanitizers and testing with assertions. Testing with assertions is enabled in all the supported platforms and sanitizers are enabled only on the Linux platform.
|
||||
Sanitizer builds:
|
||||
|
||||
* [Linux unopt](https://ci.chromium.org/p/flutter/builders/prod/Linux%20Unopt)
|
||||
|
||||
@ -40,7 +40,7 @@ A Flutter release is very similar to what would be seen on the master branch, wi
|
||||
Prework: Ensure Flutter's release infrastructure is branched for the current version.
|
||||
|
||||
1. Apply any Dart cherry-picks to the Dart branch
|
||||
2. Roll Dart into [flutter/engine](https://github.com/flutter/engine)
|
||||
2. Bump Dart version
|
||||
3. Apply any engine cherry-picks
|
||||
4. Verify all engine builds are green
|
||||
5. Sign engine binaries
|
||||
|
||||
@ -239,9 +239,9 @@ In addition, consider these issues that fall under another team's triage, but ar
|
||||
- [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Ateam-engine%2Cfyi-engine+-label%3Atriaged-engine+no%3Aassignee+-label%3A%22will+need+additional+triage%22+sort%3Aupdated-asc)
|
||||
- [P0 list](https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Ateam-engine+label%3AP0+sort%3Aupdated-asc)
|
||||
- [Buildroot PRs](https://github.com/flutter/buildroot/pulls)
|
||||
- [Approved PRs that have not yet landed](https://github.com/flutter/engine/pulls?q=is%3Aopen+is%3Apr+draft%3Afalse+-label%3A%22Work+in+progress+%28WIP%29%22+review%3Aapproved+NOT+%22Roll+Skia%22+-label%3Aplatform-web+sort%3Acreated-asc)
|
||||
- [PRs awaiting review](https://github.com/flutter/engine/pulls?q=is%3Aopen+is%3Apr+draft%3Afalse+-label%3A%22Work+in+progress+%28WIP%29%22+-label%3A%22waiting+for+tree+to+go+green%22+-label%3A%22platform-web%22+-review%3Aapproved+-label%3A%22waiting+for+customer+response%22+NOT+%22Roll+Skia%22+NOT+%22Roll+Dart%22+NOT+%22Roll+Fuchsia%22+sort%3Aupdated-asc++-label%3A%22platform-web%22+)
|
||||
- [Draft PRs](https://github.com/flutter/engine/pulls?q=is%3Aopen+is%3Apr+label%3A%22Work+in+progress+%28WIP%29%22+-label%3A%22waiting+for+tree+to+go+green%22+-label%3A%22platform-web%22+-review%3Aapproved+-label%3A%22waiting+for+customer+response%22+NOT+%22Roll+Skia%22+sort%3Aupdated-asc++-label%3A%22platform-web%22+)
|
||||
- [Approved PRs that have not yet landed](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+draft%3Afalse+-label%3A%22Work+in+progress+%28WIP%29%22+review%3Aapproved+NOT+%22Roll+Skia%22+-label%3Aplatform-web+sort%3Acreated-asc+label%3Aengine)
|
||||
- [PRs awaiting review](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+draft%3Afalse+-label%3A%22Work+in+progress+%28WIP%29%22+-label%3A%22waiting+for+tree+to+go+green%22+-label%3Aplatform-web+-review%3Aapproved+-label%3A%22waiting+for+customer+response%22+NOT+%22Roll+Skia%22+NOT+%22Roll+Dart%22+NOT+%22Roll+Fuchsia%22+sort%3Aupdated-asc+-label%3Aplatform-web+label%3Aengine)
|
||||
- [Draft PRs](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+-label%3A%22waiting+for+tree+to+go+green%22+-label%3Aplatform-web+-review%3Aapproved+-label%3A%22waiting+for+customer+response%22+NOT+%22Roll+Skia%22+sort%3Aupdated-asc+-label%3Aplatform-web+draft%3Atrue+label%3Aengine)
|
||||
|
||||
### Framework team (`team-framework`)
|
||||
|
||||
|
||||
@ -141,7 +141,7 @@ function verify_licenses() (
|
||||
echo "changed, and then update this file:"
|
||||
echo " flutter/sky/packages/sky_engine/LICENSE"
|
||||
echo "For more information, see the script in:"
|
||||
echo " https://github.com/flutter/engine/tree/main/tools/licenses"
|
||||
echo " https://github.com/flutter/flutter/tree/main/engine/src/flutter/tools/licenses"
|
||||
echo ""
|
||||
diff -U 6 "flutter/ci/licenses_golden/$(basename "$f")" "$f"
|
||||
echo "================================================================="
|
||||
@ -161,7 +161,7 @@ function verify_licenses() (
|
||||
echo "license tool signature golden file:"
|
||||
echo " ci/licenses_golden/tool_signature"
|
||||
echo "For more information, see the script in:"
|
||||
echo " https://github.com/flutter/engine/tree/main/tools/licenses"
|
||||
echo " https://github.com/flutter/flutter/tree/main/engine/src/flutter/tools/licenses"
|
||||
echo ""
|
||||
diff -U 6 "flutter/ci/licenses_golden/tool_signature" "out/license_script_output/tool_signature"
|
||||
echo "================================================================="
|
||||
|
||||
@ -1,4 +1,4 @@
|
||||
This is an index of team-facing documentation for the [flutter/engine repository](https://github.com/flutter/engine/).
|
||||
This is an index of team-facing documentation for the [flutter/engine team](https://github.com/flutter/flutter/tree/main/engine).
|
||||
|
||||
- [Accessibility on Windows](https://github.com/flutter/flutter/blob/master/docs/platforms/desktop/windows/Accessibility-on-Windows.md)
|
||||
- [Code signing metadata](./release/Code-signing-metadata.md) for engine binaries
|
||||
|
||||
@ -3,7 +3,7 @@
|
||||
### How do I enable Impeller to try it out myself?
|
||||
|
||||
See the instructions in the README on how to [try Impeller in
|
||||
Flutter](https://github.com/flutter/engine/tree/main/impeller#try-impeller-in-flutter).
|
||||
Flutter](https://github.com/flutter/flutter/tree/main/engine/src/flutter/impeller#try-impeller-in-flutter).
|
||||
|
||||
Support on some platforms is further along than on others. The current priority
|
||||
for the team is to support iOS, Android, Desktops, and Embedder API users (in
|
||||
@ -17,7 +17,7 @@ tracker](https://github.com/flutter/flutter/issues/new/choose).
|
||||
Please explicitly mention that this is an Impeller specific regression. You can
|
||||
quickly swap between the Impeller and Skia backends using the command line flag
|
||||
flag detailed in [section in the README on how to try
|
||||
Impeller](https://github.com/flutter/engine/tree/main/impeller#try-impeller-in-flutter).
|
||||
Impeller](https://github.com/flutter/flutter/tree/main/engine/src/flutter/impeller#try-impeller-in-flutter).
|
||||
|
||||
Reduced test cases are the most useful. Please also report any performance
|
||||
regressions.
|
||||
|
||||
@ -13,7 +13,7 @@ and is responsible for:
|
||||
> [!CAUTION]
|
||||
> This is a best effort attempt to document the Android embedder. It is not
|
||||
> guaranteed to be up to date or complete. If you find a discrepancy, please
|
||||
> [send a pull request](https://github.com/flutter/engine/compare)!
|
||||
> [send a pull request](https://github.com/flutter/flutter/compare)!
|
||||
|
||||
See also:
|
||||
|
||||
|
||||
@ -13,7 +13,7 @@ For more information on embedders, see the
|
||||
> [!CAUTION]
|
||||
> This is a best effort attempt to document the Windows embedder. It is not
|
||||
> guaranteed to be up to date or complete. If you find a discrepancy, please
|
||||
> [send a pull request](https://github.com/flutter/engine/compare)!
|
||||
> [send a pull request](https://github.com/flutter/flutter/compare)!
|
||||
|
||||
See also:
|
||||
|
||||
|
||||
@ -1115,7 +1115,7 @@ def run_impeller_golden_tests(build_dir: str, require_skia_gold: bool = False):
|
||||
raise RuntimeError(
|
||||
"""
|
||||
The GOLDCTL environment variable is not set. This is required for Skia Gold tests.
|
||||
See https://github.com/flutter/engine/tree/main/testing/skia_gold_client#configuring-ci
|
||||
See flutter/tree/main/engine/src/flutter/testing/skia_gold_client#configuring-ci
|
||||
for more information.
|
||||
"""
|
||||
)
|
||||
|
||||
Loading…
Reference in New Issue
Block a user