github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] do not use IOSink for writing cache responses (#67231)

Browse Source 
Any File-derived IOSink may throw un-handleable async exceptions into the zone, see dart-lang/sdk#43663 . Instead, just write to a file with an append mode.
This commit is contained in:
Jonah Williams 2020-10-05 09:05:41 -07:00 committed by GitHub
parent fdd1bf2944
commit 4ce2a7aa6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/flutter_tools/lib/src/cache.dart
View File

@ -1598,10 +1598,11 @@ class ArtifactUpdater {
);
try {
_ensureExists(tempFile.parent);
final IOSink ioSink = tempFile.openWrite();
await _download(url, ioSink);
await ioSink.flush();
await ioSink.close();
if (tempFile.existsSync()) {
tempFile.deleteSync();
}
await _download(url, tempFile);
if (!tempFile.existsSync()) {
throw Exception('Did not find downloaded file ${tempFile.path}');
}
@ -1656,13 +1657,15 @@ class ArtifactUpdater {
}
/// Download bytes from [url], throwing non-200 responses as an exception.
Future<void> _download(Uri url, IOSink ioSink) async {
Future<void> _download(Uri url, File file) async {
final HttpClientRequest request = await _httpClient.getUrl(url);
final HttpClientResponse response = await request.close();
if (response.statusCode != HttpStatus.ok) {
throw Exception(response.statusCode);
}
await response.forEach(ioSink.add);
await response.forEach((List<int> chunk) {
file.writeAsBytesSync(chunk, mode: FileMode.append);
});
}
/// Create a temporary file and invoke [onTemporaryFile] with the file as

3
packages/flutter_tools/test/general.shard/artifact_updater_test.dart
View File

@ -18,7 +18,7 @@ import 'package:mockito/mockito.dart';
import '../src/common.dart';
import '../src/mocks.dart';
final Platform testPlatform = FakePlatform(environment: <String, String>{});
final Platform testPlatform = FakePlatform(environment: const <String, String>{});
void main() {
testWithoutContext('ArtifactUpdater can download a zip archive', () async {
@ -367,6 +367,7 @@ class MockHttpClientResponse extends Mock implements HttpClientResponse {
@override
Future<void> forEach(void Function(List<int> element) action) async {
action(<int>[0]);
return;
}
}