github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't be case-sensitive when checking for extension (#18515)

Browse Source 
Seems like VS Code may have started using lowercase extension folders recently (our identifier is `Dart-Code.flutter` but now the folder is named `dart-code.flutter`), so this makes the check not sensitive to casing.

Also reuse extension identifier for download link
This commit is contained in:
Danny Tuppeny 2018-06-18 06:37:01 +01:00 committed by GitHub
parent 3f79f8cba5
commit 592c5ba91a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/vscode/vscode.dart
View File

@ -30,12 +30,13 @@ class VsCode {
} }
// Check for presence of extension. // Check for presence of extension.
final String extensionIdentifierLower = extensionIdentifier.toLowerCase();
final Iterable<FileSystemEntity> extensionDirs = fs final Iterable<FileSystemEntity> extensionDirs = fs
.directory(extensionDirectory) .directory(extensionDirectory)
.listSync() .listSync()
.where((FileSystemEntity d) => d is Directory) .where((FileSystemEntity d) => d is Directory)
.where( .where(
(FileSystemEntity d) => d.basename.startsWith(extensionIdentifier)); (FileSystemEntity d) => d.basename.toLowerCase().startsWith(extensionIdentifierLower));
if (extensionDirs.isNotEmpty) { if (extensionDirs.isNotEmpty) {
final FileSystemEntity extensionDir = extensionDirs.first; final FileSystemEntity extensionDir = extensionDirs.first;

2
packages/flutter_tools/lib/src/vscode/vscode_validator.dart
View File

@ -10,7 +10,7 @@ import 'vscode.dart';
class VsCodeValidator extends DoctorValidator { class VsCodeValidator extends DoctorValidator {
static const String extensionMarketplaceUrl = static const String extensionMarketplaceUrl =
'https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter'; 'https://marketplace.visualstudio.com/items?itemName=${VsCode.extensionIdentifier}';
final VsCode _vsCode; final VsCode _vsCode;
VsCodeValidator(this._vsCode) : super(_vsCode.productName); VsCodeValidator(this._vsCode) : super(_vsCode.productName);