diff --git a/CODEOWNERS b/CODEOWNERS index 0228cbefa3d..67a33944d7e 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -6,11 +6,18 @@ # # Use git ls-files '' without a / prefix to see the list of matching files. -/packages/flutter_tools/templates/module/ios/ @jmagman -/packages/flutter_tools/templates/**/Podfile* @jmagman -/packages/flutter_tools/lib/src/ios/ @jmagman +/engine/src/build/config/ios/** @vashworth +/packages/flutter_tools/templates/module/ios/ @vashworth +/packages/flutter_tools/templates/**/Podfile* @vashworth +/packages/flutter_tools/lib/src/ios/ @vashworth # flutter_driver, integration_test, and internal dev infra. /dev/** @matanlurey /packages/flutter_driver/** @matanlurey /packages/integration_test/** @matanlurey + +# The following files define an Application Binary Interface (ABI) that must maintain +# both forward and backward compatibility. Changes should be heavily +# scrutinized as mistakes are irreversible. +/engine/src/flutter/shell/platform/embedder/embedder.h @cbracken @chinmaygarde @loic-sharma +/engine/src/flutter/shell/platform/embedder/tests/embedder_frozen.h @cbracken @chinmaygarde @loic-sharma diff --git a/engine/src/CODEOWNERS b/engine/src/CODEOWNERS deleted file mode 100644 index f91f5e7a0cc..00000000000 --- a/engine/src/CODEOWNERS +++ /dev/null @@ -1,9 +0,0 @@ -# Below is a list of Flutter hackers GitHub handles who are -# suggested reviewers for contributions to this repository. -# -# These names are just suggestions. It is fine to have your changes -# reviewed by someone else. -# -# Use git ls-files '' without a / prefix to see the list of matching files. - -/build/config/ios/** @jmagman diff --git a/engine/src/flutter/CODEOWNERS b/engine/src/flutter/CODEOWNERS deleted file mode 100644 index df68a330f42..00000000000 --- a/engine/src/flutter/CODEOWNERS +++ /dev/null @@ -1,5 +0,0 @@ -# The following files define an Application Binary Interface (ABI) that must maintain -# both forward and backward compatibility. Changes should be heavily -# scrutinized as mistakes are irreversible. -/shell/platform/embedder/embedder.h @cbracken @chinmaygarde -/shell/platform/embedder/tests/embedder_frozen.h @cbracken @chinmaygarde @loic-sharma diff --git a/engine/src/flutter/ci/licenses_golden/excluded_files b/engine/src/flutter/ci/licenses_golden/excluded_files index a7b219ad069..b01e52a6e0c 100644 --- a/engine/src/flutter/ci/licenses_golden/excluded_files +++ b/engine/src/flutter/ci/licenses_golden/excluded_files @@ -3,7 +3,6 @@ ../../../.gitignore ../../../.gn ../../../AUTHORS -../../../CODEOWNERS ../../../README.md ../../../build ../../../build_overrides @@ -16,7 +15,6 @@ ../../../flutter/.gitignore ../../../flutter/.style.yapf ../../../flutter/AUTHORS -../../../flutter/CODEOWNERS ../../../flutter/CONTRIBUTING.md ../../../flutter/Doxyfile ../../../flutter/README.md