github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed unused method packagesFile from ApplicationPackage. (#95033)

Browse Source 
The method name is confusing and the implementation in different
subclasses are pointing to different things.
This commit is contained in:
Lau Ching Jun 2021-12-13 06:46:04 -08:00 committed by GitHub
parent 9de8849905
commit 5cb09e779a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/android/application_package.dart
View File

@ -203,9 +203,6 @@ class AndroidApk extends ApplicationPackage {
); );
} }
@override
File get packagesFile => file;
@override @override
String get name => file.basename; String get name => file.basename;
} }

2
packages/flutter_tools/lib/src/application_package.dart
View File

@ -28,8 +28,6 @@ abstract class ApplicationPackage {
String? get displayName => name; String? get displayName => name;
File? get packagesFile => null;
@override @override
String toString() => displayName ?? id; String toString() => displayName ?? id;
} }

3
packages/flutter_tools/lib/src/tester/flutter_tester.dart
View File

@ -36,9 +36,6 @@ class FlutterTesterApp extends ApplicationPackage {
@override @override
String get name => _directory.basename; String get name => _directory.basename;
@override
File get packagesFile => _directory.childFile('.packages');
} }
/// The device interface for running on the flutter_tester shell. /// The device interface for running on the flutter_tester shell.

1
packages/flutter_tools/test/general.shard/tester/flutter_tester_test.dart
View File

@ -36,7 +36,6 @@ void main() {
final FlutterTesterApp app = FlutterTesterApp.fromCurrentDirectory(fileSystem); final FlutterTesterApp app = FlutterTesterApp.fromCurrentDirectory(fileSystem);
expect(app.name, 'my_project'); expect(app.name, 'my_project');
expect(app.packagesFile.path, fileSystem.path.join(projectPath, '.packages'));
}); });
group('FlutterTesterDevices', () { group('FlutterTesterDevices', () {