mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
fix failing lint : findByPath requires a specific ordering of project evaluation in aar_init_script.gradle
(#159301)
android studio linter is prompting this lint:  ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
This commit is contained in:
parent
eb6af3d029
commit
5ffb45bf78
@ -47,7 +47,7 @@ void configureProject(Project project, String outputDir) {
|
||||
String engineRealm = Paths.get(getFlutterRoot(project), "bin", "internal", "engine.realm")
|
||||
.toFile().text.trim()
|
||||
if (engineRealm) {
|
||||
engineRealm = engineRealm + "/"
|
||||
engineRealm += "/"
|
||||
}
|
||||
|
||||
// This is a Flutter plugin project. Plugin projects don't apply the Flutter Gradle plugin,
|
||||
@ -179,8 +179,12 @@ projectsEvaluated {
|
||||
// Configure the `assembleAar<variantName>` task for each plugin's projects and make
|
||||
// the module's equivalent task depend on the plugin's task.
|
||||
String variantName = variant.name.capitalize()
|
||||
moduleProject.tasks.findByPath("assembleAar$variantName")
|
||||
.dependsOn(pluginProject.tasks.findByPath("assembleAar$variantName"))
|
||||
|
||||
Task moduleProjectTask = moduleProject.tasks.named("assembleAar$variantName").get()
|
||||
assert(moduleProjectTask != null)
|
||||
Task pluginProjectTask = pluginProject.tasks.named("assembleAar$variantName").get()
|
||||
assert(pluginProjectTask != null)
|
||||
moduleProjectTask.dependsOn(pluginProjectTask)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user