From 61a04b1551a8f63b3081267dc7a0bbc16a1b4bf5 Mon Sep 17 00:00:00 2001 From: Shi-Hao Hong Date: Thu, 9 Jul 2020 15:52:19 +0800 Subject: [PATCH] Fix and address Inconsistencies with Pashto support (#60600) * Normalize Pashto incomplete translations * Add comment to README.md about incomplete Pashto support --- .../bin/gen_missing_localizations.dart | 4 +-- .../lib/src/l10n/README.md | 12 +++++++++ .../generated_material_localizations.dart | 26 +++++++++---------- .../lib/src/l10n/material_ps.arb | 26 +++++++++---------- 4 files changed, 40 insertions(+), 28 deletions(-) diff --git a/dev/tools/localization/bin/gen_missing_localizations.dart b/dev/tools/localization/bin/gen_missing_localizations.dart index 9dffe582b80..d505e659f53 100644 --- a/dev/tools/localization/bin/gen_missing_localizations.dart +++ b/dev/tools/localization/bin/gen_missing_localizations.dart @@ -6,8 +6,8 @@ // entries that are included in the English arb files. This is useful when // adding new resources for localization. You can just add the appropriate // entries to the English arb file and then run this script. It will then check -// all of the other language locale arb files and update them with new 'TBD' -// entries for any missing resources. These will be picked up by the localization +// all of the other language locale arb files and update them with the English +// source for any missing resources. These will be picked up by the localization // team and then translated. // // ## Usage diff --git a/packages/flutter_localizations/lib/src/l10n/README.md b/packages/flutter_localizations/lib/src/l10n/README.md index c68042c42df..d03b1555b3c 100644 --- a/packages/flutter_localizations/lib/src/l10n/README.md +++ b/packages/flutter_localizations/lib/src/l10n/README.md @@ -199,6 +199,18 @@ dev/tools/localization/bin/encode_kn_arb_files.dart. The localizations code generator uses generateEncodedString() from dev/tools/localization/localizations_utils.dart. +### Support for Pashto (ps) translations + +When Flutter first set up i18n for the Material library, Pashto (ps) +translations were included for the first set of Material widgets. +However, Pashto was never set up to be continuously maintained in +Flutter by Google, so material_ps.arb was never updated beyond the +initial commit. + +To prevent breaking applications that rely on these original Pashto +translations, they will be kept. However, all new strings will have +the English translation until support for Pashto is provided. +See https://github.com/flutter/flutter/issues/60598. ### Translations Status, Reporting Errors diff --git a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart index 52e79196c65..f3697044f13 100644 --- a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart @@ -19563,7 +19563,7 @@ class MaterialLocalizationPs extends GlobalMaterialLocalizations { String get closeButtonTooltip => 'بنده'; @override - String get collapsedIconTapHint => 'TBD'; + String get collapsedIconTapHint => 'Expand'; @override String get continueButtonLabel => 'منځپانګې'; @@ -19617,7 +19617,7 @@ class MaterialLocalizationPs extends GlobalMaterialLocalizations { String get drawerLabel => 'د نیویگیشن مینو'; @override - String get expandedIconTapHint => 'TBD'; + String get expandedIconTapHint => 'Collapse'; @override String get hideAccountsLabel => 'حسابونه پټ کړئ'; @@ -19653,7 +19653,7 @@ class MaterialLocalizationPs extends GlobalMaterialLocalizations { String get modalBarrierDismissLabel => 'رد کړه'; @override - String get moreButtonTooltip => 'TBD'; + String get moreButtonTooltip => 'More'; @override String get nextMonthTooltip => 'بله میاشت'; @@ -19689,7 +19689,7 @@ class MaterialLocalizationPs extends GlobalMaterialLocalizations { String get previousPageTooltip => 'مخکینی مخ'; @override - String get refreshIndicatorSemanticLabel => 'TBD'; + String get refreshIndicatorSemanticLabel => 'Refresh'; @override String get remainingTextFieldCharacterCountFew => null; @@ -19698,34 +19698,34 @@ class MaterialLocalizationPs extends GlobalMaterialLocalizations { String get remainingTextFieldCharacterCountMany => null; @override - String get remainingTextFieldCharacterCountOne => 'TBD'; + String get remainingTextFieldCharacterCountOne => '1 character remaining'; @override - String get remainingTextFieldCharacterCountOther => 'TBD'; + String get remainingTextFieldCharacterCountOther => '\$remainingCount characters remaining'; @override String get remainingTextFieldCharacterCountTwo => null; @override - String get remainingTextFieldCharacterCountZero => 'TBD'; + String get remainingTextFieldCharacterCountZero => 'No characters remaining'; @override - String get reorderItemDown => 'TBD'; + String get reorderItemDown => 'Move down'; @override - String get reorderItemLeft => 'TBD'; + String get reorderItemLeft => 'Move left'; @override - String get reorderItemRight => 'TBD'; + String get reorderItemRight => 'Move right'; @override - String get reorderItemToEnd => 'TBD'; + String get reorderItemToEnd => 'Move to the end'; @override - String get reorderItemToStart => 'TBD'; + String get reorderItemToStart => 'Move to the start'; @override - String get reorderItemUp => 'TBD'; + String get reorderItemUp => 'Move up'; @override String get rowsPerPageTitle => 'د هرې پاڼې پاڼې:'; diff --git a/packages/flutter_localizations/lib/src/l10n/material_ps.arb b/packages/flutter_localizations/lib/src/l10n/material_ps.arb index 0f0790bd418..44fc2d0ad46 100644 --- a/packages/flutter_localizations/lib/src/l10n/material_ps.arb +++ b/packages/flutter_localizations/lib/src/l10n/material_ps.arb @@ -39,19 +39,19 @@ "dialogLabel": "خبرې اترې", "alertDialogLabel": "خبرتیا", "searchFieldLabel": "لټون", - "reorderItemToStart": "TBD", - "reorderItemToEnd": "TBD", - "reorderItemUp": "TBD", - "reorderItemDown": "TBD", - "reorderItemLeft": "TBD", - "reorderItemRight": "TBD", - "expandedIconTapHint": "TBD", - "collapsedIconTapHint": "TBD", - "remainingTextFieldCharacterCountZero": "TBD", - "remainingTextFieldCharacterCountOne": "TBD", - "remainingTextFieldCharacterCountOther": "TBD", - "refreshIndicatorSemanticLabel": "TBD", - "moreButtonTooltip": "TBD", + "moreButtonTooltip": "More", + "reorderItemToStart": "Move to the start", + "reorderItemToEnd": "Move to the end", + "reorderItemUp": "Move up", + "reorderItemDown": "Move down", + "reorderItemLeft": "Move left", + "reorderItemRight": "Move right", + "expandedIconTapHint": "Collapse", + "collapsedIconTapHint": "Expand", + "remainingTextFieldCharacterCountZero": "No characters remaining", + "remainingTextFieldCharacterCountOne": "1 character remaining", + "remainingTextFieldCharacterCountOther": "$remainingCount characters remaining", + "refreshIndicatorSemanticLabel": "Refresh", "dateSeparator": "/", "dateHelpText": "mm/dd/yyyy", "selectYearSemanticsLabel": "Select year",