github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)

Browse Source 
This reverts commit 6c7c2e372a.
This commit is contained in:
Leaf Petersen 2020-03-24 23:02:41 -07:00 committed by GitHub
parent 6c7c2e372a
commit 6563b0de34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/test/services/platform_channel_test.dart
View File

@ -70,7 +70,7 @@ void main() {
} }
}, },
); );
expect(channel.invokeMethod<List<String>>('sayHello', 'hello'), throwsA(isInstanceOf<TypeError>())); expect(channel.invokeMethod<List<String>>('sayHello', 'hello'), throwsA(isCastError));
expect(await channel.invokeListMethod<String>('sayHello', 'hello'), <String>['hello', 'world']); expect(await channel.invokeListMethod<String>('sayHello', 'hello'), <String>['hello', 'world']);
}); });
@ -102,7 +102,7 @@ void main() {
} }
}, },
); );
expect(channel.invokeMethod<Map<String, String>>('sayHello', 'hello'), throwsA(isInstanceOf<TypeError>())); expect(channel.invokeMethod<Map<String, String>>('sayHello', 'hello'), throwsA(isCastError));
expect(await channel.invokeMapMethod<String, String>('sayHello', 'hello'), <String, String>{'hello': 'world'}); expect(await channel.invokeMapMethod<String, String>('sayHello', 'hello'), <String, String>{'hello': 'world'});
}); });

2
packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart
View File

@ -25,7 +25,7 @@ const bool kIconTreeShakerEnabledDefault = false;
List<Map<String, dynamic>> _getList(dynamic object, String errorMessage) { List<Map<String, dynamic>> _getList(dynamic object, String errorMessage) {
try { try {
return (object as List<dynamic>).cast<Map<String, dynamic>>(); return (object as List<dynamic>).cast<Map<String, dynamic>>();
} on TypeError catch (_) { } on CastError catch (_) {
throw IconTreeShakerException._(errorMessage); throw IconTreeShakerException._(errorMessage);
} }
} }