From 6757c7dd473ef5d970285efed672079e43f9619c Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 17 Feb 2021 14:31:03 -0800 Subject: [PATCH] Use a null default skip value in testWidgets so it can inherit the group's skip flag (#76174) --- packages/flutter_test/lib/src/widget_tester.dart | 2 +- packages/flutter_test/test/widget_tester_test.dart | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/flutter_test/lib/src/widget_tester.dart b/packages/flutter_test/lib/src/widget_tester.dart index eb8988960b5..5193f9cae78 100644 --- a/packages/flutter_test/lib/src/widget_tester.dart +++ b/packages/flutter_test/lib/src/widget_tester.dart @@ -108,7 +108,7 @@ typedef WidgetTesterCallback = Future Function(WidgetTester widgetTester); void testWidgets( String description, WidgetTesterCallback callback, { - bool skip = false, + bool? skip, test_package.Timeout? timeout, Duration? initialTimeout, bool semanticsEnabled = true, diff --git a/packages/flutter_test/test/widget_tester_test.dart b/packages/flutter_test/test/widget_tester_test.dart index 7ce6c61549b..458ced8ac17 100644 --- a/packages/flutter_test/test/widget_tester_test.dart +++ b/packages/flutter_test/test/widget_tester_test.dart @@ -52,6 +52,12 @@ void main() { }); }); + group('respects the group skip flag', () { + testWidgets('should be skipped', (WidgetTester tester) async { + expect(false, true); + }); + }, skip: true); + group('findsOneWidget', () { testWidgets('finds exactly one widget', (WidgetTester tester) async { await tester.pumpWidget(const Text('foo', textDirection: TextDirection.ltr));