From 6cf5dbe37151515a8b6f4bccd0b69ab10f5a5aa7 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 10 Aug 2023 14:34:49 -0700 Subject: [PATCH] Analyze code snippets in integration_test docs (#132314) --- dev/bots/analyze_snippet_code.dart | 2 ++ packages/integration_test/lib/integration_test.dart | 4 ++-- .../lib/integration_test_driver_extended.dart | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dev/bots/analyze_snippet_code.dart b/dev/bots/analyze_snippet_code.dart index d29d6d251e5..e6de1e4cf59 100644 --- a/dev/bots/analyze_snippet_code.dart +++ b/dev/bots/analyze_snippet_code.dart @@ -72,6 +72,7 @@ import 'package:watcher/watcher.dart'; final String _flutterRoot = path.dirname(path.dirname(path.dirname(path.fromUri(Platform.script)))); final String _packageFlutter = path.join(_flutterRoot, 'packages', 'flutter', 'lib'); final String _packageFlutterTest = path.join(_flutterRoot, 'packages', 'flutter_test', 'lib'); +final String _packageIntegrationTest = path.join(_flutterRoot, 'packages', 'integration_test', 'lib'); final String _defaultDartUiLocation = path.join(_flutterRoot, 'bin', 'cache', 'pkg', 'sky_engine', 'lib', 'ui'); final String _flutter = path.join(_flutterRoot, 'bin', Platform.isWindows ? 'flutter.bat' : 'flutter'); @@ -151,6 +152,7 @@ Future main(List arguments) async { flutterPackages = [ Directory(_packageFlutter), Directory(_packageFlutterTest), + Directory(_packageIntegrationTest), // TODO(goderbauer): Add all other packages. ]; } diff --git a/packages/integration_test/lib/integration_test.dart b/packages/integration_test/lib/integration_test.dart index 14542e6637e..811f1c244e3 100644 --- a/packages/integration_test/lib/integration_test.dart +++ b/packages/integration_test/lib/integration_test.dart @@ -326,9 +326,9 @@ https://flutter.dev/docs/testing/integration-tests#testing-on-firebase-test-lab /// /// Future main() { /// return integrationDriver( - /// responseDataCallback: (data) async { + /// responseDataCallback: (Map? data) async { /// if (data != null) { - /// for (var entry in data.entries) { + /// for (final MapEntry entry in data.entries) { /// print('Writing ${entry.key} to the disk.'); /// await writeResponseData( /// entry.value as Map, diff --git a/packages/integration_test/lib/integration_test_driver_extended.dart b/packages/integration_test/lib/integration_test_driver_extended.dart index d449d7df989..d4226f4ecb2 100644 --- a/packages/integration_test/lib/integration_test_driver_extended.dart +++ b/packages/integration_test/lib/integration_test_driver_extended.dart @@ -20,13 +20,14 @@ import 'common.dart'; /// ```dart /// import 'dart:async'; /// +/// import 'package:flutter_driver/flutter_driver.dart'; /// import 'package:integration_test/integration_test_driver_extended.dart'; /// /// Future main() async { /// final FlutterDriver driver = await FlutterDriver.connect(); /// await integrationDriver( /// driver: driver, -/// onScreenshot: (String screenshotName, List screenshotBytes) async { +/// onScreenshot: (String name, List image, [Map? args]) async { /// return true; /// }, /// );